[waffle] [ANNOUNCE] waffle 1.6.1

2020-03-31 Thread Emil Velikov
Hi all, I'd like to announce waffle 1.6.1 as available for download immediately. The release focuses on bugfixes and brings us: - wflinfo: Correctly install the bash completion file - GLX/WGL: Handle ARB_create_context appropriatelly - Wayland: Build fix for -fno-common, default with GCC10 -

Re: [waffle] [PATCH 5/7] surfaceless_egl: Implement new platform

2016-10-29 Thread Emil Velikov
On 29 October 2016 at 18:59, Chad Versace <chadvers...@chromium.org> wrote: > On Wed 19 Oct 2016, Emil Velikov wrote: >> On 18 October 2016 at 18:33, Chad Versace <chadvers...@chromium.org> wrote: >> > Now waffle_init() supports WAFFLE_PLATFORM_SURFACELESS_EGL.

Re: [waffle] [PATCH 0/7] Use eglGetPlatformDisplay when possible (v2)

2016-10-25 Thread Emil Velikov
t; Cannot see 8/8 in the list, so I've check it via the repo. The lot looks great imho. Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> -Emil ___ waffle mailing list waffle@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 7/7] egl: Use eglGetPlatformDisplay when possible

2016-10-21 Thread Emil Velikov
On 19 October 2016 at 22:52, Chad Versace <chadvers...@chromium.org> wrote: > On Wed 19 Oct 2016, Emil Velikov wrote: >> On 18 October 2016 at 17:58, Chad Versace <chadvers...@chromium.org> wrote: >> > Tested against Mesa master@8c78fdb with `ninja check-func` on Li

Re: [waffle] [PATCH 5/7] surfaceless_egl: Implement new platform

2016-10-18 Thread Emil Velikov
On 18 October 2016 at 18:33, Chad Versace wrote: > Now waffle_init() supports WAFFLE_PLATFORM_SURFACELESS_EGL. > > Cc: Gurchetan Singh > Cc: Haixia Shi > --- > include/waffle/waffle.h | 1 + >

Re: [waffle] [PATCH 4/7] cmake: Add option waffle_has_surfaceless_egl

2016-10-18 Thread Emil Velikov
On 18 October 2016 at 18:33, Chad Versace wrote: > This patch contains just the CMake changes for the new surfaceless_egl > platform. Code will come in the following patches. > > Cc: Gurchetan Singh > Cc: Haixia Shi > ---

Re: [waffle] [PATCH 0/7] Use eglGetPlatformDisplay when possible

2016-10-18 Thread Emil Velikov
ure > egl: Use eglGetPlatformDisplay when possible > The questions in 5 and 7 are not blockers, by any means. Just please split the Android change from 3. With that (and the extra Android change itself) are Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> -Emil _

Re: [waffle] [PATCH 7/7] egl: Use eglGetPlatformDisplay when possible

2016-10-18 Thread Emil Velikov
On 18 October 2016 at 17:58, Chad Versace wrote: > Tested against Mesa master@8c78fdb with `ninja check-func` on Linux. > --- > src/waffle/egl/wegl_display.c | 22 ++ > src/waffle/egl/wegl_platform.c | 35 +-- >

Re: [waffle] [PATCH 3/7] egl: Move each platform's setenv("EGL_PLATFORM") into core EGL code

2016-10-18 Thread Emil Velikov
On 18 October 2016 at 17:58, Chad Versace wrote: > +case EGL_PLATFORM_ANDROID_KHR: > +setenv("EGL_PLATFORM", "android", true); > +break; Thus hunk is a new addition. Can you please split it out ? -Emil

Re: [waffle] [PATCH 1/2] Revert "wegl: add EGL image create/destroy"

2016-10-14 Thread Emil Velikov
On 12 October 2016 at 18:17, Chad Versace wrote: > Hmm... I just (17:16:23 UTC) tried to giving you write access to the > Github Issues section. Let me know if it works. I admit that the Github > gui confounds me. Just closed an old/obsolete PR request, so it seems to

Re: [waffle] [PATCH 1/2] Revert "wegl: add EGL image create/destroy"

2016-10-12 Thread Emil Velikov
On 11 October 2016 at 18:23, Chad Versace <chadvers...@chromium.org> wrote: > On Thu 21 Jul 2016, Emil Velikov wrote: >> This reverts commit 1a8e8ef3b8072fa1135dbe2a04dc6bb9f8e3a12f. >> >> The symbols were added as they are required by the null/surfaceless >> platf

Re: [waffle] [PATCH] gbm: add WAFFLE_GBM_RENDER_NODE for multi-GPU systems

2016-09-09 Thread Emil Velikov
Hi Marek, On 9 September 2016 at 14:14, Marek Olšák wrote: > From: Marek Olšák > > --- > src/waffle/gbm/wgbm_display.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/waffle/gbm/wgbm_display.c

Re: [waffle] [PATCH 0/4] Implement gbm window_resize

2016-08-19 Thread Emil Velikov
On 18 August 2016 at 11:41, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 16 May 2016 at 11:48, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> Hi all, >> >> This is a respin of Emmanuel (linkmauve)'s work [1] without all the >> unneeded coping. On g

Re: [waffle] [PATCH 0/4] Implement gbm window_resize

2016-08-18 Thread Emil Velikov
On 16 May 2016 at 11:48, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi all, > > This is a respin of Emmanuel (linkmauve)'s work [1] without all the > unneeded coping. On gbm one needs to teardown the old window (which this > series does only if we can create the new on

Re: [waffle] [PATCH 00/13] Core waffle cleanups

2016-08-18 Thread Emil Velikov
On 21 June 2016 at 11:33, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 16 May 2016 at 11:57, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 16 May 2016 at 11:54, Emil Velikov <emil.l.veli...@gmail.com> wrote: >>> Hi all, >>> >&g

Re: [waffle] [PATCH] egl: resolve build issue with pre EGL 1.5 headers

2016-08-18 Thread Emil Velikov
On 20 July 2016 at 17:27, Emil Velikov <emil.l.veli...@gmail.com> wrote: > In some cases (like building on Android) the headers might not have the > 1.5 definitions, leading to a build failures like the one in github > issue #41. > > Since the ABI is baked in stone, add a lo

[waffle] [PATCH 2/2] gbm: coding style cleanup

2016-07-21 Thread Emil Velikov
Waffle aims to keep the main code path in it's core, with the error path diverging via goto labels and alike. Follow the approach and update the gbm code. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/gbm/wgbm_platform.c | 10 +- 1 file changed, 5 inse

[waffle] [PATCH 1/2] Revert "wegl: add EGL image create/destroy"

2016-07-21 Thread Emil Velikov
This reverts commit 1a8e8ef3b8072fa1135dbe2a04dc6bb9f8e3a12f. The symbols were added as they are required by the null/surfaceless platform. Since that one hasn't landed yet, just remove the patch. Furthermore, using dlsym is non-compatible (according to the spec) since the symbols are part of an

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-06-22 Thread Emil Velikov
On 23 June 2016 at 00:58, Jason Ekstrand <ja...@jlekstrand.net> wrote: > > > On Tue, Jun 21, 2016 at 9:06 PM, Chad Versace <chad.vers...@intel.com> > wrote: >> >> On Mon 20 Jun 2016, Chad Versace wrote: >> > On Sun 17 Apr 2016, Emil Velikov wrote: >

Re: [waffle] [PATCH 00/13] Core waffle cleanups

2016-06-21 Thread Emil Velikov
On 16 May 2016 at 11:57, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 16 May 2016 at 11:54, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> Hi all, >> >> While looking at the gbm/egl I've noticed a few interesting bits. >> - We do NULL checkin

Re: [waffle] long-standing wgl pixel format issue

2016-06-20 Thread Emil Velikov
On 20 June 2016 at 15:46, Brian Paul <bri...@vmware.com> wrote: > On 06/17/2016 07:59 PM, Emil Velikov wrote: >> >> On 17 June 2016 at 16:53, Brian Paul <bri...@vmware.com> wrote: >>> >>> >>> I spent a few hours yesterday pulling out my hair

Re: [waffle] long-standing wgl pixel format issue

2016-06-17 Thread Emil Velikov
On 17 June 2016 at 16:53, Brian Paul wrote: > > I spent a few hours yesterday pulling out my hair trying to understand why > the piglit fbo-mipmap-copypix test was failing on Windows. But it was only > failing when I ran it directly. It passed when I ran it via piglit-run.py

Re: [waffle] [PATCH 1/2] tests/gl_basic: Make GL symbol queries more robust

2016-06-14 Thread Emil Velikov
PATCH 07/13] wegl: untangle dl_can_open() and support_api() >> Fortunate me did not see the issue since I have both libGLESv1_CM and libGLESv2 libraries :-) That aside: Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> Thanks Emil ___ waf

Re: [waffle] [PATCH 4/4] gbm: implement window_resize

2016-06-14 Thread Emil Velikov
On 16 May 2016 at 11:48, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Reuse the existing init/teardown functions to create a new window and > nuke the old one on success. > > Note: as we need the origin

Re: [waffle] [PATCH 00/29] Rework the functionality test(s)

2016-06-14 Thread Emil Velikov
On 14 June 2016 at 18:10, Chad Versace <chad.vers...@intel.com> wrote: > On Tue 26 Apr 2016, Emil Velikov wrote: >> Humble ping ? > > And an embarassedly late merge. > > Thanks for all the cleanups. All the patches in the series, except patch > 1, are mer

Re: [waffle] [PATCH 00/13] Core waffle cleanups

2016-05-16 Thread Emil Velikov
On 16 May 2016 at 11:54, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi all, > > While looking at the gbm/egl I've noticed a few interesting bits. > - We do NULL checking for values that are guaranteed by API to be > non-NULL. > - wcore_*_init does not need a r

[waffle] [PATCH 13/13] linux: remove 'self' NULL check

2016-05-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> All the callers already ensure this never happens. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/waffle/linux/linux_platform.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/waffle/linux/linux_platform.c

[waffle] [PATCH 12/13] android: remove 'self' NULL checks

2016-05-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Similar to earlier commits - the API layer already does these for us. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/waffle/android/droid_window.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-)

[waffle] [PATCH 11/13] wayland: tweak wayland_wrapper_init()

2016-05-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Analogous to previous commit. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/waffle/wayland/wayland_wrapper.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/wa

[waffle] [PATCH 10/13] egl: tweak wegl_platform_init()

2016-05-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Drop the goto label and bail directly from the macro. The current strange construct has gotten us once, so we might as well try to avoid it for the future. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/waffle/egl/weg

[waffle] [PATCH 04/13] all: remove 'self' NULL check from *_display_destroy()

2016-05-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Analogous to previous commit Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/waffle/android/droid_display.c | 3 --- src/waffle/cgl/cgl_display.m | 3 --- src/waffle/gbm/wgbm_display.c| 8 ++-- sr

[waffle] [PATCH 05/13] all: remove 'self' NULL check from *_window_destroy()

2016-05-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Analogous to previous commit Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/waffle/android/droid_window.c | 11 +++ src/waffle/cgl/cgl_window.m | 7 ++- src/waffle/gbm/wgbm_window.c| 7

[waffle] [PATCH 07/13] all: remove 'self' NULL check from *_config_destroy()

2016-05-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Analogous to previous commit Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/waffle/cgl/cgl_config.m | 11 +++ src/waffle/egl/wegl_config.c | 7 ++- src/waffle/glx/glx_config.c | 7 ++- src

[waffle] [PATCH 02/13] egl: inline wegl_context_{init, teardown}() in the respective callers

2016-05-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Seems like an overkill to keep them separate considering the caller and callee are just a single function call. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/waffle/egl/wegl_co

[waffle] [PATCH 01/13] x11: straighten code flow

2016-05-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Having goto statements jump over each other makes the code harder/more annoying to read. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/waffle/x11/x11_window.c | 7 ++- 1 file changed, 2 insertions(+), 5 deleti

[waffle] [PATCH 00/13] Core waffle cleanups

2016-05-16 Thread Emil Velikov
Hi all, While looking at the gbm/egl I've noticed a few interesting bits. - We do NULL checking for values that are guaranteed by API to be non-NULL. - wcore_*_init does not need a return type, plus in some places we were not calling it in the correct time. - wcore_*_teardown is a simple

[waffle] [PATCH 1/4] egl: fix build against old headers

2016-05-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Namely add the EGL_CONTEXT_OPENGL_ROBUST_ACCESS define, if missing. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/egl/wegl_context.c | 4 1 file changed, 4 insertions(+) diff --git a/src/waffle/egl/wegl

[waffle] [PATCH 2/4] egl: fold eglGetConfigAttrib() within wegl_config_choose()

2016-05-16 Thread Emil Velikov
Rather than having the call in multiple places and multiple times, just query the native visual id once and store it for later use. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/waffle/egl/wegl_config.c | 7 +++ src/waffle/egl/wegl_config.h | 1 + src/waff

[waffle] [PATCH 3/4] gbm: factor out gbm_window_{init,teardown}

2016-05-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> We'll need then with next patch as we implement window_resize(). Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- src/waffle/gbm/wgbm_window.c | 69 +--- 1 file changed, 46 inser

[waffle] [PATCH 0/4] Implement gbm window_resize

2016-05-16 Thread Emil Velikov
Hi all, This is a respin of Emmanuel (linkmauve)'s work [1] without all the unneeded coping. On gbm one needs to teardown the old window (which this series does only if we can create the new one and make it current). Note: this adds a rather hacky looking link to the config in struct

[waffle] [PATCH 4/4] gbm: implement window_resize

2016-05-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Reuse the existing init/teardown functions to create a new window and nuke the old one on success. Note: as we need the original config, we keep a reference to it in struct wcore_config. Ideally there will be a generic way to query it. Sign

Re: [waffle] json, approach 2, version 2

2016-04-26 Thread Emil Velikov
lloc or strdup), the leak is plugged and people are happy with the other two topics (loose common GL data, even if we fail in print_platform_specific) (don't print anything and/or error if print_platform_specific() is not implemented), I'd say just do with the series. Rev

Re: [waffle] [PATCH 17/29] UPSTREAM: cmocka: include strings.h for strcasecmp

2016-04-26 Thread Emil Velikov
Ftr this patch has landed in upstream cmocka. If people prefer we can re-sync out local copy with the latest version. Personally I'm fine either way. Emil ___ waffle mailing list waffle@lists.freedesktop.org

Re: [waffle] [RFC PATCH 0/8] Android: plus memory leaks

2016-04-26 Thread Emil Velikov
[Adding Juha-Pekka since he did a bunch of fixes in the area] Juha-Pekka, all, Does anyone have some recommended reading on the topic of smart pointers and Android ? Can anyone spare a few cycles and skim through the series ? Thanks Emil On 5 April 2016 at 23:52, Emil Velikov <emil.l.v

Re: [waffle] [PATCH 00/13] Do less validation of the context version

2016-04-26 Thread Emil Velikov
Humble ping ? On 5 April 2016 at 22:58, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi all, > > This is a re-spin of an ancient RFC [1] covering two (core) topics > - Should waffle do fine grained checking of the context version prior > to feeding it to the dri

Re: [waffle] [PATCH 00/29] Rework the functionality test(s)

2016-04-26 Thread Emil Velikov
Humble ping ? On 6 January 2016 at 21:27, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi all, > > Recently I had the chance to finish a lenghty series started some months > ago. Namely - rework gl_basic_tests and kick waffle_test out the door. > > It starts with

Re: [waffle] [PATCH 07/12] waffle: support platform-specific information

2016-04-26 Thread Emil Velikov
On 25 April 2016 at 04:30, Frank Henigman <fjhenig...@google.com> wrote: > On Sun, Apr 24, 2016 at 5:04 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> On 24 April 2016 at 20:52, Frank Henigman <fjhenig...@google.com> wrote: >>> On Sun, Apr 24, 201

Re: [waffle] [PATCH 05/12] waffle: add waffle_display_info_json()

2016-04-24 Thread Emil Velikov
On 24 April 2016 at 20:50, Frank Henigman <fjhenig...@google.com> wrote: > On Sun, Apr 24, 2016 at 6:42 AM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> On 21 April 2016 at 21:25, Frank Henigman <fjhenig...@google.com> wrote: >>> On Fri, Jan 8, 201

Re: [waffle] [PATCH 04/12] core: add JSON library

2016-04-24 Thread Emil Velikov
On 6 January 2016 at 19:56, Frank Henigman wrote: > +static void > +put(struct json *jj, char *s) > +{ > +if (!jj->buf) > +return; > + > +for (;;) { > +if (!(*jj->pos = *s++)) > +break; > +if (++jj->pos == jj->buf + jj->size) { >

Re: [waffle] [PATCH 10/12] egl: implement platform-specific information

2016-04-24 Thread Emil Velikov
On 24 April 2016 at 20:52, Frank Henigman <fjhenig...@google.com> wrote: > On Sat, Apr 23, 2016 at 2:51 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> On 21 April 2016 at 21:27, Frank Henigman <fjhenig...@google.com> wrote: >>> On Fri, Jan 8, 201

[waffle] [PATCH 05/12] waffle: add waffle_display_info_json()

2016-04-24 Thread Emil Velikov
On 21 April 2016 at 21:25, Frank Henigman <fjhenig...@google.com> wrote: > On Fri, Jan 8, 2016 at 7:40 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 6 January 2016 at 21:56, Frank Henigman <fjhenig...@google.com> wrote: >>> Duplicate wflinfo functiona

Re: [waffle] [PATCH 07/12] waffle: support platform-specific information

2016-04-24 Thread Emil Velikov
On 21 April 2016 at 21:26, Frank Henigman <fjhenig...@google.com> wrote: > On Fri, Jan 8, 2016 at 7:44 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 6 January 2016 at 21:56, Frank Henigman <fjhenig...@google.com> wrote: >>> Add a platform hook

Re: [waffle] [PATCH 04/12] core: add JSON library

2016-04-24 Thread Emil Velikov
On 21 April 2016 at 21:25, Frank Henigman <fjhenig...@google.com> wrote: > On Fri, Apr 8, 2016 at 7:38 PM, Chad Versace <chad.vers...@intel.com> wrote: >> On 01/08/2016 04:17 AM, Emil Velikov wrote: >>> On 6 January 2016 at 21:56, Frank Henigman <fjhenig...@google

[waffle] [PATCH 10/12] egl: implement platform-specific information

2016-04-23 Thread Emil Velikov
On 21 April 2016 at 21:27, Frank Henigman <fjhenig...@google.com <javascript:;>> wrote: > On Fri, Jan 8, 2016 at 7:50 AM, Emil Velikov <emil.l.veli...@gmail.com <javascript:;>> wrote: >> On 6 January 2016 at 21:56, Frank Henigman <fjhenig...@google.com

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-04-17 Thread Emil Velikov
On 17 April 2016 at 01:41, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Sat, Apr 16, 2016 at 4:12 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> >> On 16 April 2016 at 22:06, Jason Ekstrand <ja...@jlekstrand.net> wrote: >> >> >&

Re: [waffle] [PATCH] egl: Support robust access contexts with EGL 1.5.

2016-04-15 Thread Emil Velikov
(plat, "eglInitialize"); > goto fail; > diff --git a/src/waffle/egl/wegl_display.h b/src/waffle/egl/wegl_display.h > index b82a2ec..0d03ec8 100644 > --- a/src/waffle/egl/wegl_display.h > +++ b/src/waffle/egl/wegl_display.h > @@ -3

Re: [waffle] [PATCH] egl: correctly set the attrib/bits for robust contexts

2016-04-15 Thread Emil Velikov
On 16 April 2016 at 00:34, Emil Velikov <emil.l.veli...@gmail.com> wrote: > The EXT_create_context_robustness extension covers only GLES contexts, > while the latter EGL_KHR_create_context works for both GL and GLES ones. > Actually the second extension seems a bit inconsistent

[waffle] [PATCH v2] wgl: don't use ARB_create_context with pre 3.2 contexts

2016-04-15 Thread Emil Velikov
Direct port of previous commit. v2: The version should be 3.2 and not 3.0 as originally. Cc: Jose Fonseca <jfons...@vmware.com> Cc: Ilia Mirkin <imir...@alum.mit.edu> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/wgl/wgl_config.c | 7 -

[waffle] [PATCH v2] glx: don't use ARB_create_context with pre 3.2 contexts

2016-04-15 Thread Emil Velikov
be 3.2 and not 3.0 as originally. Cc: Ilia Mirkin <imir...@alum.mit.edu> Reviewed-by: Jose Fonseca <jfons...@vmware.com> (v1) Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/glx/glx_config.c | 7 --- src/waffle/glx/glx_context.c | 12 ++

Re: [waffle] [PATCH 1/3] glx: don't use ARB_create_context with pre 3.0 contexts

2016-04-15 Thread Emil Velikov
On 15 April 2016 at 20:04, Chad Versace <chad.vers...@intel.com> wrote: > On 04/06/2016 02:12 AM, Jose Fonseca wrote: >> On 05/04/16 22:45, Emil Velikov wrote: >>> This way if the user requests GL pre 3.0 context which lacks the >>> flags/extra bits which require

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-04-15 Thread Emil Velikov
On 15 April 2016 at 21:56, Chad Versace <chad.vers...@intel.com> wrote: > On 04/15/2016 09:36 AM, Jason Ekstrand wrote: >> On Fri, Apr 15, 2016 at 3:03 AM, Emil Velikov <emil.l.veli...@gmail.com >> <mailto:emil.l.veli...@gmail.com>> wrote: >> >>

[waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-04-15 Thread Emil Velikov
The waffle code doesn't reference wl_proxy_marshal_constructor_versioned directly but indirectly via wayland-scanner. v2: * Add paragraph about how wl_proxy_marshal_constructor_versioned was introduced. (Emil Velikov) * Only resolve wl_proxy_marshal_constructor_versioned with wayland >=

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-04-15 Thread Emil Velikov
On 15 April 2016 at 03:32, Michel Dänzer <mic...@daenzer.net> wrote: > On 15.04.2016 11:14, Michel Dänzer wrote: >> On 14.04.2016 22:16, Emil Velikov wrote: >>> On 14 April 2016 at 09:23, Michel Dänzer <mic...@daenzer.net> wrote: >>>> From: Michel Dänze

Re: [waffle] [PATCH] wayland: add support for wl_proxy_marshal_constructor_versioned

2016-04-14 Thread Emil Velikov
On 14 April 2016 at 19:12, Dylan Baker wrote: > This fixes waffle to build against wayland 1.10. > > Thanks to Jason Eckstrand for help getting this working. > I can never get names right, although this one seems off - s/Eckstrand/Ekstrand/ ;-) > Fixes #38 > > cc: Chad

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-04-14 Thread Emil Velikov
s introduced in wayland 1.9.91 by commit 557032e3 ("Track > protocol object versions inside wl_proxy."). The waffle code doesn't > reference wl_proxy_marshal_constructor_versioned directly but > indirectly via wayland-scanner. > > v2: > * Add paragraph about how wl_proxy_marsh

Re: [waffle] [PATCH 1/6] wcore: Add support for robust access contexts.

2016-04-11 Thread Emil Velikov
On 11 April 2016 at 21:11, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 6 April 2016 at 16:59, Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> wrote: >> Signed-off-by: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> >> --- >> include/waffle/waffle.h

Re: [waffle] [PATCH 1/6] wcore: Add support for robust access contexts.

2016-04-11 Thread Emil Velikov
On 6 April 2016 at 16:59, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen > --- > include/waffle/waffle.h | 4 > man/waffle_config.3.xml | 24 >

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned

2016-04-07 Thread Emil Velikov
Hi Michel, On 7 April 2016 at 09:20, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes build failure due to wl_proxy_marshal_constructor_versioned being > unresolved when building against current wayland. > Thanks for that patch. Can you please add

Re: [waffle] [PATCH 01/29] wayland: add wl_proxy_create wrapper

2016-04-07 Thread Emil Velikov
On 6 April 2016 at 13:20, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 6 January 2016 at 21:27, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> libwayland has broken its ABI by replacing wl_proxy_create + >> wl_proxy_marshal with wfl_wl_proxy_marsha

[waffle] [PATCH 3/8] android: annotate static functions as such

2016-04-05 Thread Emil Velikov
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/android/droid_surfaceflingerlink.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/waffle/android/droid_surfaceflingerlink.cpp b/src/waffle/android/droid_surfaceflingerlink.cpp

[waffle] [PATCH 4/8] android: cleanup surfaceflinger_link management

2016-04-05 Thread Emil Velikov
If the C++ runtime fails to create the relevant object(s) an exception will be raised, thus the NULL checks will never get hit. While we're here replace the opencoded SurfaceComposerClient dtor with the proper one. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/a

[waffle] [PATCH 2/8] android: move droid_destroy_surface() further up the file

2016-04-05 Thread Emil Velikov
Analogous to previous commit, minus the case where the setup (wrongly) open-codes it. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/android/droid_surfaceflingerlink.cpp | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/

[waffle] [PATCH 1/8] android: avoid unneeded (function) forward declaration

2016-04-05 Thread Emil Velikov
There is no specific reason why we cannot move the teardown function prior to the setup one. Most (rest of) waffle does so already. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/android/droid_surfaceflingerlink.cpp | 32 +++-- 1 file chang

[waffle] [PATCH 07/13] wegl: untangle dl_can_open() and support_api()

2016-04-05 Thread Emil Velikov
added a minimum requirement of EGL 1.2 as things will explode badly with versions prior to it. v2: Completely reword commit message, finish implementation. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/egl/wegl_config.c | 37 ++--- src/waff

[waffle] [PATCH 08/13] glx: remove dl_can_open() logic from supports_api()

2016-04-05 Thread Emil Velikov
As mentioned earlier with similar EGL commit - one should two to keep the two separate. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/glx/glx_config.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/src/waffle/glx/glx_conf

[waffle] [PATCH 06/13] wegl: add closing bracket in error message

2016-04-05 Thread Emil Velikov
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/egl/wegl_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/waffle/egl/wegl_display.c b/src/waffle/egl/wegl_display.c index 88fce7a..b3d0d88 100644 --- a/src/waffle/egl/wegl_display.c +++

[waffle] [PATCH 02/13] wgl: indent with spaces, not tabs

2016-04-05 Thread Emil Velikov
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/wgl/wgl_config.h | 2 +- src/waffle/wgl/wgl_context.h | 2 +- src/waffle/wgl/wgl_display.h | 2 +- src/waffle/wgl/wgl_platform.h | 2 +- src/waffle/wgl/wgl_window.h | 2 +- 5 files changed, 5 insertions(+), 5 del

[waffle] [PATCH 01/13] wgl: remove unneeded asserts

2016-04-05 Thread Emil Velikov
fwd_compat is already handled at the top of the function, while version checks will become invalid with a later patch. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/wgl/wgl_config.c | 9 - 1 file changed, 9 deletions(-) diff --git a/src/waffle/wgl/wgl_conf

[waffle] [PATCH 04/13] wcore: don't parse/validate the exact major/minor version

2016-04-05 Thread Emil Velikov
change. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/core/wcore_config_attrs.c | 45 --- src/waffle/core/wcore_config_attrs_unittest.c | 64 --- 2 files changed, 109 deletions(-) diff --git a/src/waffle/core/wcore_confi

[waffle] [PATCH 10/13] cgl: fold all ES handling in supports_api()

2016-04-05 Thread Emil Velikov
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/cgl/cgl_display.m | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/waffle/cgl/cgl_display.m b/src/waffle/cgl/cgl_display.m index 1820e6c..1ec5e39 100644 --- a/src/waffle/cgl/cgl_display.m +++ b/src/waff

[waffle] [PATCH 12/13] linux: cosmetic/coding style fixes

2016-04-05 Thread Emil Velikov
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/linux/linux_platform.c | 16 +--- src/waffle/linux/linux_platform.h | 10 +++--- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/src/waffle/linux/linux_platform.c b/src/waffle

[waffle] [PATCH 09/13] waffle: replace wcore_error_internal with assert()

2016-04-05 Thread Emil Velikov
The upper layer (api/core) already checks and bails out if the provided value for context_api is invalid. Change the condition to an assert so that we can catch it as (if) we extend the API and forget to update one of the backends. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --

[waffle] [PATCH 05/13] wcore: indent with spaces, not tabs

2016-04-05 Thread Emil Velikov
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/core/wcore_config_attrs.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/src/waffle/core/wcore_config_attrs.c b/src/waffle/core/wcore_config_attrs.c index b

[waffle] [PATCH 0/3] Pre OpenGL 3.0, ARB_create_context and waffle

2016-04-05 Thread Emil Velikov
Hi all, A few fixes, all maint material considering we all agree on the idea. Long story short, piglit explicitly feeds in a requested version in the range 10-15 which waffle interprets as "I must use {GLX,WGL}_ARB_create_context". Jose and Ilia managed to convince me that this should really

[waffle] [PATCH 3/3] tests/gl_basic_test: query context flags only for desktop GL 3.0 or later

2016-04-05 Thread Emil Velikov
Spotted while attemting to use classic swrast with waffle. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- tests/functional/gl_basic_test.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/tests/functional/gl_basic_te

[waffle] [PATCH 2/3] wgl: don't use ARB_create_context with pre 3.0 contexts

2016-04-05 Thread Emil Velikov
Direct port of previous commit. Cc: Jose Fonseca <jfons...@vmware.com> Cc: Ilia Mirkin <imir...@alum.mit.edu> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/wgl/wgl_config.c | 7 --- src/waffle/wgl/wgl_context.c | 12 +++- src/waffle/wgl/

[waffle] [PATCH 1/3] glx: don't use ARB_create_context with pre 3.0 contexts

2016-04-05 Thread Emil Velikov
ons...@vmware.com> Cc: Ilia Mirkin <imir...@alum.mit.edu> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/glx/glx_config.c | 7 --- src/waffle/glx/glx_context.c | 12 +++- src/waffle/glx/glx_context.h | 16 3 files changed, 3

Re: [waffle] [PATCH] add robust access context support

2016-04-04 Thread Emil Velikov
Hi Bas, Big thanks for adding this. It's been on my radar for a while but considering no mesa drivers supported it I never got to it. Top-level question, can we please split this into a separate patches - waffle.h + core, egl, glx, wgl. On 4 April 2016 at 12:31, Bas Nieuwenhuizen

Re: [waffle] [PATCH 04/12] core: add JSON library

2016-01-08 Thread Emil Velikov
On 6 January 2016 at 21:56, Frank Henigman wrote: > A small library for building JSON strings. > > Signed-off-by: Frank Henigman > --- > src/waffle/CMakeLists.txt | 1 + > src/waffle/core/json.c| 235 >

Re: [waffle] [PATCH 03/12] core: store current context in wcore_display

2016-01-08 Thread Emil Velikov
On 6 January 2016 at 21:56, Frank Henigman wrote: > For core functions that need to know the current context, like the > forthcoming wflinfo-like function. > > Signed-off-by: Frank Henigman > --- > src/waffle/api/waffle_gl_misc.c | 11 +++ >

Re: [waffle] [PATCH 01/12] core: store platform type in wcore_platform

2016-01-08 Thread Emil Velikov
Hi Frank, On 6 January 2016 at 21:56, Frank Henigman wrote: > Facilitates platform-specific code in core functions, like the forthcoming > wflinfo-like function. > > Signed-off-by: Frank Henigman > --- > src/waffle/api/waffle_init.c | 32

Re: [waffle] [PATCH 05/12] waffle: add waffle_display_info_json()

2016-01-08 Thread Emil Velikov
On 6 January 2016 at 21:56, Frank Henigman wrote: > Duplicate wflinfo functionality in the API, with the difference that the > information is returned in JSON form. > The function has a parameter for including platform-specific information, > but it is ignored for now. > >

Re: [waffle] [PATCH v2 3/4] wflinfo.c: split version, renderer, and vendor checks

2016-01-06 Thread Emil Velikov
On 5 January 2016 at 19:46, wrote: > From: Dylan Baker > > Pull these out into helper functions, this change will be used in a > following patch to add a JSON printer. > > Signed-off-by: Dylan Baker > > v2: - change

[waffle] [PATCH 03/29] tests/gl_basic: introduce --platform param

2016-01-06 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> This will allow us to selectively run the tests we want, and even run the sets in parallel. Fixes #33: https://github.com/waffle-gl/waffle/issues/33 Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- tests/functional/CM

[waffle] [PATCH 09/29] tests/gl_basic: add test_glXX_core() test macro

2016-01-06 Thread Emil Velikov
... and use it to minimise the duplication across the file. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- tests/functional/gl_basic_test.c | 168 --- 1 file changed, 52 insertions(+), 116 deletions(-) diff --git a/tests/functional/gl_basic_

[waffle] [PATCH 06/29] tests/gl_basic: add test_XX_rgb{,a} macro

2016-01-06 Thread Emil Velikov
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- tests/functional/gl_basic_test.c | 141 --- 1 file changed, 56 insertions(+), 85 deletions(-) diff --git a/tests/functional/gl_basic_test.c b/tests/functional/gl_basic_test.c index 55d078d..0

[waffle] [PATCH 01/29] wayland: add wl_proxy_create wrapper

2016-01-06 Thread Emil Velikov
-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/waffle/wayland/wayland_wrapper.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/waffle/wayland/wayland_wrapper.h b/src/waffle/wayland/wayland_wrapper.h index 40a581a..e2c96ca 100644 --- a/src/waffle/wayland/wayland_wrapper.h

[waffle] [PATCH 05/29] tests/gl_basic: use actual/expect arrays for the pixel storage

2016-01-06 Thread Emil Velikov
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- tests/functional/gl_basic_test.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/tests/functional/gl_basic_test.c b/tests/functional/gl_basic_test.c index c95ae39..55d078d

[waffle] [PATCH 07/29] tests/gl_basic: add test_glXX() macro

2016-01-06 Thread Emil Velikov
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- tests/functional/gl_basic_test.c | 192 +++ 1 file changed, 73 insertions(+), 119 deletions(-) diff --git a/tests/functional/gl_basic_test.c b/tests/functional/gl_basic_test.c index 03c4a0b..a

[waffle] [PATCH 12/29] tests/gl_basic: add test_glesXX() macro

2016-01-06 Thread Emil Velikov
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- tests/functional/gl_basic_test.c | 93 1 file changed, 36 insertions(+), 57 deletions(-) diff --git a/tests/functional/gl_basic_test.c b/tests/functional/gl_basic_test.c index f753276..1

  1   2   3   4   >