Re: [waffle] [PATCH] egl: resolve build issue with pre EGL 1.5 headers

[Chad Versace]

On Fri 19 Aug 2016, Tapani Pälli wrote:
> 
> 
> On 08/18/2016 01:27 PM, Emil Velikov wrote:
> > On 20 July 2016 at 17:27, Emil Velikov  wrote:
> > > In some cases (like building on Android) the headers might not have the
> > > 1.5 definitions, leading to a build failures like the one in github
> > > issue #41.
> > > 
> > > Since the ABI is baked in stone, add a local define to resolve that.
> > > 
> > > Cc: Chad Versace 
> > > Fixes: f8a485e7cc7 ("egl: Improve support for robust GLES contexts on
> > > EGL 1.5")
> > > Issue: https://github.com/waffle-gl/waffle/issues/41
> > > Signed-off-by: Emil Velikov 
> > > ---
> > >  src/waffle/egl/wegl_context.c | 5 +
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/src/waffle/egl/wegl_context.c b/src/waffle/egl/wegl_context.c
> > > index 0e59231..97931fc 100644
> > > --- a/src/waffle/egl/wegl_context.c
> > > +++ b/src/waffle/egl/wegl_context.c
> > > @@ -34,6 +34,11 @@
> > >  #include "wegl_platform.h"
> > >  #include "wegl_util.h"
> > > 
> > > +// Pre EGL 1.5 headers lack the definition.
> > > +#ifndef EGL_CONTEXT_OPENGL_ROBUST_ACCESS
> > > +#define EGL_CONTEXT_OPENGL_ROBUST_ACCESS  0x31B2
> > > +#endif
> > > +
> > Humble poke ?
> 
> LGTM (checked that the values is correct):
> 
> Reviewed-by: Tapani Pälli 

Thanks and pushed.
___
waffle mailing list
waffle@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH] egl: resolve build issue with pre EGL 1.5 headers

[Tapani Pälli]

On 08/18/2016 01:27 PM, Emil Velikov wrote:

On 20 July 2016 at 17:27, Emil Velikov  wrote:

In some cases (like building on Android) the headers might not have the
1.5 definitions, leading to a build failures like the one in github
issue #41.

Since the ABI is baked in stone, add a local define to resolve that.

Cc: Chad Versace 
Fixes: f8a485e7cc7 ("egl: Improve support for robust GLES contexts on
EGL 1.5")
Issue: https://github.com/waffle-gl/waffle/issues/41
Signed-off-by: Emil Velikov 
---
 src/waffle/egl/wegl_context.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/src/waffle/egl/wegl_context.c b/src/waffle/egl/wegl_context.c
index 0e59231..97931fc 100644
--- a/src/waffle/egl/wegl_context.c
+++ b/src/waffle/egl/wegl_context.c
@@ -34,6 +34,11 @@
 #include "wegl_platform.h"
 #include "wegl_util.h"

+// Pre EGL 1.5 headers lack the definition.
+#ifndef EGL_CONTEXT_OPENGL_ROBUST_ACCESS
+#define EGL_CONTEXT_OPENGL_ROBUST_ACCESS  0x31B2
+#endif
+

Humble poke ?


LGTM (checked that the values is correct):

Reviewed-by: Tapani Pälli 



-Emil
___
waffle mailing list
waffle@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/waffle


___
waffle mailing list
waffle@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH] egl: resolve build issue with pre EGL 1.5 headers

[Emil Velikov]

On 20 July 2016 at 17:27, Emil Velikov  wrote:
> In some cases (like building on Android) the headers might not have the
> 1.5 definitions, leading to a build failures like the one in github
> issue #41.
>
> Since the ABI is baked in stone, add a local define to resolve that.
>
> Cc: Chad Versace 
> Fixes: f8a485e7cc7 ("egl: Improve support for robust GLES contexts on
> EGL 1.5")
> Issue: https://github.com/waffle-gl/waffle/issues/41
> Signed-off-by: Emil Velikov 
> ---
>  src/waffle/egl/wegl_context.c | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/waffle/egl/wegl_context.c b/src/waffle/egl/wegl_context.c
> index 0e59231..97931fc 100644
> --- a/src/waffle/egl/wegl_context.c
> +++ b/src/waffle/egl/wegl_context.c
> @@ -34,6 +34,11 @@
>  #include "wegl_platform.h"
>  #include "wegl_util.h"
>
> +// Pre EGL 1.5 headers lack the definition.
> +#ifndef EGL_CONTEXT_OPENGL_ROBUST_ACCESS
> +#define EGL_CONTEXT_OPENGL_ROBUST_ACCESS  0x31B2
> +#endif
> +
Humble poke ?

-Emil
___
waffle mailing list
waffle@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/waffle

[waffle] [PATCH] egl: resolve build issue with pre EGL 1.5 headers

[Emil Velikov]

In some cases (like building on Android) the headers might not have the
1.5 definitions, leading to a build failures like the one in github
issue #41.

Since the ABI is baked in stone, add a local define to resolve that.

Cc: Chad Versace 
Fixes: f8a485e7cc7 ("egl: Improve support for robust GLES contexts on
EGL 1.5")
Issue: https://github.com/waffle-gl/waffle/issues/41
Signed-off-by: Emil Velikov 
---
 src/waffle/egl/wegl_context.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/src/waffle/egl/wegl_context.c b/src/waffle/egl/wegl_context.c
index 0e59231..97931fc 100644
--- a/src/waffle/egl/wegl_context.c
+++ b/src/waffle/egl/wegl_context.c
@@ -34,6 +34,11 @@
 #include "wegl_platform.h"
 #include "wegl_util.h"
 
+// Pre EGL 1.5 headers lack the definition.
+#ifndef EGL_CONTEXT_OPENGL_ROBUST_ACCESS
+#define EGL_CONTEXT_OPENGL_ROBUST_ACCESS  0x31B2
+#endif
+
 static bool
 bind_api(struct wegl_platform *plat, int32_t waffle_context_api)
 {
-- 
2.9.0

___
waffle mailing list
waffle@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/waffle