Re: [waffle] [PATCH 1/4] waffle: put waffle_enum items in a macro

2015-05-12 Thread Chad Versace
On Wed 06 May 2015, Jordan Justen wrote: > On 2015-05-05 21:18:52, Chad Versace wrote: > > Since the only dynamically generated portion of waffle.h (for now, at > > least) will be the enum definitions, there's no reason to use XML if you > > feel it's overkill. (I'm also not opposed to XML, if you

Re: [waffle] [PATCH 1/4] waffle: put waffle_enum items in a macro

2015-05-06 Thread Jordan Justen
On 2015-05-05 21:18:52, Chad Versace wrote: > Since the only dynamically generated portion of waffle.h (for now, at > least) will be the enum definitions, there's no reason to use XML if you > feel it's overkill. (I'm also not opposed to XML, if you do want to go > that route). Chad, you worked on

Re: [waffle] [PATCH 1/4] waffle: put waffle_enum items in a macro

2015-05-05 Thread Chad Versace
On Thu 23 Apr 2015, Emil Velikov wrote: > On 23 April 2015 at 02:07, Frank Henigman wrote: > > On Wed, Apr 22, 2015 at 8:09 PM, Jordan Justen > > wrote: > >> On 2015-04-22 11:03:47, Frank Henigman wrote: > >>> List all waffle_enum items in a big #define to avoid duplicating > >>> the list when a

Re: [waffle] [PATCH 1/4] waffle: put waffle_enum items in a macro

2015-04-23 Thread Emil Velikov
On 23 April 2015 at 02:07, Frank Henigman wrote: > On Wed, Apr 22, 2015 at 8:09 PM, Jordan Justen > wrote: >> On 2015-04-22 11:03:47, Frank Henigman wrote: >>> List all waffle_enum items in a big #define to avoid duplicating >>> the list when a case is needed for each item, e.g. enum to string. >

Re: [waffle] [PATCH 1/4] waffle: put waffle_enum items in a macro

2015-04-22 Thread Frank Henigman
On Wed, Apr 22, 2015 at 8:09 PM, Jordan Justen wrote: > On 2015-04-22 11:03:47, Frank Henigman wrote: >> List all waffle_enum items in a big #define to avoid duplicating >> the list when a case is needed for each item, e.g. enum to string. > > This looks kind of yucky. :) > > When you recently men

Re: [waffle] [PATCH 1/4] waffle: put waffle_enum items in a macro

2015-04-22 Thread Jordan Justen
On 2015-04-22 11:03:47, Frank Henigman wrote: > List all waffle_enum items in a big #define to avoid duplicating > the list when a case is needed for each item, e.g. enum to string. This looks kind of yucky. :) When you recently mentioned the idea of changing wflinfo to be written in python, it m

[waffle] [PATCH 1/4] waffle: put waffle_enum items in a macro

2015-04-22 Thread Frank Henigman
List all waffle_enum items in a big #define to avoid duplicating the list when a case is needed for each item, e.g. enum to string. Signed-off-by: Frank Henigman --- include/waffle/waffle.h | 150 ++-- 1 file changed, 81 insertions(+), 69 deletions(-)