Re: [waffle] json, approach 2, version 2

2016-06-14 Thread Chad Versace
On Thu 21 Apr 2016, Frank Henigman wrote: > Thanks Emil and Chad for reviewing my json series. All suggestions > implemented in v2, except where I replied inline. I'll hold off > sending in case there's more back-and-forth over the first set of > comments. Would also be nice if Chad merged his

Re: [waffle] [PATCH 00/29] Rework the functionality test(s)

2016-06-14 Thread Chad Versace
On Tue 26 Apr 2016, Emil Velikov wrote: > Humble ping ? And an embarassedly late merge. Thanks for all the cleanups. All the patches in the series, except patch 1, are merged. I skipped patch 1 because it introduced a single symbol, but that symbol was never used.

Re: [waffle] [PATCH 00/13] Do less validation of the context version

2016-06-14 Thread Chad Versace
On Tue 26 Apr 2016, Emil Velikov wrote: > Humble ping ? And an embarrasedly late reply... This year, I've taken nearly 4 months off (paternity leave + vacation + sabbatical) and was in a Vulkan crunch for the 3 months before that. My schedule has finally returned to normal. > On 5 April 2016 at

Re: [waffle] [PATCH 00/29] Rework the functionality test(s)

2016-06-14 Thread Emil Velikov
On 14 June 2016 at 18:10, Chad Versace wrote: > On Tue 26 Apr 2016, Emil Velikov wrote: >> Humble ping ? > > And an embarassedly late merge. > > Thanks for all the cleanups. All the patches in the series, except patch > 1, are merged. I skipped patch 1 because it

Re: [waffle] [PATCH 4/4] gbm: implement window_resize

2016-06-14 Thread Emil Velikov
On 16 May 2016 at 11:48, Emil Velikov wrote: > From: Emil Velikov > > Reuse the existing init/teardown functions to create a new window and > nuke the old one on success. > > Note: as we need the original config, we keep a reference to it in

[waffle] [PATCH 1/2] tests/gl_basic: Make GL symbol queries more robust

2016-06-14 Thread Chad Versace
The rules that dictate how to properly query a GL symbol are complex. The rules depend on the OS, on the winsys API, and even on the particular driver being used. The rules differ between EGL 1.4 and EGL 1.5; differ between Linux, Windows, and Mac; and differ between Mesa and Mali. gl_basic_test

Re: [waffle] [PATCH 1/2] tests/gl_basic: Make GL symbol queries more robust

2016-06-14 Thread Emil Velikov
On 14 June 2016 at 22:22, Chad Versace wrote: > Again, with Emil's real email. > > On Tue 14 Jun 2016, Chad Versace wrote: >> Emil, this patch fixes the regressions caused by your patch (still >> uncommitted): >> >> [PATCH 07/13] wegl: untangle dl_can_open() and

Re: [waffle] [PATCH 1/2] tests/gl_basic: Make GL symbol queries more robust

2016-06-14 Thread Chad Versace
Emil, this patch fixes the regressions caused by your patch (still uncommitted): [PATCH 07/13] wegl: untangle dl_can_open() and support_api() On Tue 14 Jun 2016, Chad Versace wrote: > The rules that dictate how to properly query a GL symbol are complex. > The rules depend on the OS, on the

Re: [waffle] [PATCH 1/2] tests/gl_basic: Make GL symbol queries more robust

2016-06-14 Thread Chad Versace
Again, with Emil's real email. On Tue 14 Jun 2016, Chad Versace wrote: > Emil, this patch fixes the regressions caused by your patch (still > uncommitted): > > [PATCH 07/13] wegl: untangle dl_can_open() and support_api() > > On Tue 14 Jun 2016, Chad Versace wrote: > > The rules that dictate

Re: [waffle] [PATCH 00/29] Rework the functionality test(s)

2016-06-14 Thread Emil Velikov
On 14 June 2016 at 22:17, Chad Versace wrote: > On Tue 14 Jun 2016, Emil Velikov wrote: >> On 14 June 2016 at 18:10, Chad Versace wrote: >> > On Tue 26 Apr 2016, Emil Velikov wrote: >> >> Humble ping ? >> > >> > And an embarassedly late merge. >> >

Re: [waffle] json, approach 2, version 2

2016-06-14 Thread Chad Versace
On Thu 21 Apr 2016, Frank Henigman wrote: > Thanks Emil and Chad for reviewing my json series. All suggestions > implemented in v2, except where I replied inline. I'll hold off > sending in case there's more back-and-forth over the first set of > comments. Would also be nice if Chad merged his

Re: [waffle] [PATCH 06/12] wflinfo: add option for JSON output

2016-06-14 Thread Chad Versace
On Thu 21 Apr 2016, Frank Henigman wrote: > On Fri, Apr 8, 2016 at 8:14 PM, Chad Versace wrote: > > On 01/06/2016 11:56 AM, Frank Henigman wrote: > I really hope we can keep this simple. > > I mentioned in the cover letter to this series that the next step is > to gut