Re: [waffle] [PATCH v2 2/4] gl_basic: print a message if gl_basic is successful

2012-08-20 Thread Chad Versace
I committed this patch to master. On 08/13/2012 05:11 PM, Jordan Justen wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- examples/gl_basic.c |1 + 1 file changed, 1 insertion(+) diff --git a/examples/gl_basic.c b/examples/gl_basic.c index 800756a..ea9243d 100644 ---

[waffle] [ANNOUNCE] waffle-1.0.0

2012-08-23 Thread Chad Versace
to implement interactions with the native objects, such as keyboard input, that lie outside Waffle's scope. Acknowledgements - Contributors to this release: Ben Widawski b...@bwidawsk.net Chad Versace chad.vers...@linux.intel.com Jordan Justen jordan.l.jus...@intel.com

[waffle] [ANNOUNCE] waffle-1.0.1

2012-08-29 Thread Chad Versace
#1.0.1 Changes - --- The full set changes can be viewed with `git log waffle-1.0.0..waffle-1.0.1`. Chad Versace (4): include: Fix #include's in waffle_glx.h api: Fix return values waffle: Fix waffle_*_get_native functions waffle: Bump version to 1.0.1 -BEGIN PGP

Re: [waffle] [PATCH] Enabling Waffle library for Android.

2012-08-30 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thanks for incorporating the requested changes. I just commited the patch to master. I made a few cleanups to the patch, which I noted in the commit message. The code is nearly identical to your original patch, except that I had to rename some symbols

Re: [waffle] Waffle Mac Patches

2012-09-25 Thread Chad Versace
[CC'ing waffle list] On 09/24/2012 09:50 PM, Jeff wrote: Hi Chad, Nice presentation on waffle at XDC! I was trying to build it on OSX and ran into some issues with the current git master. I made some patches that fix the build and attached them if you are interested in applying them (all 3

[waffle] [PATCH 4/4] core: Add unittests for boolean waffle_config attrs

2012-09-25 Thread Chad Versace
a unittest exist that checked that an error was thrown on bad values. This patch adds such a test for the other two. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/waffle/core/wcore_config_attrs_unittest.c | 30 +++ 1 file changed, 30 insertions(+) diff --git

[waffle] Trello board

2012-09-27 Thread Chad Versace
For anyone interested, I've created a Trello board [1] for Waffle. It lists bugs and sundry tasks. There is also a link to the Trello board on Waffle's homepage. Ping me if you want write access. [1] https://trello.com/board/waffle/4f3d5a187864df3c3343c1a6

Re: [waffle] Hi just found out about this project.

2012-11-05 Thread Chad Versace
On 11/05/2012 03:17 AM, mortdeus wrote: Hi, I just found out about this, and it is perfect for my gocos2d project im working on. Nice. I wanted to know if you guys have looked into google's angle project at all and what your guys opinion is for using it for windows? I've never used ANGLE

Re: [waffle] Hi just found out about this project.

2012-11-11 Thread Chad Versace
/mortdeus/egles/tree/master/waffle On Thu, Nov 8, 2012 at 12:47 PM, Chad Versace chad.vers...@linux.intel.com mailto:chad.vers...@linux.intel.com wrote: I think those two subjects---translating GL to D3D and translating among GL api,s---is outside of the scope of Waffle. But my opinion may

[waffle] [ANNOUNCE] waffle-1.2.1

2012-11-15 Thread Chad Versace
-1.2.0..waffle-1.2.1`. Chad Versace (3): doc/html: Fix fatal typo 'wafffle' in url include: #define restrict for C language c99 doc: Add waffle-1.2.1 release notes signature.asc Description: OpenPGP digital signature ___ waffle mailing list waffle

Re: [waffle] [PATCH] android: Fold nearly all headers into waffle.h

2012-11-18 Thread Chad Versace
Adrian, I split this into two patches and committed it to the master and the 1.2 branch. Like I said in IRC, apologies for the broken 1.2 release. Waffle is now at the point where I can't decide alone that it's time to tag a release and publish the tarball. For waffle-1.3, I'll pull you and Juha

[waffle] [ANNOUNCE] waffle-1.2.2

2012-11-27 Thread Chad Versace
-1.2.2`. Adrian Marius Negreanu (2): android: Fold nearly all headers into waffle.h android: Fix c99-ism in wcore_config_attrs.c Chad Versace (1): egl: Fix call to eglBindAPI for WAFFLE_OPENGL_ES3 Android.mk | 13 + src/waffle/core/wcore_config_attrs.c

Re: [waffle] [Piglit] [ANNOUNCE] waffle-1.2.2

2012-11-28 Thread Chad Versace
On 11/28/2012 10:40 AM, Marek Olšák wrote: On Wed, Nov 28, 2012 at 7:26 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 11/27/2012 07:47 PM, Marek Olšák wrote: HI Chad, FYI, the core GL support in the GLX backend of waffle and/or piglit seems to be broken. All piglit tests

Re: [waffle] [Piglit] [ANNOUNCE] waffle-1.2.2

2012-11-28 Thread Chad Versace
On 11/28/2012 12:22 PM, Marek Olšák wrote: On Wed, Nov 28, 2012 at 8:42 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 11/28/2012 10:40 AM, Marek Olšák wrote: On Wed, Nov 28, 2012 at 7:26 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 11/27/2012 07:47 PM, Marek Olšák wrote

Re: [waffle] [PATCH] glx: make unsuccessful context creation not terminate the whole process

2012-11-29 Thread Chad Versace
Marek, thanks. Until I figure out how waffle clients should register error handlers, this fix looks like a good workaround. I committed it to the master and 1.2 branch. ___ waffle mailing list waffle@lists.freedesktop.org

Re: [waffle] [Piglit] [ANNOUNCE] waffle-1.2.2

2012-11-29 Thread Chad Versace
On 11/29/2012 01:35 PM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: On 11/28/2012 12:22 PM, Marek Olšák wrote: On Wed, Nov 28, 2012 at 8:42 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 11/28/2012 10:40 AM, Marek Olšák wrote: On Wed, Nov 28, 2012 at 7:26

Re: [waffle] [PATCH] Android: Fix surface setup segfault

2013-02-20 Thread Chad Versace
On 02/18/2013 04:20 AM, Juha-Pekka Heikkila wrote: Seems like compiling with latest Android tree malloc/free did not work with structures in droid_surfaceflingerlink.cpp, some members in structures become strange causing segfault. Using new/delete fix this. Signed-off-by: Juha-Pekka

[waffle] Test, please ignore (v7)

2013-04-10 Thread Chad Versace
Test, please ignore. ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

[waffle] [ANNOUNCE] waffle-1.3.rc1

2013-09-19 Thread Chad Versace
A new pre-release has been tagged, waffle-1.3.rc1. The real waffle-1.3.0 will get released on Thu 26 Sept. I request your assistance in testing it on your favorite platform. Specifically, I need assistance in testing Android and Mac OS 10.7. As long as the test application examples/gl_basic

Re: [waffle] [PATCH v2 1/4] waffle utils: add wflinfo utility

2014-01-06 Thread Chad Versace
On Mon, Dec 23, 2013 at 09:48:33PM -0800, Jordan Justen wrote: glxinfo for waffle, but using the command line interface of waffle's gl_basic test. v2: * Various cleanups suggested by Chad * Print context flags rather than verifying them. * Only print extensions when --verbose is used

Re: [waffle] [PATCH v2 3/4] waffle utils: add wflinfo man page

2014-01-06 Thread Chad Versace
+ refsect1 +titleOptions/title + refsect1 +titleDescription/title to + refsect1 +titleDescription/title + refsect1 +titleRequired Parameters/title + refsect1 +titleOptions/title With that change, Reviewed-by: Chad Versace chad.vers...@linux.intel.com

Re: [waffle] [PATCH 1/4] wflinfo: Clean usage text

2014-01-25 Thread Chad Versace
Jordan, I committed this series to master. ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

[waffle] [PATCH] wfinfo: Add short option -h for --help

2014-02-07 Thread Chad Versace
Document it in the manpage too. CC: Jordan Justen jordan.l.jus...@intel.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- man/wflinfo.1.xml | 1 + src/utils/wflinfo.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/man/wflinfo.1.xml b/man/wflinfo.1.xml

Re: [waffle] waffle for android-4.1.2_r1

2014-03-01 Thread Chad Versace
Juha and Arun, I posted this patch on a temporary branch for your testing 'tmp-android-fixes'. https://github.com/chadversary/waffle/commits/tmp-android-fixes After Juha-Pekka tests the patch, I'll commit. -Chad On Fri, Feb 28, 2014 at 12:14:38PM +0530, Arun Sl wrote: Hello Juha,

Re: [waffle] waffle for android-4.1.2_r1

2014-03-01 Thread Chad Versace
Arun, I committed your changes to master. As Juha said, when contributing patches to public projects, please create your patches with `git format-patch`. If you do that, it makes the maintainer's job (that's me) much easier, because I can quickly apply your patches git `git am`. If you're feeling

[waffle] [PATCH] egl: Fix creation of compatibility contexts

2014-03-08 Thread Chad Versace
From: Chad Versace c...@kiwitree.net wegl_context_create() ignored wcore_config_attrs::context_profile and never set EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR. The default value of EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR is EGL_CONTEXT_OPENGL_CORE_PROFILE_BIT_KHR. Therefore, for context versions = 3.2

Re: [waffle] [PATCH] egl: Fix creation of compatibility contexts

2014-03-08 Thread Chad Versace
On Sat, Mar 8, 2014 at 6:43 PM, Jordan Justen jljus...@gmail.com wrote: On Sat, Mar 8, 2014 at 9:39 AM, Chad Versace c...@chad-versace.us wrote: From: Chad Versace c...@kiwitree.net Jordan, this patch is untested because I have access to no Linux computer this weekend. When you

[waffle] [PATCH 0/6] wflinfo: Make wflinfo understand OpenGL 3.1 profiles

2014-04-28 Thread Chad Versace
I believe this is final feature needed for waffle-1.4. So, after this series lands and the few remaining 1.4 blocker issues on https://github.com/waffle-gl/waffle/issues?milestone=1state=open get resolved, I'll send out a wafle-1.4 release candidate announcement. Chad Versace (6): wflinfo

[waffle] [PATCH 1/6] wflinfo: Don't modify struct options after initialization

2014-04-28 Thread Chad Versace
parse_args() initializes global options. After that, options should be immutable. To ensure that, constify each occurence of struct options as a function parameter. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/utils/wflinfo.c | 13 +++-- 1 file changed, 7 insertions

Re: [waffle] waffle man pages 80 columns

2014-04-30 Thread Chad Versace
On Sun, Apr 27, 2014 at 03:33:36PM -0700, Jordan Justen wrote: Debian's lintian tool is flagging a manpage-has-errors-from-man warning on: * waffle_config.3 * waffle_context.3 * waffle_display.3 * waffle_is_extension_in_string.3 * waffle_window.3 I guess the issue is that these man pages

Re: [waffle] [PATCH 5/6] wflinfo: Distinguish between cmdline options and func options

2014-04-30 Thread Chad Versace
On Mon, Apr 28, 2014 at 11:45:41PM -0700, Jordan Justen wrote: On Mon, Apr 28, 2014 at 8:43 PM, Chad Versace static bool -wflinfo_try_create_context(const struct options *opts, - struct waffle_display *dpy, +wflinfo_try_create_context(struct waffle_display *dpy

Re: [waffle] [PATCH 2/2] wflinfo: Properly handle minor versions 9

2014-04-30 Thread Chad Versace
On Wed, Apr 30, 2014 at 10:27:04AM -0700, Jordan Justen wrote: On Tue, Apr 29, 2014 at 1:12 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Tuesday, April 29, 2014 08:39:19 Jordan Justen wrote: Previously -V 1.40 would be treated the same as -V 5.0. Instead, whenever a minor version is

Re: [waffle] [PATCH 1/2] wflinfo: Don't allow negative version numbers

2014-04-30 Thread Chad Versace
On Tue, Apr 29, 2014 at 08:39:18AM -0700, Jordan Justen wrote: Previously, -V 4.-8 would be treated the same as -V 3.2. WTF?!? Reviewed-by: Chad Versace chad.vers...@linux.intel.com (Jordan, commit the patch with your new superpowers. It's your patch afterall). Hmm... wflinfo keeps getting

Re: [waffle] [PATCH 0/6] wflinfo: Make wflinfo understand OpenGL 3.1 profiles

2014-04-30 Thread Chad Versace
On Mon, Apr 28, 2014 at 11:23:13PM -0700, Jordan Justen wrote: On Mon, Apr 28, 2014 at 8:43 PM, Chad Versace chad.vers...@linux.intel.com wrote: After this series, the following all do what the user wants them to do. wflinfo --api=gl --version=3.1 wflinfo --api=gl --version=3.1

Re: [waffle] [PATCH 0/6] wflinfo: Make wflinfo understand OpenGL 3.1 profiles

2014-04-30 Thread Chad Versace
On Wed, Apr 30, 2014 at 07:25:39PM -0700, Chad Versace wrote: On Mon, Apr 28, 2014 at 11:23:13PM -0700, Jordan Justen wrote: These results (on nvidia with GL 4.4) could be better: $ bin/wflinfo -p glx -a gl -V 3.1 --profile=core Waffle error: 0x0 WAFFLE_NO_ERROR $ bin/wflinfo -p

Re: [waffle] [PATCH 2/6] wflinfo: Cleanup signature of wflinfo_try_create_context()

2014-05-05 Thread Chad Versace
On Sat, May 03, 2014 at 12:36:49AM +0100, Emil Velikov wrote: On 29/04/14 04:43, Chad Versace wrote: The function creates and returns two objects: a context and a config. The context is the function's return value, and the config is an out parameter. Functions with asymmetric returns

Re: [waffle] [PATCH 2/4] waffle internals: Add helper functions for attrs versions

2014-05-08 Thread Chad Versace
On Thu, May 08, 2014 at 10:13:59PM -0700, Chad Versace wrote: On Sun, May 04, 2014 at 10:14:19AM -0700, Jordan Justen wrote: These functions make it easier to compare against known OpenGL and OpenGLES versions since all known and expected future versions have a minor version = 9

[waffle] [website PATCH 1/2] Move release tarballs from chad's freedesktop home dir to github

2014-05-09 Thread Chad Versace
Change the url for each file waffle-${version}.tar.xz. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- releases.html | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/releases.html b/releases.html index c9d36bf..ffbd87b 100644

Re: [waffle] [PATCH 1/3] doc/release-notes: Add waffle-next.txt

2014-05-12 Thread Chad Versace
On Fri, May 09, 2014 at 09:40:57AM -0700, Jordan Justen wrote: On Thu, May 8, 2014 at 9:31 PM, Chad Versace chad.vers...@linux.intel.com wrote: On Fri, May 02, 2014 at 07:51:07PM -0700, Jordan Justen wrote: Looks good to me, except that the next release will be 1.4.0, not 1.3.90. If you

Re: [waffle] [PATCH] pkg arch/mac: Update release tarball urls

2014-05-12 Thread Chad Versace
couldn't handle https. So the Portfile lookds good to me, though I didn't test either. (I tend to test Mac very infrequently). Feel free to slap Reviewed-by/Tested-by: Emil Velikov emil.l.veli...@gmail.com And add mine too. Reviewed-by: Chad Versace chad.vers...@linux.intel.com Just added your tree

Re: [waffle] [PATCH] man: Update waffle website url

2014-05-12 Thread Chad Versace
Reviewed-by: Chad Versace chad.vers...@linux.intel.com On Fri, May 09, 2014 at 11:04:13AM -0700, Jordan Justen wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- 'git grep chadversary' shows that the release notes still use the old url. Should these be updated? Let's

[waffle] ANNOUNCE: Waffle has moved to Github

2014-05-27 Thread Chad Versace
Waffle's website and source has moved from Freedesktop to Github. The mailing list will remain at Freedesktop. These are the new urls: source: git://github.com/waffle-gl/waffle gitweb: https://github.com/waffle-gl/waffle issue-tracker: https://github.com/waffle-gl/waffle/issues

Re: [waffle] [PATCH 4/8] cmake: use the relative path in the install targets

2014-05-30 Thread Chad Versace
Committed to master. On Sat, May 24, 2014 at 11:51:31PM +0100, Emil Velikov wrote: Otherwise make DESTDIR=... install will not function properly. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- CMakeLists.txt| 4 ++-- doc/CMakeLists.txt| 4 ++--

Re: [waffle] [PATCH 6/8] waffle: move WAFFLE_API out of the API header

2014-05-30 Thread Chad Versace
On Sat, May 24, 2014 at 11:51:33PM +0100, Emil Velikov wrote: WAFFLE_API is used to define the symbol visibility and all functions provided by the API must be non-hidden. Thus the define should be used internally in conjunction with the compiler used in order to properly annotate the symbols.

Re: [waffle] [PATCH 0/8] Move WAFFLE_API out of the public header + misc patches

2014-05-30 Thread Chad Versace
Patch 7 is committed to master. I added an r-b tag for Jose. On Thu, May 29, 2014 at 11:17:55AM -0700, Jose Fonseca wrote: The Windows specifc change (patch 7) looks good. The rest looks sensible too FWIW, but I'm not the best person to comment, as I'm not yet familiar with the code base.

Re: [waffle] [PATCH 8/8] core: update wcore_enum_to_string()

2014-05-30 Thread Chad Versace
On Sat, May 24, 2014 at 11:51:35PM +0100, Emil Velikov wrote: Add a couple of missing cases - PLATFORM_GBM and DL_OPENGL_ES3. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/waffle/core/wcore_util.c | 2 ++ 1 file changed, 2 insertions(+) Committed to master.

Re: [waffle] [GSOC 2014] How to deal with non win32 api, wgl(Create, Make)Context depends on existing window

2014-06-02 Thread Chad Versace
On Sat, May 31, 2014 at 12:02:10PM -0700, Jose Fonseca wrote: - Original Message - - Original Message - On 24/05/14 20:28, Emil Velikov wrote: Hi all, Another round of interesting bits and bulbs. Bit of an update: The email came out a

Re: [waffle] [GSOC 2014] How to deal with non win32 api, wgl(Create, Make)Context depends on existing window

2014-06-05 Thread Chad Versace
On Wed, Jun 04, 2014 at 11:47:32PM -0700, Jose Fonseca wrote: I thought we wanted to go ahead an provide a binary build for windows, and thus: 1. It should be buildable under Linux using mingw 2. The binary should have a reasonable license situation Didn't we already pretty much have

Re: [waffle] [GSOC 2014] How to deal with non win32 api, wgl(Create, Make)Context depends on existing window

2014-06-05 Thread Chad Versace
On Wed, Jun 04, 2014 at 01:24:38PM -0700, Jose Fonseca wrote: - Original Message - On 02/06/14 19:55, Chad Versace wrote: On Sat, May 31, 2014 at 12:02:10PM -0700, Jose Fonseca wrote: - Original Message - - Original Message - On 24/05/14 20:28

Re: [waffle] [PATCH 01/10] pkg/archlinux: Update to a dual (+multilib) package

2014-06-05 Thread Chad Versace
On Sat, May 31, 2014 at 03:21:59AM +0100, Emil Velikov wrote: Include both 64bit and multilib binaries when building on x86-64 platform. This saves us deeping track of version numbers and interdependencies in case of a split package. v2: Rebase and bump pkgrel Signed-off-by: Emil Velikov

Re: [waffle] [PATCH 02/10] cmake: reformat/update install targets

2014-06-05 Thread Chad Versace
it to 'bin'. v2: Tag html documentation as htmldocs COMPONENT. Suggested by Chad. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http

Re: [waffle] [PATCH 04/10] cmake: add autodetection for waffle_has_egl, glx...

2014-06-06 Thread Chad Versace
On Sat, May 31, 2014 at 03:22:02AM +0100, Emil Velikov wrote: Silence the pkg_check_modules and check set the default options depending on the packages found. This is a good idea and will make Waffle easier to configure for everyone. There are a few problems though. If configuration fails

Re: [waffle] [PATCH 05/10] waffle: remove found_platform from waffle_init_parse_attrib_list

2014-06-06 Thread Chad Versace
On Sat, May 31, 2014 at 03:22:03AM +0100, Emil Velikov wrote: Whenever a platform is missing a case statement, the default will kick in throwing an error and exiting the function. Ah, but that's not what 'found_platform' is checking for... -if (!found_platform) { -

Re: [waffle] [PATCH 08/10] cgl: avoid leaking the PixelFormat

2014-06-06 Thread Chad Versace
On Sat, May 31, 2014 at 03:22:06AM +0100, Emil Velikov wrote: According to apple developer page, starting with OS X v10.5 the pixelformat is reference counted. The object is created at CGLChoosePixelFormat and should be unrefeferenced via CGLReleasePixelFormat/CGLDestroyPixelFormat. The

Re: [waffle] [PATCH 09/10] x11: correctly set the screen number of the current display

2014-06-06 Thread Chad Versace
= DefaultScreen(self-xlib); return true; } Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 10/10] glx: glx_context_create_native returns GLXContext not bool

2014-06-06 Thread Chad Versace
NULL; ctx = wrapped_glXCreateContextAttribsARB(platform, dpy-x11.xlib, -- Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http

Re: [waffle] [PATCH 0/3] Memory leak fixes

2014-06-06 Thread Chad Versace
On Sun, Jun 01, 2014 at 03:11:59PM +0100, Emil Velikov wrote: Spotted while searching for a severe memory corruption under wgl. Did not manage to find it yet, although notices these bad boys. Awesome. Patch 1 is rb'd and committed to master. I will case the corruption bug over the next few

Re: [waffle] [GSOC2014] Current design/implementation + the infamous corruption

2014-06-06 Thread Chad Versace
On Thu, Jun 05, 2014 at 05:49:04PM +0100, Emil Velikov wrote: On 05/06/14 03:19, Emil Velikov wrote: waffle_window_create(config, w, h) + waffle_window_resize() // Reuse the window... and boom. Any suggestions on // how to resolve this, or should we mandate that

Re: [waffle] [PATCHv2 04/10] cmake: add autodetection for waffle_has_egl, glx...

2014-06-10 Thread Chad Versace
On Fri, Jun 06, 2014 at 02:18:37PM +0100, Emil Velikov wrote: Silence the pkg_check_modules and check set the default options depending on the packages found. Error out if the user has selected an option and it's requirements are not met. v2: - Do not silence pkg_check_modules. -

Re: [waffle] [PATCH 05/10] waffle: remove found_platform from waffle_init_parse_attrib_list

2014-06-10 Thread Chad Versace
On Fri, Jun 06, 2014 at 12:24:06PM +0100, Emil Velikov wrote: On 06/06/14 07:25, Chad Versace wrote: On Sat, May 31, 2014 at 03:22:03AM +0100, Emil Velikov wrote: Whenever a platform is missing a case statement, the default will kick in throwing an error and exiting the function. Ah

Re: [waffle] Waffle and GL dispatch

2014-06-27 Thread Chad Versace
On Thu, Jun 26, 2014 at 05:46:56PM +0100, Eric Anholt wrote: Emil Velikov emil.l.veli...@gmail.com writes: Not aiming at it atm, but just curious - which one would you consider as the better option: - Convert waffle to use libepoxy, or - clone the current implementation into waffle and

Re: [waffle] waffle-wgl a hefty mId-term code drop :)

2014-06-27 Thread Chad Versace
On Thu, Jun 26, 2014 at 12:55:53PM +0100, Emil Velikov wrote: Hi all, It's official the first half of the project is now complete. Concise and up-to the point information can be seen in the release notes [1]. [1] https://github.com/evelikov/waffle/releases/tag/v1.0 Awesome! P.S. If it

Re: [waffle] [PATCH 0/3] Memory leak fixes

2014-07-01 Thread Chad Versace
On Thu, Jun 26, 2014 at 01:17:30PM +0100, Emil Velikov wrote: On 06/06/14 07:38, Chad Versace wrote: On Sun, Jun 01, 2014 at 03:11:59PM +0100, Emil Velikov wrote: Spotted while searching for a severe memory corruption under wgl. Did not manage to find it yet, although notices these bad boys

Re: [waffle] waffle vs msvc: Round 1, Fight !!!

2014-07-01 Thread Chad Versace
On Mon, Jun 30, 2014 at 01:05:27AM +0100, Emil Velikov wrote: Hello all, Another day another long email :) As usual, a list of issues, possible solutions, and my personal preference for each. At the end I have tried to assign a priority for most. Any input would be greatly appreciated.

Re: [waffle] [PATCH 03/33] cgl: avoid leaking the PixelFormat

2014-07-15 Thread Chad Versace
Patches 1-3 look good and are committed to master. ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 05/33] api: remove double NULL check

2014-07-15 Thread Chad Versace
/api/waffle_context.c | 2 +- src/waffle/api/waffle_gl_misc.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http

Re: [waffle] [PATCH 07/33] linux: plug a memory leak

2014-07-16 Thread Chad Versace
On 07/07/2014 10:28 AM, Emil Velikov wrote: Chad, do you have a plan/idea how to handle this ? I'm assuming that your plan is to tackle this once waffle_init is gone/replaced with a better solution (issue #7). There appears to be a straightforward solution: add a new API call

Re: [waffle] [PATCH 16/33] third_party/threads: import c11 threads emulation wrappers

2014-07-16 Thread Chad Versace
Emil, I'm finished reviewing for today, and am stopping here at patch 16. I'll resume reviewing tomorrow. I see that you're collecting reviewed-by tags and cleanups on versioned brancehs (for-upstream-3.*). I will defer cherry-picking patches off the mailing list onto master; and instead will

[waffle] Windows workflow and updates

2014-07-21 Thread Chad Versace
On 07/21/2014 09:45 AM, Emil Velikov wrote: On 17/07/14 05:40, Chad Versace wrote: I see that you're collecting reviewed-by tags and cleanups on versioned branches (for-upstream-3.*). I will defer cherry-picking patches off the mailing list onto master; and instead will wait for you to send

Re: [waffle] [PATCH 16/33] third_party/threads: import c11 threads emulation wrappers

2014-07-27 Thread Chad Versace
On 07/23/2014 09:11 AM, Jose Fonseca wrote: On 21/07/14 17:45, Emil Velikov wrote: On 17/07/14 05:40, Chad Versace wrote: Emil, I think that mixing GLUT with other stuff is a bad idea. Otherwise -- whether to add some input support to waffle or not -- is a design choice that Chad needs

Re: [waffle] [PULL] waffle-fixes

2014-07-27 Thread Chad Versace
On 07/27/2014 05:38 AM, Emil Velikov wrote: Humble ping :) On 22/07/14 20:42, Emil Velikov wrote: Hi Chad, Can you please pull the series into master. It contains most of the lengthy series of fixes that was flowing on the mailing-list. Ping acknowledged :) I merged your series into

Re: [waffle] [PATCH 03/18] README_WIN: add some notes about configuring and building WGL

2014-07-30 Thread Chad Versace
On 07/23/2014 08:40 AM, Emil Velikov wrote: On 23/07/14 16:13, Jose Fonseca wrote: On 23/07/14 04:31, Emil Velikov wrote: TODO: - Fill in the missing sections. - Move to a better place. - Double-check for typos and thinkos. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---

Re: [waffle] [PATCH 01/18] cmake: include the CPACK module

2014-07-30 Thread Chad Versace
more than the traditional GNU-style `make dist` or `make tarball`. Reviewed-by: Chad Versace chad.vers...@linux.intel.com Tested-by: Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org

Re: [waffle] [PATCH 02/18] pkg/archlinux: add mingw-w64-waffle package

2014-07-30 Thread Chad Versace
..a2ebde5 --- /dev/null +++ b/pkg/archlinux/mingw-w64-waffle/PKGBUILD @@ -0,0 +1,80 @@ +# Maintainer: Chad Versace chad.vers...@linux.intel.com + +pkgname='mingw-w64-waffle' +pkgver='1.3.0' +pkgrel=1 +pkgdesc='a library for choosing window system and OpenGL API at runtime (mingw-w64)' +arch

Re: [waffle] [PATCH 06/18] wgl: implement display management

2014-07-30 Thread Chad Versace
On 07/23/2014 08:27 AM, Jose Fonseca wrote: On 23/07/14 16:25, Jose Fonseca wrote: On 23/07/14 04:31, Emil Velikov wrote: +PIXELFORMATDESCRIPTOR pfd = { +sizeof(PIXELFORMATDESCRIPTOR), +1, +PFD_SUPPORT_OPENGL | +PFD_DRAW_TO_WINDOW | +

Re: [waffle] [PATCH 1/4] wgl: strings.h does not exist in MSVC

2014-08-18 Thread Chad Versace
For this 4 patch series, Reviewed-by: Chad Versace chad.vers...@linux.intel.com I'll wait for a pull request. ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 0/8] make check cleanup windows support

2014-08-19 Thread Chad Versace
On 08/04/2014 07:34 AM, Emil Velikov wrote: So it seems like I've completely missed out to send this series last week, so here it goes. The series covers - Consolidates the duplicating gl_basic_test(s) into two groups - all and all_but_cgl (as cgl is the wierd one this time). - Adds

Re: [waffle] [PATCH 0/8] make check cleanup windows support

2014-08-20 Thread Chad Versace
On 08/20/2014 05:58 AM, Emil Velikov wrote: On 20/08/14 00:38, Chad Versace wrote: On 08/04/2014 07:34 AM, Emil Velikov wrote: TEST_RUN2(gl_basic, glx_gl20, all_gl20); TEST_RUN2(gl_basic, glx_gl21, all_gl21); Note that this still gives us a ton of duplication, yet I feel that any further

Re: [waffle] [PATCH] x11: fix for a non-zero default screen

2014-08-20 Thread Chad Versace
On 08/20/2014 07:11 AM, Emil Velikov wrote: On 19/08/14 23:10, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Marek you have my vote if you ever run for a president, going through mesa and waffle to fix this - you're a star :) Must admit that I don't have much experience with xcb

Re: [waffle] [PATCH 4/4] wgl: attempt to fix the final test

2014-08-20 Thread Chad Versace
On 08/19/2014 11:42 AM, Jose Fonseca wrote: On 19/08/14 18:44, Emil Velikov wrote: On 19 August 2014 16:51, Jose Fonseca jfons...@vmware.com wrote: On 19/08/14 16:41, Jose Fonseca wrote: I'm sure it overflows on Linux too. valgrind might complain. But MSVC emits code to check for stack

Re: [waffle] Final (GSoCwise) waffle WGL release

2014-08-20 Thread Chad Versace
On 08/20/2014 06:55 AM, Emil Velikov wrote: waffle works like a champ with WGL, even piglit approves :P With branches 'yet-another-round-of-msvc-fixes-1.2' [1] and 'waffle-WGL-1.2' I can run piglit+waffle+wgl on my Windows 7 machine and even crash the drivers on a non-concurrent run :)

[waffle] [ANNOUNCE] Waffle 1.4.0-rc1

2014-09-07 Thread Chad Versace
information about the system's OpenGL capabilities, similar to 'glxinfo'. See the documentation at [man:wflinfo.1] or [http://www.waffle-gl.org/man/wflinfo.1.html]. (Implemented by Jordan Justen. Chad Versace fixed some bugs and corner cases). * Linux * GBM backend

Re: [waffle] [PATCH] android: misc build fixes

2014-09-09 Thread Chad Versace
Thanks. Pushed to 'next'. On 07/31/2014 06:14 AM, Emil Velikov wrote: - Add $(top)/include to the local_c_includes. Required for c99_compat.h header. - Build third_party/threads library, add $(top)/third_party/threads to local_c_includes (for threads.h) - pthread_mutex_timedlock is not

Re: [waffle] Checking In

2014-09-11 Thread Chad Versace
On 09/07/2014 05:37 PM, Jordan Justen wrote: Emil has made some progress on the linking issue. https://github.com/waffle-gl/waffle/issues/9 This might be something to also consider for 2.0, but might delay it a bit. Having a year between 1.3 and 1.4, I'm reluctant to introduce delays. To

Re: [waffle] Checking In

2014-09-11 Thread Chad Versace
On 09/08/2014 10:06 AM, Emil Velikov wrote: Hi Chad, On 08/09/14 00:47, Chad Versace wrote: P.S. Preliminary time-schedule looks good imho. Here's the plan I have for the remainder of September. If you see problems with this plan or if you think it's just fine, please let me know

Re: [waffle] [PATCH] HACKING.txt: Don't recommend Apache 2.0 for contributions

2014-09-11 Thread Chad Versace
-by: Chad Versace chad.vers...@linux.intel.com The mentioning of Apache was unintentional, a product of copy-paste from an older file. My recommendation is that the wording should request that BSD be used, but note that MIT licensed code would also be accepted. The reason is that I think

[waffle] [PATCH (master)] doc: Install all release notes

2014-09-16 Thread Chad Versace
This fixes a bug. The 1.4.0-rc1 release installed the 1.3 release notes but not any 1.4 release notes. To fix this, let's follow the precedent set by git. Update CMake to install *all* release notes. Cc: Jordan Justen jordan.l.jus...@intel.com Signed-off-by: Chad Versace chad.vers

Re: [waffle] [PATCH] cmake: wire up check and check-func with valgrind

2014-09-17 Thread Chad Versace
} ${CMAKE_BINARY_DIR}/tests/functional/gl_basic_test COMMAND ${VALGRIND_EXECUTABLE} $TARGET_FILE:gl_basic_test Without or without Nils' changes, this patch is Reviewed-by: Chad Versace chad.vers...@linux.intel.com I've already applied Nil's changes in my local branch. Do you mind if I push with his

[waffle] [ANNOUNCE] Waffle 1.4.0

2014-09-22 Thread Chad Versace
]. (Implemented by Jordan Justen. Chad Versace fixed some bugs and corner cases). * Linux * GBM backend gains support for DRM render nodes. Waffle's GBM backend will now use render nodes (/dev/dri/render*) if available. Otherwise, it falls back to 1.3.0 behavior and will use

Re: [waffle] Checking In

2014-10-24 Thread Chad Versace
On Wed 22 Oct 2014, Emil Velikov wrote: On 11/09/14 15:43, Chad Versace wrote: On 09/07/2014 05:37 PM, Jordan Justen wrote: Having a year between 1.3 and 1.4, I'm reluctant to introduce delays. To avoid delays like that in the future, I'm thinking that waffle should adopt a short

[waffle] [ANNOUNCE] Waffle 1.4.1

2014-11-07 Thread Chad Versace
Release Notes == Bugfixes * Update the CMake requirement to 2.8.11. Changes --- Chad Versace (3): waffle: Bump version to 1.4.1 .gitignore: Ignore static libraries *.a Android.mk: Fix version of 1.4.0 Emil Velikov (1): cmake: bump minimum

Re: [waffle] Drop the libEGL linking, take 2

2014-11-07 Thread Chad Versace
On Wed 10 Sep 2014, Emil Velikov wrote: Changes comparing to previous round - raised the severity on dlopen/dlsym - crushed some typos - use the versioned lib on linux and the unversioned on android - updated the android build (but untested) Emil, this looks good to me. It's nice to see one

Re: [waffle] Drop the libEGL linking, take 2

2014-11-08 Thread Chad Versace
On Sat 08 Nov 2014, Emil Velikov wrote: On 08/11/14 05:18, Chad Versace wrote: On Wed 10 Sep 2014, Emil Velikov wrote: Changes comparing to previous round - raised the severity on dlopen/dlsym - crushed some typos - use the versioned lib on linux and the unversioned on android - updated

Re: [waffle] [PULL] WGL support

2014-11-09 Thread Chad Versace
On Sun 09 Nov 2014, Emil Velikov wrote: As mentioned earlier here is a rebase of all the wgl work so far on top of origin/master. Merged to next! So... what does that mean??? That means I'll merge your branch to 'master' after it cooks for a little while and I'm certain Piglit doesn't

Re: [waffle] [PULL] WGL support

2014-11-10 Thread Chad Versace
On Mon 10 Nov 2014, Emil Velikov wrote: On 10/11/14 06:17, Chad Versace wrote: On Sun 09 Nov 2014, Emil Velikov wrote: - As explained in man:gitworkflow(7), merges between branches always flow upwards and never downwards. That is, maint - master - next and never

Re: [waffle] [PATCH 1/7] pkg/archlinux: use configure autodetection

2014-11-11 Thread Chad Versace
On Mon 10 Nov 2014, Emil Velikov wrote: Since waffle 1.4 we have autodetection at configure time. Let's use it and drop a couple of lines PKGBUILD magic. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Patch 1 is Reviewed-by: Chad Versace chad.vers...@linux.intel.com

Re: [waffle] [PATCH 2/7] pkg/archlinux: waffle does not link against libegl

2014-11-11 Thread Chad Versace
On Mon 10 Nov 2014, Emil Velikov wrote: As such demote libegl to makedepend/optdepent, so that one can build waffle, and optionally use x11_egl/gbm/wayland. Patch 2 is Reviewed-by: Chad Versace chad.vers...@linux.intel.com And, I see for *more* EGL dependency removal. If I understand

Re: [waffle] [PATCH 3/7] gbm: fetch the libgbm function pointers at wgbm_platform_init

2014-11-11 Thread Chad Versace
/wgbm_platform.h | 17 + 2 files changed, 59 insertions(+), 1 deletion(-) Patch 3 is Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] Remove libgbm/libGL linktime dependency

2014-11-11 Thread Chad Versace
Emil, please collect my reviewed-bys onto your branch and look over the changes in my v2 of patch 4. If all looks good to you, let me know and I'll merge branch. On Mon 10 Nov 2014, Emil Velikov wrote: Hello all, As the name suggests, the series removes the hard dependency of waffle of the

Re: [waffle] [PULL] WGL support

2014-11-12 Thread Chad Versace
On Wed 12 Nov 2014, Jose Fonseca wrote: Hi Emil, I went through the new patches and they look good AFAICT. Thanks for doing this. While going through wgl: fully support ARB_create_context and EXT_create_context_es_profile. again I noticed a couple of issues with the usage of

  1   2   3   >