Re: [waffle] [RFC 1/3] wflinfo.c: split out flags struct

[Dylan Baker]

I'll take that out. It's probably a rebasing artifact anyway.

On Sun, Dec 27, 2015 at 7:43 AM, Frank Henigman 
wrote:

> On Wed, Dec 16, 2015 at 8:37 PM,   wrote:
> > From: Dylan Baker 
> >
> > This is groundwork for adding a json interface to wflinfo.
> > ---
> >  src/utils/wflinfo.c | 19 +++
> >  1 file changed, 11 insertions(+), 8 deletions(-)
> >
> > diff --git a/src/utils/wflinfo.c b/src/utils/wflinfo.c
> > index 268d4b8..905fd90 100644
> > --- a/src/utils/wflinfo.c
> > +++ b/src/utils/wflinfo.c
> > @@ -487,17 +487,18 @@ print_extensions(bool use_stringi)
> >  printf("\n");
> >  }
> >
> > +static struct {
> > +GLint flag;
> > +char *str;
> > +} flags[] = {
> > +{ GL_CONTEXT_FLAG_FORWARD_COMPATIBLE_BIT, "FORWARD_COMPATIBLE" },
> > +{ GL_CONTEXT_FLAG_DEBUG_BIT, "DEBUG" },
> > +{ GL_CONTEXT_FLAG_ROBUST_ACCESS_BIT_ARB, "ROBUST_ACCESS" },
> > +};
> > +
> >  static void
> >  print_context_flags(void)
> >  {
> > -static struct {
> > -GLint flag;
> > -char *str;
> > -} flags[] = {
> > -{ GL_CONTEXT_FLAG_FORWARD_COMPATIBLE_BIT, "FORWARD_COMPATIBLE"
> },
> > -{ GL_CONTEXT_FLAG_DEBUG_BIT, "DEBUG" },
> > -{ GL_CONTEXT_FLAG_ROBUST_ACCESS_BIT_ARB, "ROBUST_ACCESS" },
> > -};
> >  int flag_count = sizeof(flags) / sizeof(flags[0]);
> >  GLint context_flags = 0;
> >
> > @@ -526,6 +527,8 @@ print_context_flags(void)
> >  }
> >  }
> >  printf("\n");
> > +
> > +return;
>
> Not a big deal but I don't see the point of adding this return.
>
> >  }
> >
> >  /// @brief Print out information about the context that was created.
> > --
> > 2.6.4
> >
> > ___
> > waffle mailing list
> > waffle@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/waffle
>
___
waffle mailing list
waffle@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [RFC 1/3] wflinfo.c: split out flags struct

[Frank Henigman]

On Wed, Dec 16, 2015 at 8:37 PM,   wrote:
> From: Dylan Baker 
>
> This is groundwork for adding a json interface to wflinfo.
> ---
>  src/utils/wflinfo.c | 19 +++
>  1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/src/utils/wflinfo.c b/src/utils/wflinfo.c
> index 268d4b8..905fd90 100644
> --- a/src/utils/wflinfo.c
> +++ b/src/utils/wflinfo.c
> @@ -487,17 +487,18 @@ print_extensions(bool use_stringi)
>  printf("\n");
>  }
>
> +static struct {
> +GLint flag;
> +char *str;
> +} flags[] = {
> +{ GL_CONTEXT_FLAG_FORWARD_COMPATIBLE_BIT, "FORWARD_COMPATIBLE" },
> +{ GL_CONTEXT_FLAG_DEBUG_BIT, "DEBUG" },
> +{ GL_CONTEXT_FLAG_ROBUST_ACCESS_BIT_ARB, "ROBUST_ACCESS" },
> +};
> +
>  static void
>  print_context_flags(void)
>  {
> -static struct {
> -GLint flag;
> -char *str;
> -} flags[] = {
> -{ GL_CONTEXT_FLAG_FORWARD_COMPATIBLE_BIT, "FORWARD_COMPATIBLE" },
> -{ GL_CONTEXT_FLAG_DEBUG_BIT, "DEBUG" },
> -{ GL_CONTEXT_FLAG_ROBUST_ACCESS_BIT_ARB, "ROBUST_ACCESS" },
> -};
>  int flag_count = sizeof(flags) / sizeof(flags[0]);
>  GLint context_flags = 0;
>
> @@ -526,6 +527,8 @@ print_context_flags(void)
>  }
>  }
>  printf("\n");
> +
> +return;

Not a big deal but I don't see the point of adding this return.

>  }
>
>  /// @brief Print out information about the context that was created.
> --
> 2.6.4
>
> ___
> waffle mailing list
> waffle@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/waffle
___
waffle mailing list
waffle@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/waffle