> Am Sonntag, 18. Februar 2007 schrieb Giel van Schijndel: >> Author: muggenhor >> Date: Sun Feb 18 22:30:51 2007 >> New Revision: 779 >> >> URL: http://svn.gna.org/viewcvs/warzone?rev=779&view=rev >> Log: >> * improve code readability (e.g. only keeping the `if (malloc(...) == >> NULL) handleError;` part, so as not to wrap all the rest of the code in >> a >> big (recursive) else block * remove function `static void >> sound_SaveTrackData` because the operation it performs doesn't justify a >> whole function (and its calling overhead) * some cleanup in functions >> sound_ReadTrackFromBuffer and sound_ReadTrackFromFile * commented >> operation >> of both functions >> * moved the content of function sound_SaveTrackData (only one >> statement) >> to sound_ReadTrackFromBuffer * modified sound_ReadTrackFromFile to not >> allocate double the size of the needed memory for a buffer >> >> Modified: >> trunk/lib/sound/openal_track.c > You forgot to close the file... Is that intentional?
Yes, I was trying to improve that bit of code in a partially incremental way. So therefore I waited with adding PHYSFS_close until r780. PS It seems that, that is now the only piece of code that actually uses PHYSFS_close. -- Giel _______________________________________________ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
