Re: [warzone2100-dev] demote Asserts to LOG_INFO
On Sun, Apr 24, 2011 at 6:36 AM, buginator buginato...@gmail.com wrote: Unless there are any objections, I plan to demote ASSERT_FAILURE() to use LOG_INFO instead of LOG_ERROR. The main reason for this is that LOG_ERROR is meant for serious errors, and all LOG_ERRORs are echoed to the in game console on all platforms. LOG_INFO is still on in both debug release builds. The other option is LOG_WARNING, which is only enabled in debug builds. Objections ? I thought an assert error was a serious error. At least most serious error nowadays are reported in the form of an assert(_or_return). Maybe we should remove some asserts and / or fix some bugs instead? - Per ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [warzone2100-dev] demote Asserts to LOG_INFO
On 4/24/11, Per Inge Mathisen xxx...@gmail.com wrote: On Sun, Apr 24, 2011 at 6:36 AM, buginator xxx...@gmail.com wrote: Unless there are any objections, I plan to demote ASSERT_FAILURE() to use LOG_INFO instead of LOG_ERROR. The main reason for this is that LOG_ERROR is meant for serious errors, and all LOG_ERRORs are echoed to the in game console on all platforms. LOG_INFO is still on in both debug release builds. The other option is LOG_WARNING, which is only enabled in debug builds. Objections ? I thought an assert error was a serious error. At least most serious error nowadays are reported in the form of an assert(_or_return). Maybe we should remove some asserts and / or fix some bugs instead? There is a difference between when we get those errors, and the end-user. We don't dump any useful information most of the time, and the only way to see what is going on is have a deep stack dump along with all vars. As Kreuvf pointed out, having a log with a bunch of asserts really does not help us do anything, since we can't replicate it, and even if we can replicate it, some of those can't easily be fixed since they happen in the gamestate before the current one, and we don't have a stack dump that goes that far back. In short, we have asserts that fire, and we *know* there is a issue, but can't get at that issue for multiple reasons. No need to spam the in-game console with assert messages. ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [warzone2100-dev] demote Asserts to LOG_INFO
On Sun, Apr 24, 2011 at 9:47 PM, buginator buginato...@gmail.com wrote: In short, we have asserts that fire, and we *know* there is a issue, but can't get at that issue for multiple reasons. No need to spam the in-game console with assert messages. Then stop sending LOG_ERROR to the console? Perhaps make a new LOG_CONSOLE that goes to console? - Per ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
[warzone2100-dev] demote Asserts to LOG_INFO
Unless there are any objections, I plan to demote ASSERT_FAILURE() to use LOG_INFO instead of LOG_ERROR. The main reason for this is that LOG_ERROR is meant for serious errors, and all LOG_ERRORs are echoed to the in game console on all platforms. LOG_INFO is still on in both debug release builds. The other option is LOG_WARNING, which is only enabled in debug builds. Objections ? ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [warzone2100-dev] demote Asserts to LOG_INFO
24.04.2011 06:36, buginator wrote: Unless there are any objections, I plan to demote ASSERT_FAILURE() to use LOG_INFO instead of LOG_ERROR. The main reason for this is that LOG_ERROR is meant for serious errors, and all LOG_ERRORs are echoed to the in game console on all platforms. LOG_INFO is still on in both debug release builds. The other option is LOG_WARNING, which is only enabled in debug builds. Objections ? Any specific reason such as http://developer.wz2100.net/ticket/2573 ? No objections :X Regards - Kreuvf signature.asc Description: OpenPGP digital signature ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
