Re: [Warzone-dev] [patch] code-cleanup: () -> (void)
On Wed, Sep 13, 2006 at 11:47:33AM +0200, Stefan Huehner wrote:
> Hi,
>
> attached patch converts all functions declarations without parameters in
> src/ from () to the ansi c (void) form.
>
attached patch converts some more functions, which have been missed on
the previous patch.
Regards,
Stefan
diff -u src/multijoin.c src/multijoin.c
--- src/multijoin.c (working copy)
+++ src/multijoin.c (working copy)
@@ -72,7 +72,7 @@
//
// Version Check
-BOOL sendVersionCheck()
+BOOL sendVersionCheck(void)
{
NETMSG msg;
diff -u src/multiint.c src/multiint.c
--- src/multiint.c (working copy)
+++ src/multiint.c (working copy)
@@ -771,7 +771,7 @@
//
// Game Chooser Screen.
-static void addGames()
+static void addGames(void)
{
UDWORD i,gcount=0;
W_BUTINIT sButInit;
@@ -1566,7 +1566,7 @@
}
//
-static void SendFireUp()
+static void SendFireUp(void)
{
NETMSG m;
@@ -3263,7 +3263,7 @@
// removewhiteboard
-BOOL removeWhiteBoard()
+static BOOL removeWhiteBoard(void)
{
bWhiteBoardUp = FALSE;
widgReleaseScreen(psWhiteScreen);
@@ -3272,7 +3272,7 @@
// runwhiteboard
-BOOL runWhiteBoard()
+static BOOL runWhiteBoard(void)
{
NETMSG m;
static UDWORD lastSent=0;
@@ -3414,7 +3414,7 @@
}
// add whiteboard
-BOOL addWhiteBoard()
+static BOOL addWhiteBoard(void)
{
W_FORMINIT sFormInit;
diff -u src/mission.c src/mission.c
--- src/mission.c (working copy)
+++ src/mission.c (working copy)
@@ -3541,7 +3541,7 @@
}
-void intRunMissionResult()
+void intRunMissionResult(void)
{
processFrontendSnap(FALSE);
--- src/scriptfuncs.c (revision 345)
+++ src/scriptfuncs.c (working copy)
@@ -2786,7 +2786,7 @@
//
-
// multiplayer limit handler.
-BOOL scrApplyLimitSet()
+BOOL scrApplyLimitSet(void)
{
applyLimitSet();
return TRUE;
--- src/visibility.c(revision 345)
+++ src/visibility.c(working copy)
@@ -1212,7 +1212,7 @@
BOOL bDisplaySensorRange;
-void startSensorDisplay()
+void startSensorDisplay(void)
{
MAPTILE *psTile;
UDWORD x;
@@ -1258,7 +1258,7 @@
bDisplaySensorRange = TRUE;
}
-void stopSensorDisplay()
+void stopSensorDisplay(void)
{
// set the display flag off.
bDisplaySensorRange = FALSE;
--- src/multiopt.c (revision 345)
+++ src/multiopt.c (working copy)
@@ -630,7 +630,7 @@
//
// setup templates
-BOOL multiTemplateSetup()
+BOOL multiTemplateSetup(void)
{
UDWORD player, pcPlayer = 0;
CHARsTemp[256];
@@ -944,7 +944,7 @@
*/
//
// setup a campaign game
-static BOOL campInit()
+static BOOL campInit(void)
{
UDWORD player;
UBYTE newPlayerArray[MAX_PLAYERS];
--- src/keybind.c (revision 345)
+++ src/keybind.c (working copy)
@@ -992,7 +992,7 @@
// --
#define DEFINE_NUMED_KF(x) \
- voidkf_SelectGrouping_##x( ) { \
+ voidkf_SelectGrouping_##x( void ) { \
kf_SelectGrouping(x); \
} \
voidkf_AssignGrouping_##x( void ) { \
--- src/configuration.c (revision 345)
+++ src/configuration.c (working copy)
@@ -475,7 +475,7 @@
return closeWarzoneKey();
}
-BOOL loadRenderMode()
+BOOL loadRenderMode(void)
{
char str[32];
DWORD val;
@@ -500,7 +500,7 @@
}
//
-BOOL saveConfig()
+BOOL saveConfig(void)
{
debug( LOG_WZ, "Writing prefs to registry\n" );
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev
Fwd: Re: [Warzone-dev] [patch] code-cleanup: () -> (void)
KMail seems broken. :( Doesn't answer to the mailinglist by default anymore... -- Am Mittwoch, 13. September 2006 11:34 schrieben Sie: > On Wed, Sep 13, 2006 at 10:24:56AM +0200, Dennis Schridde wrote: > > Am Mittwoch, 13. September 2006 01:31 schrieb Stefan Huehner: > > > Hi, > > > > > > attached patch corrects function declarations without parameters from > > > the old () to the ansi C (void) form. > > > > Commited, but lib/ivis_common/piestate.h doesn't apply. (You modify lines > > 900+, but the file has less than 200 lines?!) > > Hi Dennis, > could you please commit several different topics i.e. my patch and the > VOID -> void changes in different commits? This would make tracking > which portion of ones patch has been committed much easier. As I said, the complete patch has been applied, just piestate.h is missing. But ok, next time I'll do it seperate... --Dennis pgpDU5a1EWenb.pgp Description: PGP signature ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] [patch] code-cleanup: () -> (void)
On Wed, Sep 13, 2006 at 10:24:56AM +0200, Dennis Schridde wrote: > Am Mittwoch, 13. September 2006 01:31 schrieb Stefan Huehner: > > Hi, > > > > attached patch corrects function declarations without parameters from > > the old () to the ansi C (void) form. > Commited, but lib/ivis_common/piestate.h doesn't apply. (You modify lines > 900+, but the file has less than 200 lines?!) Hi Dennis, could you please commit several different topics i.e. my patch and the VOID -> void changes in different commits? This would make tracking which portion of ones patch has been committed much easier. Regards, Stefan ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] [patch] code-cleanup: () -> (void)
On Wed, Sep 13, 2006 at 10:24:56AM +0200, Dennis Schridde wrote: > Am Mittwoch, 13. September 2006 01:31 schrieb Stefan Huehner: > > Hi, > > > > attached patch corrects function declarations without parameters from > > the old () to the ansi C (void) form. > Commited, but lib/ivis_common/piestate.h doesn't apply. (You modify lines > 900+, but the file has less than 200 lines?!) Hi, thanks for applying. The erronous bit is my fault. I'm cutting the diffs into managle pieces for submission and have screwed up this one. I'll send the failing bits along with the next bunch of patches. Regards, Stefan ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] [patch] code-cleanup: () -> (void)
Am Mittwoch, 13. September 2006 01:31 schrieb Stefan Huehner: > Hi, > > attached patch corrects function declarations without parameters from > the old () to the ansi C (void) form. Commited, but lib/ivis_common/piestate.h doesn't apply. (You modify lines 900+, but the file has less than 200 lines?!) --Dennis pgpIxM6iLMmAq.pgp Description: PGP signature ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
