Re: [Warzone-dev] Patch to add research name to 'Research Completed' message in console

[Dennis Schridde]

Am Sonntag, 15. April 2007 schrieb Giel van Schijndel:
> Hylke schreef:
> > Yay!
> > But svn rev 1099 segfaults now :( Backtrace:
> >
> >
> > Program received signal SIGSEGV, Segmentation fault.
> >
> > [Switching to Thread -1224694048 (LWP 15215)]
> > 0x080efdd1 in researchResult (researchIndex=66, player=0 '\0',
> > bDisplay=1) at research.c:2036
> > 2036sprintf(&consoleMsg, _("Research
> > Completed: %s"), *pResearch->pViewData->ppTextMsg);
> > (gdb) bt
> > #0  0x080efdd1 in researchResult (researchIndex=66, player=0 '\0',
> > bDisplay=1) at research.c:2036
> > #1  0x0815331b in structureUpdate (psBuilding=0x8affb90) at
> > structure.c:4314 #2  0x080bc66f in gameLoop () at loop.c:421
> > #3  0x080be65a in main (argc=1, argv=0xbfc3c944) at main.c:714
>
> Looks like a buffer overflow to me.
Should be fixed in 1103.


signature.asc
Description: This is a digitally signed message part.
___
Warzone-dev mailing list
[EMAIL PROTECTED]
https://mail.gna.org/listinfo/warzone-dev

Re: [Warzone-dev] Patch to add research name to 'Research Completed' message in console

[Giel van Schijndel]

Hylke schreef:
> Yay!
> But svn rev 1099 segfaults now :( Backtrace:
>
>
> Program received signal SIGSEGV, Segmentation fault.
>
> [Switching to Thread -1224694048 (LWP 15215)]
> 0x080efdd1 in researchResult (researchIndex=66, player=0 '\0',
> bDisplay=1) at research.c:2036
> 2036sprintf(&consoleMsg, _("Research
> Completed: %s"), *pResearch->pViewData->ppTextMsg);
> (gdb) bt
> #0  0x080efdd1 in researchResult (researchIndex=66, player=0 '\0',
> bDisplay=1) at research.c:2036
> #1  0x0815331b in structureUpdate (psBuilding=0x8affb90) at structure.c:4314
> #2  0x080bc66f in gameLoop () at loop.c:421
> #3  0x080be65a in main (argc=1, argv=0xbfc3c944) at main.c:714
>   
Looks like a buffer overflow to me.

-- 
Giel



signature.asc
Description: OpenPGP digital signature
___
Warzone-dev mailing list
[EMAIL PROTECTED]
https://mail.gna.org/listinfo/warzone-dev

Re: [Warzone-dev] Patch to add research name to 'Research Completed' message in console

[Hylke]

Yay!
But svn rev 1099 segfaults now :( Backtrace:


Program received signal SIGSEGV, Segmentation fault.

[Switching to Thread -1224694048 (LWP 15215)]
0x080efdd1 in researchResult (researchIndex=66, player=0 '\0',
bDisplay=1) at research.c:2036
2036sprintf(&consoleMsg, _("Research
Completed: %s"), *pResearch->pViewData->ppTextMsg);
(gdb) bt
#0  0x080efdd1 in researchResult (researchIndex=66, player=0 '\0',
bDisplay=1) at research.c:2036
#1  0x0815331b in structureUpdate (psBuilding=0x8affb90) at structure.c:4314
#2  0x080bc66f in gameLoop () at loop.c:421
#3  0x080be65a in main (argc=1, argv=0xbfc3c944) at main.c:714



The Watermelon wrote:
> Requested by The Noid and Kreuvf on IRC,their wise has been granted. =)
>  
> MAX_RESEARCH_MSG_SIZE is the max size of the message(Length of 'Research
> Completed:' + Length of Research Name)
> I set it to 200 and I think it should be sufficient for all research
> topic names,feel free to change it to greater number if you think it
> will be too small for potential research name size increase such as
> translated research name in other languages.



___
Warzone-dev mailing list
[EMAIL PROTECTED]
https://mail.gna.org/listinfo/warzone-dev