Re: Github pull requests discussion

2016-04-25 Thread Evan Hughes
Yeah, just wanted to make sure community was okay with using pull requests for main repo as a method to accept contributions. On 26/04/2016 11:20 AM, "Michael MacFadden" wrote: > I don't know that we have to "move" to git hub pull requests. We can > support both I guess? > > ~Michael > > > On Apr

Re: Github pull requests discussion

2016-04-25 Thread Michael MacFadden
I don't know that we have to "move" to git hub pull requests. We can support both I guess? ~Michael > On Apr 24, 2016, at 8:38 AM, Evan Hughes wrote: > > Regarding #1 see the commits I pushed today. >> On 25/04/2016 12:58 AM, "Yuri Z" wrote: >> >> I think we can try it. >> I see a few cons t

Re: Github pull requests discussion

2016-04-24 Thread Yuri Z
I see, nice :) On Sun, Apr 24, 2016 at 6:39 PM Evan Hughes wrote: > Regarding #1 see the commits I pushed today. > On 25/04/2016 12:58 AM, "Yuri Z" wrote: > > > I think we can try it. > > I see a few cons though: > > 1. I don't know how to make the asfgit close abandoned pull requests. > > 2. T

Re: Github pull requests discussion

2016-04-24 Thread Evan Hughes
Regarding #1 see the commits I pushed today. On 25/04/2016 12:58 AM, "Yuri Z" wrote: > I think we can try it. > I see a few cons though: > 1. I don't know how to make the asfgit close abandoned pull requests. > 2. There's no integration between Jira and github pull requests. > 3. There's no link

Re: Github pull requests discussion

2016-04-24 Thread Yuri Z
I think we can try it. I see a few cons though: 1. I don't know how to make the asfgit close abandoned pull requests. 2. There's no integration between Jira and github pull requests. 3. There's no link to code review that we can out into commit message, thus providing context for the change. This m

Re: Github pull requests discussion

2016-04-24 Thread ๏̯͡๏ Guido Barosio
+1 On Sunday, April 24, 2016, Pablo Ojanguren wrote: > +1 > > 2016-04-24 6:25 GMT+02:00 Andreas Kotes >: > > > Hi, > > > > On Sun, Apr 24, 2016 at 04:12:52AM +, Evan Hughes wrote: > > > I think we should move to github pull requests as the standardised way > > for > > > all our repos. ATM w

Re: Github pull requests discussion

2016-04-24 Thread Pablo Ojanguren
+1 2016-04-24 6:25 GMT+02:00 Andreas Kotes : > Hi, > > On Sun, Apr 24, 2016 at 04:12:52AM +, Evan Hughes wrote: > > I think we should move to github pull requests as the standardised way > for > > all our repos. ATM we have docs and android client on pull requests and > the > > main repo is t

Re: Github pull requests discussion

2016-04-23 Thread Andreas Kotes
Hi, On Sun, Apr 24, 2016 at 04:12:52AM +, Evan Hughes wrote: > I think we should move to github pull requests as the standardised way for > all our repos. ATM we have docs and android client on pull requests and the > main repo is through review board. Its easier to get automated testing and >