Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-28 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3508/#review4674 --- Committed as r1237143. Please let me know if there will be after

Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-27 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3508/#review4645 --- Any update? I want this patch to be committed so I can proceed. If

Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-27 Thread Lennard de Rijk
Are you using eclipse? Could you set it to remve whitespace at the end of lines upon saving a file :-)? I see a lot of whitespace damage (unless the diff viewer is tricking me). Upayavira, correct me if I am wrong. But I think the copyright header should state Apache (Wave) instead of nothing?

Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-19 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3508/#review4481 --- src/org/waveprotocol/box/server/waveserver/MemorySearchProvider.java

Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-18 Thread Michael MacFadden
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3508/#review4437 --- I went through the files in order of the diffs. It wasn't until I

Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-16 Thread Andrew Kaplanov
This is a very desirable and timely addition. Thank you very much. I would ask to add the following. Now interface org.waveprotocol.box.server.waveserver.SearchProvider consists of this function: *SearchResult search(ParticipantId user, String query, int startAt, int numResults);* I think

Re: Review Request: Decouple the search implementation from the waves persistence logic.

2012-01-16 Thread Yuri Z
Currently the startAt index is not really used in the search results representation, only numResults. But you are probably right. Anyway, I am planning to work on more simple MongoDB indexing as herehttp://goo.gl/Xczzb . On Mon, Jan 16, 2012 at 9:48 PM, Andrew Kaplanov akapla...@gmail.comwrote: