[GitHub] incubator-wave pull request #21: Remove atmosphere as websocket's provider

2017-04-20 Thread pablojan
Github user pablojan closed the pull request at: https://github.com/apache/incubator-wave/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] incubator-wave pull request #21: Remove atmosphere as websocket's provider

2017-04-18 Thread vega113
Github user vega113 commented on a diff in the pull request: https://github.com/apache/incubator-wave/pull/21#discussion_r111923579 --- Diff: wave/src/main/java/org/apache/wave/box/server/rpc/InitialsAvatarsServlet.java --- @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache

[GitHub] incubator-wave pull request #21: Remove atmosphere as websocket's provider

2017-04-18 Thread wisebaldone
Github user wisebaldone commented on a diff in the pull request: https://github.com/apache/incubator-wave/pull/21#discussion_r111923488 --- Diff: wave/src/main/java/org/apache/wave/box/server/rpc/InitialsAvatarsServlet.java --- @@ -0,0 +1,57 @@ +/** + * Licensed to the Apa

[GitHub] incubator-wave pull request #21: Remove atmosphere as websocket's provider

2017-04-18 Thread wisebaldone
Github user wisebaldone commented on a diff in the pull request: https://github.com/apache/incubator-wave/pull/21#discussion_r111923475 --- Diff: wave/src/main/java/org/apache/wave/box/server/rpc/InitialsAvatarsServlet.java --- @@ -0,0 +1,57 @@ +/** + * Licensed to the Apa

[GitHub] incubator-wave pull request #21: Remove atmosphere as websocket's provider

2017-04-17 Thread vega113
Github user vega113 commented on a diff in the pull request: https://github.com/apache/incubator-wave/pull/21#discussion_r111781203 --- Diff: wave/src/main/java/org/apache/wave/box/server/rpc/InitialsAvatarsServlet.java --- @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache

[GitHub] incubator-wave pull request #21: Remove atmosphere as websocket's provider

2017-04-17 Thread vega113
Github user vega113 commented on a diff in the pull request: https://github.com/apache/incubator-wave/pull/21#discussion_r111781019 --- Diff: wave/src/main/java/org/waveprotocol/wave/client/common/util/SignalEventImpl.java --- @@ -93,8 +93,8 @@ public static boolean isKeyEvent(Eve

[GitHub] incubator-wave pull request #21: Remove atmosphere as websocket's provider

2017-04-17 Thread vega113
Github user vega113 commented on a diff in the pull request: https://github.com/apache/incubator-wave/pull/21#discussion_r111780378 --- Diff: wave/src/main/java/org/apache/wave/box/server/rpc/InitialsAvatarsServlet.java --- @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache

[GitHub] incubator-wave pull request #21: Remove atmosphere as websocket's provider

2017-04-17 Thread pablojan
GitHub user pablojan opened a pull request: https://github.com/apache/incubator-wave/pull/21 Remove atmosphere as websocket's provider Atmosphere has been use for last two years to provide a reliable transport layer for the client-server communications. However, at this moment it se