[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 Olivier Fourdan changed: What|Removed |Added Status|NEW |RESOLVED

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 Daniel Boles changed: What|Removed |Added URL|

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #30 from Olivier Fourdan --- I've filed two MR (gtk3 and gtk4) for this here: gtk3: https://gitlab.gnome.org/GNOME/gtk/merge_requests/31 gtk4: https://gitlab.gnome.org/GNOME/gtk/merge_requests/32 -- You are

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #28 from Olivier Fourdan --- In that case it would be better to fix the issue in the Wayland backend, I reckon, as this is less likely to break other backends. At least we now know exactly what happens and why it

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #27 from Martin Stransky --- (In reply to Olivier Fourdan from comment #26) > Created attachment 368558 [details] [review] > [PATCH] gdkwindow: Don't paint if the window is unmapped > > I don't know if unmapping

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 Olivier Fourdan changed: What|Removed |Added Status|NEEDINFO|NEW -- You are

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #24 from Olivier Fourdan --- So I think what happens and I believe this is Firefox doing something unexpected. The issue occurs because the window we're updating recursively is being unmapped (on Wayland if you

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #23 from Martin Stransky --- It may be useful to run Firefox under rr (http://rr-project.org/) and check how exactly that happens. -- You are receiving this mail because: You are on the CC list for the

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #22 from Olivier Fourdan --- Reproduced as well... -- You are receiving this mail because: You are on the CC list for the bug.___ wayland-bugs mailing list

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #21 from Olivier Fourdan --- FWIW, the code in gdk/gdkwindow.c with the patch applied should read as: 3802 static void 3803 _gdk_window_process_updates_recurse_helper (GdkWindow *window, 3804

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #20 from Olivier Fourdan --- (In reply to Martin Stransky from comment #19) > Yes, I checked it again. I use my own custom build with the patch, I checked > package build log and the patch is applied. It also

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #19 from Martin Stransky --- (In reply to Olivier Fourdan from comment #18) > (In reply to Martin Stransky from comment #16) > > With the latest patch applied I still see a crash: > > Weird. Can you double-check

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #18 from Olivier Fourdan --- (In reply to Martin Stransky from comment #16) > With the latest patch applied I still see a crash: Weird. Can you double-check the version you use is the one with the patch? Reason

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #17 from Martin Stransky --- I can 100% reproducible with the firefox-59 build I provide. Navigate to url bar and type "about:addons" there. When awesomebar disappears FF crashes. -- You are receiving this mail

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #16 from Martin Stransky --- With the latest patch applied I still see a crash: #6 0x7fcd1de3aaf0 in () at /lib64/libpthread.so.0 #7 0x7fcd1671ee79 in wl_proxy_marshal (proxy=0x0, opcode=2) at

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #15 from Olivier Fourdan --- I am not 100% sure about the leak, I've left FF running a few times overnight and that did not happen. The patch fixes the issue, I reckon. -- You are receiving this mail because:

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #14 from Martin Stransky --- I'll check that patch, Thanks. The leaking is interesting, I'll check that. -- You are receiving this mail because: You are on the CC list for the

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 Olivier Fourdan changed: What|Removed |Added Status|NEW |NEEDINFO -- You

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #13 from Olivier Fourdan --- FWIW, I've been running with this patch since yesterday and had no crash in gdk Wayland code since then. Not surprising, if the window is withdrawn, the Wayland resources are NULL

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #12 from Olivier Fourdan --- Can you try with this patch? -- You are receiving this mail because: You are on the CC list for the bug.___ wayland-bugs mailing list

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #11 from Olivier Fourdan --- Created attachment 367922 --> https://bugzilla.gnome.org/attachment.cgi?id=367922=edit [PATCH] gdkwindow: Do not generate expose event if not mapped If a window is not mapped, we

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #10 from Olivier Fourdan --- “old_state = GDK_WINDOW_STATE_FOCUSED, state = (GDK_WINDOW_STATE_WITHDRAWN | GDK_WINDOW_STATE_FOCUSED)” seems weird, how can a window be withdrawn and focused? Another weird thing is:

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #9 from Ray Strode [halfline] --- that's a weird combo: state = (GDK_WINDOW_STATE_WITHDRAWN | GDK_WINDOW_STATE_FOCUSED) -- You are receiving this mail because: You are on the CC list for the

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #8 from Olivier Fourdan --- OK, I managed to reproduce a couple of times (every time that occured while switching back to the FF window, when it changes from “unfocused” to “focused” state) and take a closer look

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #5 from Olivier Fourdan --- (In reply to Martin Stransky from comment #4) > You can use this package to do the testing: > > https://koji.fedoraproject.org/koji/buildinfo?buildID=1022923 > > it runs natively

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #6 from Martin Stransky --- (In reply to Olivier Fourdan from comment #5) > (In reply to Martin Stransky from comment #4) > > You can use this package to do the testing: > > > >

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #7 from Olivier Fourdan --- Nope, no crash (yet), but it's hardly usable for me because all menus are truncated, missing most of the entries. Seems like restarting FF has fixed it now... weird. -- You are

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #3 from Olivier Fourdan --- I wonder how we can end up in end_paint() with a wl_surface being NULL. _gdk_frame_clock_emit_paint() ends up calling gtk_widget_render() which calls gdk_window_end_draw_frame (window,

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #2 from Martin Stransky --- This crash happens at gdk_window_impl_wayland_end_paint() and at wl_surface_damage() where impl->display_server.wl_surface is null. -- You are receiving this mail because: You are on

[Wayland-bugs] [Bug 793062] [Wayland] Crash under gdk_wayland_window_attach_image()

https://bugzilla.gnome.org/show_bug.cgi?id=793062 --- Comment #1 from Martin Stransky --- I see another crash with this patch applied: (gdb) pimpl->display_server.wl_surface $2 = (struct wl_surface *) 0x0 It also comes from the expose event handler, bt: #8