[Wayland-bugs] [Bug 105535] SynPS/2 Synaptics TouchPad detects fingers not touching the touchpad while using two-finger scrolling

2018-03-19 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=105535

--- Comment #5 from Oleksandr Popel  ---
I'll try to play with pressure threshold values later. As for single-finger
pointer motion - it's normal. Bug does not not appear there. Also, it does not
appear without normal touching first. As seen in video by Sergei, first you
have to actually touch a touchpad and only then you can scroll without touching
it. So there's that.
And what about the fact that bug didn't exist in 1.9? What changes was made
that could provoke it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

2018-03-19 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #23 from Michał Kopeć  ---
Created attachment 138195
  --> https://bugs.freedesktop.org/attachment.cgi?id=138195=edit
libinput debug-events --verbose with patch on ThinkPad X60 Tablet

Yes, the property does show up correctly when running udevadm test
/sys/class/input/event4. The patch does not seem to be working for me even
after a restart.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105535] SynPS/2 Synaptics TouchPad detects fingers not touching the touchpad while using two-finger scrolling

2018-03-19 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=105535

--- Comment #6 from Matthias Baur  ---
Created attachment 138207
  --> https://bugs.freedesktop.org/attachment.cgi?id=138207=edit
evemu-descibe-ThinkPad-T430s

evemu describe of my ThinkPad T430s. As far as I can tell, it looks pretty much
the same as the one Sergei posted.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105535] SynPS/2 Synaptics TouchPad detects fingers not touching the touchpad while using two-finger scrolling

2018-03-19 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=105535

--- Comment #7 from Matthias Baur  ---
Thanks, I've patched the measurement tool as following:

diff --git a/tools/libinput-measure-touchpad-pressure
b/tools/libinput-measure-touchpad-pressure
index 89dd117f..7ea44bee 100755
--- a/tools/libinput-measure-touchpad-pressure
+++ b/tools/libinput-measure-touchpad-pressure
@@ -155,7 +155,7 @@ class Device(object):
 # then extract the pressure absinfo from that
 all_caps = self.device.capabilities(absinfo=True)
 caps = all_caps.get(evdev.ecodes.EV_ABS, [])
-p = [cap[1] for cap in caps if cap[0] == evdev.ecodes.ABS_MT_PRESSURE]
+p = [cap[1] for cap in caps if cap[0] in
[evdev.ecodes.ABS_MT_PRESSURE, evdev.ecodes.ABS_PRESSURE] ]
 if not p:
 raise InvalidDeviceError("device does not have ABS_MT_PRESSURE")

@@ -226,6 +226,10 @@ def handle_abs(device, event):
 s = device.current_sequence()
 s.append(Touch(pressure=event.value))
 print("\r{}".format(s), end="")
+elif event.code == evdev.ecodes.ABS_PRESSURE:
+s = device.current_sequence()
+s.append(Touch(pressure=event.value))
+print("\r{}".format(s), end="")


 def handle_event(device, event):


Seems to work now :) I'm currently experimenting with it, but think 32:25
should be a good value to start with.

What I found kind of strange are the hwdb default values:

s0me0ne@s0me0ne-Thinkpad:~/Sources/libinput$ sudo
./tools/libinput-measure-touchpad-pressure
Using SynPS/2 Synaptics TouchPad: /dev/input/event15

Ready for recording data.
Pressure range used: 25:30
Palm pressure range used: 130
Place a single finger on the touchpad to measure pressure values.
Ctrl+C to exit
^C

The man page of libinput-measure-touchpad-pressure says "The thresholds have to
be in device-specific pressure values and it is required that down >= up.".
"down >= up." seems to be not fulfilled.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105592] Improve nn-button scrolling

2018-03-19 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=105592

Peter Hutterer  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||peter.hutte...@who-t.net

--- Comment #1 from Peter Hutterer  ---
Regarding 1: I'm not sure what exactly the behaviour should be, could you
expand please?


> 2) Add delay between scroll button press/release emulation.

don't we do this? The timestamps of the events should reflect the button
press/release times, right?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 104812] kernel: touchpad jump (libinput 1.9.3) Lenovo R61

2018-03-19 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=104812

Peter Hutterer  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #7 from Peter Hutterer  ---
sorry, should've checked myself first. Jump happens on single-finger to
double-finger change, see 

E: 0.703993 0003  2457  # EV_ABS / ABS_X2457
E: 0.703993 0003 0001 2527  # EV_ABS / ABS_Y2527
E: 0.703993 0003 001c 0005  # EV_ABS / ABS_TOOL_WIDTH   5
E: 0.703993 0001 0145   # EV_KEY / BTN_TOOL_FINGER  0
E: 0.703993 0001 014d 0001  # EV_KEY / BTN_TOOL_DOUBLETAP   1
E: 0.703993     #  SYN_REPORT (0) -- +10ms
E: 0.716439 0003  2525  # EV_ABS / ABS_X2525
E: 0.716439 0003 0001 5159  # EV_ABS / ABS_Y5159
E: 0.716439 0003 001c 0010  # EV_ABS / ABS_TOOL_WIDTH   10
E: 0.716439 0001 0145 0001  # EV_KEY / BTN_TOOL_FINGER  1
E: 0.716439 0001 014d   # EV_KEY / BTN_TOOL_DOUBLETAP   0
E: 0.716439     #  SYN_REPORT (0) -- +13ms
E: 0.729451 0003  2639  # EV_ABS / ABS_X2639
E: 0.729451 0003 0001 5132  # EV_ABS / ABS_Y5132
E: 0.729451 0003 001c 0008  # EV_ABS / ABS_TOOL_WIDTH   8
E: 0.729451     #  SYN_REPORT (0) -- +13ms

Needs an axis range fix too, still using the traditional made-up synaptics
ranges and 5132 is quite a bit out of that...

Anyway, I noticed this is a touchpad from 2007. We have some code in place to
ignore jumps on finger count changes and that should/may work with this
touchpad but tbh, I don't have any spare time to invest in hw that's 10 years
old.

Given that we notice the jump and discard it, the worst bit right now is the
error message, right? So I'll just do the jedi-wave, tell you this is not the
error message you're looking for and close this as WONTFIX. Sorry.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105258] libinput crashes Xorg with SIGABRT in tp_tap_handle_state() [evdev-mt-touchpad-tap.c:1030|1028]

2018-03-19 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=105258

Peter Hutterer  changed:

   What|Removed |Added

 Blocks||105535


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=105535
[Bug 105535] SynPS/2 Synaptics TouchPad detects fingers not touching the
touchpad while using two-finger scrolling
-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105535] SynPS/2 Synaptics TouchPad detects fingers not touching the touchpad while using two-finger scrolling

2018-03-19 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=105535

Peter Hutterer  changed:

   What|Removed |Added

 Depends on||105258
 Status|NEEDINFO|ASSIGNED

--- Comment #8 from Peter Hutterer  ---
oops, the range mismatch is fixed in master now (4ff5f02d9c). But the big thing
here is:

> As for single-finger pointer motion - it's normal. Bug does not not appear 
> there.

Basically this means that the touchpad pressure changes when two fingers are
down. That's not good... Anyway, I bisected this and came up with: commit
3979b9e16a5ed141506d95f80ddfd7b94651dcfa. Basically the problem is that we now
assume that when we have more fingers down than the touchpad can individually
detect (>1 for semi-mt devices) then we assume all fingers have an
above-threshold pressure value.

This matches the data in the evemu recording, the pressure is well below the
thresholds yet we treat it as down. Should be fixable.


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=105258
[Bug 105258] libinput crashes Xorg with SIGABRT in tp_tap_handle_state()
[evdev-mt-touchpad-tap.c:1030|1028]
-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

2018-03-19 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=103749

Peter Hutterer  changed:

   What|Removed |Added

 Status|REOPENED|NEEDINFO

--- Comment #24 from Peter Hutterer  ---
(In reply to Davide Depau from comment #22)
> Created attachment 138192 [details]

event4  - tablet_mode_switch: activated for AT Translated Set 2
keyboard<->ThinkPad Extra Buttons


(In reply to Michał Kopeć from comment #23)
> Created attachment 138195 [details]

event4  - tablet_mode_switch: activated for AT Translated Set 2
keyboard<->ThinkPad Extra Buttons

same thing here

This indicates that the keyboard is still paired for the tablet mode switch. So
either the udev property isn't applied correctly, or the patch isn't working.
Unfortunately I don't currently have time to work on this, sorry.

However, it's easy to debug locally, sudo gdb ./builddir/libinput-debug-events
is all you need. The keyboard is only disabled in that libinput context so it
won't affect your session and you can fake a tablet mode switch with sudo
evemu-event --type EV_SW --code SW_TABLET_MODE --value 1 --sync (and then again
with value 0).


> the property does show up correctly when running udevadm test

just fwwiw: udevadm info shows the current properties, udevadm test shows the
ones to be applied. So without a restart, udevadm test won't really do
anything.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 104812] kernel: touchpad jump (libinput 1.9.3) Lenovo R61

2018-03-19 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=104812

--- Comment #6 from Benjamin Tissoires  ---
(In reply to Dave from comment #3)
> Dmesg output attached. I tried using hid-recorder against the input device,
> but it just returns an error.
> 
> ```
> # hid-recorder /dev/input/event4
> D: 0
> HIDIOCGRDESCSIZE: Invalid argument
> Unable to open device: Invalid argument
> 
> No events where recorded.
> ```
> 
> Everything I've seen online and in the man pages indicates it should be
> recording a /dev/hidraw device, but I don't have any hidraw devices
> anywhere under /dev. Is there something I need to do to enable those devices?

Well, your touchpad is using PS/2 so no it's normal you do not have any hidraw
node. The dmesg shows that your touchpad is ps2 only, so there won't be much we
can do in the kernel if the evemu-record. Peter if you can pinpoint where the
jump happens in the evemu-file I might be able to tell if if this is fixable in
the kernel or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

2018-03-19 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=103749

Davide Depau  changed:

   What|Removed |Added

 CC||dav...@depau.eu

--- Comment #22 from Davide Depau  ---
Created attachment 138192
  --> https://bugs.freedesktop.org/attachment.cgi?id=138192=edit
libinput debug-events --verbose with patch, ThinkPad X1 Yoga 1st

Coming here from 101008. I applied the patch to Libinput (latest git, I added
it to the AUR package: https://aur.archlinux.org/packages/libinput-git/, had a
hard time applying it due to changes in evdev.h) and it seems like it's not
working.

Side volume buttons and touchscreen Super key don't work. See `debug-events`
with patch applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105592] Improve nn-button scrolling

2018-03-19 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=105592

Bug ID: 105592
   Summary: Improve nn-button scrolling
   Product: Wayland
   Version: unspecified
  Hardware: All
OS: Linux (All)
Status: NEW
  Severity: enhancement
  Priority: medium
 Component: libinput
  Assignee: wayland-bugs@lists.freedesktop.org
  Reporter: andris.ze...@gmail.com

Hi.

I was going to suggest 3 improvements for on-button scrolling. I've been using
this feature for years (patched evdev) with right mouse button as scroll
button. So after upgrading to libinput I was looking to restore similar
functionality. I noticed that one of my suggestions was already tackled by bug
99666 (though not quite in a way I thought it could be done, check my comment),
so that leaves two.

1) Allow mouse movement when scrolling with external mouse. When scrolling with
trackpoint it's better to have mouse cursor stuck in one place. However when
using external mouse it means that the correlation between cursor position on
screen and mouse location on desk is broken. So you need to lift the mouse and
reposition it. If the cursor would move when scrolling you could simply release
scroll button and move mouse without having to lift it.

I think this is almost required feature for using on-button scrolling with
external mouse, however trackball users might have different opinion (I believe
they both are detected as external mouse).


2) Add delay between scroll button press/release emulation. It would ensure
better compatibility as some applications (for example project view in Eclipse
CDT) have trouble processing the emulated button press.

While this was must have feature for me (Eclipse CDT is my daily tool), I'm not
sure about it's generic usability.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs