[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens
https://bugzilla.gnome.org/show_bug.cgi?id=771841 --- Comment #12 from Jonas Ådahl --- (In reply to Sjoerd Simons from comment #11) > With the last 2 patches on top of those from Jonas the issue is fixed for > me. > > The reason why i was apparently still hitting it is that the configure event > is triggered by meta_window_place_with_placement_rule in finish_popup_setup > which was before the popup monitor was synced with that of the toplevel, > hence the configure event using the wrong monitors scale. > > > Would be nice if in the long-term mutter kept the buffer coordinates > (pixels) and surface coordinates seperate so all this fragile scaling can go > away :) The long term plan is to have the stage coordinate space to be in logical pixels, meaning that indeed all these hacks will go away. -- You are receiving this mail because: You are on the CC list for the bug.___ wayland-bugs mailing list wayland-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens
https://bugzilla.gnome.org/show_bug.cgi?id=771841 --- Comment #11 from Sjoerd Simons --- With the last 2 patches on top of those from Jonas the issue is fixed for me. The reason why i was apparently still hitting it is that the configure event is triggered by meta_window_place_with_placement_rule in finish_popup_setup which was before the popup monitor was synced with that of the toplevel, hence the configure event using the wrong monitors scale. Would be nice if in the long-term mutter kept the buffer coordinates (pixels) and surface coordinates seperate so all this fragile scaling can go away :) -- You are receiving this mail because: You are on the CC list for the bug.___ wayland-bugs mailing list wayland-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens
https://bugzilla.gnome.org/show_bug.cgi?id=771841 --- Comment #10 from Sjoerd Simons --- Created attachment 336173 --> https://bugzilla.gnome.org/attachment.cgi?id=336173&action=edit wayland/xdg-shell: update popup window monitor early As meta_window_place_with_placement_rule will trigger a configure event being sent ensure that the popup is placed on the correct monitor first to ensure the right scale factor is applied. Signed-off-by: Sjoerd Simons -- You are receiving this mail because: You are on the CC list for the bug.___ wayland-bugs mailing list wayland-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens
https://bugzilla.gnome.org/show_bug.cgi?id=771841 --- Comment #9 from Sjoerd Simons --- Created attachment 336172 --> https://bugzilla.gnome.org/attachment.cgi?id=336172&action=edit wayland/xdg-popup: Force monitor of the top-level Directly set the monitor of the toplevel window for the popup to avoid the change not being applied due to later constraints calculation. Signed-off-by: Sjoerd Simons -- You are receiving this mail because: You are on the CC list for the bug.___ wayland-bugs mailing list wayland-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens
https://bugzilla.gnome.org/show_bug.cgi?id=771841 --- Comment #8 from Jonas Ådahl --- (In reply to Sjoerd Simons from comment #7) > Seems that even with these two, the configure on the non-hdpi screen still > gets a width/height half of the requested one The configure event of the pop-up? I can't reproduce that. Could you send WAYLAND_DEBUG=1 log? -- You are receiving this mail because: You are on the CC list for the bug.___ wayland-bugs mailing list wayland-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens
https://bugzilla.gnome.org/show_bug.cgi?id=771841 --- Comment #7 from Sjoerd Simons --- Seems that even with these two, the configure on the non-hdpi screen still gets a width/height half of the requested one -- You are receiving this mail because: You are on the CC list for the bug.___ wayland-bugs mailing list wayland-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens
https://bugzilla.gnome.org/show_bug.cgi?id=771841 --- Comment #6 from Jonas Ådahl --- Created attachment 336146 --> https://bugzilla.gnome.org/attachment.cgi?id=336146&action=edit wayland/xdg-shell: Scale configure relative popup coordinate The parent local popup coordinate needs to be scaled according to the monitor scale it is assigned. -- You are receiving this mail because: You are on the CC list for the bug.___ wayland-bugs mailing list wayland-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens
https://bugzilla.gnome.org/show_bug.cgi?id=771841 --- Comment #5 from Jonas Ådahl --- Created attachment 336145 --> https://bugzilla.gnome.org/attachment.cgi?id=336145&action=edit wayland/xdg-popup: Always use monitor of toplevel Always use the monitor of the toplevel surface's window, so that the popup menu and the parent will always have the same scale. This fixes the dimensions sent in the xdg_popup configure event. -- You are receiving this mail because: You are on the CC list for the bug.___ wayland-bugs mailing list wayland-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens
https://bugzilla.gnome.org/show_bug.cgi?id=771841 Sjoerd Simons changed: What|Removed |Added CC||sjo...@luon.net --- Comment #4 from Sjoerd Simons --- This fixes the issue for me on my hidpi screen, however when using mixed setup (hidpi laptop + normal dpi monitor) the issue still occurs on the non-hidpi screen. -- You are receiving this mail because: You are on the CC list for the bug.___ wayland-bugs mailing list wayland-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens
https://bugzilla.gnome.org/show_bug.cgi?id=771841 --- Comment #3 from Jonas Ådahl --- (In reply to Bjørn Lie from comment #2) > Created attachment 336142 [details] > With patch > > Works for me, but if possible, look at the oversize in the attached > screenshot. > > This is in any case much better than what we have :-) so stil +1 from me Ah, some more coordinates that need the scale hack probably. -- You are receiving this mail because: You are on the CC list for the bug.___ wayland-bugs mailing list wayland-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
