[Wayland-bugs] [Bug 104939] Tablet tools without ABS_Z cause a crash when updating rotation

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104939

Peter Hutterer  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Peter Hutterer  ---
commit cbb4ec1e3e76b64ec53c25036976e0374aaf41de
Author: Peter Hutterer 
Date:   Mon Feb 5 09:11:42 2018 +1000

tablet: don't set rotation on a tool if we don't have ABS_Z

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104939] Tablet tools without ABS_Z cause a crash when updating rotation

2018-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104939

--- Comment #2 from Peter Hutterer  ---
And for extra fun, the series starting here:
https://lists.freedesktop.org/archives/wayland-devel/2018-February/036853.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104939] Tablet tools without ABS_Z cause a crash when updating rotation

2018-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104939

--- Comment #1 from Peter Hutterer  ---
https://lists.freedesktop.org/archives/wayland-devel/2018-February/036827.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104939] Tablet tools without ABS_Z cause a crash when updating rotation

2018-02-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104939

Peter Hutterer  changed:

   What|Removed |Added

 CC||peter.hutte...@who-t.net
 Blocks||104911


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=104911
[Bug 104911] Fake BTN_TOOL_PEN on tablets that don't send it
-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104939] Tablet tools without ABS_Z cause a crash when updating rotation

2018-02-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104939

Bug ID: 104939
   Summary: Tablet tools without ABS_Z cause a crash when updating
rotation
   Product: Wayland
   Version: unspecified
  Hardware: Other
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: medium
 Component: libinput
  Assignee: wayland-bugs@lists.freedesktop.org
  Reporter: peter.hutte...@who-t.net

This affects tablets that are not listed in libwacom, specifically, tablets
where libwacom does not provide the stylus axis information.

On tablet init, we check the event codes. A tablet may have ABS_Z and thus have
rotation. Or it has BTN_TOOL_MOUSE + ABS_TILT_X/Y and thus have rotation. On
init, all axes are marked as 'changed' to ensure we send the data in the first
event. For non-libwacom tablets, the tool has the same bits set as the tablet
provides, so if mouse+tilt is there, we have rotation on all tools. But the
code itself relies on ABS_Z for rotation on all the styli (except mouse/lense).

In the case of Aiptek tablets we do have mouse+tilt but we *don't* have ABS_Z.
If the first tool that comes into proximity is *not* the mouse/lens tool [1],
we try to update the rotation by accessing ABS_Z. This leads to a null-pointer
dereference in tablet_update_artpen_rotation() on the very first event.

See https://bugzilla.redhat.com/show_bug.cgi?id=1535755.

It doesn't matter that the tool never sends the actual events - because all
axes are marked as 'changed' on proximity in, we always access the axis on the
first event and crash.

[1] see also Bug 104911

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs