[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2017-10-04 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=771112

Daniel Boles  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||dboles@gmail.com
 Resolution|--- |NOTABUG

--- Comment #16 from Daniel Boles  ---
It looks like there's not any actual bug here. The outstanding one was probably
the concerns about the docs mentioned in Comment 11, but Emmanuele seems to
have fixed that the next day with commit
08e443e0db6f74ade5836f8028073aeac14aab38.

So, resolving as NOTABUG (in GTK+) (anymore)!

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-17 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=771112

--- Comment #15 from Emmanuele Bassi (:ebassi)  ---
> you cannot use the allocation that you get from GtkWidget because that does 
> not include the client-side decorations.

Sorry, this sentence contains an additional "not"; the problem is that the
allocation *has* to contain the size of the client-side decoration, but since
those decorations may be automatically added by the toolkit depending on the
windowing system, they should not contribute to the logical size of the window.
If they do, then you get the issue of this bug, i.e. ever-growing windows.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-17 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=771112

--- Comment #14 from Emmanuele Bassi (:ebassi)  ---
(In reply to Kai Willadsen from comment #11)
> (In reply to Emmanuele Bassi (:ebassi) from comment #7)
> > Querying the window size and then setting it with GtkWindow API is perfectly
> > fine.
> > 
> > Querying the window size with GtkWidget API and then setting it with
> > GtkWindow API, *or* querying the window size with GtkWindow API and then
> > setting it with GtkWidget API, is *not* okay, and only worked up until now
> > with server-side decorations only on X11.
> 
> In the current GtkWindow docs for gtk_window_get_size(), the second and
> fourth notes directly contradict each other, and I'm pretty sure the first
> paragraph is now also incorrect.

Indeed; the documentation was likely written for GTK+ 2.x or even before that,
when we did not have support for Wayland or for client-side decorations.

> I don't know what these other apps do, but
> Meld's implementation here listens for configure-event and uses those sizes,
> which is pretty much exactly what the first note there tells you to do.

Yep, and that's really not how you should do this; the configure-event signal
is an X11-ism, even though GTK+ tries to map it to other windowing systems.

The appropriate way to get a notification of a size change in a widget is to
use the GtkWidget::size-allocate signal. For top-levels, though, especially the
ones using client-side decorations, you cannot use the allocation that you get
from GtkWidget because that does not include the client-side decorations. If it
did, all code running on Wayland would break, since the decorations are added
automatically by GTK+ itself.

For this reason, you need to use GtkWindow-specific API to get the size of the
window, in order to store it.

I'll make sure to change the documentation of GtkWindow.get_size() so that it
reflects reality.

> Pushing this issue on to applications by suggesting that they've been doing
> something unsupported this whole time is not a very reasonable position to
> take.

Sadly, we're in a bit of a "rock/hard place" situation, here; if we didn't do
this, we would break other, existing code, when running using client-side
decorations, both when manually added by the application developers, and when
added automatically by GTK+, for instance when running on Wayland. We attempted
that, and the resulting complexity and layering violation ended up ballooning
out of control.

In the end, we opted for asking application developers — who most likely have
to deal with ensuring their applications are already Wayland-ready — to change
their code to deal with client-side decorations.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-16 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=771112

--- Comment #12 from Michael Catanzaro  ---
(In reply to Kai Willadsen from comment #11)
> Pushing this issue on to applications by suggesting that they've been doing
> something unsupported this whole time is not a very reasonable position to
> take.

Stuff like this has been par for the course for GTK+ 3 thus far. It just needs
a docs update.

But see:
https://blog.gtk.org/2016/09/01/versioning-and-long-term-stability-promise-in-gtk/

TL;DR GTK+ 3.22 will be stable LTS, and breaking changes like this will no
longer be allowed in GTK+ 3... starting next week.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-16 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=771112

Kai Willadsen  changed:

   What|Removed |Added

 CC||kai.willad...@gmail.com

--- Comment #11 from Kai Willadsen  ---
(In reply to Emmanuele Bassi (:ebassi) from comment #7)
> Querying the window size and then setting it with GtkWindow API is perfectly
> fine.
> 
> Querying the window size with GtkWidget API and then setting it with
> GtkWindow API, *or* querying the window size with GtkWindow API and then
> setting it with GtkWidget API, is *not* okay, and only worked up until now
> with server-side decorations only on X11.

In the current GtkWindow docs for gtk_window_get_size(), the second and fourth
notes directly contradict each other, and I'm pretty sure the first paragraph
is now also incorrect. I don't know what these other apps do, but Meld's
implementation here listens for configure-event and uses those sizes, which is
pretty much exactly what the first note there tells you to do.

Pushing this issue on to applications by suggesting that they've been doing
something unsupported this whole time is not a very reasonable position to
take.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-12 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=771112

Michael Catanzaro  changed:

   What|Removed |Added

 CC||mcatanz...@gnome.org

--- Comment #10 from Michael Catanzaro  ---
(In reply to Kamil Páral from comment #9)
> I individually reported the issue in apps where I spotted the problem:
> https://bugzilla.gnome.org/show_bug.cgi?id=771290
> https://bugzilla.gnome.org/show_bug.cgi?id=771292
> https://bugzilla.gnome.org/show_bug.cgi?id=771293
> https://bugzilla.gnome.org/show_bug.cgi?id=771295
> https://bugzilla.redhat.com/show_bug.cgi?id=1375178
> https://bugzilla.redhat.com/show_bug.cgi?id=1375175
> https://bugzilla.gnome.org/show_bug.cgi?id=771288

FYI half of these apps do not have active maintainers so the bugs won't be
fixed unless somebody volunteers patches.

In the case of Epiphany, I can't reproduce the issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-12 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=771112

--- Comment #9 from Kamil Páral  ---
I individually reported the issue in apps where I spotted the problem:
https://bugzilla.gnome.org/show_bug.cgi?id=771290
https://bugzilla.gnome.org/show_bug.cgi?id=771292
https://bugzilla.gnome.org/show_bug.cgi?id=771293
https://bugzilla.gnome.org/show_bug.cgi?id=771295
https://bugzilla.redhat.com/show_bug.cgi?id=1375178
https://bugzilla.redhat.com/show_bug.cgi?id=1375175
https://bugzilla.gnome.org/show_bug.cgi?id=771288

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-12 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=771112

Kamil Páral  changed:

   What|Removed |Added

   See Also||https://bugzilla.gnome.org/
   ||show_bug.cgi?id=771295

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-12 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=771112

Kamil Páral  changed:

   What|Removed |Added

   See Also||https://bugzilla.gnome.org/
   ||show_bug.cgi?id=771293

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-12 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=771112

Kamil Páral  changed:

   What|Removed |Added

   See Also||https://bugzilla.gnome.org/
   ||show_bug.cgi?id=771292

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-12 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=771112

Kamil Páral  changed:

   What|Removed |Added

   See Also||https://bugzilla.gnome.org/
   ||show_bug.cgi?id=771290

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-12 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=771112

Kamil Páral  changed:

   What|Removed |Added

   See Also||https://bugzilla.gnome.org/
   ||show_bug.cgi?id=771288

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-09 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=771112

Matthias Clasen  changed:

   What|Removed |Added

 CC||mcla...@redhat.com
Summary|gtk3 3.21.5 causes windows  |some applications windows
   |to grow on startup (with|to grow on startup (with
   |CSD)|CSD)

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs