[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-14 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

Jonas Ådahl  changed:

   What|Removed |Added

 Attachment #336145|none|committed
 status||

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-14 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

Jonas Ådahl  changed:

   What|Removed |Added

 Attachment #336146|none|committed
 status||

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-14 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

Jonas Ådahl  changed:

   What|Removed |Added

 Attachment #336172|accepted-commit_now |committed
 status||

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-14 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

Jonas Ådahl  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #37 from Jonas Ådahl  ---
Attachment 336145 pushed as c0c132a - wayland/xdg-popup: Always use monitor of
toplevel
Attachment 336146 pushed as a3d7ae6 - wayland/xdg-shell: Scale configure
relative popup coordinate
Attachment 336172 pushed as 8a6fa72 - wayland/xdg-popup: Force monitor of the
top-level
Attachment 336173 pushed as d2f79af - wayland/xdg-shell: update popup window
monitor early
Attachment 337556 pushed as 68645df - wayland/xdg-shell: Scale positioner
coordinates

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-14 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

Jonas Ådahl  changed:

   What|Removed |Added

 Attachment #336173|accepted-commit_now |committed
 status||

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-14 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

Jonas Ådahl  changed:

   What|Removed |Added

 Attachment #337556|none|committed
 status||

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-13 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #36 from François Guerraz  ---
Review of attachment 337556:

Tested on mutter-3.22.1 on arch 64, works well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-13 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #35 from Sjoerd Simons  ---
Review of attachment 337556:

Looks good to me, tested the set with this patch as opposed to its previous
iteration and everything seems happy as expected

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-13 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

Jonas Ådahl  changed:

   What|Removed |Added

 Attachment #336172|reviewed|accepted-commit_now
 status||

--- Comment #34 from Jonas Ådahl  ---
Review of attachment 336172:

Marking as a-c-n. Ihis patch doesn't stop the re-scaling would the parent
window move, since the scaling that is left out is the not-to-be-run "avoid
jumping-back-and-forth-between-scales" scaling, so looks good to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-13 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

Jonas Ådahl  changed:

   What|Removed |Added

 Attachment #336140|0   |1
is obsolete||

--- Comment #33 from Jonas Ådahl  ---
Created attachment 337556
  --> https://bugzilla.gnome.org/attachment.cgi?id=337556=edit
wayland/xdg-shell: Scale positioner coordinates

When the monitor is scaled (i.e. HiDPI scaling) the placement coordinates
ere still in unscaled xdg_surface window geometry coordinate space when
used to place the window. Fix this by scaling the coordinates by the
monitor scale of the parent toplevel window before using them.

-

Rewrote the first patch to scale the coordinates as a more sane place. Also
added a comment documenting the coordinate space of the stored placement rule
fields.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-12 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #31 from Sjoerd Simons  ---
Daniel i meant what gtk+ version, what mutter version did you apply the patches
on what's your screen setup (one hidpi, other normal dpi? or?)

The patches from Jonas are enough to solve the issue for a single hidpi screen,
mine are needed on top to fix the issue for mixed dpi setups.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-11 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #30 from Daniel Buch  ---
Eventually the program will crash with this:

(gnome-calculator:9872): Gtk-WARNING **: Negative content width -7 (allocation
1, extents 4x4) while allocating gadget (node arrow, owner GtkTreeMenu)

(gnome-calculator:9872): Gdk-WARNING **: Error 71 (Protocol error) dispatching
to Wayland display.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-11 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #29 from Daniel Buch  ---
This behavior persist even though i patch these mutter patches.
As a last comment, i discovered that the shrinking problem, is widget
instance-wise. So clicking one button and the popup shrink to half the size
exponentially for each click.

>From my understanding, i believe this logic is now in gdk, not gtk and not
mutter - is that correct?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-11 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #28 from Daniel Buch  ---
Created attachment 337455
  --> https://bugzilla.gnome.org/attachment.cgi?id=337455=edit
Popup positioning

This shows that popup position (x,y) is _NOT_ multiplied by scaling factor.
Look at cursor and popup

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-11 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #27 from Daniel Buch  ---
Created attachment 337454
  --> https://bugzilla.gnome.org/attachment.cgi?id=337454=edit
GtkMenu-Click-2

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-11 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #26 from Daniel Buch  ---
Created attachment 337453
  --> https://bugzilla.gnome.org/attachment.cgi?id=337453=edit
GtkMenu-Click-1

This is when i click once, next will be shrink further by factor two. Next
attachment will show that

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-11 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #25 from Daniel Buch  ---
Created attachment 337452
  --> https://bugzilla.gnome.org/attachment.cgi?id=337452=edit
Daniel setup info

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-11 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #24 from Sjoerd Simons  ---
Daniel can you indicate how exactly you rpreoduce the issue and what your setup
is, there might be some subtilities that these patches haven't covere ofcourse.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-09 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #23 from Daniel Buch  ---
(In reply to djb from comment #22)
> (In reply to Daniel Buch from comment #21)
> > I installed a built with attachment 336172 [details] [review] [review], and 
> > for me it
> > sadly doesn't work for me. Any news i missed?
> 
> Did you build with all the other related patches? They seem to be required:
> 
> (In reply to Sjoerd Simons from comment #11)
> > With the last 2 patches on top of those from Jonas the issue is fixed for
> > me.

I managed to apply all attached patches. But problem still persists.
This thread is now moved to Gtk so i guess the problem lies there and not in
mutter.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-09 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

djb  changed:

   What|Removed |Added

 CC||db0...@gmail.com

--- Comment #22 from djb  ---
(In reply to Daniel Buch from comment #21)
> I installed a built with attachment 336172 [details] [review], and for me it
> sadly doesn't work for me. Any news i missed?

Did you build with all the other related patches? They seem to be required:

(In reply to Sjoerd Simons from comment #11)
> With the last 2 patches on top of those from Jonas the issue is fixed for
> me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-08 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #21 from Daniel Buch  ---
I installed a built with attachment 336172, and for me it sadly doesn't work
for me. Any news i missed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-10-04 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #20 from Sjoerd Simons  ---
(In reply to Jonas Ådahl from comment #19)
> (In reply to Sjoerd Simons from comment #16)
> > Review of attachment 336172 [details] [review] [review]:
> > 
> > The initial case block doesn't actually happen as _meta_window_shared_new
> > will set the initial monitor via meta_screen_calculate_monitor_for_window,
> > which means from is never NULL. So the first round through this function
> > actually has from != to. The problem this patch avoids is not syncing the
> > popup monitor to the top-level monitor as the scaled_new monitor doesn't
> > match the top-level monitor.
> 
> Ah, I see. I guess we can go with that approach then, and fix it properly
> after I've reworked how MetaWindow's are constructed.

Could you commit these in that case ;). Would be great to have that sorted in
git

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-29 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #19 from Jonas Ådahl  ---
(In reply to Sjoerd Simons from comment #16)
> Review of attachment 336172 [details] [review]:
> 
> The initial case block doesn't actually happen as _meta_window_shared_new
> will set the initial monitor via meta_screen_calculate_monitor_for_window,
> which means from is never NULL. So the first round through this function
> actually has from != to. The problem this patch avoids is not syncing the
> popup monitor to the top-level monitor as the scaled_new monitor doesn't
> match the top-level monitor.

Ah, I see. I guess we can go with that approach then, and fix it properly after
I've reworked how MetaWindow's are constructed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-28 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

Carlos Garnacho  changed:

   What|Removed |Added

 CC||carl...@gnome.org

--- Comment #18 from Carlos Garnacho  ---
(In reply to Sjoerd Simons from comment #17)
> Review of attachment 336173 [details] [review]:
> 
> fwiw i don't have commit access on git.gnome anymore, so please commit for
> me ;)

OT, probably
https://www.dragonsreach.it/2014/10/07/the-gnome-infrastructure-is-now-powered-by-freeipa/
has instructions that may help you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-28 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #17 from Sjoerd Simons  ---
Review of attachment 336173:

fwiw i don't have commit access on git.gnome anymore, so please commit for me
;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-28 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #16 from Sjoerd Simons  ---
Review of attachment 336172:

The initial case block doesn't actually happen as _meta_window_shared_new will
set the initial monitor via meta_screen_calculate_monitor_for_window, which
means from is never NULL. So the first round through this function actually has
from != to. The problem this patch avoids is not syncing the popup monitor to
the top-level monitor as the scaled_new monitor doesn't match the top-level
monitor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-27 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

Jonas Ådahl  changed:

   What|Removed |Added

 Attachment #336172|none|reviewed
 status||

--- Comment #14 from Jonas Ådahl  ---
Review of attachment 336172:

A popup can potentially change scale: if its not a grabbing popup, and the
parent window is moved, the popup should move with the parent surface. With
that said, we don't handle this situation yet (since we don't have a
non-grabbing popup used by a client yet) so it probably wouldn't work to begin
with. With that said, why is this patch needed? from == to should always hold
(except for the initial set, which is handled) in the use cases we currently
have.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-27 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

Jonas Ådahl  changed:

   What|Removed |Added

 Attachment #336173|none|accepted-commit_now
 status||

--- Comment #15 from Jonas Ådahl  ---
Review of attachment 336173:

Looks reasonable to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-26 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #13 from Sjoerd Simons  ---
Great to hear.

FWIW i reproduce the issue by running mutter with:
  MUTTER_DEBUG_NUM_DUMMY_MONITORS=2 MUTTER_DEBUG_DUMMY_MONITOR_SCALES=2,1 

iotw dual monitor setup, left (primary) monitor hidpi. The issue can be seen by
starting e.g. gtk3-demo and moving it to the right monitor before opening a
popup.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-23 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #11 from Sjoerd Simons  ---
With the last 2 patches on top of those from Jonas the issue is fixed for me. 

The reason why i was apparently still hitting it is that the configure event is
triggered by meta_window_place_with_placement_rule in finish_popup_setup which
was before the popup monitor was synced with that of the toplevel, hence the
configure event using the wrong monitors scale.


Would be nice if in the long-term mutter kept the buffer coordinates (pixels)
and surface coordinates seperate so all this fragile scaling can go away :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-23 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #10 from Sjoerd Simons  ---
Created attachment 336173
  --> https://bugzilla.gnome.org/attachment.cgi?id=336173=edit
wayland/xdg-shell: update popup window monitor early

As meta_window_place_with_placement_rule will trigger a configure event
being sent ensure that the popup is placed on the correct monitor first
to ensure the right scale factor is applied.

Signed-off-by: Sjoerd Simons 

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-23 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #9 from Sjoerd Simons  ---
Created attachment 336172
  --> https://bugzilla.gnome.org/attachment.cgi?id=336172=edit
wayland/xdg-popup: Force monitor of the top-level

Directly set the monitor of the toplevel window for the popup to avoid
the change not being applied due to later constraints calculation.

Signed-off-by: Sjoerd Simons 

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-23 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #8 from Jonas Ådahl  ---
(In reply to Sjoerd Simons from comment #7)
> Seems that even with these two, the configure on the non-hdpi screen still
> gets a width/height half of the requested one

The configure event of the pop-up? I can't reproduce that. Could you send
WAYLAND_DEBUG=1 log?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-23 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #7 from Sjoerd Simons  ---
Seems that even with these two, the configure on the non-hdpi screen still gets
a width/height half of the requested one

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-23 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #6 from Jonas Ådahl  ---
Created attachment 336146
  --> https://bugzilla.gnome.org/attachment.cgi?id=336146=edit
wayland/xdg-shell: Scale configure relative popup coordinate

The parent local popup coordinate needs to be scaled according to the
monitor scale it is assigned.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-23 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #5 from Jonas Ådahl  ---
Created attachment 336145
  --> https://bugzilla.gnome.org/attachment.cgi?id=336145=edit
wayland/xdg-popup: Always use monitor of toplevel

Always use the monitor of the toplevel surface's window, so that the
popup menu and the parent will always have the same scale. This fixes
the dimensions sent in the xdg_popup configure event.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-23 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

Sjoerd Simons  changed:

   What|Removed |Added

 CC||sjo...@luon.net

--- Comment #4 from Sjoerd Simons  ---
This fixes the issue for me on my hidpi screen, however when using mixed setup
(hidpi laptop + normal dpi monitor) the issue still occurs on the non-hidpi
screen.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-23 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #3 from Jonas Ådahl  ---
(In reply to Bjørn Lie from comment #2)
> Created attachment 336142 [details]
> With patch
> 
> Works for me, but if possible, look at the oversize in the attached
> screenshot.
> 
> This is in any case much better than what we have :-) so stil +1 from me

Ah, some more coordinates that need the scale hack probably.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-23 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #2 from Bjørn Lie  ---
Created attachment 336142
  --> https://bugzilla.gnome.org/attachment.cgi?id=336142=edit
With patch

Works for me, but if possible, look at the oversize in the attached screenshot.

This is in any case much better than what we have :-) so stil +1 from me

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-23 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

--- Comment #1 from Jonas Ådahl  ---
Created attachment 336140
  --> https://bugzilla.gnome.org/attachment.cgi?id=336140=edit
wayland/xdg-shell: Scale positioner coordinates

When the monitor is scaled (i.e. HiDPI scaling) the placement
coordinates are still in unscaled xdg_surface window geometry
coordinate space. Fix this by simply scaling the coordinates by the
monitor scale of the parent toplevel window.

This is inherently racy, but since we won't move the toplevel window
before the popup is placed, and we won't move the window without
unmapping the popup, there is little point in introducing more complex
adaptive scaling, especially when the end goal is to get rid of all
these types of scaling hacks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771841] [Wayland] Drop-down menus are broken in position and size on HiDPI screens

2016-09-22 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771841

Michael Catanzaro  changed:

   What|Removed |Added

 CC||mcatanz...@gnome.org
 Blocks||757579

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs