[Wayland-bugs] [Bug 791939] Add xdg-shell (stable) support

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=791939

GNOME Infrastructure Team  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |OBSOLETE

--- Comment #11 from GNOME Infrastructure Team  ---
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from
further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/999.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 791939] Add xdg-shell (stable) support

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=791939

Daniel Boles  changed:

   What|Removed |Added

URL|https://gitlab.gnome.org/GN |https://gitlab.gnome.org/GN
   |OME/gtk/merge_requests/36   |OME/gtk/merge_requests/35
Version|unspecified |3.93.x

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 791939] Add xdg-shell (stable) support

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=791939

Daniel Boles  changed:

   What|Removed |Added

URL||https://gitlab.gnome.org/GN
   ||OME/gtk/merge_requests/36
 CC||dboles@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 791939] Add xdg-shell (stable) support

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=791939

--- Comment #10 from Jonas Ådahl  ---
Added https://gitlab.gnome.org/GNOME/gtk/merge_requests/35 and
https://gitlab.gnome.org/GNOME/gtk/merge_requests/36

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 791939] Add xdg-shell (stable) support

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=791939

--- Comment #9 from Matthias Clasen  ---
Ah, I have an older version of wayland-protocols in my jhbuild tree. Building
against the one in /usr worked. So, looks good to go then, as far as I'm
concerned. Can you look bringing this to master, too ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 791939] Add xdg-shell (stable) support

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=791939

--- Comment #8 from Jonas Ådahl  ---
(In reply to Daniel Stone from comment #7)
> (In reply to Jonas Ådahl from comment #4)
> > Regarding master, I was thinking of just replacing xdg_shell unstable v6
> > with xdg_shell stable, dropping the support for the old. Or is there any
> > point in supporting legacy protocol in gtk4?
> 
> Weston doesn't have a stable xdg_shell implementation yet, right?

Not that I know of. I guess an alternative is to wait with replacing it until
it has one. My point is mostly that it'd be nice to start with a "clean slate"
with gtk4 with less legacy cruft.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 791939] Add xdg-shell (stable) support

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=791939

Daniel Stone  changed:

   What|Removed |Added

 CC||dan...@fooishbar.org

--- Comment #7 from Daniel Stone  ---
(In reply to Jonas Ådahl from comment #4)
> Regarding master, I was thinking of just replacing xdg_shell unstable v6
> with xdg_shell stable, dropping the support for the old. Or is there any
> point in supporting legacy protocol in gtk4?

Weston doesn't have a stable xdg_shell implementation yet, right?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 791939] Add xdg-shell (stable) support

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=791939

--- Comment #6 from Jonas Ådahl  ---
(In reply to Matthias Clasen from comment #5)
> (In reply to Jonas Ådahl from comment #4)
> > What's the error when generating protocol sources?
> 
> They just don't seem to get generated... I've re-autogen'ed, and still, no
> sign of these files after a build.

Strange. I just tried

git clean -fdx
./autogen
make -C gdk -j8

It built fine and I can see gdk/wayland/xdg-shell-client-protocol.h in there.
Can you double check that wayland-protocols 1.12 is the version installed? It
seems autotools will automagically disable the wayland backend if the version
is not new enough when you run autogen.sh.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 791939] Add xdg-shell (stable) support

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=791939

--- Comment #5 from Matthias Clasen  ---
(In reply to Jonas Ådahl from comment #4)
> What's the error when generating protocol sources?

They just don't seem to get generated... I've re-autogen'ed, and still, no sign
of these files after a build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 791939] Add xdg-shell (stable) support

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=791939

--- Comment #4 from Jonas Ådahl  ---
What's the error when generating protocol sources?

Regarding master, I was thinking of just replacing xdg_shell unstable v6 with
xdg_shell stable, dropping the support for the old. Or is there any point in
supporting legacy protocol in gtk4?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 791939] Add xdg-shell (stable) support

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=791939

Matthias Clasen  changed:

   What|Removed |Added

 CC||mcla...@redhat.com

--- Comment #3 from Matthias Clasen  ---
I have trouble getting this to generate the protocol sources. Maybe I'm missing
something.

If it works for you, can also do a similar patch for master ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 791939] Add xdg-shell (stable) support

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=791939

--- Comment #1 from Jonas Ådahl  ---
Created attachment 365963
  --> https://bugzilla.gnome.org/attachment.cgi?id=365963=edit
wayland: Add support for xdg-shell stable

This commit adds support the stable version of the xdg-shell protocol.
Support for the last version of the unstable series is left intact, but
will not receive new features.

The stable version is prioritized above the older version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 791939] Add xdg-shell (stable) support

[gtk+]

https://bugzilla.gnome.org/show_bug.cgi?id=791939

--- Comment #2 from Jonas Ådahl  ---
Created attachment 365964
  --> https://bugzilla.gnome.org/attachment.cgi?id=365964=edit
wayland: Minor whitespace cleanups

Broke up a long line, added an empty one, and indented another one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs