[PATCH weston] compositor: when unmapping a surface remove it from the compositor's list

2013-09-21 Thread Giulio Camuffo
compositor.surface_list is recreated every redraw with the mapped surfaces, but if a surface gets unmapped and then in the same frame weston_compositor_pick_surface() is called we must make sure it does not pick the unmapped surface, since it traverses the surface_list to find one. If after the

Re: [RFC DRAFT] graphics tablet protocol extension

2013-09-21 Thread Bill Spitzak
On 09/20/2013 03:35 AM, Peter Hutterer wrote: * focus handling for the stylus is easy. focus handling for the buttons on the pad isn't. they could technically be focused elsewhere, like a keyboard focus. some buttons are definitely stylus based (BTN_STYLUS, BTN_STYLUS2, etc.) so should

Re: [PATCH] input: Fix trailing whitspaces and indent.

2013-09-21 Thread Kristian Høgsberg
On Tue, Sep 17, 2013 at 10:54:09AM +0100, Stefan Schmidt wrote: Just some cosmetics to conform to the wayland coding style. Yeah, thanks, lets' get rid of that. Kristian Signed-off-by: Stefan Schmidt s.schm...@samsung.com --- src/input.c | 10 +- 1 file changed, 5 insertions(+),

Re: [PATCH wayland] doc: Slight tweaks to wl_listener

2013-09-21 Thread Kristian Høgsberg
On Tue, Sep 17, 2013 at 04:44:24PM -0500, Aaron Faanes wrote: Prefer \comment over // in code blocks for consistency's sake and keep variable definitions separated by a line from the rest of the body. --- Thanks, got these patches. Kristian src/wayland-server.h | 10 ++ 1 file

Re: [PATCH] client: fix an inconsistency in documentation

2013-09-21 Thread Kristian Høgsberg
On Wed, Sep 18, 2013 at 10:45:06AM +, Chang Liu wrote: The errno is set to EAGAIN when there are undispatched events, according to L1066 of wayland-client.c. Thanks, good catch. Kristian --- src/wayland-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH weston] xwm: set the right cursor when hovering on the decoration borders

2013-09-21 Thread Kristian Høgsberg
On Wed, Sep 18, 2013 at 03:20:04PM +0200, Giulio Camuffo wrote: use the alternative cursor names used also in window.c, since the names it used previously are not guaranteed to exist in all themes. Makes sense, applied. Kristian --- src/xwayland/window-manager.c | 86

Re: Tests for wl_signal and wl_resource

2013-09-21 Thread Kristian Høgsberg
On Wed, Sep 18, 2013 at 05:29:47PM +0200, Marek Ch wrote: Hey, I wrote these tests, could you please review it? Additionaly, I modified test-runner so that now it prints how many leaks are present in test. That's a good change and the test cases look good. Thanks, all three patches

RE: [PATCH 4/9] output gl repaint in clone mode

2013-09-21 Thread Zhang, Xiong Y
The primary output will wait clone output. Until all the finish of clone output's page flip, primary output can send frame callback to clients and begin the next page flip. thanks -Original Message- From: wayland-devel-bounces+xiong.y.zhang=intel@lists.freedesktop.org

Re: weston-launch: xkbcommon error

2013-09-21 Thread christophe . jarry
xkbcommon: ERROR: failed to add default include path /usr/share/X11/xkb You need to install xkeyboard-config into /usr/share. Thanks. This fixed this issue. Christophe ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org

Re: [PATCH weston] compositor: when unmapping a surface remove it from the compositor's list

2013-09-21 Thread Kristian Høgsberg
On Sat, Sep 21, 2013 at 06:08:28PM +0200, Giulio Camuffo wrote: compositor.surface_list is recreated every redraw with the mapped surfaces, but if a surface gets unmapped and then in the same frame weston_compositor_pick_surface() is called we must make sure it does not pick the unmapped

Re: [PATCH weston 1/2 v2] input: Emit events on all resources for a client

2013-09-21 Thread Kristian Høgsberg
On Thu, Sep 19, 2013 at 05:32:00PM +0100, Neil Roberts wrote: Here is a second version of Robert's patch with the following changes: I think the problem where clients would not immediately become active when starting was caused by it calling weston_*_set_focus instead of sending the enter

Re: [PATCH 2/2] Add a hacky client to test multiple pointer/keyboard resources

2013-09-21 Thread Kristian Høgsberg
On Thu, Sep 19, 2013 at 05:32:01PM +0100, Neil Roberts wrote: ** I don't expect this patch to be landed but it might be useful if anyone wants to test the multi-resource stuff ** This adds a hacked version of simple-shm which can create multiple pointer and keyboard resources. The

Re: [PATCH wayland] Export the Wayland protocol XML file

2013-09-21 Thread Kristian Høgsberg
On Fri, Sep 20, 2013 at 08:27:06AM -0500, Jason Ekstrand wrote: Signed-off-by: Jason Ekstrand ja...@jlekstrand.net Yeah, let's do this; committed. Kristian --- protocol/Makefile.am | 2 +- src/wayland-client.pc.in | 2 ++ src/wayland-server.pc.in | 2 ++ 3 files changed, 5

Re: [PATCH 0/2] v2, Notify clients when the native mode is switched

2013-09-21 Thread Kristian Høgsberg
On Wed, Sep 18, 2013 at 11:56:34PM +0200, Hardening wrote: This revised version takes in account the comment of Pekka Paalanen and Jason Ekstrand. Thanks for working on this, both patches committed. Kristian Hardening (2): Rename current, origin, scale, origin_scale Notify clients on