Re: [RFC] Common input device library

2013-11-13 Thread Peter Hutterer
On Wed, Nov 13, 2013 at 01:22:26PM +0100, Jonas Ådahl wrote: > On Wed, Nov 13, 2013 at 7:22 AM, Peter Hutterer > wrote: > > Hi Jonas, > > > > On Tue, Nov 12, 2013 at 10:50:56PM +0100, Jonas Ådahl wrote: > >> Wayland compositors are expected to deal with input device processing > >> themselves prov

Re: [PATCH weston 3/8] westoy: Use subsurfaces for tooltips instead of transient windows

2013-11-13 Thread Kristian Høgsberg
On Tue, Nov 12, 2013 at 08:19:59PM -0500, Jasper St. Pierre wrote: > Transient windows, at least not as they are today, don't exist in > xdg_shell. Subsurfaces allow for specially placed surfaces relative > to a window, so use these instead. > --- > clients/window.c | 47 --

Re: [PATCH weston 4/8] westoy: Remove some accessors for wl_shell / wl_shell_surface

2013-11-13 Thread Kristian Høgsberg
On Tue, Nov 12, 2013 at 08:20:00PM -0500, Jasper St. Pierre wrote: > We want to remove support for these deprecated interfaces. Since > nothing is using them, this is a simple change. Applied, thanks. Kristian > --- > clients/window.c | 12 > clients/window.h | 6 -- > 2 files

Re: [PATCH weston 2/8] westoy: Remove unused support for window parents

2013-11-13 Thread Kristian Høgsberg
On Tue, Nov 12, 2013 at 08:19:58PM -0500, Jasper St. Pierre wrote: > It seems that this was only used by the popup menu infrastructure, > which can handle this all on its own. Implementing e.g. transients > in the future can be done with a simple xdg_shell_set_transient_for. > --- > clients/image.

Re: [PATCH weston 2/8] westoy: Remove unused support for window parents

2013-11-13 Thread Kristian Høgsberg
On Tue, Nov 12, 2013 at 08:19:58PM -0500, Jasper St. Pierre wrote: > It seems that this was only used by the popup menu infrastructure, > which can handle this all on its own. Implementing e.g. transients > in the future can be done with a simple xdg_shell_set_transient_for. Yeah, sounds good. Kr

Re: [PATCH weston 1/8] westoy: Remove window_touch_move

2013-11-13 Thread Kristian Høgsberg
On Tue, Nov 12, 2013 at 08:19:57PM -0500, Jasper St. Pierre wrote: > It seems to be the same as window_move, except it ignores the passed > in serial (???) and instead just uses the one of the display. Ok, hmm, yes, that's a little odd. Patch committed, thanks. Kristian > clients/flower.c

Re: [PATCH v2] server: Add API to protect access to an SHM buffer

2013-11-13 Thread Kristian Høgsberg
On Wed, Nov 13, 2013 at 03:32:05PM +, Neil Roberts wrote: > Ok, here is a second version of the patch which leaves the signal > handler permanently installed and uses thread-local storage to keep > track of the current pool. Yeah, that looks good now, both patches pushed. thanks, Kristian >

Re: [PATCH weston 7/8] westoy: Schedule a full resize when we add a subsurface

2013-11-13 Thread Jasper St. Pierre
On Wed, Nov 13, 2013 at 3:41 PM, Bill Spitzak wrote: > Is this to force the commit so that the subsurface appears? It might be > better to have a direct way to get the commit to happen without redrawing > the main surface. > It's to make sure that the transient's position and size is set, and th

Re: [PATCH weston 3/8] westoy: Use subsurfaces for tooltips instead of transient windows

2013-11-13 Thread Jasper St. Pierre
On Wed, Nov 13, 2013 at 3:36 PM, Bill Spitzak wrote: > Jasper St. Pierre wrote: > > Transient windows, at least not as they are today, don't exist in >> xdg_shell. Subsurfaces allow for specially placed surfaces relative >> to a window, so use these instead. >> > > So you noticed that subsurface

Re: [PATCH weston 1/8] westoy: Remove window_touch_move

2013-11-13 Thread Jasper St. Pierre
On Wed, Nov 13, 2013 at 3:37 PM, Bill Spitzak wrote: > Did you see my suggestion that the move and resize requests also be merged? > Yes, but I don't see what that has to do with this patch. This is about toy toolkit cleanup... > Jasper St. Pierre wrote: > >> It seems to be the same as window_

Re: [PATCH weston 7/8] westoy: Schedule a full resize when we add a subsurface

2013-11-13 Thread Bill Spitzak
Is this to force the commit so that the subsurface appears? It might be better to have a direct way to get the commit to happen without redrawing the main surface. In any case this looks a lot like you are hiding a bug that perhaps should be investigated, especially if it is in weston or your

Re: [PATCH weston 1/8] westoy: Remove window_touch_move

2013-11-13 Thread Bill Spitzak
Did you see my suggestion that the move and resize requests also be merged? Jasper St. Pierre wrote: It seems to be the same as window_move, except it ignores the passed in serial (???) and instead just uses the one of the display. ___ wayland-devel m

Re: [PATCH weston 3/8] westoy: Use subsurfaces for tooltips instead of transient windows

2013-11-13 Thread Bill Spitzak
Jasper St. Pierre wrote: Transient windows, at least not as they are today, don't exist in xdg_shell. Subsurfaces allow for specially placed surfaces relative to a window, so use these instead. So you noticed that subsurfaces and transient windows are very similer, huh? :-) In all seriousne

Re: [RFC v2] surface crop & scale protocol extension

2013-11-13 Thread Bill Spitzak
Pekka Paalanen wrote: Is your whole issue based on the premise, that the output resolution is not a multiple of output_scale? I think there is some serious confusion here. Everything here is a multiple of everything else. My client is attempting to obey the output_scale on the assumption th

[PATCH weston v2] Add calls to wl_shm_buffer_begin/end_access

2013-11-13 Thread Neil Roberts
Thanks for the feedback. Here is a version two of the patch which fixes some merge conflicts on master and adds support for the pixman renderer. Kristian wrote: > As for the pixman renderer it should be a matter of just wrapping > the calls to pixman_image_composite32() in > pixman_renderer_read_

[PATCH v2] server: Add API to protect access to an SHM buffer

2013-11-13 Thread Neil Roberts
Ok, here is a second version of the patch which leaves the signal handler permanently installed and uses thread-local storage to keep track of the current pool. Regards, - Neil --- >8 --- (use git am --scissors to automatically chop here) Linux will let you mmap a region of a fil

Re: [RFC] Common input device library

2013-11-13 Thread Jonas Ådahl
On Wed, Nov 13, 2013 at 7:22 AM, Peter Hutterer wrote: > Hi Jonas, > > On Tue, Nov 12, 2013 at 10:50:56PM +0100, Jonas Ådahl wrote: >> Wayland compositors are expected to deal with input device processing >> themselves providing input events according to the Wayland protocol to >> the clients. So

Re: [RFC] Common input device library

2013-11-13 Thread Jonas Ådahl
On Wed, Nov 13, 2013 at 4:00 AM, Christopher James Halse Rogers wrote: > On Tue, 2013-11-12 at 22:50 +0100, Jonas Ådahl wrote: >> Hi, >> >> Wayland compositors are expected to deal with input device processing >> themselves providing input events according to the Wayland protocol to >> the clients

Re: [RFC] Common input device library

2013-11-13 Thread Jonas Ådahl
On Wed, Nov 13, 2013 at 1:49 AM, Kristian Høgsberg wrote: > On Tue, Nov 12, 2013 at 1:50 PM, Jonas Ådahl wrote: >> Hi, >> >> Wayland compositors are expected to deal with input device processing >> themselves providing input events according to the Wayland protocol to >> the clients. So far only

Re: [RFC v2] surface crop & scale protocol extension

2013-11-13 Thread Alexander Larsson
On ons, 2013-11-13 at 11:54 +0200, Pekka Paalanen wrote: > On Tue, 12 Nov 2013 16:14:36 -0800 > Bill Spitzak wrote: > > > Pekka Paalanen wrote: > > > > >> The source rectangle *must* be in buffer pixels. Putting it in > > >> buffer_scale units makes absolutely no sense, as the buffer_scale is i

Re: [RFC v2] surface crop & scale protocol extension

2013-11-13 Thread Pekka Paalanen
On Tue, 12 Nov 2013 16:14:36 -0800 Bill Spitzak wrote: > Pekka Paalanen wrote: > > >> The source rectangle *must* be in buffer pixels. Putting it in > >> buffer_scale units makes absolutely no sense, as the buffer_scale is in > >> effect ignored for this surface, overridden entirely by the sca

Re: [PATCH] input: Don't send leave events to destroyed views

2013-11-13 Thread Emilio Pozuelo Monfort
On 12/11/13 19:28, Emilio Pozuelo Monfort wrote: > If a view which has focus is destroyed, we would send a leave > event while changing focus, causing a segfault. Prevent this > by listening to the view's destroy signal and removing it from > the pointer focus. > > Signed-off-by: Emilio Pozuelo Mo