Re: [PATCH 02/12] shell.c: Restore maximized and fullscreen window on destroyed output

2014-03-18 Thread Ander Conselvan de Oliveira
On 03/18/2014 07:39 AM, Zhang, Xiong Y wrote: On Mon, 2014-03-17 at 19:17 +0200, Ander Conselvan de Oliveira wrote: On 03/07/2014 10:27 AM, Xiong Zhang wrote: When maximized or fullscreen window is on destroyed output, compositor can't change these windows to normal window without notify

Re: [PATCH 02/12] shell.c: Restore maximized and fullscreen window on destroyed output

2014-03-18 Thread Zhang, Xiong Y
On Tue, 2014-03-18 at 10:21 +0200, Conselvan De Oliveira, Ander wrote: On 03/18/2014 07:39 AM, Zhang, Xiong Y wrote: On Mon, 2014-03-17 at 19:17 +0200, Ander Conselvan de Oliveira wrote: On 03/07/2014 10:27 AM, Xiong Zhang wrote: When maximized or fullscreen window is on destroyed output,

[PATCH] Add error handling for wl_cursors

2014-03-18 Thread Hardening
This patch adds some error management in wayland cursors --- cursor/wayland-cursor.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/cursor/wayland-cursor.c b/cursor/wayland-cursor.c index b16f530..dba3b51 100644 --- a/cursor/wayland-cursor.c +++

[PATCH] Check return value of wl_cursor functions

2014-03-18 Thread Hardening
This patch adds checks for themes and cursors returned by wl_cursor functions. --- clients/simple-egl.c | 10 ++ clients/window.c | 4 src/compositor-wayland.c | 7 ++- 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/clients/simple-egl.c

[PATCH weston-ivi-shell v5 9/9] Modify example clients to support ivi-application.xml

2014-03-18 Thread Nobuhiko Tanibata
Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp --- Changes for v2, v3 and v4 - nothing. Version number aligned to the first patch Changes for v5 - support weston-dnd-ivi to verify wl_pointer::set_cursor and wl_data_device::start_drag clients/.gitignore | 6 +

Re: [PATCH weston-ivi-shell v3 02/10] ivi application protocol:

2014-03-18 Thread Nobuhiko Tanibata
2014-03-17 18:11 に Nobuhiko Tanibata さんは書きました: 2014-03-17 16:15 に Pekka Paalanen さんは書きました: Hi pq, I see. In case of ivi, ivi_application shall be exclusive from others. In wayland client manner, client manages which role wl_surface shall do, I understand. Sub-surface: it can have a

[PATCH] Make RDP backend supports arbitrary modes

2014-03-18 Thread Hardening
This patch removes the extra modes parameter for the RDP compositor. And make it support any mode that is requested (be aware that RDP client may not support all possible modes, especially odd resolution). This is definitely useful for the fullscreen shell. --- src/compositor-rdp.c | 105

Re: [PATCH] Add error handling for wl_cursors

2014-03-18 Thread Bryce W. Harrington
LGTM Reviewed-by: Bryce Harrington b.harring...@samsung.com On Tue, Mar 18, 2014 at 11:29:00AM +0100, Hardening wrote: This patch adds some error management in wayland cursors --- cursor/wayland-cursor.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff

Re: [PATCH 1/3] wayland: Add wl_output name event

2014-03-18 Thread Bryce W. Harrington
On Mon, Mar 17, 2014 at 11:34:50AM +0800, Quanxian Wang wrote: This event contains name of output. It may be sent after binding the output object. It is intended that client could input a character output name as a parameter or for log output. Signed-off-by: Quanxian Wang

Re: [PATCH 0/3] Add wl_output name event

2014-03-18 Thread Bryce W. Harrington
Apart from my phrasing suggestions on the first patch, the series looks good now, so feel free to add: Reviewed-by: Bryce Harrington b.harring...@samsung.com On Mon, Mar 17, 2014 at 11:34:49AM +0800, Quanxian Wang wrote: This event contains name of output. It may be sent after binding the

[PATCH] compositor: Use weston_log rather than perror for error messages

2014-03-18 Thread Bryce W. Harrington
weston_log() seems to be the standard elsewhere in the codebase for errors. These are the only two instances where perror() is used instead, and their error messages aren't that informative anyway. Signed-off-by: Bryce Harrington b.harring...@samsung.com --- src/compositor-wayland.c |4 ++--

Re: [PATCH] compositor: Use weston_log rather than perror for error messages

2014-03-18 Thread Hardening
Le 18/03/2014 20:34, Bryce W. Harrington a écrit : weston_log() seems to be the standard elsewhere in the codebase for errors. These are the only two instances where perror() is used instead, and their error messages aren't that informative anyway. Signed-off-by: Bryce Harrington

Re: [PATCH 1/3] wayland: Add wl_output name event

2014-03-18 Thread Jason Ekstrand
On Mar 18, 2014 2:09 PM, Bryce W. Harrington b.harring...@samsung.com wrote: On Mon, Mar 17, 2014 at 11:34:50AM +0800, Quanxian Wang wrote: This event contains name of output. It may be sent after binding the output object. It is intended that client could input a character output name as

Re: [PATCH 2/3] weston: Add wl_output name event

2014-03-18 Thread Jason Ekstrand
On Mar 16, 2014 10:20 PM, Quanxian Wang quanxian.w...@intel.com wrote: Signed-off-by: Quanxian Wang quanxian.w...@intel.com --- src/compositor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index 98a4f6f..f82f771 100644 --- a/src/compositor.c

Re: [PATCH 3/3] shell: Add wl_output name event

2014-03-18 Thread Jason Ekstrand
On Mar 16, 2014 10:20 PM, Quanxian Wang quanxian.w...@intel.com wrote: Signed-off-by: Quanxian Wang quanxian.w...@intel.com --- clients/desktop-shell.c | 10 +- clients/window.c| 10 +- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git

RE: [PATCH 2/3] weston:Add wl_output name event

2014-03-18 Thread Jason Ekstrand
On Mar 16, 2014 5:30 AM, Wang, Quanxian quanxian.w...@intel.com wrote: From: Jason Ekstrand [mailto:ja...@jlekstrand.net] Sent: Saturday, March 15, 2014 9:10 PM To: Wang, Quanxian Cc: ppaala...@gmail.com; wayland-devel@lists.freedesktop.org Subject: RE: [PATCH 2/3] weston:Add wl_output

RE: [PATCH 1/3] wayland: Add wl_output name event

2014-03-18 Thread Wang, Quanxian
-Original Message- From: Bryce W. Harrington [mailto:b.harring...@samsung.com] Sent: Wednesday, March 19, 2014 3:09 AM To: Wang, Quanxian Cc: wayland-devel@lists.freedesktop.org; ja...@jlekstrand.net Subject: Re: [PATCH 1/3] wayland: Add wl_output name event On Mon, Mar 17, 2014 at

Re: [PATCH 1/3] wayland: Add wl_output name event

2014-03-18 Thread Bryce W. Harrington
On Wed, Mar 19, 2014 at 01:54:13AM +, Wang, Quanxian wrote: [Wang, Quanxian] Thanks Bryce. I glanced at the other patches and they look technically correct, but I think what might be missing here is a stronger justification about why this is needed? [Wang, Quanxian] name is one property

RE: [PATCH 2/3] weston:Add wl_output name event

2014-03-18 Thread Wang, Quanxian
From: Jason Ekstrand [mailto:ja...@jlekstrand.net] Sent: Wednesday, March 19, 2014 8:55 AM To: Wang, Quanxian Cc: ppaala...@gmail.com; wayland-devel@lists.freedesktop.org Subject: RE: [PATCH 2/3] weston:Add wl_output name event On Mar 16, 2014 5:30 AM, Wang, Quanxian

RE: [PATCH 1/3] wayland: Add wl_output name event

2014-03-18 Thread Wang, Quanxian
-Original Message- From: Bryce W. Harrington [mailto:b.harring...@samsung.com] Sent: Wednesday, March 19, 2014 10:01 AM To: Wang, Quanxian Cc: wayland-devel@lists.freedesktop.org; ja...@jlekstrand.net Subject: Re: [PATCH 1/3] wayland: Add wl_output name event On Wed, Mar 19, 2014 at

RE: [PATCH 2/3] weston:Add wl_output name event

2014-03-18 Thread Wang, Quanxian
From: Wang, Quanxian Sent: Wednesday, March 19, 2014 10:03 AM To: 'Jason Ekstrand' Cc: ppaala...@gmail.com; wayland-devel@lists.freedesktop.org Subject: RE: [PATCH 2/3] weston:Add wl_output name event From: Jason Ekstrand [mailto:ja...@jlekstrand.net] Sent: Wednesday, March 19, 2014 8:55 AM

[PATCH 2/3] weston:Add wl_output name event

2014-03-18 Thread Quanxian Wang
Signed-off-by: Quanxian Wang quanxian.w...@intel.com --- src/compositor.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 40e4b11..78e2b48 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -3115,7 +3115,7 @@

[PATCH 1/3] wayland: Add wl_output name event

2014-03-18 Thread Quanxian Wang
This event contains a human-readable name of output. It may be sent after binding the output object. It is intended that the client can use this output name as a parameter or display it in logs. For example, in weston randr application, output name can be a parameter in command line to stand for

[PATCH 0/3] Add wl_output name event

2014-03-18 Thread Quanxian Wang
This event contains a human-readable name of output. It may be sent after binding the output object. It is intended that the client can use this output name as a parameter or display it in logs. For example, in weston randr application, output name can be a parameter in command line to stand for

[PATCH 3/3] shell: Add wl_output name event

2014-03-18 Thread Quanxian Wang
Signed-off-by: Quanxian Wang quanxian.w...@intel.com --- clients/desktop-shell.c | 12 ++-- clients/window.c| 12 ++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index a0c6b6d..9b15e3c 100644 ---