Re: [PATCH] Support on-the-fly transparency changes in pixman renderer

2014-04-07 Thread Kristian Høgsberg
On Sat, Apr 05, 2014 at 05:31:37AM +0200, Manuel Bachmann wrote: When the alpha channel of a surface is changed and the surface refreshed, pixman renderer will now apply a mask corresponding to the alpha channel value. This allows visual effects like shell fade in, shell fade out, window

Re: [PATCH weston] nested: Disable cairo on the subsurfaces

2014-04-07 Thread Kristian Høgsberg
On Mon, Feb 24, 2014 at 07:07:08PM +, Neil Roberts wrote: The subsurface widgets on the nested example aren't using Cairo to render so we should turn it off to prevent the toy toolkit from creating a redundant extra surface for it. This is particularly important since Mesa commit

Re: [PATCH] Support on-the-fly transparency changes in pixman renderer

2014-04-07 Thread Pekka Paalanen
On Sat, 5 Apr 2014 05:31:37 +0200 Manuel Bachmann manuel.bachm...@open.eurogiciel.org wrote: When the alpha channel of a surface is changed and the surface refreshed, pixman renderer will now apply a mask corresponding to the alpha channel value. A minor nitpick here. The term alpha channel

[PATCH] Fix on-the-fly transparency changes in pixman-renderer

2014-04-07 Thread Manuel Bachmann
This fixes : - leaking the mask used to simulate transparency ; - code style (definitions moved up, use of brackets) ; - applying an opaque region when transparency is wanted (shound not happen). Signed-off-by: Manuel Bachmann manuel.bachm...@open.eurogiciel.org --- src/pixman-renderer.c | 19

Re: [PATCH] Support on-the-fly transparency changes in pixman renderer

2014-04-07 Thread Manuel Bachmann
Hi Kristian, Thanks a lot for your review ! You're totally right, I was leaking the mask (shame on me :-( ) and wasn't totally consistent on the code style part. I just submitted another patch, which should address most of our concerns :

[PATCH weston] Make sure config.h is included before any system headers

2014-04-07 Thread Andrew Wedgbury
There was an issue recently in screen-share.c where config.h was not being included, resulting in the wrong definition for off_t being used on 32 bit systems. I checked and I don't think this problem is happening elsewhere, but to help avoid this sort of problem in the future, I went through

Re: [PATCH] Fix on-the-fly transparency changes in pixman-renderer

2014-04-07 Thread Pekka Paalanen
On Mon, 7 Apr 2014 11:58:45 +0200 Manuel Bachmann manuel.bachm...@open.eurogiciel.org wrote: This fixes : - leaking the mask used to simulate transparency ; - code style (definitions moved up, use of brackets) ; - applying an opaque region when transparency is wanted (shound not happen).

[PATCH weston] gl-renderer: Keep track of the GL format used for SHM buffers

2014-04-07 Thread Neil Roberts
Jason Ekstrand wrote: We may still have a problem if the client changes buffer formats mid-stream. Say it starts out with RGB565 to save memory but latter decides it wants alpha so it switches to ARGB. We should probably detect this and make sure glTexImage2D gets called again to reset

Re: [PATCH weston] gl-renderer: Keep track of the GL format used for SHM buffers

2014-04-07 Thread Kristian Høgsberg
On Mon, Apr 07, 2014 at 03:01:01PM +0100, Neil Roberts wrote: Jason Ekstrand wrote: We may still have a problem if the client changes buffer formats mid-stream. Say it starts out with RGB565 to save memory but latter decides it wants alpha so it switches to ARGB. We should probably

[PATCH weston] Don't include xserver-server-protocol.h

2014-04-07 Thread Mariusz Ceier
It was removed in 757d8aff2757387bcd594e2ee2a27055b366eac3, along with xserver protocol. Signed-off-by: Mariusz Ceier mceier+wayl...@gmail.com --- xwayland/dnd.c| 1 - xwayland/launcher.c | 1 - xwayland/window-manager.c | 1 - 3 files changed, 3 deletions(-) diff --git

Re: [PATCH] Fix on-the-fly transparency changes in pixman-renderer

2014-04-07 Thread Kristian Høgsberg
On Mon, Apr 07, 2014 at 04:02:11PM +0300, Pekka Paalanen wrote: On Mon, 7 Apr 2014 11:58:45 +0200 Manuel Bachmann manuel.bachm...@open.eurogiciel.org wrote: This fixes : - leaking the mask used to simulate transparency ; - code style (definitions moved up, use of brackets) ; -

Re: [PATCH weston] Don't include xserver-server-protocol.h

2014-04-07 Thread Kristian Høgsberg
On Mon, Apr 07, 2014 at 06:02:13PM +0200, Mariusz Ceier wrote: It was removed in 757d8aff2757387bcd594e2ee2a27055b366eac3, along with xserver protocol. Signed-off-by: Mariusz Ceier mceier+wayl...@gmail.com Thanks, applied. /me hangs head in shame. Kristian --- xwayland/dnd.c

Re: [PATCH weston] Make sure config.h is included before any system headers

2014-04-07 Thread Kristian Høgsberg
On Mon, Apr 07, 2014 at 12:40:35PM +0100, Andrew Wedgbury wrote: There was an issue recently in screen-share.c where config.h was not being included, resulting in the wrong definition for off_t being used on 32 bit systems. I checked and I don't think this problem is happening elsewhere, but

Re: [PATCH] Fix on-the-fly transparency changes in pixman-renderer

2014-04-07 Thread Manuel Bachmann
Awesome ! Thank you both once again. Regards, Manuel 2014-04-07 18:46 GMT+02:00 Kristian Høgsberg hoegsb...@gmail.com: On Mon, Apr 07, 2014 at 04:02:11PM +0300, Pekka Paalanen wrote: On Mon, 7 Apr 2014 11:58:45 +0200 Manuel Bachmann manuel.bachm...@open.eurogiciel.org wrote: This

[PATCH V3 5/7] weston:Add the weston randr protocol implementation

2014-04-07 Thread Quanxian Wang
Signed-off-by: Quanxian Wang quanxian.w...@intel.com --- module/Makefile.am|3 + module/wrandr/Makefile.am | 32 ++ module/wrandr/wrandr.c| 1262 + 3 files changed, 1297 insertions(+) create mode 100644 module/Makefile.am create mode

[PATCH V3 4/7] Add new mode function in drm backend

2014-04-07 Thread Quanxian Wang
provide drm_output_new_mode interface to create new mode from outsite instead of only from edid or configure. Signed-off-by: Quanxian Wang quanxian.w...@intel.com --- src/compositor-drm.c | 76 1 file changed, 76 insertions(+) diff --git

[PATCH V3 0/7] Add weston randr protocol

2014-04-07 Thread Quanxian Wang
Important Changes compared with V2: 1) Provide 2 methods to mode match for mode setting and mode delete. a) Exact mode number match Client selects the mode number according to query information. b) Fuzzy match for width, height and refresh Set: First matches, first takes effect.

[PATCH V3 6/7] weston: Add configure to support wrandr.

2014-04-07 Thread Quanxian Wang
Signed-off-by: Quanxian Wang quanxian.w...@intel.com --- Makefile.am | 5 + configure.ac | 8 2 files changed, 13 insertions(+) diff --git a/Makefile.am b/Makefile.am index f22c542..254cde7 100644 --- a/Makefile.am +++ b/Makefile.am @@ -6,11 +6,16 @@ if ENABLE_XWAYLAND

[PATCH V3 1/7] weston: Add weston randr protocol

2014-04-07 Thread Quanxian Wang
Weston randr protocol will provide interfaces to 1) Mode set of output (scale, transform, mode setting) For mode setting, three match methods are provided. 2) Position of output (currently support leftof, rightof) More need to be done, above, below and any positoion of output with (x,y). 3)

[PATCH V3 2/7] weston: Add the weston randr support in compositor.h

2014-04-07 Thread Quanxian Wang
1) Add weston_randr definition and randr_backend intreface. 2) Export functions used in compositor.c so that module wrandr could use them. For example, weston_output_transform_scale_init. 3) Support new_mode backend interface in output structure. Signed-off-by: Quanxian Wang

[PATCH V3 3/7] weston: Add enable-wrandr option and export common functions

2014-04-07 Thread Quanxian Wang
When starting weston with parameter --enable-wrandr, it will automatically load wrandr.so module. This is for QA testing and Admin configuration. weston_output_transform_scale_init will be used by weston randr module. Signed-off-by: Quanxian Wang quanxian.w...@intel.com --- src/compositor.c |