Re: Bug 78372 - create multiple windows with offset

2014-05-08 Thread Pekka Paalanen
On Thu, 08 May 2014 13:13:34 -0700 Bill Spitzak wrote: > I posted the same patch for the xserver for 6 months to allow it to read > a different xorg.conf file. I finally got sick of being ignored and gave > up, also recent xwayland can now work on a non-EGL wayland without > having a special x

[PATCH] event: Cheking for NULL before dereferencing the pointer.

2014-05-08 Thread Srivardhan Hebbar
Checking for NULL before dereferencing the wl_event_source pointer so as to avoid crash. Signed-off-by: Srivardhan Hebbar --- src/event-loop.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/event-loop.c b/src/event-loop.c index 9790cde..b62d16e 100644 --- a/src/

Re: [PATCH] Destroy resources when destroying input and output

2014-05-08 Thread Pekka Paalanen
On Thu, 8 May 2014 19:32:12 -0500 Jason Ekstrand wrote: > On Tue, Dec 31, 2013 at 3:37 AM, Pekka Paalanen wrote: > > > You cannot just go and destroy wl_resources, because there are > > clients using them - that is why the wl_resources exist in the > > first place. Clients use all protocol obje

Re: [PATCH 2/2] compositor-wayland: Add touch support

2014-05-08 Thread Boyan Ding
At 2014-05-08 09:55:23, "Jason Ekstrand" wrote: Boyan, By and large, this looks really good! I have just a few comments below. As I said in another e-mail, I don't have any touch hardware I can test this on, so I wasn't able to actually test it. Unfortunately, I don't have touch hardware ei

[PATCH] desktop-shell: Fix black edges on scaled desktop pattern

2014-05-08 Thread Bill Spitzak
Filter sampling outside the source image can leak black into the edges of the desktop image. This is most easily seen by scaling the default tiled image with this weston.ini: # no background-image and no background-color background-type=scale-crop --- clients/desktop-shell.c |

Re: weston logind and display managers

2014-05-08 Thread nerdopolis
On Wednesday, May 07, 2014 10:18:00 PM Pier Luigi wrote: > Hi, > > I'm porting sddm (QtQuick based display manager) to Wayland, it's > still work in progress but close to be in a usable state and you can > find it here: > > https://github.com/plfiorini/sddm/tree/wayland > > There are some multip

Re: [PATCH weston] Destroy resources when destroying an output

2014-05-08 Thread Jason Ekstrand
On Thu, May 8, 2014 at 1:07 PM, Mariusz Ceier wrote: > Hi, >I sent similar patch in the past, and this reply from Pekka may be > still relevant: > > http://lists.freedesktop.org/archives/wayland-devel/2013-December/012691.html > See the reply I just sent out to the above e-mail. --Jason Ekstr

Re: [PATCH] Destroy resources when destroying input and output

2014-05-08 Thread Jason Ekstrand
On Tue, Dec 31, 2013 at 3:37 AM, Pekka Paalanen wrote: > On Wed, 25 Dec 2013 17:02:09 +0100 > Mariusz Ceier wrote: > > > Some structures containing resources list are freed before > > resources on that list are destroyed, and that triggers invalid > > read/write in compositor.c:3103 indirectly c

[PATCH wayland 4/6] scanner: Also fail when an implicitly versioned message is out of order

2014-05-08 Thread Jonas Ådahl
Fail if a message with version implicitly set to 1 (i.e. not specified) comes after a message with since-version > 1. Signed-off-by: Jonas Ådahl --- src/scanner.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index dd1c7b6..28fadb0 1

[PATCH wayland 6/6] scanner: Generate macros for getting the 'since' version of an event

2014-05-08 Thread Jonas Ådahl
This could be useful for compositors who need to be able to not send events if the client bound a version lower than the newest provided. Event version numbers are exposed as [INTERFACE_NAME]_[EVENT_NAME]_SINCE_VERSION for example wl_output.scale will have the version macro WL_OUTPUT_SCALE_SINCE_V

[PATCH wayland 5/6] tests: Add message version sanity test

2014-05-08 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- Makefile.am | 5 - tests/message-test.c | 50 ++ 2 files changed, 54 insertions(+), 1 deletion(-) create mode 100644 tests/message-test.c diff --git a/Makefile.am b/Makefile.am index f1584d5..ee9f29e 10

[PATCH wayland 3/6] protocol: Fix order the messages of wl_pointer, wl_keyboard and wl_touch

2014-05-08 Thread Jonas Ådahl
The "release" message of wl_pointer, wl_keyboard and wl_touch was placed first in the respective interface XML element, causing wayland-scanner to misbehave and set the version number of the "release" message to all subsequent messages with no explicitly specified "since" version. Signed-off-by: J

[PATCH wayland 2/6] doc: Remove deprecated doxygen tag

2014-05-08 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- doc/doxygen/wayland.doxygen.in | 16 1 file changed, 16 deletions(-) diff --git a/doc/doxygen/wayland.doxygen.in b/doc/doxygen/wayland.doxygen.in index dd98594..c5544ac 100644 --- a/doc/doxygen/wayland.doxygen.in +++ b/doc/doxygen/wayland.doxygen.i

[PATCH wayland 1/6] event-loop-test: Remove unused variable

2014-05-08 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- tests/event-loop-test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/event-loop-test.c b/tests/event-loop-test.c index 1218163..655de87 100644 --- a/tests/event-loop-test.c +++ b/tests/event-loop-test.c @@ -228,7 +228,6 @@ timer_update_callback_2(void *d

Re: Bug 78372 - create multiple windows with offset

2014-05-08 Thread Bill Spitzak
On 05/08/2014 01:34 PM, Jasper St. Pierre wrote: xorg.conf is outdated, and really shouldn't be used in production. It's been replaced by /etc/xorg.conf.d. Xwayland shouldn't require *any* configuration. At all. If we need to configure Xwayland somewhere, we've messed up. If you're still having

Re: Bug 78372 - create multiple windows with offset

2014-05-08 Thread Jasper St. Pierre
On Thu, May 8, 2014 at 4:13 PM, Bill Spitzak wrote: > On 05/08/2014 11:31 AM, Jasper St. Pierre wrote: > >> I don't know how you can have been on the Wayland mailing list for this >> long and not grasp core Wayland protocol concepts. Clients cannot get >> global surface positions, and it's been t

Re: Bug 78372 - create multiple windows with offset

2014-05-08 Thread Bill Spitzak
On 05/08/2014 11:31 AM, Jasper St. Pierre wrote: I don't know how you can have been on the Wayland mailing list for this long and not grasp core Wayland protocol concepts. Clients cannot get global surface positions, and it's been that way since day 1 six years ago. Yes I know that. I said EXAC

Re: Bug 78372 - create multiple windows with offset

2014-05-08 Thread Jasper St. Pierre
I don't know how you can have been on the Wayland mailing list for this long and not grasp core Wayland protocol concepts. Clients cannot get global surface positions, and it's been that way since day 1 six years ago. I also have never seen a patch or a line of code from you, ever. It's incredibly

Re: [PATCH weston] Destroy resources when destroying an output

2014-05-08 Thread Mariusz Ceier
Hi, I sent similar patch in the past, and this reply from Pekka may be still relevant: http://lists.freedesktop.org/archives/wayland-devel/2013-December/012691.html Mariusz Ceier On 8 May 2014 19:38, Neil Roberts wrote: > When an output is destroyed it now also destroys any resources that >

Re: Bug 78372 - create multiple windows with offset

2014-05-08 Thread Bill Spitzak
On 05/07/2014 10:54 PM, Pekka Paalanen wrote: This is similar to session save/restore, lacking a better term for it. We do not even pretend to support or enable this yet. It is just yet one more feature that the shell protocol suite for desktop should cover, but so far no-one has done any work o

[PATCH weston] Destroy resources when destroying an output

2014-05-08 Thread Neil Roberts
When an output is destroyed it now also destroys any resources that were pointing to it. Otherwise if the resource is destroyed after the output then the resource would try to remove itself from the resource list but the head of the resource list would no longer be valid and it would write to inval

Re: [PATCH wayland 2/3] server: Split out code to open sockets for a specific display name

2014-05-08 Thread Jasper St. Pierre
On Wed, May 7, 2014 at 9:24 PM, Jason Ekstrand wrote: > Comments below, > --Jason Ekstrand > > On Wed, May 7, 2014 at 9:25 AM, Jasper St. Pierre > wrote: > >> We'll use this to autodetect a good socket to open on. >> --- >> src/wayland-server.c | 40 +--- >>

[Question]wl_input_method and wl_input_panel are bound in diffrent processes

2014-05-08 Thread yan . wang
Hi, All, I have a question about wl_input_method and wl_input_panel. I read the sample named keyboard.c in weston/client. This sample binds the 2 interfaces. My question is whether the 2 interfaces could be bound in different process? E.g. When porting scim input method to Weston, virtual key

[PATCH weston] editor: Fix cursor positioning with pointer and touch

2014-05-08 Thread Ander Conselvan de Oliveira
The calculation off the vertical offset between the widget coordinates and where the text was rendered was wrong. It was using the constant for horizontal offset for that too. --- clients/editor.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git

Re: Bug 78372 - create multiple windows with offset

2014-05-08 Thread Jasper St. Pierre
What should happen if the user unplugs monitors, or adds an additional one, or repositions them? What should be restored where? On Wed, May 7, 2014 at 4:10 PM, Bill Spitzak wrote: > Good to see there is an actual bug on this, but I need to ask for our > exact case: > > Our app can be configured