At 2014-05-08 09:55:23, Jason Ekstrand ja...@jlekstrand.net wrote:
Boyan,
By and large, this looks really good! I have just a few comments below. As I
said in another e-mail, I don't have any touch hardware I can test this on, so
I wasn't able to actually test it.
Unfortunately, I don't
On Thu, 8 May 2014 19:32:12 -0500
Jason Ekstrand ja...@jlekstrand.net wrote:
On Tue, Dec 31, 2013 at 3:37 AM, Pekka Paalanen ppaala...@gmail.com wrote:
You cannot just go and destroy wl_resources, because there are
clients using them - that is why the wl_resources exist in the
first
Checking for NULL before dereferencing the wl_event_source
pointer so as to avoid crash.
Signed-off-by: Srivardhan Hebbar sri.heb...@samsung.com
---
src/event-loop.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/event-loop.c b/src/event-loop.c
index
On Thu, 08 May 2014 13:13:34 -0700
Bill Spitzak spit...@gmail.com wrote:
I posted the same patch for the xserver for 6 months to allow it to read
a different xorg.conf file. I finally got sick of being ignored and gave
up, also recent xwayland can now work on a non-EGL wayland without
On Thu, 08 May 2014 10:52:51 -0700
Bill Spitzak spit...@gmail.com wrote:
On 05/07/2014 10:54 PM, Pekka Paalanen wrote:
This is similar to session save/restore, lacking a better term for it.
We do not even pretend to support or enable this yet. It is just yet one
more feature that the
Le 09/05/2014 08:43, Srivardhan Hebbar a écrit :
Checking for NULL before dereferencing the wl_event_source
pointer so as to avoid crash.
Signed-off-by: Srivardhan Hebbar sri.heb...@samsung.com
---
src/event-loop.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git
Hi, Pq
Thanks for your comment and idea.
I list several cases for discussion.
Case 1:
Original:
├──
│ B │
└──
Action: Move A leftof B
├───┼───┤
│ A │ B │
└───┴───┘
As you said, B must not change, A will have negative coordinates. That is fine.
Case 2:
Original:
├───┼───┤
│ C │ D │E
Hi,
On 9 May 2014 08:34, Pekka Paalanen ppaala...@gmail.com wrote:
On Thu, 08 May 2014 10:52:51 -0700
Bill Spitzak spit...@gmail.com wrote:
Possibly you are reading the words save/restore literally, in that you
are imagining some blob of data stored in the compositor that is
recognized
On Thu, 08 May 2014 20:00:35 -0700
Bill Spitzak spit...@gmail.com wrote:
Filter sampling outside the source image can leak black into the edges
of the
desktop image. This is most easily seen by scaling the default tiled image
with this weston.ini:
# no background-image and no
-Original Message-
From: wayland-devel [mailto:wayland-devel-
boun...@lists.freedesktop.org] On Behalf Of Hardening
Sent: Friday, May 09, 2014 1:08 PM
To: wayland-devel@lists.freedesktop.org
Subject: Re: [PATCH] event: Cheking for NULL before dereferencing the
pointer.
Le
On Fri, 09 May 2014 14:56:14 +0530
Srivardhan sri.heb...@samsung.com wrote:
-Original Message-
From: wayland-devel [mailto:wayland-devel-
boun...@lists.freedesktop.org] On Behalf Of Hardening
Sent: Friday, May 09, 2014 1:08 PM
To: wayland-devel@lists.freedesktop.org
-Original Message-
From: Pekka Paalanen [mailto:ppaala...@gmail.com]
Sent: Friday, May 09, 2014 3:09 PM
To: Srivardhan
Cc: 'Hardening'; wayland-devel@lists.freedesktop.org
Subject: Re: [PATCH] event: Cheking for NULL before dereferencing the
pointer.
On Fri, 09 May 2014
On Fri, 09 May 2014 15:21:51 +0530
Srivardhan sri.heb...@samsung.com wrote:
-Original Message-
From: Pekka Paalanen [mailto:ppaala...@gmail.com]
Sent: Friday, May 09, 2014 3:09 PM
To: Srivardhan
Cc: 'Hardening'; wayland-devel@lists.freedesktop.org
Subject: Re: [PATCH]
From: Pekka Paalanen pekka.paala...@collabora.co.uk
See 918f2dd4cfb8b177f67b45653efbbe4325cbe9dc
Signed-off-by: Pekka Paalanen pekka.paala...@collabora.co.uk
---
src/rpi-renderer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/rpi-renderer.c b/src/rpi-renderer.c
Le 09/05/2014 12:20, Pekka Paalanen a écrit :
On Fri, 09 May 2014 15:21:51 +0530
Srivardhan sri.heb...@samsung.com wrote:
-Original Message-
From: Pekka Paalanen [mailto:ppaala...@gmail.com]
Sent: Friday, May 09, 2014 3:09 PM
To: Srivardhan
Cc: 'Hardening';
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
The error handling for the function that writes the encoded frame on
the disk was bogus, always assuming the buffer supplied to the encoder
was too small. That would cause a bigger buffer to be allocated and
another attempt
On Fri, 09 May 2014 14:50:19 +0200
Hardening rdp.eff...@gmail.com wrote:
Le 09/05/2014 12:20, Pekka Paalanen a écrit :
On Fri, 09 May 2014 15:21:51 +0530
Srivardhan sri.heb...@samsung.com wrote:
-Original Message-
From: Pekka Paalanen [mailto:ppaala...@gmail.com]
Sent:
Perhaps we should consider applying the patch anyway even though it's
not ideal. Currently if a client uses a dead output in a request such as
xdg_surface.set_output Weston will end up with a weston_output pointer
that points to freed memory. This could cause the compositor to crash.
That is worse
On Fri, 09 May 2014 14:33:58 +0100
Neil Roberts n...@linux.intel.com wrote:
Perhaps we should consider applying the patch anyway even though it's
not ideal. Currently if a client uses a dead output in a request such as
xdg_surface.set_output Weston will end up with a weston_output pointer
This patch sets to NULL event sources after a call to wl_event_source_remove()
has been made.
---
src/clipboard.c | 3 ++-
src/compositor-drm.c | 3 +++
src/compositor-rpi.c | 1 +
src/compositor-x11.c | 2 ++
src/compositor.c | 6 +-
src/evdev-touchpad.c | 1 +
src/evdev.c
This patch handles the case where a signal event source can not be created.
---
src/compositor.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/compositor.c b/src/compositor.c
index 6ad3387..047df8a 100644
--- a/src/compositor.c
+++ b/src/compositor.c
@@
On Fri, May 9, 2014 at 1:37 AM, Pekka Paalanen ppaala...@gmail.com wrote:
Looking at it in general, there is one more fun complication.
If the inert object has requests in its interface, that create new
objects, the server cannot just ignore those requests. I think the
server will need to
On Fri, May 9, 2014 at 1:09 AM, Boyan Ding stu_...@126.com wrote:
At 2014-05-08 09:55:23, Jason Ekstrand ja...@jlekstrand.net wrote:
Boyan,
By and large, this looks really good! I have just a few comments below.
As I said in another e-mail, I don't have any touch hardware I can test
this
Jason Ekstrand ja...@jlekstrand.net writes:
Most of the magic there is in allowing resources with no handler in
libwayland-server. The patch would be about 4 lines. Right now,
client-side wl_proxy objects are allowed to have a NULL implementation
and there's no problem; server-side, this is
The release message of wl_pointer, wl_keyboard and wl_touch introduced
in version 3 was placed first in the respective interface XML element,
causing wayland-scanner to misbehave and set the version number of the
release message to all subsequent messages with no explicitly specified
since
On 05/09/2014 12:34 AM, Pekka Paalanen wrote:
Possibly you are reading the words save/restore literally, in that you
are imagining some blob of data stored in the compositor that is
recognized to restore the layout. However this is NOT what is wanted.
Sure, that's the first thing comes to my
On 05/09/2014 02:11 AM, Pekka Paalanen wrote:
On Thu, 08 May 2014 20:00:35 -0700
Bill Spitzak spit...@gmail.com wrote:
Filter sampling outside the source image can leak black into the edges
of the
desktop image. This is most easily seen by scaling the default tiled image
with this
Only accept specific literal values from the environment variable
WESTON_LIBINPUT_LOG_PRIORITY... debug, info, or error.
Signed-off-by: U. Artie Eoff ullysses.a.e...@intel.com
---
src/libinput-seat.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/libinput-seat.c
On Fri, May 09, 2014 at 11:13:54AM -0700, Bill Spitzak wrote:
On 05/09/2014 02:11 AM, Pekka Paalanen wrote:
On Thu, 08 May 2014 20:00:35 -0700
Bill Spitzak spit...@gmail.com wrote:
Filter sampling outside the source image can leak black into the edges
of the
desktop image. This is most
On Wed, May 07, 2014 at 01:11:07AM +, Bryce W. Harrington wrote:
Quells warning:
clients/keyboard.c: In function ‘keyboard_handle_key.isra.5’:
clients/keyboard.c:556:11: warning: ‘label’ may be used uninitialized in
this function [-Wuninitialized]
Signed-off-by: Bryce Harrington
On Wed, May 07, 2014 at 02:13:11AM +, Bryce W. Harrington wrote:
Signed-off-by: Bryce Harrington b.harring...@samsung.com
---
clients/editor.c |4 +---
clients/subsurfaces.c |8 ++--
clients/window.c | 13 ++---
3 files changed, 5 insertions(+), 20
On Wed, May 07, 2014 at 02:13:11AM +, Bryce W. Harrington wrote:
Signed-off-by: Bryce Harrington b.harring...@samsung.com
---
clients/desktop-shell.c |2 +-
clients/editor.c|2 +-
clients/fullscreen.c|2 +-
clients/subsurfaces.c |6 +++---
On Wed, May 07, 2014 at 02:13:11AM +, Bryce W. Harrington wrote:
Signed-off-by: Bryce Harrington b.harring...@samsung.com
---
clients/editor.c | 12 ++--
clients/image.c|4 ++--
clients/keyboard.c | 12 ++--
clients/terminal.c |2 +-
4 files changed,
On Wed, May 07, 2014 at 09:37:45AM +0530, Srivardhan Hebbar wrote:
Signed-off-by: Srivardhan Hebbar sri.heb...@samsung.com
---
src/wayland-server.c |9 +
1 file changed, 9 insertions(+)
diff --git a/src/wayland-server.c b/src/wayland-server.c
index f2b1b42..57b65ce 100644
---
On Wed, May 07, 2014 at 11:47:08AM +0300, Pekka Paalanen wrote:
On Tue, 6 May 2014 14:40:53 -0700
Kristian Høgsberg hoegsb...@gmail.com wrote:
On Mon, May 05, 2014 at 05:02:15PM +0300, Ander Conselvan de Oliveira
wrote:
From: Ander Conselvan de Oliveira
On Wed, May 07, 2014 at 11:57:28AM +0300, Ander Conselvan de Oliveira wrote:
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
The check to avoid calling weston_keyboard_set_focus() for a seat that
didn't have a keyboard in restore_focus_state() was cheking the wrong
On Wed, May 07, 2014 at 02:22:23PM +0300, Ander Conselvan de Oliveira wrote:
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
Moving a maximized surface with the pointer is already not possible,
so make the behavior with touch consistent.
Filter sampling outside the source image can leak black into the edges of the
desktop image. This is most easily seen by scaling the default tiled image
with this weston.ini:
# no background-image and no background-color
background-type=scale-crop
---
clients/desktop-shell.c |
Thanks, it looks like that setup worked, patch sent correctly now.
On 05/09/2014 11:52 AM, Jonas Ådahl wrote:
If you are using gmail, you can just use Googles SMTP server directly.
The example configuration in the manual [0] even is a @gmail.com
address setup.
Jonas
[0]
On Thu, May 08, 2014 at 08:00:35PM -0700, Bill Spitzak wrote:
Filter sampling outside the source image can leak black into the edges of
the
desktop image. This is most easily seen by scaling the default tiled image
with this weston.ini:
# no background-image and no background-color
On Fri, May 09, 2014 at 02:56:14PM +0530, Srivardhan wrote:
-Original Message-
From: wayland-devel [mailto:wayland-devel-
boun...@lists.freedesktop.org] On Behalf Of Hardening
Sent: Friday, May 09, 2014 1:08 PM
To: wayland-devel@lists.freedesktop.org
Subject: Re: [PATCH]
On Fri, May 09, 2014 at 03:08:06PM +0300, Pekka Paalanen wrote:
From: Pekka Paalanen pekka.paala...@collabora.co.uk
See 918f2dd4cfb8b177f67b45653efbbe4325cbe9dc
Thanks Pekka, applied.
Kristian
Signed-off-by: Pekka Paalanen pekka.paala...@collabora.co.uk
---
src/rpi-renderer.c | 4 ++--
On Fri, May 09, 2014 at 03:57:38PM +0300, Ander Conselvan de Oliveira wrote:
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
The error handling for the function that writes the encoded frame on
the disk was bogus, always assuming the buffer supplied to the encoder
was
On Fri, May 09, 2014 at 04:03:51PM +0200, Hardening wrote:
This patch sets to NULL event sources after a call to wl_event_source_remove()
has been made.
We don't generally set freed memory to NULL, unless we rely on testing that
to decide whether the pointer points to an object or not.
On Fri, May 09, 2014 at 04:03:52PM +0200, Hardening wrote:
This patch handles the case where a signal event source can not be created.
---
src/compositor.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/compositor.c b/src/compositor.c
index
On Fri, May 09, 2014 at 11:24:40AM -0700, U. Artie Eoff wrote:
Only accept specific literal values from the environment variable
WESTON_LIBINPUT_LOG_PRIORITY... debug, info, or error.
Signed-off-by: U. Artie Eoff ullysses.a.e...@intel.com
Thanks Artie, I think we can squeeze that in with the
On Fri, May 09, 2014 at 01:52:33PM -0700, Bill Spitzak wrote:
Thanks, it looks like that setup worked, patch sent correctly now.
Great, it's good to have git send-email working. As it turns out, I
didn't have any problems applying your initial email, but I do have the
fix whitespace option
On Thu, May 08, 2014 at 11:39:49PM +0200, Jonas Ådahl wrote:
This could be useful for compositors who need to be able to not send
events if the client bound a version lower than the newest provided.
Event version numbers are exposed as
[INTERFACE_NAME]_[EVENT_NAME]_SINCE_VERSION for example
On Wed, May 07, 2014 at 04:26:29PM +0300, Pekka Paalanen wrote:
From: Pekka Paalanen pekka.paala...@collabora.co.uk
If the test is named xwayland.weston, then the automake test harness
keys it off xwayland.log. Making xwayland.log runs the test.
The test harness has implicit rules to create
On Thu, May 08, 2014 at 02:55:50PM +0300, Ander Conselvan de Oliveira wrote:
The calculation off the vertical offset between the widget coordinates
and where the text was rendered was wrong. It was using the constant for
horizontal offset for that too.
---
clients/editor.c | 33
50 matches
Mail list logo
