Re: [PATCH weston] xdg-shell: Make stable

2014-08-26 Thread Pekka Paalanen
On Mon, 25 Aug 2014 11:21:33 -0700 Bill Spitzak spit...@gmail.com wrote: On 08/25/2014 04:11 AM, Pekka Paalanen wrote: Let's also think about the size hints, how do they interact here, even if we are not adding them yet. The client creates a wl_surface, gives it content, and turns it

Re: [PATCH weston] xdg-shell: Make stable

2014-08-26 Thread Pekka Paalanen
On Mon, 25 Aug 2014 21:51:57 -0700 Jason Ekstrand ja...@jlekstrand.net wrote: Just a couple quick comments below. I can't fin where this goes, so I'm putting it here: Why are we having compositors send an initial configure event again? Given that we have a serial, tiling compositors can

Re: [PATCH weston] xdg-shell: Make stable

2014-08-26 Thread Giulio Camuffo
2014-08-26 10:24 GMT+03:00 Pekka Paalanen ppaala...@gmail.com: On Mon, 25 Aug 2014 21:51:57 -0700 Jason Ekstrand ja...@jlekstrand.net wrote: Just a couple quick comments below. I can't fin where this goes, so I'm putting it here: Why are we having compositors send an initial configure

Re: Wayland and Weston 1.6 alpha snapshot (1.5.91)

2014-08-26 Thread Daniel Stone
Hi, On 23 August 2014 15:38, Pekka Paalanen ppaala...@gmail.com wrote: On Fri, 22 Aug 2014 10:51:19 -0700 Jason Ekstrand ja...@jlekstrand.net wrote: On Fri, Aug 22, 2014 at 9:08 AM, Pekka Paalanen ppaala...@gmail.com wrote: Just before this alpha release, we bumped the xdg-shell

Re: Wayland and Weston 1.6 alpha snapshot (1.5.91)

2014-08-26 Thread Pekka Paalanen
On Tue, 26 Aug 2014 10:36:58 +0100 Daniel Stone dan...@fooishbar.org wrote: Hi, On 23 August 2014 15:38, Pekka Paalanen ppaala...@gmail.com wrote: On Fri, 22 Aug 2014 10:51:19 -0700 Jason Ekstrand ja...@jlekstrand.net wrote: On Fri, Aug 22, 2014 at 9:08 AM, Pekka Paalanen

Re: [PATCH v2 1/2] Protocol: Add destructor to wl_data_device interface Fix for Bug# 81745

2014-08-26 Thread Pekka Paalanen
On Fri, 22 Aug 2014 19:16:49 +0530 kabeer.k...@samsung.com wrote: From: kabeer kabeer.k...@samsung.com Signed-off-by: kabeer kabeer.k...@samsung.com --- protocol/wayland.xml |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/protocol/wayland.xml

Re: [PATCH v2 2/2] Implement data_device interface destructor

2014-08-26 Thread Pekka Paalanen
On Fri, 22 Aug 2014 19:17:55 +0530 kabeer.k...@samsung.com wrote: From: kabeer kabeer.k...@samsung.com window: use data_device interface destructor data-device: implement data_device_release destructor Signed-off-by: kabeer kabeer.k...@samsung.com --- clients/window.c |2 +-

Re: Re: [PATCH v2 1/2] Protocol: Add destructor to wl_data_device interface Fix for Bug# 81745

2014-08-26 Thread Kabeer Ahmed Khan
Title: Samsung Enterprise Portal mySingle Hi Thank You Pekka for review comments. I will bump the revision on wl_data_device_manager and submit another patch. With Thanks and Regards Kabeer --- Original Message --- Sender : Pekka Paalanenppaala...@gmail.com Date : Aug 26, 2014

[PATCH weston] simple-shm: remove an unnecessary call of wl_display_get_fd()

2014-08-26 Thread Ryo Munakata
--- clients/simple-shm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/clients/simple-shm.c b/clients/simple-shm.c index b1c311f..c1cb386 100644 --- a/clients/simple-shm.c +++ b/clients/simple-shm.c @@ -393,8 +393,6 @@ create_display(void) exit(1); } -

Re: [PATCH weston] xdg-shell: Make stable

2014-08-26 Thread Giulio Camuffo
2014-08-26 17:39 GMT+03:00 Jason Ekstrand ja...@jlekstrand.net: On Aug 26, 2014 1:01 AM, Giulio Camuffo giuliocamu...@gmail.com wrote: 2014-08-26 10:24 GMT+03:00 Pekka Paalanen ppaala...@gmail.com: On Mon, 25 Aug 2014 21:51:57 -0700 Jason Ekstrand ja...@jlekstrand.net wrote: Just a

Re: [PATCH weston] xdg-shell: Make stable

2014-08-26 Thread Jason Ekstrand
On Aug 26, 2014 1:01 AM, Giulio Camuffo giuliocamu...@gmail.com wrote: 2014-08-26 10:24 GMT+03:00 Pekka Paalanen ppaala...@gmail.com: On Mon, 25 Aug 2014 21:51:57 -0700 Jason Ekstrand ja...@jlekstrand.net wrote: Just a couple quick comments below. I can't fin where this goes, so I'm

Re: [PATCH weston] simple-shm: remove an unnecessary call of wl_display_get_fd()

2014-08-26 Thread Nils Chr. Brause
Since wl_display_get_fd() doesn't have any side effects, this is truly useless. Reviewed-by: Nils Chr. Brause nilschrbra...@gmail.com On Tue, Aug 26, 2014 at 2:59 PM, Ryo Munakata ryomnk...@gmail.com wrote: --- clients/simple-shm.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH weston] xdg-shell: Make stable

2014-08-26 Thread Bill Spitzak
On 08/25/2014 11:25 PM, Pekka Paalanen wrote: No, please make it impossible for a client to rely on events being echoed in response to requests. Otherwise toolkits will rely on this and Wayland will become a synchronous protocol. Did you understand that this is not an additional round-trip,

Re: [PATCH weston] xdg-shell: Make stable

2014-08-26 Thread Bill Spitzak
On 08/26/2014 07:39 AM, Jason Ekstrand wrote: - Preferred fullscreen scaling: I would like to be as large as possible, I would like to be pixel-perfect, even if that means smaller and surrounded in black, etc. TBH, I don't know how many clients would actually like the later one. Maybe if

Re: [PATCH weston] xdg-shell: Make stable

2014-08-26 Thread Jasper St. Pierre
For as fast as possible, can I show randomly generated pixels instead? For a HiDPI display, it's as useful as running 1:1, centered, and it certainly is a hell of a lot faster. I don't care about fast if it can't make any guarantees about what the user gets in the end. Games might try and set the

Re: [PATCH weston] xdg-shell: Make stable

2014-08-26 Thread Bill Spitzak
You are right, as fast as possible is a poor name. What I think the options are is: 1. Use a scale so the surface exactly fills the screen 2. Use the largest integer that fits on the screen. This will produce a sharper image. I'm unsure if there is any hardware where integer scaling is

Re: Wayland and Weston 1.6 alpha snapshot (1.5.91)

2014-08-26 Thread Peter Hutterer
On Fri, Aug 22, 2014 at 07:08:59PM +0300, Pekka Paalanen wrote: Hi, here is the alpha release on our road to 1.6.0: 0b0513706eee5a43d33f5e4bc9cafa5d78037db5 wayland-1.5.91.tar.xz 6d0f298665e0f6b11a18ab6b6ccc49ba990b4b3e wayland 1.5.91 tag 59b3f1fa9456ed9cf6b21201647ce3a96c91e03b

[PATCH libinput 03/11] udev: use evdev_device_calibrate() instead of manually writing the matrix

2014-08-26 Thread Peter Hutterer
We have a wrapper, use it. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/udev-seat.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/src/udev-seat.c b/src/udev-seat.c index 8d19894..2947e71 100644 --- a/src/udev-seat.c +++

[PATCH weston] libinput: normalize WL_CALIBRATION before passing it to libinput

2014-08-26 Thread Peter Hutterer
WL_CALIBRATION, introduced in weston-1.1, requires the translation component of the calibration matrix to be in screen coordinates. libinput does not have access to this and it's not a very generic way to do this anyway. So with the libinput backend, WL_CALIBRATION support is currently broken

[PATCH libinput 04/11] evdev: constify evdev_device_calibrate

2014-08-26 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 3 ++- src/evdev.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index b09bb98..9c53e32 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -976,7 +976,8 @@

[PATCH libinput 08/11] udev: drop WL_CALIBRATION, replace with LIBINPUT_CALIBRATION_MATRIX

2014-08-26 Thread Peter Hutterer
WL_CALIBRATION is a weston-specific property that required the translation component of the matrix to be in pixels. libinput can't provide calibration based on unknown outputs, so drop support for this property. The basic functionality is maintained, renaming just makes the change in behavior

[PATCH libinput 07/11] evdev: switch to a normalized transformation matrix

2014-08-26 Thread Peter Hutterer
The big change here is the requirement to have the translation component in a device-normalized coordinate space. Without that, we cannot reliably rotate as the coordinate space is effectively unknown and may differ between the axes. This affects any rotation matrix or translation matrix, pure

[PATCH libinput 01/11] test: add helpers to wait for specific events

2014-08-26 Thread Peter Hutterer
litest_wait_for_event() returns if any event is available. litest_wait_for_event_of_type(... type, type, type, -1) returns if any of the given event types is availble. All other events are discarded. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/litest.c | 46

[PATCH libinput 11/11] evdev: load the LIBINPUT_CALIBRATION_MATRIX as default matrix

2014-08-26 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- See patch 08/11, not sure we really want that configuration back-channel. src/evdev.c | 19 --- src/evdev.h | 4 src/udev-seat.c | 2 +- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git

[PATCH libinput 02/11] test: add a generic single-touch device

2014-08-26 Thread Peter Hutterer
With a non-zero absmin for both axes and different ranges for x/y, just to detect those errors. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/Makefile.am | 1 + test/litest-generic-singletouch.c | 88 +++ test/litest.c

[PATCH libinput 00/11] Fix device calibration

2014-08-26 Thread Peter Hutterer
This series fixes calibration support in libinput. The two simple changes: calibration is now applied to multitouch events as well, and instead of libinput_device_calibrate() there is the quartett of configuration hooks: libinput_device_config_calibration_has/set/get/get_default_matrix()

[PATCH libinput 09/11] test: add tests for touch calibration

2014-08-26 Thread Peter Hutterer
Basic tests for rotation, translation and scaling events. Note that tests need to be added separately for single-touch and touch devices, this is a restriction of the litest framework. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/touch.c | 192

[PATCH libinput 06/11] util: add a couple of 3x3 matrix helper functions

2014-08-26 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-util.h | 100 test/misc.c | 78 2 files changed, 178 insertions(+) diff --git a/src/libinput-util.h b/src/libinput-util.h