RE: [PATCH 2/2] clients: Maximize window when double touch on title bar

2014-09-09 Thread Zhang, Xiong Y
On Thu, 12 Jun 2014 11:06:26 +0800 Xiong Zhang xiong.y.zh...@intel.com wrote: Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com --- clients/window.c| 26 -- shared/cairo-util.h | 7 +++ shared/frame.c | 49

Re: [PATCH] xdg-shell: update shsurf-output when maximizing

2014-09-09 Thread Marek Chalupa
Hi, On 8 September 2014 20:08, Bill Spitzak spit...@gmail.com wrote: I'm probably being stupid, but I still can't figure out how it chooses the output for a NON-maximized surface. I would think that should use exactly the same algorithm as maximized does here? Each surface has assigned

Re: [PATCH weston 2/2] main: don't leak option strings

2014-09-09 Thread Pekka Paalanen
On Mon, 08 Sep 2014 11:00:37 -0700 Bill Spitzak spit...@gmail.com wrote: On 09/07/2014 11:28 PM, Pekka Paalanen wrote: I think it is safe to assume the contents of argv will not get overwritten. It is common to copy argv itself and modify that, but not to modify the strings it points

Re: [PATCH 2/2] clients: Maximize window when double touch on title bar

2014-09-09 Thread Pekka Paalanen
On Tue, 9 Sep 2014 06:14:34 + Zhang, Xiong Y xiong.y.zh...@intel.com wrote: On Thu, 12 Jun 2014 11:06:26 +0800 Xiong Zhang xiong.y.zh...@intel.com wrote: Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com --- clients/window.c| 26 --

[PATCH] tests: use nanosleep instead of usleep

2014-09-09 Thread Marek Chalupa
man usleep says that bahaviour of using usleep with SIGALRM signal is unspecified. So use nanosleep instead. Signed-off-by: Marek Chalupa mchqwe...@gmail.com --- tests/display-test.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git

Re: [PATCH weston] compositor: remove unused signal

2014-09-09 Thread Pekka Paalanen
On Fri, 5 Sep 2014 23:26:33 +0300 Giulio Camuffo giuliocamu...@gmail.com wrote: The move_signal in weston_output isn't used, and not even initialized, so anything trying to listen to it will crash on wl_signal_add(). Instead of it, the 'output_moved_signal' in weston_compositor is used, so

[PATCH v2] tests: use nanosleep instead of usleep

2014-09-09 Thread Marek Chalupa
man usleep says that bahaviour of using usleep with SIGALRM signal is unspecified. So create our own usleep that calls nanosleep instead. Signed-off-by: Marek Chalupa mchqwe...@gmail.com --- tests/display-test.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff

Re: [PATCH weston 1/2] main: usual patterns can be extracted to functions

2014-09-09 Thread Pekka Paalanen
Hi, this should really be two separate patches, each with a specific commit message. The subject line here does not really tell much. I rewrote the commit message, and pushed. Thanks, pq On Sat, 6 Sep 2014 07:32:05 +0900 Ryo Munakata ryomnk...@gmail.com wrote: Signed-off-by: Ryo Munakata

RE: [PATCH 2/2] clients: Maximize window when double touch on title bar

2014-09-09 Thread Zhang, Xiong Y
Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com --- clients/window.c| 26 -- shared/cairo-util.h | 7 +++ shared/frame.c | 49 + 3 files changed, 80 insertions(+), 2 deletions(-) diff --git

Re: [PATCH weston] compositor: fix memory corruption when removing an output

2014-09-09 Thread Pekka Paalanen
On Sat, 6 Sep 2014 16:18:02 +0300 Giulio Camuffo giuliocamu...@gmail.com wrote: The destructor set on the wl_output resources needs the weston_output to be allocated, because it removes the resource from its list. So unset the destructor on all the resources when destroying an output. ---

Re: [PATCH 3/4] tests: add display test that highlights another bug in read_events

2014-09-09 Thread Marek Chalupa
On 4 September 2014 15:17, Pekka Paalanen ppaala...@gmail.com wrote: On Fri, 29 Aug 2014 11:21:30 +0200 Marek Chalupa mchqwe...@gmail.com wrote: When wl_display_read_events() returns with errno == EAGAIN, we naturally try to call it again. But this next call results in deadlock.

Re: [PATCH weston 2/2] main: don't leak option strings

2014-09-09 Thread Daniel Stone
Hi, On 9 September 2014 07:49, Pekka Paalanen ppaala...@gmail.com wrote: On Mon, 08 Sep 2014 11:00:37 -0700 Bill Spitzak spit...@gmail.com wrote: On 09/07/2014 11:28 PM, Pekka Paalanen wrote: Trying to shut up valgrind on exit is an exercise in futility and adding a free() to try to shut

Re: [PATCH 2/2] clients: Maximize window when double touch on title bar

2014-09-09 Thread Steven Newbury
On Tue, 2014-09-09 at 10:06 +0300, Pekka Paalanen wrote: On Tue, 9 Sep 2014 06:14:34 + Zhang, Xiong Y zh...@intel.com wrote: On Thu, 12 Jun 2014 11:06:26 +0800 Xiong Zhang zh...@intel.com wrote: Signed-off-by: Xiong Zhang zh...@intel.com --- clients/window.c| 26

Re: [PATCH 3/4] tests: add display test that highlights another bug in read_events

2014-09-09 Thread Marek Chalupa
On 9 September 2014 13:10, Marek Chalupa mchqwe...@gmail.com wrote: On 4 September 2014 15:17, Pekka Paalanen ppaala...@gmail.com wrote: On Fri, 29 Aug 2014 11:21:30 +0200 Marek Chalupa mchqwe...@gmail.com wrote: When wl_display_read_events() returns with errno == EAGAIN, we naturally

Re: [PATCH 3/4] tests: add display test that highlights another bug in read_events

2014-09-09 Thread Pekka Paalanen
On Tue, 9 Sep 2014 13:10:48 +0200 Marek Chalupa mchqwe...@gmail.com wrote: On 4 September 2014 15:17, Pekka Paalanen ppaala...@gmail.com wrote: On Fri, 29 Aug 2014 11:21:30 +0200 Marek Chalupa mchqwe...@gmail.com wrote: When wl_display_read_events() returns with errno == EAGAIN, we

Re: [PATCH] xdg-shell: update shsurf-output when maximizing

2014-09-09 Thread Bill Spitzak
On 09/08/2014 11:15 PM, Marek Chalupa wrote: Each surface has assigned output it is currently mapped on (so it can be NULL). This surface-output is set by weston_surface_assign_output which is called by weston_view_assign_output (and that by weston_surface_update_transform) or by surface_unmap.

Re: [PATCH weston 2/2] main: don't leak option strings

2014-09-09 Thread Bill Spitzak
On 09/08/2014 11:49 PM, Pekka Paalanen wrote: parse_options() already strdups() all strings it returns, which is one reason why I would not go removing the strdups. You are right it already does that. Did not realize it even though I worked some on that code. I figured it was doing pointer

Re: [PATCH v2 weston] libinput: normalize WL_CALIBRATION before passing it to libinput

2014-09-09 Thread Jonas Ådahl
On Tue, Sep 09, 2014 at 01:15:42PM +1000, Peter Hutterer wrote: On Mon, Sep 08, 2014 at 08:16:07PM +0200, Jonas Ådahl wrote: On Fri, Sep 05, 2014 at 11:25:25AM +1000, Peter Hutterer wrote: WL_CALIBRATION, introduced in weston-1.1, requires the translation component of the calibration

Re: [PATCH v2 weston] libinput: normalize WL_CALIBRATION before passing it to libinput

2014-09-09 Thread Peter Hutterer
On Tue, Sep 09, 2014 at 10:42:26PM +0200, Jonas Ådahl wrote: On Tue, Sep 09, 2014 at 01:15:42PM +1000, Peter Hutterer wrote: On Mon, Sep 08, 2014 at 08:16:07PM +0200, Jonas Ådahl wrote: On Fri, Sep 05, 2014 at 11:25:25AM +1000, Peter Hutterer wrote: WL_CALIBRATION, introduced in

[PATCH libinput 2/2] Document the static udev configuration options we support

2014-09-09 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 32 1 file changed, 32 insertions(+) diff --git a/src/libinput.h b/src/libinput.h index 7fde65f..a0e5d4c 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -104,6 +104,38 @@ extern C {

[PATCH libinput 1/2] Document LIBINPUT_CALIBRATION_MATRIX properly

2014-09-09 Thread Peter Hutterer
Make this part of our API proper and outline the 4 most common examples. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput.h | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/libinput.h b/src/libinput.h index 5af0dde..7fde65f 100644

Re: [PATCH libinput 1/2] Document LIBINPUT_CALIBRATION_MATRIX properly

2014-09-09 Thread Bill Spitzak
On 09/09/2014 04:40 PM, Peter Hutterer wrote: + * The udev property is parsed as 6 floating point numbers separated by a + * single space each (scanf(3) format %f %f %f %f %f %f). + * The 6 values represent the first two rows of the calibration matrix as + * described in