Re: [PATCH weston] input: don't send to clients key events eaten by bindings

Hi, On 19 November 2014 21:05, Bill Spitzak spit...@gmail.com wrote: On 11/19/2014 05:08 AM, Pekka Paalanen wrote: Just like Jasper said, it is a mistake to use wl_keyboard focus for window focus, xdg_shell has a separate mechanism for window focus. Window focus is a shell concept IMO,

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

Hi, On 20 November 2014 08:05, Daniel Stone dan...@fooishbar.org wrote: On 19 November 2014 21:05, Bill Spitzak spit...@gmail.com wrote: On 11/19/2014 05:08 AM, Pekka Paalanen wrote: Just like Jasper said, it is a mistake to use wl_keyboard focus for window focus, xdg_shell has a separate

Re: [PATCH weston] dnd: reset the mouse cursor after adding a new item

Hi, On 19 November 2014 22:41, Bill Spitzak spit...@gmail.com wrote: On 11/19/2014 07:16 AM, Derek Foreman wrote: I'm pretty sure the mouse may have already moved - exactly the same reason as above, this handler is getting the drop co-ords but time has passed since the drop. You are

[PATCH weston] desktop-shell: don't crash input-panel if no kbd focus

From: Pekka Paalanen pekka.paala...@collabora.co.uk If a keyboard exists but it has no current focus, yet something asks the input-panel to come up, we would crash here. Check that there is a focus before attempting to use it. Maybe there should not even exist a case where input-panel tries to

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-20 10:05 GMT+02:00 Daniel Stone dan...@fooishbar.org: Hi, On 19 November 2014 21:05, Bill Spitzak spit...@gmail.com wrote: On 11/19/2014 05:08 AM, Pekka Paalanen wrote: Just like Jasper said, it is a mistake to use wl_keyboard focus for window focus, xdg_shell has a separate

Re: [PATCH libinput v2 3/3] touchpad: Add edge-scrolling support

Hi, On 11/20/2014 07:21 AM, Peter Hutterer wrote: On Wed, Nov 19, 2014 at 01:45:35PM +0100, Hans de Goede wrote: Add edge-scrolling support for non multi-touch touchpads as well as for users who prefer edge-scrolling (as long as they don't have a clickpad). Note the percentage to use of the

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

On 11/20/2014 12:05 AM, Daniel Stone wrote: As far as I can tell from what the others are saying - which I'd totally agree with - is that wl_keyboard's focus would be much more transient than it is now, reflecting where keyboard events are _actually_ being delivered _right now_. So if the

Re: [PATCH weston] dnd: reset the mouse cursor after adding a new item

On 19/11/14 04:41 PM, Bill Spitzak wrote: On 11/19/2014 07:16 AM, Derek Foreman wrote: I'm pretty sure the mouse may have already moved - exactly the same reason as above, this handler is getting the drop co-ords but time has passed since the drop. You are right about that. I'm not clear

[PATCH weston] input: don't run the key bindings on focus in

When getting the focus we get the list of pressed keys, but we are not supposed to run the key binding on them. --- src/input.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/input.c b/src/input.c index 80aa34e..15ff6ed 100644 --- a/src/input.c +++ b/src/input.c @@ -1404,12 +1404,6

[PATCH weston v2] dnd: Fix some mouse cursor issues

When ending a drag in the window the cursor will be wrong until the mouse is moved again. This is because the item being dragged isn't added until after the enter event. Also, when picking up an item while moving the mouse the cursor can switch back to a non-drag cursor before the drag begins.

[PATCH weston] clients: Use xmalloc in a few more places

Just changes some places where a malloc failure is unhandled to our xmalloc function that exit()s a little more gracefully. Signed-off-by: Derek Foreman der...@osg.samsung.com --- clients/editor.c | 4 ++-- clients/window.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH wayland] tests: rename NO_ASSERT_LEAK_CHECK

On Wed, Nov 19, 2014 at 12:00:10PM +0100, Marek Chalupa wrote: This env variable is used for turning off the leak checks in tests. Rename it to WAYLAND_TESTS_NO_LEAK_CHECK, so that it is consistent with WAYLAND_TESTS_NO_TIMEOUTS. Should these both be 'WAYLAND_TEST_'? In weston there is

Re: [PATCH libinput v2 3/3] touchpad: Add edge-scrolling support

On Thu, Nov 20, 2014 at 10:34:51AM +0100, Hans de Goede wrote: [...] +int +tp_edge_scroll_init(struct tp_dispatch *tp, struct evdev_device *device) +{ + struct tp_touch *t; + int width, height; + int edge_width, edge_height; + + width = device-abs.absinfo_x-maximum -

[PATCH 1/3] Use zalloc rather than malloc and manually setting members to 0

Signed-off-by: Bryce Harrington br...@osg.samsung.com --- src/clipboard.c | 5 +++-- src/screenshooter.c | 9 ++--- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/clipboard.c b/src/clipboard.c index 5a3a02d..dbd8c9b 100644 --- a/src/clipboard.c +++ b/src/clipboard.c @@

[PATCH 2/3] Setting members to 0/NULL after a zalloc or calloc is redundant

calloc (and zalloc) set the allocated memory to 0, so there's really no need to do it manually. Signed-off-by: Bryce Harrington br...@osg.samsung.com --- src/compositor-fbdev.c | 4 src/compositor.c | 12 src/evdev.c| 4 src/gl-renderer.c | 2 --

[PATCH 3/3] Use zalloc instead of calloc(1, ...)

Signed-off-by: Bryce Harrington br...@osg.samsung.com --- src/cms-helper.c | 2 +- src/compositor-drm.c | 4 ++-- src/compositor-fbdev.c | 6 +++--- src/compositor-rpi.c | 6 +++--- src/compositor.c | 16 src/gl-renderer.c | 12 +---