Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-25 Thread Pekka Paalanen
On Mon, 24 Nov 2014 15:20:35 -0800 Bryce Harrington br...@osg.samsung.com wrote: On Mon, Nov 24, 2014 at 04:31:01PM -0600, Derek Foreman wrote: On 24/11/14 05:01 AM, Pekka Paalanen wrote: On Wed, 19 Nov 2014 15:06:21 -0800 Bryce Harrington br...@osg.samsung.com wrote: From: Derek

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Pekka Paalanen
On Tue, 25 Nov 2014 02:33:53 +0100 sob...@gmail.com (Krzysztof A. Sobiecki) wrote: This patch allows libinput to ignore devices that have joystick buttons. Signed-off-by: Krzysztof Sobiecki sob...@gmail.com --- src/evdev.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Peter Hutterer
On Tue, Nov 25, 2014 at 12:16:18PM +0200, Pekka Paalanen wrote: On Tue, 25 Nov 2014 02:33:53 +0100 sob...@gmail.com (Krzysztof A. Sobiecki) wrote: This patch allows libinput to ignore devices that have joystick buttons. Signed-off-by: Krzysztof Sobiecki sob...@gmail.com ---

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Peter Hutterer
On Tue, Nov 25, 2014 at 02:33:53AM +0100, Krzysztof A. Sobiecki wrote: This patch allows libinput to ignore devices that have joystick buttons. Signed-off-by: Krzysztof Sobiecki sob...@gmail.com --- src/evdev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/evdev.c

Re: [PATCH wayland 2/2] support specifying custom directories for the client and server

2014-11-25 Thread Pekka Paalanen
On Tue, 25 Nov 2014 09:02:22 +0200 Jussi Laako jussi.la...@linux.intel.com wrote: On 19.11.2014 12:56, Pekka Paalanen wrote: I have very hard time deciding if we should allow the environment to overwrite the server and client assumptions on where the socket is. It would be easier for me to

Let env var override socket directory in libwayland-client?

2014-11-25 Thread Pekka Paalanen
On Tue, 25 Nov 2014 09:22:47 +0200 Jussi Laako jussi.la...@linux.intel.com wrote: On 19.11.2014 16:22, Pekka Paalanen wrote: When a session compositor is started, you can already use WAYLAND_SOCKET environment variable to pass an opened connection to it. If your system compositor forks

Re: [PATCH wayland 2/2] support specifying custom directories for the client and server

2014-11-25 Thread Jussi Laako
On 25.11.2014 15:01, Pekka Paalanen wrote: However, all upstream cases will use XDG_RUNTIME_DIR, which probably is not appropriate for your use case, depending on how you actually start things. That's why I thought providing an alternative could be useful. It still supports XDG_RUNTIME_DIR

Re: [PATCH 3/9] doc: preserve links produced by Doxygen

2014-11-25 Thread Pekka Paalanen
On Tue, 11 Nov 2014 18:42:56 -0800 Bill Spitzak spit...@gmail.com wrote: These links are pretty useful for navigation, though sometimes excessive (you can turn them off by putting % before the word in the comment). I had to turn off validation because it failed on missing and duplicate

Re: [PATCH 6/9] doc: Added \code tags around sample code in doxygen comments

2014-11-25 Thread Pekka Paalanen
On Tue, 11 Nov 2014 18:42:59 -0800 Bill Spitzak spit...@gmail.com wrote: Also removed \comment and used C++ comments. There does not appear to be any other way to put comments into code samples. --- src/wayland-client.c | 25 ++--- src/wayland-server.h |8

Re: [PATCH 2/9] doc: Preserve spaces

2014-11-25 Thread Pekka Paalanen
On Tue, 11 Nov 2014 18:42:55 -0800 Bill Spitzak spit...@gmail.com wrote: Slight variation on Pekka's patch. It seems harmless to put this anywhere. I assume you refer to http://cgit.freedesktop.org/wayland/wayland/commit/?id=4a661c5b0c9c66102a142cd8d327dcad8007f1d7 Unfortunately every

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-25 Thread Derek Foreman
On 25/11/14 03:53 AM, Pekka Paalanen wrote: On Mon, 24 Nov 2014 15:20:35 -0800 Bryce Harrington br...@osg.samsung.com wrote: On Mon, Nov 24, 2014 at 04:31:01PM -0600, Derek Foreman wrote: On 24/11/14 05:01 AM, Pekka Paalanen wrote: On Wed, 19 Nov 2014 15:06:21 -0800 Bryce Harrington

Re: [PATCH v1 weston 07/11] tests: Add a fadein test

2014-11-25 Thread Derek Foreman
On 25/11/14 04:11 AM, Pekka Paalanen wrote: On Mon, 24 Nov 2014 18:48:51 -0800 Bryce Harrington br...@osg.samsung.com wrote: On Mon, Nov 24, 2014 at 01:19:46PM +0200, Pekka Paalanen wrote: On Wed, 19 Nov 2014 15:06:22 -0800 Bryce Harrington br...@osg.samsung.com wrote: This also serves as

Re: [PATCH libinput 2/2] test: Add test for mouse dpi tag parser

2014-11-25 Thread Derek Foreman
On 25/11/14 01:35 AM, Peter Hutterer wrote: On Mon, Nov 24, 2014 at 03:53:37PM -0600, Derek Foreman wrote: Signed-off-by: Derek Foreman der...@osg.samsung.com --- test/Makefile.am| 7 - test/mouse_dpi_parser.c | 69 + 2 files

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Derek Foreman
On 25/11/14 04:32 AM, Peter Hutterer wrote: On Tue, Nov 25, 2014 at 02:33:53AM +0100, Krzysztof A. Sobiecki wrote: This patch allows libinput to ignore devices that have joystick buttons. Signed-off-by: Krzysztof Sobiecki sob...@gmail.com --- src/evdev.c | 9 + 1 file changed, 9

Re: [PATCH 3/9] doc: preserve links produced by Doxygen

2014-11-25 Thread Bill Spitzak
On 11/25/2014 06:46 AM, Pekka Paalanen wrote: On Tue, 11 Nov 2014 18:42:56 -0800 Bill Spitzak spit...@gmail.com wrote: These links are pretty useful for navigation, though sometimes excessive (you can turn them off by putting % before the word in the comment). I had to turn off validation

Re: [PATCH 6/9] doc: Added \code tags around sample code in doxygen comments

2014-11-25 Thread Bill Spitzak
On 11/25/2014 06:47 AM, Pekka Paalanen wrote: On Tue, 11 Nov 2014 18:42:59 -0800 Bill Spitzak spit...@gmail.com wrote: Also removed \comment and used C++ comments. There does not appear to be any other way to put comments into code samples. --- src/wayland-client.c | 25

[PATCH v2 libinput 1/2] evdev: Query mouse DPI from udev

2014-11-25 Thread Derek Foreman
Instead of using a hard coded mouse DPI value, we query it from udev. If it's not present or the property is obviously broken we fall back to default. Signed-off-by: Derek Foreman der...@osg.samsung.com --- src/evdev.c | 20 +++ src/libinput-util.c | 55

[PATCH v2 libinput 2/2] test: Add test for mouse dpi tag parser

2014-11-25 Thread Derek Foreman
Signed-off-by: Derek Foreman der...@osg.samsung.com --- test/misc.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/test/misc.c b/test/misc.c index 4ed9dce..c8ac51f 100644 --- a/test/misc.c +++ b/test/misc.c @@ -548,6 +548,43 @@

Re: [PATCH v1] Added string conversion utility functions

2014-11-25 Thread Bill Spitzak
On 11/24/2014 11:12 PM, Imran Zaman wrote: On Tue, Nov 25, 2014 at 1:15 AM, Bill Spitzak spit...@gmail.com wrote: On 11/24/2014 11:32 AM, Imran Zaman wrote: [IZ2] This is the case where endptr is used in patch. I can remove endptr but it seems its used so i have to keep the existing

Re: [PATCH weston] simple-shm: explain two initial roundtrips

2014-11-25 Thread Bill Spitzak
Can you add what wl_shm events it must get before continuing? (I guess it is the list of supported formats). This is not clear from this comment, which reads more like bind won't work unless you do sync afterwards. On 11/24/2014 11:58 PM, Pekka Paalanen wrote: From: Pekka Paalanen

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-25 Thread Bill Spitzak
On 11/25/2014 07:11 AM, Derek Foreman wrote: What's fuzz exactly? Each pixel can be within +-fuzz/2 on each color component and still be a match? a fuzz of 256 would match everything? The cairo project has done some work on a fuzzy comparison for their tests, may be able to reuse that.

[PATCH weston] Drop legacy backends in favor of libinput

2014-11-25 Thread Peter Hutterer
--- Makefile.am| 15 +- configure.ac | 10 +- src/compositor-drm.c | 2 +- src/compositor-fbdev.c | 2 +- src/compositor-rpi.c | 2 +- src/evdev-touchpad.c | 800 - src/evdev.c| 755

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Peter Hutterer
On Tue, Nov 25, 2014 at 10:41:50AM -0600, Derek Foreman wrote: On 25/11/14 04:32 AM, Peter Hutterer wrote: On Tue, Nov 25, 2014 at 02:33:53AM +0100, Krzysztof A. Sobiecki wrote: This patch allows libinput to ignore devices that have joystick buttons. Signed-off-by: Krzysztof Sobiecki

[PATCH v3 libinput] evdev: Query mouse DPI from udev

2014-11-25 Thread Peter Hutterer
From: Derek Foreman der...@osg.samsung.com Instead of using a hard coded mouse DPI value, we query it from udev. If it's not present or the property is obviously broken we fall back to default. Signed-off-by: Derek Foreman der...@osg.samsung.com Signed-off-by: Peter Hutterer

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-25 Thread Bryce Harrington
On Tue, Nov 25, 2014 at 11:46:05AM -0800, Bill Spitzak wrote: On 11/25/2014 07:11 AM, Derek Foreman wrote: What's fuzz exactly? Each pixel can be within +-fuzz/2 on each color component and still be a match? a fuzz of 256 would match everything? The cairo project has done some work on a

[PATCH] doc: Removed extra indentation from wl_list code sample

2014-11-25 Thread Bill Spitzak
This is a minor documentation fix. I did not see any asterisks in the output as reported by Pekka Paalanen. Using doxygen 1.7.6.1. --- src/wayland-util.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wayland-util.h b/src/wayland-util.h index 46f9a81..a4b22b5

Re: [PATCH 6/9] doc: Added \code tags around sample code in doxygen comments

2014-11-25 Thread Pekka Paalanen
On Tue, 25 Nov 2014 09:46:17 -0800 Bill Spitzak spit...@gmail.com wrote: On 11/25/2014 06:47 AM, Pekka Paalanen wrote: On Tue, 11 Nov 2014 18:42:59 -0800 Bill Spitzak spit...@gmail.com wrote: Also removed \comment and used C++ comments. There does not appear to be any other way to put