[ANNOUNCE] weston 1.6.93 (aka 1.7.0-rc2)

2015-02-06 Thread Bryce Harrington
This is the second and final release candidate for Weston 1.7.0. Aside from some low impact cleanup patches, this fixes some crashes: One when the xwm window manager is destroyed. Another if a client erroneously duplicately sets an xdg_surface role. And a third with ivi-shell if a multi-touch a

[ANNOUNCE] wayland 1.6.93 (aka 1.7.0-rc2)

2015-02-06 Thread Bryce Harrington
This is the second and final release candidate for Wayland 1.7.0. Really just two changes of note. On older systems (e.g. Ubuntu 12.04), we incurred a regression in failing to detecting expat since expact lacked a pkg-config file back then; Bill's patch restores the old logic (with some fixes) to

Re: [PATCH weston v2 2/2] text-input: Replace model with input

2015-02-06 Thread Bryce Harrington
On Wed, Jan 28, 2015 at 02:40:42PM -0600, Derek Foreman wrote: > commit 78d00e45cc renamed text_model to text_input > > This cleans up remaining uses of the word "model" > > Signed-off-by: Derek Foreman For both patches: Reviewed-by: Bryce Harrington Daniel could you give a review to these tw

Re: [PATCH weston v3] desktop-shell: Fail if get_xdg_surface is called on an xdg_surface

2015-02-06 Thread Bryce Harrington
On Fri, Feb 06, 2015 at 10:15:28AM +0800, Jonas Ã…dahl wrote: > If a client calls xdg_shell.get_xdg_surface on a surface that is already > an xdg_surface would, prior to this patch, succeed, but cause weston to > crash later when trying to configure. This patch instead sends a role > error to the cl

Re: [PATCH] egl, wayland: RGB565 format support on Back-buffer

2015-02-06 Thread Bryce Harrington
On Fri, Feb 06, 2015 at 04:01:51PM -0800, Jon A. Cruz wrote: > On 02/06/2015 03:50 PM, Bryce Harrington wrote: > > On Fri, Feb 06, 2015 at 12:29:02PM -0800, Jon A. Cruz wrote: > >> > >> My initial concern with this is that it changes from one hardcoding to > >> two hardcodings. Is 565 the only othe

Re: [PATCH weston] xwm: remove the create surface listener in weston_wm_destroy

2015-02-06 Thread Bryce Harrington
On Fri, Feb 06, 2015 at 04:34:10PM +0200, Giulio Camuffo wrote: > 2015-02-03 19:05 GMT+02:00 Derek Foreman : > > Failing to remove this can result in a crash when the signal is sent > > after the window manager is destroyed. > > Simple enough, > > Reviewed-By: Giulio Camuffo Thanks, applied:

Re: [PATH wayland] allow to set server socket dir on a different directory than XDG_RUNTIME_DIR

2015-02-06 Thread Bryce Harrington
On Fri, Feb 06, 2015 at 01:21:41AM +0100, Bettio, Davide wrote: > Hello, > > Il 2015-02-05 19:31 Bryce Harrington ha scritto: > >On Thu, Feb 05, 2015 at 11:14:09AM +0100, Bettio, Davide wrote: > >>commit 68beb2b60f851c74b982b0a23da4bb1ce375efcf > >>Author: Davide Bettio > >>Date: Wed Feb 4 13:4

Re: [PATCH] ivi-shell: SEGV occurs when multi touch happens in transition

2015-02-06 Thread Bryce Harrington
On Fri, Feb 06, 2015 at 08:34:32AM +, Daniel Stone wrote: > On Friday, February 6, 2015, Nobuhiko Tanibata < > nobuhiko_tanib...@xddp.denso.co.jp> wrote: > > > of application launching. This is because cancel callback is mistakenly > > set to weston_touch_grab_interface. To fix this issue, add

Re: [PATCH V4] configure.ac: Fallback to older detection code if pkg-config can't find expat

2015-02-06 Thread Bryce Harrington
On Fri, Feb 06, 2015 at 12:15:20PM +, Andrew Oakley wrote: > On 03/02/15 22:26, Bill Spitzak wrote: > > This paritally reverts commit a4afd90f9f0c27ed5f3f313b915c260673f8be34. > > > > On older expat versions (ie the one on Ubuntu 12.04) there is no pkg-config > > file, so fall back to a test f

Re: [PATCH] egl, wayland: RGB565 format support on Back-buffer

2015-02-06 Thread Jon A. Cruz
On 02/06/2015 03:50 PM, Bryce Harrington wrote: > On Fri, Feb 06, 2015 at 12:29:02PM -0800, Jon A. Cruz wrote: >> >> My initial concern with this is that it changes from one hardcoding to >> two hardcodings. Is 565 the only other format that will need to be >> supported? Could XRGB888 or others als

Re: [PATCH] egl, wayland: RGB565 format support on Back-buffer

2015-02-06 Thread Bryce Harrington
On Fri, Feb 06, 2015 at 12:29:02PM -0800, Jon A. Cruz wrote: > > My initial concern with this is that it changes from one hardcoding to > two hardcodings. Is 565 the only other format that will need to be > supported? Could XRGB888 or others also be needed? > > If this needs changing it might be

Re: [PATH wayland] allow to set server socket dir on a different directory than XDG_RUNTIME_DIR

2015-02-06 Thread Jon A. Cruz
LGTM Reviewed-by: Jon A. Cruz On 02/05/2015 02:14 AM, Bettio, Davide wrote: > commit 68beb2b60f851c74b982b0a23da4bb1ce375efcf > Author: Davide Bettio > Date: Wed Feb 4 13:46:19 2015 +0100 > > Allow to explicitly set wayland server socket dir using > WAYLAND_SERVER_SOCKET_DIR > > diff -

Re: [PATH wayland] allow clients to connect to a socket located on a different dir than XDG_RUNTIME_DIR

2015-02-06 Thread Jon A. Cruz
Looks good (however I did hit some odd formatting error with the patch file itself) Reviewed-by: Jon A. Cruz On 02/05/2015 08:42 AM, Bettio, Davide wrote: > commit 1ebae6d4f27ff0d336f2df0b8821099d2b2e510e > Author: Davide Bettio > Date: Thu Feb 5 17:04:42 2015 +0100 > > Added support

Re: [ANNOUNCE] weston 1.6.92

2015-02-06 Thread Bryce Harrington
On Fri, Feb 06, 2015 at 03:34:55PM +0900, Tanibata, Nobuhiko (ADITJ/SWG) wrote: > Hi, > > I verified ivi-shell part by manual with this version, 1.6.92, as well about, > - Window management of hmi-controller; tiling, side by side, maximum, and > randow. > - Examples behavior. All samples work fin

Re: [PATCH wayland v5] tests: Fix FAIL in sanity-test (*timeout*) when Yama LSM enabled

2015-02-06 Thread Bryce Harrington
On Fri, Feb 06, 2015 at 02:32:21PM +, Daniel Stone wrote: > (obviously that mail was lacking the crucial part - Reviewed-by: > Daniel Stone ) Thanks for reviewing Derek, Daniel, and Marek, applied: 310fea4..76fe89e master -> master Bryce > On 6 February 2015 at 14:31, Daniel Stone wro

Re: [PATCH libinput 2/2] evdev: switch to using udev's device tagging system

2015-02-06 Thread Benjamin Tissoires
On Thu, Feb 5, 2015 at 6:03 AM, Peter Hutterer wrote: > Use ID_INPUT_FOO to assume a device is a FOO, don't decide ourselves based on > whatever bits are available. This moves the categorization out to udev's > input_id builtin by default and other bits that tag the device. libwacom tags > all kno

Re: [PATCH weston] input: store the grab serial of the keyboard

2015-02-06 Thread Giulio Camuffo
2015-02-06 22:27 GMT+02:00 Bill Spitzak : > Why did you move the code out of the first if statement and into a duplicate > if statement? If this needs to be done later, could the whole if/else > statement be moved down (ie move those idle_inhibit/release calls down to > the same point). Because th

Re: [PATCH] egl, wayland: RGB565 format support on Back-buffer

2015-02-06 Thread Jon A. Cruz
My initial concern with this is that it changes from one hardcoding to two hardcodings. Is 565 the only other format that will need to be supported? Could XRGB888 or others also be needed? If this needs changing it might be good to be sure it is comprehensive. On 02/03/2015 02:52 PM, Dongwon Ki

Re: [PATCH weston] input: store the grab serial of the keyboard

2015-02-06 Thread Bill Spitzak
Why did you move the code out of the first if statement and into a duplicate if statement? If this needs to be done later, could the whole if/else statement be moved down (ie move those idle_inhibit/release calls down to the same point). On 02/06/2015 09:06 AM, Giulio Camuffo wrote: The seria

Re: [PATCH] Fallback to older detection code if pkg-config can't find expat

2015-02-06 Thread Bill Spitzak
Well actually I posted a patch to fix the web page of how to build on Ubuntu 12.04 to include downloading and building expat, so it works with the current makefile. I got the feeling that was considered a better solution and I withdrew this patch. People compiling on Ubuntu12.04 already have to

Re: [PATCH weston] input: store the grab serial of the keyboard

2015-02-06 Thread Daniel Stone
Hi, On 6 February 2015 at 17:06, Giulio Camuffo wrote: > The serial can be checked against the one passed to wl_shell.set_popup > or equivalent. Looks good to me. I was worried about the impact on other users, but it turns out there are no (in-tree) users of any of keyboard->grab_*. Hah. Bryce

[PATCH weston] input: store the grab serial of the keyboard

2015-02-06 Thread Giulio Camuffo
The serial can be checked against the one passed to wl_shell.set_popup or equivalent. --- src/input.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/input.c b/src/input.c index fa4fc4e..a0a817f 100644 --- a/src/input.c +++ b/src/input.c @@ -1321,8 +1321,6 @@ notif

Re: [PATCH wayland v5] tests: Fix FAIL in sanity-test (*timeout*) when Yama LSM enabled

2015-02-06 Thread Daniel Stone
Hi, On 6 February 2015 at 16:15, Derek Foreman wrote: > FWIW, the waitpid thing was never a bug, I errantly called it one in an > off list conversation. It'll work fine the way it is now, or the way it > was. Right, I tested both with and without the change (i.e. v4 with s/rc/errno/ and v5) and

Re: [PATCH wayland v5] tests: Fix FAIL in sanity-test (*timeout*) when Yama LSM enabled

2015-02-06 Thread Derek Foreman
On 05/02/15 07:39 PM, Bryce Harrington wrote: > This fixes a regression in the testsuite since c3653f7f, where four of > the timeout tests fail with "Timeouts suppressed" messages. > > The timeouts are being suppressed because the testsuite is erroneously > detecting that a debugger is attached.

Re: [PATCH weston] xwm: remove the create surface listener in weston_wm_destroy

2015-02-06 Thread Giulio Camuffo
2015-02-03 19:05 GMT+02:00 Derek Foreman : > Failing to remove this can result in a crash when the signal is sent > after the window manager is destroyed. Simple enough, Reviewed-By: Giulio Camuffo > > Signed-off-by: Derek Foreman > --- > xwayland/window-manager.c | 1 + > 1 file changed, 1 i

Re: [PATCH wayland v5] tests: Fix FAIL in sanity-test (*timeout*) when Yama LSM enabled

2015-02-06 Thread Daniel Stone
(obviously that mail was lacking the crucial part - Reviewed-by: Daniel Stone ) On 6 February 2015 at 14:31, Daniel Stone wrote: > Hi, > > On 6 February 2015 at 01:39, Bryce Harrington wrote: >> This fixes a regression in the testsuite since c3653f7f, where four of >> the timeout tests fail with

Re: [PATCH wayland v5] tests: Fix FAIL in sanity-test (*timeout*) when Yama LSM enabled

2015-02-06 Thread Daniel Stone
Hi, On 6 February 2015 at 01:39, Bryce Harrington wrote: > This fixes a regression in the testsuite since c3653f7f, where four of > the timeout tests fail with "Timeouts suppressed" messages. Now passes for me on both Fedora 21 and Debian jessie. Thanks! Cheers, Daniel _

Re: [PATCH] QA: Add log for wayland performance analysis

2015-02-06 Thread Daniel Stone
Hi Quanxian, On 6 February 2015 at 09:52, Quanxian Wang wrote: > This patch is to provide the mechanism to track weston rendering performance. Have you seen the JSON timeline debugging already available in Weston? Is this something you can use in your tool? Cheers, Daniel __

Re: CRIU and Weston

2015-02-06 Thread Pekka Paalanen
On Fri, 30 Jan 2015 21:31:24 +0200 Ruslan Kuprieiev wrote: > Hi! > > I would like to add checkpoint/restore support of a graphical app(no > gl) that uses wayland. > I'll appreciate any thoughts and ideas on how to accomplish that as > well as what simplest > app should I start with. > > After d

Re: [PATCH V4] configure.ac: Fallback to older detection code if pkg-config can't find expat

2015-02-06 Thread Andrew Oakley
On 03/02/15 22:26, Bill Spitzak wrote: > This paritally reverts commit a4afd90f9f0c27ed5f3f313b915c260673f8be34. > > On older expat versions (ie the one on Ubuntu 12.04) there is no pkg-config > file, so fall back to a test for the header and library. In addition the > source for expat does not se

[PATCH] QA: Add log for wayland performance analysis

2015-02-06 Thread Quanxian Wang
Overview This patch is to provide the mechanism to track weston rendering performance. With these log information, A tool is provided separately to analyze Wayland Apps or Server rendering performance data and show them with FPS performance charts. These charts give a clear image of rende

[PATCH] weston: Add weston rendering performance log

2015-02-06 Thread Quanxian Wang
With PERF_DEBUG is enabled, the performance log will be recorded for every key rendering path. At the same time, with a tool provided, performance chart of weston apps could be generated. This patch provides following changes. 1) Add performance log mechanism for server and client. just like w

Re: [PATCH] ivi-shell: SEGV occurs when multi touch happens in transition

2015-02-06 Thread Daniel Stone
On Friday, February 6, 2015, Nobuhiko Tanibata < nobuhiko_tanib...@xddp.denso.co.jp> wrote: > of application launching. This is because cancel callback is mistakenly > set to weston_touch_grab_interface. To fix this issue, add a > callback, touch_move_workspace_grab_frame and set it to the > westo

Re: [PATCH] Fallback to older detection code if pkg-config can't find expat

2015-02-06 Thread Pekka Paalanen
On Sat, 31 Jan 2015 10:55:54 -0800 Bill Spitzak wrote: > On 01/31/2015 04:07 AM, sardemff7+wayl...@sardemff7.net wrote: > > On 2015-01-31 02:23, Bill Spitzak wrote: > >> On older expat versions there is no pkg-config file, so fall back > >> to the previous test for the header file and library if