Re: [weston, v2, 17/17] configure: add an option to allow building only the libraries

2015-05-11 Thread Pekka Paalanen
On Sat, 9 May 2015 10:09:21 +0300 Giulio Camuffo giuliocamu...@gmail.com wrote: 2015-05-09 3:15 GMT+03:00 Bryce Harrington br...@osg.samsung.com: On Thu, Dec 04, 2014 at 11:01:23PM +0200, Giulio Camuffo wrote: the --enable/disable-weston-binaries emable or disable the creation of the

Re: [PATCH weston 04/10] tests: Add surface checks

2015-05-11 Thread Pekka Paalanen
On Sat, 9 May 2015 14:52:38 +0100 Daniel Stone dan...@fooishbar.org wrote: Hi Bryce, A couple of nitpicks follow ... On 7 May 2015 at 01:44, Bryce Harrington br...@osg.samsung.com wrote: @@ -39,7 +39,7 @@ tests/weston-ivi.ini : $(srcdir)/ivi-shell/weston.ini.in all-local : weston.ini

Re: [PATCH weston 03/10] tests: Add an xmalloc helper function

2015-05-11 Thread Pekka Paalanen
On Wed, 6 May 2015 17:44:22 -0700 Bryce Harrington br...@osg.samsung.com wrote: Signed-off-by: Bryce Harrington br...@osg.samsung.com --- tests/weston-test-client-helper.c | 11 +++ tests/weston-test-client-helper.h | 16 ++-- 2 files changed, 21 insertions(+), 6

Re: [PATCH weston 07/10] tests: Add screenshot recording capability to weston-test

2015-05-11 Thread Pekka Paalanen
On Sun, 10 May 2015 20:17:55 -0700 Bryce Harrington br...@osg.samsung.com wrote: On Sat, May 09, 2015 at 02:56:54PM +0100, Daniel Stone wrote: Hi, On 7 May 2015 at 01:44, Bryce Harrington br...@osg.samsung.com wrote: +static void +copy_bgra_yflip(uint8_t *dst, uint8_t *src, int

Re: [PATCH weston 06/10] protocol: Add test screenshot capability

2015-05-11 Thread Pekka Paalanen
On Sat, 9 May 2015 14:53:48 +0100 Daniel Stone dan...@fooishbar.org wrote: Hi, On 7 May 2015 at 01:44, Bryce Harrington br...@osg.samsung.com wrote: This adds a capture_screenshot request which returns an image of the screen in the client-supplied wl_buffer for the given display output.

Re: [PATCH weston 07/10] tests: Add screenshot recording capability to weston-test

2015-05-11 Thread Pekka Paalanen
On Sat, 9 May 2015 14:56:54 +0100 Daniel Stone dan...@fooishbar.org wrote: Hi, On 7 May 2015 at 01:44, Bryce Harrington br...@osg.samsung.com wrote: +enum weston_test_screenshot_outcome { + WESTON_TEST_SCREENSHOT_SUCCESS, + WESTON_TEST_SCREENSHOT_NO_MEMORY, +

Re: [PATCH] RDP compositor: fixes for multiple connections, mstsc and FreeRDP master compilation

2015-05-11 Thread Pekka Paalanen
On Wed, 6 May 2015 10:59:42 +0200 David FORT rdp.eff...@gmail.com wrote: From: Hardening rdp.eff...@gmail.com This patch fixes the problem reported on the mailing list (http://lists.freedesktop.org/archives/wayland-devel/2015-January/019575.html). All certificate and key paths were not

Re: [PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-11 Thread Pekka Paalanen
On Sat, 9 May 2015 15:01:13 +0100 Daniel Stone dan...@fooishbar.org wrote: Hi Bryce, On 7 May 2015 at 01:44, Bryce Harrington br...@osg.samsung.com wrote: This series adds support for implementing test cases that can check rendering output without needing connection to a physical output.

Re: [PATCH weston 09/10] tests: Add internal test for the weston test screenshot capability

2015-05-11 Thread Pekka Paalanen
On Wed, 6 May 2015 17:44:28 -0700 Bryce Harrington br...@osg.samsung.com wrote: This also serves as a proof of concept of the screen capture functionality and as a demo for snapshot-based rendering verification. Implements screenshot saving clientside in the test itself. This also

Re: [PATCH weston v2] gl-renderer: If an XRGB format is requested but unavailable, try ARGB

2015-05-11 Thread Pekka Paalanen
On Tue, 5 May 2015 16:22:22 -0500 Derek Foreman der...@osg.samsung.com wrote: Recent versions of Mesa have stopped exposing XRGB visuals for gl on some Intel GPUs. While this may be changed in Mesa eventually, it's not impossible that some other hardware in the future won't provide XRGB

Re: [PATCH weston 00/10] Implement screenshot-based testing with the headless renderer

2015-05-11 Thread Daniel Stone
Hi, On 11 May 2015 at 13:41, Pekka Paalanen ppaala...@gmail.com wrote: Did you notice, that 'clientside-screenshot.png' ends up all black, if you do 'make check BACKEND=x11-backend.so'? Wonder why it does that, you're not intending to do anything backend-specific. Except the server command

Re: Proposal for better collaboration on xdg-shell

2015-05-11 Thread Jasper St. Pierre
Yeah. I think some people were assuming xdg-shell was final, and I was its gatekeeper, and it's what GNOME wants and you have to fight to get other things in. That wasn't my intention at all! My goal was to build a solid base for the rest of the DEs to eventually work more like how Bryce wants,

Re: [PATCH weston v2] gl-renderer: If an XRGB format is requested but unavailable, try ARGB

2015-05-11 Thread Derek Foreman
On 11/05/15 08:57 AM, Pekka Paalanen wrote: On Tue, 5 May 2015 16:22:22 -0500 Derek Foreman der...@osg.samsung.com wrote: Recent versions of Mesa have stopped exposing XRGB visuals for gl on some Intel GPUs. While this may be changed in Mesa eventually, it's not impossible that some other

Re: [PATCH weston v2] gl-renderer: If an XRGB format is requested but unavailable, try ARGB

2015-05-11 Thread Bill Spitzak
On 05/11/2015 06:57 AM, Pekka Paalanen wrote: How about calling it get_fallback_format_for()? I think get_ implies that the result depends on something other than the arguments. For instance the sin of an angle is a function called sin(x), not get_sin(x). While looking up an environment

[PATCH weston 2/2] compositor-drm: pass ARGB fallback to gl create functions for XRGB formats

2015-05-11 Thread Derek Foreman
If the GL implementation doesn't provide an XRGB visual we may still be able to proceed with an ARGB one. Since we're not changing the scanout buffer format, and our current rendering loop always results in saturated alpha in the frame buffer, it should be Just Fine(tm) - and probably better than

[PATCH weston 1/2] gl-renderer: Take a list of acceptable formats in create functions

2015-05-11 Thread Derek Foreman
Currently we pass either a single format or no formats to the gl renderer create and output_create functions. We extend this to any number of formats so we can allow fallback formats if we don't get our first pick. Signed-off-by: Derek Foreman der...@osg.samsung.com --- src/compositor-drm.c

[PATCH weston 0/2] Allow falling back to ARGB visuals

2015-05-11 Thread Derek Foreman
Supersedes: [PATCH weston v2] gl-renderer: if an XRGB format is requested but unavailable, try ARGB This lets back-ends specify multiple acceptable visual ids. The drm compositor uses this to fall back to ARGB visuals if XRGB isn't present. Derek Foreman (2): gl-renderer: Take a list of

[PATCH weston v2] input: add a weston_pointer_clear_focus() helper function

2015-05-11 Thread Derek Foreman
Valgrind has shown that in at least one place (default_grab_pointer_focus) we're testing uninitialized values coming out of weston_compositor_pick_view. This is happening when default_grab_pointer_focus is called when there is nothing on the view list, and during the first repaint when only the

Re: [PATCH weston] input: add a weston_pointer_clear_focus() helper function

2015-05-11 Thread Derek Foreman
On 10/05/15 04:02 AM, Giulio Camuffo wrote: 2015-04-17 0:02 GMT+03:00 Derek Foreman der...@osg.samsung.com: This adds a function to clear pointer focus and also set the sx,sy co-ordinates to an arbitrary value we shouldn't compute with. Assertions are added to make sure any time pointer focus

Re: [PATCH] xwayland: Implement smooth scrolling

2015-05-11 Thread Keith Packard
Dima Ryazanov d...@gmail.com writes: We don't even need to simulate button clicks; it's done automatically. This also fixes scrolling in Qt5 apps. Merged. 9ff89a2..81a51a6 master - master -- -keith signature.asc Description: PGP signature ___

Re: [PATCH weston 03/10] tests: Add an xmalloc helper function

2015-05-11 Thread Bryce Harrington
On Mon, May 11, 2015 at 01:39:29PM +0300, Pekka Paalanen wrote: On Wed, 6 May 2015 17:44:22 -0700 Bryce Harrington br...@osg.samsung.com wrote: Signed-off-by: Bryce Harrington br...@osg.samsung.com --- tests/weston-test-client-helper.c | 11 +++