Re: [PATCH] compositor: Disallow negative geometries in backend output configs

2015-10-24 Thread Giulio Camuffo
2015-10-24 1:29 GMT+03:00 Bryce Harrington : > Signed-off-by: Bryce Harrington > --- > src/compositor.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/compositor.h b/src/compositor.h > index 6bb6222..4443c72 100644

Re: [PATCH] compositor: Disallow negative geometries in backend output configs

2015-10-24 Thread Jasper St. Pierre
I'm struggling to understand the motivation for this patch. krh has always said that you need to think of uint and int as two entirely separate types -- mixing both in math will likely screw up. You can see this in other places -- widths are often expressed as signed ints in the protocol, not

[PATCH wayland v3 0/4] Enum and bitfield XML attributes

2015-10-24 Thread Auke Booij
There has been plenty of discussion regarding the introduction of new XML attributes. This series of patches improves on my earlier attempt to find common ground in this. Major exclusions from these patches are: - Support for cross-interface enum referencing (e.g.

[PATCH wayland v3 1/4] doc: document the enum and bitfield attributes

2015-10-24 Thread Auke Booij
Introduce the enum and bitfield attributes, which allow you to refer to the enum you are expecting in an argument, and specify which enums are to be thought of as bitfields. Signed-off-by: Auke Booij --- doc/publican/sources/Protocol.xml | 41

[PATCH wayland v3 3/4] scanner: enforce correct argument type for enums

2015-10-24 Thread Auke Booij
The scanner now checks whether arguments that have an associated have the right type. An argument with an enum attribute must be of type int or uint, and if the with that name has the bitfield attribute set to true, then the argument must be of type uint. Signed-off-by: Auke Booij

[PATCH wayland v3 2/4] protocol: specify enum and bitfield attributes

2015-10-24 Thread Auke Booij
Signed-off-by: Auke Booij --- protocol/wayland.xml | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 59819e9..9c22d45 100644 --- a/protocol/wayland.xml +++