[PATCH weston] xwm: Don't clear the selection if it has no text type available

weston maintains a copy of the most recently selected "thing" - it picks the first available type when it copies, and saves that one only. When an application quits weston will make the saved selection active. When xwm sees the selection set it will check if any of the offered types are text.

[PATCH weston 2/3] xwayland: zalloc the x11_data_sources

The wrapped weston_data_source struct has new fields which were left uninitialized, so its access is unreliable. The data source in xwayland/dnd.c should be eventually setting the drag-and-drop actions, but it is a lot more incomplete than that (read: completely), so falls out of the scope of

[PATCH weston 1/3] clipboard: zalloc the clipboard_source

The wrapped weston_data_source struct has new fields which were left uninitialized, so its access is unreliable. Signed-off-by: Carlos Garnacho --- src/clipboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/clipboard.c b/src/clipboard.c index

[PATCH weston 3/3] data-device: Check harder for selection/non-wayland sources

We're not always dealing with weston_data_sources that have a wl_resource, or data_sources that belong to drag-and-drop. Check harder for these on the drag-and-drop code paths triggered from common code. Signed-off-by: Carlos Garnacho --- src/data-device.c | 8 ++-- 1

Re: [PATCH] server: Fix possible wl_display_add_socket_fd memleak

On 01/02/16 12:35 PM, Sergi Granell wrote: > If wl_event_loop_add_fd failed, the fail path didn't free the > newly allocated struct wl_socket. Looks good to me: Reviewed-by: Derek Foreman > --- > src/wayland-server.c | 9 + > 1 file changed, 5 insertions(+), 4

Re: [PATCH weston 1/3] clipboard: zalloc the clipboard_source

On 01/02/16 01:28 PM, Carlos Garnacho wrote: > The wrapped weston_data_source struct has new fields which were left > uninitialized, so its access is unreliable. > > Signed-off-by: Carlos Garnacho Thanks for the quick fix on this. Whole series is: Reviewed-by: Derek Foreman

[PATCH] server: Fix possible wl_display_add_socket_fd memleak

If wl_event_loop_add_fd failed, the fail path didn't free the newly allocated struct wl_socket. --- src/wayland-server.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 6654cd7..3ba8a5d 100644 ---

Re: [PATCH weston 1/3] clipboard: zalloc the clipboard_source

On Mon, Feb 01, 2016 at 02:01:12PM -0600, Derek Foreman wrote: > On 01/02/16 01:28 PM, Carlos Garnacho wrote: > > The wrapped weston_data_source struct has new fields which were left > > uninitialized, so its access is unreliable. > > > > Signed-off-by: Carlos Garnacho > >

Re: [PATCH v3 wayland-protocols] Add the tablet protocol

On Mon, Feb 01, 2016 at 04:12:24PM -0800, Jason Gerecke wrote: > On Sun, Jan 31, 2016 at 2:27 PM, Peter Hutterer > wrote: > > On Fri, Jan 29, 2016 at 11:40:44AM -0800, Jason Gerecke wrote: > >> On Thu, Jan 28, 2016 at 8:32 PM, Peter Hutterer > >>

Re: [PATCH wayland] cosmetic: return NULL instead of 0

On Wed, Jan 27, 2016 at 10:06:28AM +0100, Marek Chalupa wrote: > we're returning a pointer > > Signed-off-by: Marek Chalupa Reviewed-by: Bryce Harrington And pushed: To ssh://git.freedesktop.org/git/wayland/wayland ed68095..5ac34a1 master ->

[PATCH v2 libinput] touchpad: drop motion hysteresis by default

Some older touchpad devices jitter a fair bit when a finger is resting on the touchpad. That's why the hysteresis was introduced in the synaptics driver back in 2011. However, the default value of the hysteresis in the synaptics driver ended up being 0, even though the code looks like it's using a

Re: [PATCH wayland] protocol: Add note about per version requirements to wl_data_device_manager

On Mon, Jan 18, 2016 at 01:03:48PM +0100, Carlos Garnacho wrote: > Hey Jonas, > > On Mon, Jan 18, 2016 at 11:18 AM, Jonas Ådahl wrote: > > Add a note to the wl_data_device_manager global interface about the > > different requirements for operating the objects created from the

Re: [PATCH v3 wayland-protocols] Add the tablet protocol

On Sun, Jan 31, 2016 at 2:27 PM, Peter Hutterer wrote: > On Fri, Jan 29, 2016 at 11:40:44AM -0800, Jason Gerecke wrote: >> On Thu, Jan 28, 2016 at 8:32 PM, Peter Hutterer >> wrote: >> > Signed-off-by: Peter Hutterer

Re: [PATCH] server: Fix possible wl_display_add_socket_fd memleak

On Mon, Feb 01, 2016 at 02:57:08PM -0600, Derek Foreman wrote: > On 01/02/16 12:35 PM, Sergi Granell wrote: > > If wl_event_loop_add_fd failed, the fail path didn't free the > > newly allocated struct wl_socket. > > Looks good to me: > Reviewed-by: Derek Foreman Pushed:

Re: [PATCH wayland] server: Fail to bind object when requested version is 0

On Thu, Jan 14, 2016 at 07:40:58PM +, Daniel Stone wrote: > On 14 January 2016 at 19:33, Derek Foreman wrote: > > 0 is not a valid version number for registry bind requests, so > > let's check for it in registry_bind. > > > > Signed-off-by: Derek Foreman

Re: [PATCH wayland] scanner: Print filename on DTD validation error

On Tue, Jan 26, 2016 at 12:53:00PM -0600, Derek Foreman wrote: > On 26/01/16 01:14 AM, Hardening wrote: > > Le 25/01/2016 10:28, Jonas Ådahl a écrit : > >> Don't just print prefix the errors with "protocol", but the actual file > >> name, if wayland-scanner was passed with the filename of the

Re: [PATCH v3 wayland-protocols] Add the tablet protocol

On Mon, Feb 1, 2016 at 4:55 PM, Peter Hutterer wrote: > On Mon, Feb 01, 2016 at 04:12:24PM -0800, Jason Gerecke wrote: >> On Sun, Jan 31, 2016 at 2:27 PM, Peter Hutterer >> wrote: >> > On Fri, Jan 29, 2016 at 11:40:44AM -0800, Jason Gerecke

Re: [PATCH weston] input: Don't try to send pointer frames if no focus_client

I ran into the same issue with gtk3-demo. When the popup was being destroyed, the focus was set to 0x0 and I got sigsegv, because popup grab tried to sent the frame. Reviewed-by: Marek Chalupa Regards, Marek On 01/29/2016 05:29 PM, Derek Foreman wrote: Prevents a

[PATCH libinput] tablet: delay initial proximity in event until we have a serial

If the tablet is already in proximity on startup, we used to immediately sent a proximity event. We can't fetch MSC_SERIAL from the kernel, so that tool always had a serial of 0, followed by events with the real serial. Since clients are supposed to use the serial for the tracking of tools, this

Re: [PATCH weston] input: Don't try to send pointer frames if no focus_client

On Mon, Feb 01, 2016 at 02:38:41PM +0100, Marek Chalupa wrote: > I ran into the same issue with gtk3-demo. > When the popup was being destroyed, the focus was set to 0x0 and I got > sigsegv, because popup grab tried to sent the frame. > > Reviewed-by: Marek Chalupa Pushed

Re: [PATCH libinput] touchpad: drop motion hysteresis

Hi, On 01-02-16 07:43, Peter Hutterer wrote: On Mon, Feb 01, 2016 at 12:38:13PM +1000, Peter Hutterer wrote: Some older touchpad devices jitter a fair bit when a finger is resting on the touchpad. That's why the hysteresis was introduced in the synaptics driver back in 2011. However, the

Re: [PATCH] input: send frame after axis event in default grab

On Mon, Feb 01, 2016 at 04:16:17PM +0100, Marek Chalupa wrote: > Clients that implement version 5 of pointer wait for the frame > after pointer events (e. g. GTK+ clients). We send it after motion > and button, but not after the axis event in default grab. > > Send the frame after the axis event,

[PATCH] input: send frame after axis event in default grab

Clients that implement version 5 of pointer wait for the frame after pointer events (e. g. GTK+ clients). We send it after motion and button, but not after the axis event in default grab. Send the frame after the axis event, but only in the default grab, so that some other grabs (implementing