Re: [PATCH wayland] event-loop: Make transitive include explicit

2016-05-19 Thread Jonas Ådahl
On Thu, May 19, 2016 at 12:39:13PM -0400, Yong Bakos wrote: > On May 17, 2016, at 2:32 AM, Jonas Ådahl wrote: > > > > On Mon, May 16, 2016 at 12:05:39PM -0600, Yong Bakos wrote: > >> From: Yong Bakos > >> > >> The explicit inclusion of

[PATCH libinput] udev: add the Yoga 2 to the wobbly touchpads

2016-05-19 Thread Peter Hutterer
https://bugs.freedesktop.org/show_bug.cgi?id=95290 Signed-off-by: Peter Hutterer --- udev/90-libinput-model-quirks.hwdb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/udev/90-libinput-model-quirks.hwdb b/udev/90-libinput-model-quirks.hwdb index f1ab211..a066df0

[PATCH wayland] scanner: Remove unused forward decs from client protocol

2016-05-19 Thread Yong Bakos
From: Yong Bakos wayland-client-protocol.h had forward declarations for wl_client and wl_resource, yet nothing on the client side references these types. Add a 'side' condition to only generate these forward declarations in the server protocol header. Signed-off-by:

Re: [PATCH wayland 3/5] server: don't proceed in posting no-memory error on client destruction

2016-05-19 Thread Bryce Harrington
On Mon, May 16, 2016 at 12:22:02PM +0300, Pekka Paalanen wrote: > On Fri, 13 May 2016 15:01:20 +0200 > Marek Chalupa wrote: Hi Marek, Thanks for providing the test cases to go along with this, much appreciated. The first patch in this set looked fine to me, and with pq's

Re: [PATCH wayland 1/5] display-test: move a misplaced comment

2016-05-19 Thread Bryce Harrington
On Mon, May 16, 2016 at 11:44:40AM +0300, Pekka Paalanen wrote: > On Fri, 13 May 2016 15:01:18 +0200 > Marek Chalupa wrote: > > > we split a function while refactoring in c643781 and now > > the comment makes no sense > > > > Signed-off-by: Marek Chalupa

Re: [PATCH weston] desktop-shell: Don’t reconfigure an already fullscreen surface

2016-05-19 Thread Bryce Harrington
On Tue, May 10, 2016 at 10:18:14AM -0500, Yong Bakos wrote: > On May 9, 2016, at 8:22 PM, Emmanuel Gil Peyrot > wrote: > > > > When we receive an wl_shell_surface::set_fullscreen request for a > > surface that was already fullscreen, don’t do anything if the > >

[PATCH libinput] udev: add the Dell Lattitude E5420 to the wobbly touchpads

2016-05-19 Thread Peter Hutterer
https://bugzilla.redhat.com/show_bug.cgi?id=1336084 Signed-off-by: Peter Hutterer --- udev/90-libinput-model-quirks.hwdb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/udev/90-libinput-model-quirks.hwdb b/udev/90-libinput-model-quirks.hwdb index

Re: [PATCH weston] zunitc: use platform-independent macros for integer formatting

2016-05-19 Thread Bryce Harrington
On Wed, May 18, 2016 at 05:18:18PM +0100, Emmanuel Gil Peyrot wrote: > From: Emmanuel Gil Peyrot > > Fixes warnings and potential issues on 32-bit platforms, tested only on > ARM but I’d expect the same issue on i686. > > Signed-off-by: Emmanuel Gil Peyrot

Re: [PATCH 4/6] compositor: use generated constant instead of hardcoded value

2016-05-19 Thread Bryce Harrington
On Tue, Apr 26, 2016 at 11:34:06PM +0200, David Fort wrote: > Use SINCE macros instead of the hardcoded version value. > > Signed-off-by: David Fort LGTM, Reviewed-by: Bryce Harrington Pushed: 2d4aa83..8a12069 master -> master >

Re: [PATCH 3/6] rdp: Fix the ContextNew callback with recent FreeRDP versions

2016-05-19 Thread Bryce Harrington
On Tue, Apr 26, 2016 at 11:34:05PM +0200, David Fort wrote: > Since a quite long time FreeRDP expect the ContextNew callback to return TRUE > when it succeeds. Without this we have some arbitrary failures (most probably > when eax is 0 at the end of the function). > > Signed-off-by: David Fort

Re: [PATCH 2/6] rdp: don't release the seat until it is safe

2016-05-19 Thread Bryce Harrington
On Tue, Apr 26, 2016 at 11:34:04PM +0200, David Fort wrote: > Releasing a seat is not safe, so let's just announce it without keyboard > and mouse until this is fixed. Without this patch we just can't reconnect on > the RDP compositor as it crashes. > > Signed-off-by: David Fort

Re: [PATCH 1/6] rdp: allow to compile against FreeRDP 2.0

2016-05-19 Thread Bryce Harrington
On Mon, May 16, 2016 at 11:50:14AM +0200, Quentin Glidic wrote: > On 01/05/2016 23:32, David Fort wrote: > >FreeRDP 2.0 is about to be released, this allows to compile against this > >version. > >The detection is adjusted to prefer FreeRDP 2 against version 1.x. > > > >Signed-off-by: David Fort

Re: [PATCH wayland] tests: Check for client/server-core.h inclusion

2016-05-19 Thread Bryce Harrington
On Thu, May 19, 2016 at 10:27:29AM -0600, Yong Bakos wrote: > From: Yong Bakos > > The purpose of wayland-*-protocol-core.h is to mimc the > wayland-*-protocol.h generated by scanner --include-core-only. > The only difference being what wayland-*-protocol.h should

Re: Protocol for window previews/thumbnails

2016-05-19 Thread adlo
> On 12 May 2016, at 08:57, Pekka Paalanen wrote: > > On Wed, 11 May 2016 23:35:01 +0100 > ade low wrote: >> My use case is third-party window switcher applications, such as >> xfdashboard or my program, xfce4-lightdash-plugin: >>

Re: writing Was: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

2016-05-19 Thread Mike Blumenkrantz
On Wed, May 18, 2016 at 6:33 PM Yong Bakos wrote: > Hi, > I'm partly to blame for the bikeshedding on writing, yet believe me, > I'm always asking "is this worth it?", prioritizing corrections/clarity > over mere style judgements, and am definitely sensitive to >

Re: [PATCH wayland] event-loop: Make transitive include explicit

2016-05-19 Thread Yong Bakos
On May 17, 2016, at 2:32 AM, Jonas Ådahl wrote: > > On Mon, May 16, 2016 at 12:05:39PM -0600, Yong Bakos wrote: >> From: Yong Bakos >> >> The explicit inclusion of wayland-server.h hides the real dependency, which >> is wayland-server-core.h. >> >>

[PATCH wayland] tests: Check for client/server-core.h inclusion

2016-05-19 Thread Yong Bakos
From: Yong Bakos The purpose of wayland-*-protocol-core.h is to mimc the wayland-*-protocol.h generated by scanner --include-core-only. The only difference being what wayland-*-protocol.h should include. Add an include check in the headers-protocol-core-test, to be

Re: [PATCH libinput 1/3] test: skip manually setting uinput resolution if it's already set

2016-05-19 Thread Hans de Goede
Hi, On 19-05-16 01:05, Peter Hutterer wrote: On Wed, May 18, 2016 at 10:48:45AM +0200, Hans de Goede wrote: Hi, On 18-05-16 09:02, Peter Hutterer wrote: If we have libevdev 1.5 or later, the resolution is already set, no need to change it again. Let's rely on libevdev to do the right thing