[PATCH libinput] evdev: check model flags for actual booleans

The hwdb doesn't allow unsetting a property so once we start nesting model flags it'll become important to be able to be able to unset one as well (by assigning it to 0). So rather than checking for existence, check whether the property is actually set to something resembling a boolean.

Re: [PATCH wayland-protocols v3 7/7] xdg-shell: Introduce xdg_positioner

Hello Jonas, The proposal of xdg_positioner is a good idea. I still need to review your proposal deeper, but at the moment I have few question to help my understanding. On 26/05/2016 06:32, Jonas Ådahl wrote: > xdg_positioner is a method for declarative positioning of child surfaces > (currently

Re: [PATCH wayland-protocols v3 6/7] xdg-shell: Make xdg_popup non-grabbing by default

Hello Jonas, For this patch I'm more cautious, your proposal look very complex, and I don't understand why. I will try to explain my point of view with my current knowledge and then draft a proposal from my own analysis. To be fair, I did not follow the entire discussion about grab from the

Re: [PATCH weston v3 7/8] Define the screensaver inhibitor client interface

On Thu, May 26, 2016 at 06:02:09PM +0300, Pekka Paalanen wrote: > On Thu, 7 Apr 2016 16:44:22 -0700 > Bryce Harrington wrote: > > > Hook up the API defined in wayland-protocols to allow client screensaver > > inhibition requests. > > > > Signed-off-by: Bryce Harrington

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

On Wed, Jun 08, 2016 at 12:02:14PM +0300, Pekka Paalanen wrote: > On Wed, 8 Jun 2016 10:51:30 +0800 > Jonas Ådahl wrote: > > > On Tue, Jun 07, 2016 at 07:10:25PM -0700, Bryce Harrington wrote: > > > On Fri, Jun 03, 2016 at 09:26:24AM +0800, Jonas Ådahl wrote: > > > > On Thu,

Re: [PATCH weston 2/3] Implement pointer locking and confinement

Hi Jonas, On Tue, Mar 15, 2016 at 2:14 PM, Jonas Ådahl wrote: > This patch implements the wp_pointer_constraints protocol used for > locking or confining a pointer. It consists of a new global object with > two requests; one for locking the surface to a position, one for >

Re: [PATCH wayland-protocols v3 5/7] xdg-shell: Make get_popup take a xdg_surface instead of wl_surface

Hello Jonas, Fine for me. Reviewed-by: Benoit Gschwind Best regards On 26/05/2016 06:32, Jonas Ådahl wrote: > The reason for using wl_surface before was that xdg_popup and > xdg_surface (now xdg_toplevel) had no common interface other than > wl_surface, but since

Re: [PATCH wayland-protocols v3 4/7] xdg-shell: Improve error enum formatting some

Hello Jonas, This one do what it tell. Reviewed-by: Benoit Gschwind Best regards. On 26/05/2016 06:32, Jonas Ådahl wrote: > The long lines stood out, break them by putting the summary on its own > line. > > Signed-off-by: Jonas Ådahl > Reviewed-by:

Re: [PATCH wayland-protocols v3 2/7] xdg-shell: Put xdg_shell events after requests

Hello Jonas, look good, few comment ahead. On 26/05/2016 06:32, Jonas Ådahl wrote: > It makes the structure consistent with most other protocols and > provides a clear separation between what is done by the server and what > is done by the client. > > Signed-off-by: Jonas Ådahl

Re: [PATCH wayland-protocols v3 1/7] xdg-shell: Turn xdg_surface into a generic base interface

Hello Jonas, On 08/06/2016 03:18, Jonas Ådahl wrote: > On Wed, Jun 08, 2016 at 12:37:01AM +0200, Benoit Gschwind wrote: >> Hello, >> >> This proposal look good, few optional comments following. >> >> On 26/05/2016 06:32, Jonas Ådahl wrote: >>> Split out toplevel window like requests and events

Re: [PATCH 3/3] desktop-shell: resize background and panel surfaces on output resize

On Fri, 27 May 2016 23:22:58 +0200 David Fort wrote: > When an output is resized (permanent mode switch), we should also notify the > shell client so that the panel and background fits to the new screen > dimensions. > > Signed-off-by: David Fort

Re: [PATCH 2/3] compositor: recompute output position on mode switch

On Fri, 27 May 2016 23:22:57 +0200 David Fort wrote: > When an output permanently changes its resolution, the output on the right > should be moved accordingly. We also add an event for output resizing so that > plugins can react when an output is resized. > >

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

On Wed, 8 Jun 2016 10:51:30 +0800 Jonas Ådahl wrote: > On Tue, Jun 07, 2016 at 07:10:25PM -0700, Bryce Harrington wrote: > > On Fri, Jun 03, 2016 at 09:26:24AM +0800, Jonas Ådahl wrote: > > > On Thu, Jun 02, 2016 at 02:24:20PM -0700, Bryce Harrington wrote: > > > > This

Re: [PATCH wayland-protocols v3 7/7] xdg-shell: Introduce xdg_positioner

2016-06-08 10:35 GMT+02:00 Jonas Ådahl : > On Wed, Jun 08, 2016 at 11:16:49AM +0300, Giulio Camuffo wrote: >> Hi, one comment below, but anyway i think this looks good. However i >> will try to use it in qt asap to confirm it really is. >> >> 2016-05-26 7:32 GMT+03:00 Jonas Ådahl

Re: [PATCH wayland-protocols v3 7/7] xdg-shell: Introduce xdg_positioner

On Wed, Jun 08, 2016 at 11:16:49AM +0300, Giulio Camuffo wrote: > Hi, one comment below, but anyway i think this looks good. However i > will try to use it in qt asap to confirm it really is. > > 2016-05-26 7:32 GMT+03:00 Jonas Ådahl : > > > > + > > + > > + > > +

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

On Tue, 7 Jun 2016 12:35:09 -0700 Bryce Harrington wrote: > On Fri, Jun 03, 2016 at 11:41:12AM +0300, Pekka Paalanen wrote: > > On Thu, 2 Jun 2016 14:33:42 -0700 > > Bryce Harrington wrote: > > > > > On Wed, May 18, 2016 at 04:11:39PM +0300,

Re: [PATCH wayland-protocols v3 7/7] xdg-shell: Introduce xdg_positioner

Hi, one comment below, but anyway i think this looks good. However i will try to use it in qt asap to confirm it really is. 2016-05-26 7:32 GMT+03:00 Jonas Ådahl : > + > + > + > + Set the size of the surface that is to be positioned with the > positioner > +

Re: [PATCH wayland-protocols v3 6/7] xdg-shell: Make xdg_popup non-grabbing by default

2016-06-08 3:08 GMT+02:00 Jonas Ådahl : > On Tue, Jun 07, 2016 at 05:39:09PM +0300, Giulio Camuffo wrote: >> Hi, a couple of comments below: >> >> 2016-05-26 7:32 GMT+03:00 Jonas Ådahl : >> > Turn xdg_popup into plain temporary child surfaces without any

Re: eglSwapBuffer blocks without any shell surface query!

On Wed, 8 Jun 2016 10:49:43 +0530 Vikas Patil wrote: > Dear All, > > What if I don't use any shell/shell surface in GLES/EGL based > application with wayland/weston? Will eglSwapBuffer blocks in that > case? Is using any shell surface must? If you do not use any shell

Re: [PATCH libinput 6/7] Implement tablet pad group mode support

On Tue, Jun 07, 2016 at 06:33:28PM -0700, Jason Gerecke wrote: > On Sun, Jun 5, 2016 at 11:50 PM, Peter Hutterer > wrote: > > Signed-off-by: Peter Hutterer > > --- > > configure.ac | 2 +- > > src/Makefile.am |