Re: [PATCH wayland-protocols v4] Add screensaver idle inhibitor protocol

2016-08-12 Thread Bryce Harrington
On Fri, Aug 12, 2016 at 04:40:15PM +0800, Jonas Ådahl wrote: > As one probably already noticed, this was pushed earlier and was > included in wayland-protocols 1.6. > > > Jonas Thanks again Jonas. Bryce > On Thu, Jul 14, 2016 at 06:35:31PM -0700, Bryce Harrington wrote: > > This interface allo

Re: [PATCH wayland] shm: Make shm_pool_interface static const

2016-08-12 Thread Bryce Harrington
On Fri, Aug 12, 2016 at 12:04:41PM -0700, Yong Bakos wrote: > From: Yong Bakos > > Add static const modifiers to the shm_pool_interface definition, > making it consistent with the other wl_*_interface definitions and > mundanely safer. > > Note that this does not affect the ABI, according to abi

Re: [PATCH wayland 0/8] protocol: documentation improvements

2016-08-12 Thread Bryce Harrington
On Thu, Aug 11, 2016 at 02:32:57PM -0700, Yong Bakos wrote: > From: Yong Bakos > > This series "fills in the blanks" of all missing summary attributes in > wayland.xml, and massages some inconsistencies I found along the way. > > Patch 1/8 is the meatiest, and incorporates Pekka's feedback from

Re: [PATCH wayland] server: Add doxygen comment for wl_client_for_each

2016-08-12 Thread Bryce Harrington
On Thu, Aug 11, 2016 at 01:07:51PM -0700, Bryce Harrington wrote: > On Thu, Aug 11, 2016 at 12:13:37PM -0700, Yong Bakos wrote: > > From: Yong Bakos > > > > Commit 596024f728b0a1292ee69a80dd72a85167870936 includes a doc comment > > with a link to the wl_client_for_each macro, causing an error whe

[PATCH wayland] shm: Make shm_pool_interface static const

2016-08-12 Thread Yong Bakos
From: Yong Bakos Add static const modifiers to the shm_pool_interface definition, making it consistent with the other wl_*_interface definitions and mundanely safer. Note that this does not affect the ABI, according to abi-dumper and abi-compliance-checker[1]; and weston and its shm-backed clien

Re: [PATCH wayland-protocols 1/4 v5] xdg-shell: Introduce xdg_positioner

2016-08-12 Thread Bryce Harrington
On Fri, Aug 12, 2016 at 12:45:33PM +0800, Jonas Ådahl wrote: > On Thu, Aug 11, 2016 at 09:36:42PM -0700, Bryce Harrington wrote: > > On Fri, Aug 12, 2016 at 12:33:42PM +0800, Jonas Ådahl wrote: > > > On Thu, Aug 11, 2016 at 09:08:15PM -0700, Bryce Harrington wrote: > > > > On Fri, Aug 12, 2016 at 1

Re: [PATCH wayland-protocols 3/4 v2] xdg-shell: Add resize_x/y constrain adjustment to positioner

2016-08-12 Thread Bryce Harrington
On Fri, Aug 12, 2016 at 12:44:49PM +0800, Jonas Ådahl wrote: > On Thu, Aug 11, 2016 at 09:35:57PM -0700, Bryce Harrington wrote: > > On Fri, Aug 12, 2016 at 11:56:13AM +0800, Jonas Ådahl wrote: > > > On Thu, Aug 11, 2016 at 08:49:01PM -0700, Bryce Harrington wrote: > > > > On Fri, Jul 29, 2016 at 1

Re: [PATCH 1/3 v3] wayland-server: Add API to control globals visibility

2016-08-12 Thread Yong Bakos
Hi Olivier, I thought you'd say that. :) Ok, I get it - I did think of those things as well although coming to a different conclusion. However, just consider this... > On Aug 11, 2016, at 11:32 PM, Olivier Fourdan wrote: > > Hi Yong, > > Thanks for your follow-up. > > I don;t necessarily agree

Re: [PATCH wayland-protocols 3/4 v2] xdg-shell: Add resize_x/y constrain adjustment to positioner

2016-08-12 Thread Yong Bakos
Hi Jonas & Bryce, > On Aug 11, 2016, at 9:44 PM, Jonas Ådahl wrote: > > On Thu, Aug 11, 2016 at 09:35:57PM -0700, Bryce Harrington wrote: >> On Fri, Aug 12, 2016 at 11:56:13AM +0800, Jonas Ådahl wrote: >>> On Thu, Aug 11, 2016 at 08:49:01PM -0700, Bryce Harrington wrote: On Fri, Jul 29, 201

Re: [PATCH 02/10] libweston: Add initial output API for windowed outputs configuration

2016-08-12 Thread Pekka Paalanen
On Thu, 11 Aug 2016 17:33:57 +0200 Armin Krezović wrote: > This adds new plugin-specific API for configuring outputs > on "windowed" backends, such as X11, wayland/non-fullscreen > and even headless (although, it doesn't have any windows, > its configuration is very similar). It can be used from

Re: [PATCH 01/10] libweston: Add more functionality for handling weston_output objects

2016-08-12 Thread Armin Krezović
On 12.08.2016 18:10, Pekka Paalanen wrote: > On Fri, 12 Aug 2016 15:33:27 +0200 > Armin Krezović wrote: > >> On 12.08.2016 15:02, Pekka Paalanen wrote: >>> On Thu, 11 Aug 2016 17:33:56 +0200 >>> Armin Krezović wrote: >>> This patch implements additional functionality that will be used >>

Re: [PATCH 01/10] libweston: Add more functionality for handling weston_output objects

2016-08-12 Thread Pekka Paalanen
On Fri, 12 Aug 2016 15:33:27 +0200 Armin Krezović wrote: > On 12.08.2016 15:02, Pekka Paalanen wrote: > > On Thu, 11 Aug 2016 17:33:56 +0200 > > Armin Krezović wrote: > > > >> This patch implements additional functionality that will be used > >> for configuring, enabling and disabling weston'

Re: [PATCH 03/10] compositor: Implement output configuration using windowed_output_api

2016-08-12 Thread Pekka Paalanen
On Thu, 11 Aug 2016 17:33:58 +0200 Armin Krezović wrote: > This implements output configuration for outputs which use > previously added weston_windowed_output_api. The function > takes an output that's to be configured, default configuration > that's to be set in case no configuration is specifi

Re: [PATCH 01/10] libweston: Add more functionality for handling weston_output objects

2016-08-12 Thread Armin Krezović
On 12.08.2016 15:02, Pekka Paalanen wrote: > On Thu, 11 Aug 2016 17:33:56 +0200 > Armin Krezović wrote: > >> This patch implements additional functionality that will be used >> for configuring, enabling and disabling weston's outputs. Its >> indended use is by the compositors or user programs tha

Re: [PATCH 01/10] libweston: Add more functionality for handling weston_output objects

2016-08-12 Thread Pekka Paalanen
On Thu, 11 Aug 2016 17:33:56 +0200 Armin Krezović wrote: > This patch implements additional functionality that will be used > for configuring, enabling and disabling weston's outputs. Its > indended use is by the compositors or user programs that want to > be able to configure, enable or disable

Re: [PATCH 10/10] Cleanup unneeded stuff left during the porting phrase

2016-08-12 Thread Pekka Paalanen
On Thu, 11 Aug 2016 17:34:05 +0200 Armin Krezović wrote: > - Removed weston_backend_output_config structure; Outputs > should be configured from compositors using plugin-api. > > - Merged weston_output_init() into weston_output_enable() > > - Renamed weston_output_init_pending() to weston_out

[PATCH] gl-renderer: emit frame_signal after eglSwapBuffers

2016-08-12 Thread Fabien Dessenne
Emit frame_signal at the end of the GL renderer processing, so the frame_signal clients are informed after the buffer is actually updated. Signed-off-by: Fabien Dessenne --- libweston/gl-renderer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libweston/gl-renderer.c b/libw

Re: [PATCH libinput 1/3] Add configurable button map to tappings

2016-08-12 Thread Hans de Goede
Hi, On 22-07-16 04:46, Peter Hutterer wrote: The previously hardcoded button map for tapping is 1/2/3 to LRM. But the middle button is a common feature on the desktop (used for paste, most prominently) and three-finger tapping is almost impossible to do reliably on some touchpads (e.g. the T440

Re: [PATCH 03/10] compositor: Implement output configuration using windowed_output_api

2016-08-12 Thread Quentin Glidic
On 11/08/2016 17:33, Armin Krezović wrote: This implements output configuration for outputs which use previously added weston_windowed_output_api. The function takes an output that's to be configured, default configuration that's to be set in case no configuration is specified in the config file

Re: [PATCH 02/10] libweston: Add initial output API for windowed outputs configuration

2016-08-12 Thread Quentin Glidic
On 11/08/2016 17:33, Armin Krezović wrote: This adds new plugin-specific API for configuring outputs on "windowed" backends, such as X11, wayland/non-fullscreen and even headless (although, it doesn't have any windows, its configuration is very similar). It can be used from compositors to configu

Re: [PATCH 10/10] Cleanup unneeded stuff left during the porting phrase

2016-08-12 Thread Quentin Glidic
On 11/08/2016 17:34, Armin Krezović wrote: - Removed weston_backend_output_config structure; Outputs should be configured from compositors using plugin-api. - Merged weston_output_init() into weston_output_enable() - Renamed weston_output_init_pending() to weston_output_init() Signed-off-by:

Re: [PATCH 07/10] weston: Port RDP backend to new output handling API

2016-08-12 Thread Quentin Glidic
On 11/08/2016 17:34, Armin Krezović wrote: This is a complete port of the RDP backend that uses recently added output handling API for output configuration. Output can be configured at runtime by passing the necessary configuration parameters, which can be filled in manually or obtained from the

Re: [PATCH 04/10] weston: Port DRM backend to new output handling API

2016-08-12 Thread Armin Krezović
On 12.08.2016 13:28, Quentin Glidic wrote: > On 11/08/2016 17:33, Armin Krezović wrote: >> This is a complete port of the DRM backend that uses >> recently added output handling API for output >> configuration. >> >> Output can be configured at runtime by passing the >> necessary configuration para

Re: [PATCH 06/10] weston: Port headless backend to new output handling API

2016-08-12 Thread Quentin Glidic
On 11/08/2016 17:34, Armin Krezović wrote: This is a complete port of the headless backend that uses recently added output handling API for output configuration. - Output can be configured at runtime by passing the necessary configuration parameters, which can be filled in manually, obtained

Re: [PATCH 05/10] weston: Port fbdev backend to new output handling API

2016-08-12 Thread Quentin Glidic
On 11/08/2016 17:34, Armin Krezović wrote: This is a complete port of the fbdev backend that uses recently added output handling API for output configuration. It is required that the scale and transform values are set using the previously added functionality. After everything has been set, outp

Re: [PATCH 04/10] weston: Port DRM backend to new output handling API

2016-08-12 Thread Quentin Glidic
On 11/08/2016 17:33, Armin Krezović wrote: This is a complete port of the DRM backend that uses recently added output handling API for output configuration. Output can be configured at runtime by passing the necessary configuration parameters, which can be filled in manually or obtained from the

Re: [PATCH 2/2] fullscreen-shell: Ensure that fs surface is presented on all outputs

2016-08-12 Thread Pekka Paalanen
On Thu, 11 Aug 2016 15:49:59 +0200 Armin Krezović wrote: > When no outputs are present, and no output resource is given, > a fullscreen surface won't get configured. This code ensures > that surface is properly presented on all outputs that get > connected after a surface has been created, but on

Re: [PATCH weston 6/6] clients/simple-dmabuf-v4l: Port to xdg_shell unstable v6

2016-08-12 Thread Quentin Glidic
On 12/08/2016 05:40, Jonas Ådahl wrote: Signed-off-by: Jonas Ådahl Same as simple-dmabuf-intel, maybe a comment? :-) Reviewed-by: Quentin Glidic Cheers, --- Makefile.am | 6 +-- clients/simple-dmabuf-v4l.c | 96 ++--- 2 files chang

Re: [PATCH weston 5/6] clients/simple-dmabuf-intel: Port to xdg_shell unstable v6

2016-08-12 Thread Quentin Glidic
On 12/08/2016 05:40, Jonas Ådahl wrote: Signed-off-by: Jonas Ådahl Here we could get the configure event early, but initialized would be false anyway. Ok. Maybe a comment? :-) Reviewed-by: Quentin Glidic Cheers, --- Makefile.am | 4 +- clients/simple-dmabuf-intel.c |

Re: [PATCH weston 4/6] clients/simple-damage: Port to xdg_shell unstable v6

2016-08-12 Thread Quentin Glidic
On 12/08/2016 05:40, Jonas Ådahl wrote: Signed-off-by: Jonas Ådahl Same as simple-shm, maybe add a comment. Reviewed-by: Quentin Glidic Cheers, --- Makefile.am | 4 +-- clients/simple-damage.c | 92 - 2 files changed, 63 insert

Re: [PATCH weston 3/6] clients/simple-shm: Port to xdg_shell unstable v6

2016-08-12 Thread Quentin Glidic
On 12/08/2016 11:44, Jonas Ådahl wrote: On Fri, Aug 12, 2016 at 11:27:11AM +0200, Quentin Glidic wrote: On 12/08/2016 05:40, Jonas Ådahl wrote: Signed-off-by: Jonas Ådahl One concern (in two places) below. --- Makefile.am | 4 +-- clients/simple-shm.c | 93 +

Re: [PATCH weston 3/6] clients/simple-shm: Port to xdg_shell unstable v6

2016-08-12 Thread Jonas Ådahl
On Fri, Aug 12, 2016 at 11:27:11AM +0200, Quentin Glidic wrote: > On 12/08/2016 05:40, Jonas Ådahl wrote: > > Signed-off-by: Jonas Ådahl > > One concern (in two places) below. > > > > --- > > Makefile.am | 4 +-- > > clients/simple-shm.c | 93 > >

[PATCH weston v2] clients/simple-shm: Port to xdg_shell unstable v6

2016-08-12 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl Acked-by: Bryce Harrington Acked-by: Pekka Paalanen --- > … here. You trigger a redraw (chain) if configure was received, but in this > case, the redraw is already triggered. > I guess you used the same code for all simple-*, except this one lacks (or > don’t need) th

Re: [PATCH weston 1/6] toytoolkit: Port to xdg_shell unstable v6

2016-08-12 Thread Jonas Ådahl
On Fri, Aug 12, 2016 at 11:16:22AM +0200, Quentin Glidic wrote: > On 12/08/2016 05:40, Jonas Ådahl wrote: > > Signed-off-by: Jonas Ådahl > > --- > > Makefile.am | 10 ++- > > clients/window.c | 268 > > --- > > 2 files changed, 184 insert

Re: [PATCH weston 3/6] clients/simple-shm: Port to xdg_shell unstable v6

2016-08-12 Thread Quentin Glidic
On 12/08/2016 05:40, Jonas Ådahl wrote: Signed-off-by: Jonas Ådahl One concern (in two places) below. --- Makefile.am | 4 +-- clients/simple-shm.c | 93 2 files changed, 60 insertions(+), 37 deletions(-) diff --git a/Makefile

Re: [PATCH weston 2/6] clients/simple-egl: Port to xdg_shell unstable v6

2016-08-12 Thread Quentin Glidic
On 12/08/2016 05:40, Jonas Ådahl wrote: Signed-off-by: Jonas Ådahl Looks good: Reviewed-by: Quentin Glidic Cheers, --- Makefile.am | 4 +- clients/simple-egl.c | 106 +++ 2 files changed, 66 insertions(+), 44 deletions(-) diff -

Re: [PATCH weston 3/6] Introduce libweston-desktop

2016-08-12 Thread Pekka Paalanen
On Fri, 12 Aug 2016 10:44:32 +0200 Quentin Glidic wrote: > On 12/08/2016 10:41, Quentin Glidic wrote: > > From: Quentin Glidic > > > > libweston-desktop is an abstraction library for compositors wanting to > > support desktop-like shells. > > > > The API is designed from xdg_shell features, as i

Re: [PATCH weston 1/6] toytoolkit: Port to xdg_shell unstable v6

2016-08-12 Thread Quentin Glidic
On 12/08/2016 05:40, Jonas Ådahl wrote: Signed-off-by: Jonas Ådahl --- Makefile.am | 10 ++- clients/window.c | 268 --- 2 files changed, 184 insertions(+), 94 deletions(-) diff --git a/Makefile.am b/Makefile.am index 47fc643..3a42a93 1

Re: [PATCH wayland v5] Add API to install protocol loggers on the server wl_display

2016-08-12 Thread Pekka Paalanen
On Fri, 12 Aug 2016 09:34:46 +0200 Giulio Camuffo wrote: > Ah sorry, i forgot to add Yong's R-b. > > 2016-08-12 9:33 GMT+02:00 Giulio Camuffo : > > The new wl_display_add_protocol_logger allows to set a function as > > a logger, which will get called when a new request is received or an > > even

Re: [PATCH wayland v4 2/3] Add API to retrieve and iterate over the resources list of a client

2016-08-12 Thread Pekka Paalanen
On Thu, 11 Aug 2016 17:23:10 +0200 Giulio Camuffo wrote: > To complement on the new resource created signal, this allows to > iterate over the existing resources of a client. > > Signed-off-by: Giulio Camuffo > Reviewed-by: Jonas Ådahl > --- > > v4: - really stop when the iterator says so >

Re: [PATCH wayland-protocols v2] Introduce xdg-foreign protocol

2016-08-12 Thread Jonas Ådahl
On Sun, Aug 07, 2016 at 08:14:32AM -0500, Derek Foreman wrote: > On 05/08/16 10:52 AM, Jonas Ådahl wrote: > > On Fri, Aug 05, 2016 at 07:45:50AM -0500, Derek Foreman wrote: > >> On 27/07/16 02:54 AM, Jonas Ådahl wrote: > >>> xdg-foreign is a protocol meant to enable setting up inter surface > >>> r

[PATCH weston 0/6] libweston-desktop, finally

2016-08-12 Thread Quentin Glidic
From: Quentin Glidic Hi everyone, Here is the final shape of my libweston-desktop series. A lot of things happened on Phabricator[1], and this is the result. Thanks to Jonas for the deep reviews that made it useful for real. And thanks to Giulio for the API concerns that will make it useful to

[PATCH weston 4/6] xwayland: Introduce a private struct for XWayland interface

2016-08-12 Thread Quentin Glidic
From: Quentin Glidic libweston-desktop implements this private struct. Signed-off-by: Quentin Glidic Reviewed-by: Jonas Ådahl Acked-by: Giulio Camuffo Differential Revision: https://phabricator.freedesktop.org/D1208 --- Makefile.am| 1 + libweston-desktop/xwayl

[PATCH weston 6/6] libweston-desktop: Implement xdg_shell_v6

2016-08-12 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic Acked-by: Jonas Ådahl Acked-by: Giulio Camuffo Differential Revision: https://phabricator.freedesktop.org/D1210 --- Makefile.am |4 + libweston-desktop/libweston-desktop.c | 10 + libweston-desktop/xdg-shell-v

[PATCH weston 1/6] input: Add helpers for all keyboard/pointer/touch events

2016-08-12 Thread Quentin Glidic
From: Quentin Glidic These are useful to implement grabs. Signed-off-by: Quentin Glidic Reviewed-by: Jonas Ådahl Acked-by: Giulio Camuffo Differential Revision: https://phabricator.freedesktop.org/D1245 --- libweston/compositor.h | 33 + libweston/input.c | 374 +++

[PATCH weston 2/6] libweston: Rename weston_surface::configure to ::committed

2016-08-12 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic Reviewed-by: Jonas Ådahl Acked-by: Giulio Camuffo Differential Revision: https://phabricator.freedesktop.org/D1246 --- desktop-shell/input-panel.c | 16 - desktop-shell/shell.c | 72 ++---

Re: [PATCH wayland-protocols v4] Add screensaver idle inhibitor protocol

2016-08-12 Thread Jonas Ådahl
As one probably already noticed, this was pushed earlier and was included in wayland-protocols 1.6. Jonas On Thu, Jul 14, 2016 at 06:35:31PM -0700, Bryce Harrington wrote: > This interface allows disabling of screensaver/screenblanking on a > per-surface basis. As long as the surface remains vi

Re: [PATCH weston v3 6/6] Add API to install protocol loggers on the server wl_display

2016-08-12 Thread Giulio Camuffo
2016-08-12 10:25 GMT+02:00 Pekka Paalanen : > On Thu, 11 Aug 2016 17:06:02 +0200 > Giulio Camuffo wrote: > >> 2016-08-11 16:39 GMT+02:00 Pekka Paalanen : >> > On Tue, 9 Aug 2016 12:46:56 +0200 >> > Giulio Camuffo wrote: >> > >> >> The new wl_display_add_protocol_logger allows to set a function a

Re: [PATCH weston v3 6/6] Add API to install protocol loggers on the server wl_display

2016-08-12 Thread Pekka Paalanen
On Thu, 11 Aug 2016 17:06:02 +0200 Giulio Camuffo wrote: > 2016-08-11 16:39 GMT+02:00 Pekka Paalanen : > > On Tue, 9 Aug 2016 12:46:56 +0200 > > Giulio Camuffo wrote: > > > >> The new wl_display_add_protocol_logger allows to set a function as > >> a logger, which will get called when a new re

Re: [PATCH weston 0/6] Switch client to xdg_shell unstable v6

2016-08-12 Thread Pekka Paalanen
On Thu, 11 Aug 2016 21:40:14 -0700 Bryce Harrington wrote: > On Fri, Aug 12, 2016 at 11:40:00AM +0800, Jonas Ådahl wrote: > > Hi, > > > > With a xdg_shell unstable v6 release around the corner, and a > > libweston-desktop > > about to land with a xdg_shell unstable v6 implementation available,

Re: [PATCH weston 2/7] weston-egl-ext.h: remove EGL_EGLEXT_PROTOTYPES sections

2016-08-12 Thread Pekka Paalanen
On Mon, 4 Jul 2016 15:27:14 +0100 Emil Velikov wrote: > From: Emil Velikov > > Those the function declarations alongside the EGL_EGLEXT_PROTOTYPES > guards. Although those are copy/paste sections from the header(s), > having and/or using them is a bad idea, as per the EGL spec. > > Signed-off

Re: [PATCH wayland v5] Add API to install protocol loggers on the server wl_display

2016-08-12 Thread Giulio Camuffo
Ah sorry, i forgot to add Yong's R-b. 2016-08-12 9:33 GMT+02:00 Giulio Camuffo : > The new wl_display_add_protocol_logger allows to set a function as > a logger, which will get called when a new request is received or an > event is sent. > This is akin to setting WAYLAND_DEBUG=1, but more powerful

[PATCH wayland v5] Add API to install protocol loggers on the server wl_display

2016-08-12 Thread Giulio Camuffo
The new wl_display_add_protocol_logger allows to set a function as a logger, which will get called when a new request is received or an event is sent. This is akin to setting WAYLAND_DEBUG=1, but more powerful because it can be enabled at run time and allows to show the log e.g. in a UI view. A tes

Re: [PATCH wayland v4 3/3] Add API to install protocol loggers on the server wl_display

2016-08-12 Thread Giulio Camuffo
2016-08-12 3:33 GMT+02:00 Jonas Ådahl : > On Thu, Aug 11, 2016 at 05:23:11PM +0200, Giulio Camuffo wrote: >> The new wl_display_add_protocol_logger allows to set a function as >> a logger, which will get called when a new request is received or an >> event is sent. >> This is akin to setting WAYLAN

RDP client fails to connect

2016-08-12 Thread John Obaterspok
Hi, I'm using Fedora 25 with Weston 1.10 and freerdp 2.0.0 git b02943a I get "unable to checkDescriptor" once I connect with Windows 7/10 client. I also tried to put selinux in Permissive mode (setenforce 0) Any ideas why? $ winpr-makecert -rdp server $ weston --backend=rdp-backend.so --rdp-tls