Re: [PATCH weston] libweston-desktop: fix stale ping when a wl_shell_surface is destroyed

2016-09-27 Thread nerdopolis
Hi Is this patch for https://bugs.freedesktop.org/show_bug.cgi?id=97892 , or is it for a different issue that I am getting confused with? It doesn't seem to fix the issue with wl_shell for qtwayland and EFL (when EFL is forced to use wl_shell) It actually seems to make the issue affect all

Re: [PATCH] weston-launch: Protect KDGKBMODE K_OFF ioctl by KERNEL_VERSION check

2016-09-27 Thread Dima Ryazanov
The kernel version used to build Weston isn't necessarily the same as the version that will be used to run it. Weston should already work fine on older versions: the second ioctl will return an error - but it's ok as long as the first one succeeds. Also, a compile-time check would prevent Weston

Re: [PATCH wayland v2 4/4] array-test: Include wayland-util.h and simplify init test

2016-09-27 Thread Dima Ryazanov
I think I actually know the point of the test. It tries to verify that size, alloc, and data were initialized to 0, rather than left uninitialized - but the difficulty is that uninitialized memory is often already filled with 0s. So the test repeats the process a whole bunch of times, hoping to

[PATCH] weston-launch: Protect KDGKBMODE K_OFF ioctl by KERNEL_VERSION check

2016-09-27 Thread Krzysztof Konopko
From: Tomasz SZKUTKOWSKI This patch disables unsupported ioctl `KDGKBMODE K_OFF` command if Weston is built against kernel older than 2.6.39, as this ioctl has been introduced in 2.6.39 kernel version. No functional changes have been observed by disabling this

[PATCH wayland v2 3/4] tests: Test wl_array_release

2016-09-27 Thread Yong Bakos
From: Yong Bakos array-test.c did not cover wl_array_release, so add one test that specifically tests this method. Signed-off-by: Yong Bakos --- v2: Use wl_array_add instead of calloc (pq) tests/array-test.c | 11 +++ 1 file

[PATCH wayland v2 2/4] wl_array: Set data to invalid address after free

2016-09-27 Thread Yong Bakos
From: Yong Bakos Explicitly set the data member to an invalid memory address during wl_array_release, such that re-using a freed wl_array without re-initializing causes a crash. In addition, this pointer assignment makes wl_array_release testable. Define a constant for

[PATCH wayland v2 0/4] wl_array: documentation and test

2016-09-27 Thread Yong Bakos
From: Yong Bakos This series adds documentation to wl_array and its methods. There is one implementation change: defining an invalid pointer address, and setting the `data` pointer to the invalid pointer address after free, in wl_array_release. I did not set `size` and

[PATCH wayland v2 1/4] util: Document wl_array

2016-09-27 Thread Yong Bakos
From: Yong Bakos Add doxygen comments for wl_array and its methods. Signed-off-by: Yong Bakos Reviewed-by: Eric Engestrom --- v2: Add description paragraph to wl_array (pq) Fix s/list/array (pq) Add note

[PATCH wayland v2 4/4] array-test: Include wayland-util.h and simplify init test

2016-09-27 Thread Yong Bakos
From: Yong Bakos Include wayland-util.h in addition to wayland-private.h, to be more explicit about where wl_array is defined. Remove the useless repeated testing of wl_array_init, because if it fails once out of thousands of iterations we're all doomed anyway.

Re: [PATCH weston v2] clients/stacking: Silence a compiler warning

2016-09-27 Thread Eric Engestrom
On Tue, Sep 27, 2016 at 12:35:55PM +0200, Armin Krezović wrote: > This patch fixes a compiler warning when building with > clang, since it doesn't support gnu_printf attribute. > > v2: > > - Switch to WL_PRINTF per suggestion from Eric Engestrom. > > Signed-off-by: Armin Krezović

Re: [PATCH weston 08/14 v3] weston: Port Wayland backend to new output handling API

2016-09-27 Thread Pekka Paalanen
On Thu, 18 Aug 2016 18:42:36 +0200 Armin Krezović wrote: > This is a complete port of the Wayland backend that > uses recently added output handling API for output > configuration. > > - Output can be configured at runtime by passing the > necessary configuration

Re: [PATCH weston] gl-renderer: Use EGL_KHR_no_config_context

2016-09-27 Thread Emmanuel Gil Peyrot
On Tue, Sep 27, 2016 at 12:29:51PM +0200, Armin Krezović wrote: > This patch makes use of recently implemented > EGL_KHR_no_config_context extension in Mesa, > which superseeds EGL_MESA_configless_context. > > See also (and the follow-up patch): > >

[PATCH weston v2] clients/stacking: Silence a compiler warning

2016-09-27 Thread Armin Krezović
This patch fixes a compiler warning when building with clang, since it doesn't support gnu_printf attribute. v2: - Switch to WL_PRINTF per suggestion from Eric Engestrom. Signed-off-by: Armin Krezović --- clients/stacking.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH weston] gl-renderer: Use EGL_KHR_no_config_context

2016-09-27 Thread Armin Krezović
This patch makes use of recently implemented EGL_KHR_no_config_context extension in Mesa, which superseeds EGL_MESA_configless_context. See also (and the follow-up patch): https://lists.freedesktop.org/archives/mesa-dev/2016-September/128510.html Signed-off-by: Armin Krezović