[wayland-protocols] linux-dmabuf: clarify format event description

From: Varad Gautam clearly state the request name in format event to avoid abmiguous interpretation between 'zwp_linux_buffer_params_v1::create' and 'zwp_linux_dmabuf_v1::create_params' requests. Suggested-by: Yong Bakos Signed-off-by:

[wayland-protocols v2] linux-dmabuf: advertise format modifiers with modifier event

From: Varad Gautam advertise the supported fourcc format modifiers along with supported formats to the client. bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interface versions to 3. v2: specify request name in event description for clarity (Yong Bakos)

[PATCH v2 wayland] protocol: indentation fixes

8 spaces changed to one tab Signed-off-by: Peter Hutterer Acked-by: Bryce Harrington --- Changes to v1: - Rebased on top of aa51a83 protocol/wayland.xml | 100 +-- 1 file changed, 50

Re: [PATCH wayland] protocol: spell out that we're using linux/input-event-codes.h key codes

On Fri, Nov 18, 2016 at 12:25:21PM +1000, Peter Hutterer wrote: > On Thu, Nov 17, 2016 at 10:42:41AM +0800, Jonas Ådahl wrote: > > On Wed, Nov 16, 2016 at 04:00:23PM +, Daniel Stone wrote: > > > Hi, > > > > > > On 15 November 2016 at 09:42, Jonas Ådahl wrote: > > > > On

Re: [PATCH wayland] protocol: indentation fixes

On Thu, Nov 17, 2016 at 04:42:07PM -0800, Bryce Harrington wrote: > On Thu, Nov 10, 2016 at 03:02:06PM +1000, Peter Hutterer wrote: > > 8 spaces changed to one tab > > > > Signed-off-by: Peter Hutterer > > The patch isn't applying as of change 66a26aeb (remove

Re: [PATCH v2 wayland] protocol: spell out that we're using linux/input-event-codes.h button codes

On Fri, Nov 18, 2016 at 12:35:27PM +1000, Peter Hutterer wrote: > Because we already rely on it in the callers anyway. This is a retrofit, which > is not ideal but I'm not sure any compositor out there uses anything else. > Might as well define it. > > Signed-off-by: Peter Hutterer

[PATCH v2 wayland] protocol: spell out that we're using linux/input-event-codes.h button codes

Because we already rely on it in the callers anyway. This is a retrofit, which is not ideal but I'm not sure any compositor out there uses anything else. Might as well define it. Signed-off-by: Peter Hutterer --- This is the button bit only which I think we agreed on so

Re: [PATCH wayland] protocol: spell out that we're using linux/input-event-codes.h key codes

On Thu, Nov 17, 2016 at 10:42:41AM +0800, Jonas Ådahl wrote: > On Wed, Nov 16, 2016 at 04:00:23PM +, Daniel Stone wrote: > > Hi, > > > > On 15 November 2016 at 09:42, Jonas Ådahl wrote: > > > On Thu, Nov 10, 2016 at 10:22:41AM +, Daniel Stone wrote: > > >> But this I'd

Re: [PATCH] xdg-shell: clarify popup constrain's slide mechanism

On Wed, Nov 16, 2016 at 10:23:59AM -0500, Mike Blumenkrantz wrote: > some restrictions must be placed on this or else it becomes legal for > the compositor to place popups in unexpected locations when sliding > is allowed > > Signed-off-by: Mike Blumenkrantz > --- >

Re: [PATCH wayland] protocol: indentation fixes

On Thu, Nov 10, 2016 at 03:02:06PM +1000, Peter Hutterer wrote: > 8 spaces changed to one tab > > Signed-off-by: Peter Hutterer The patch isn't applying as of change 66a26aeb (remove inconsistent line breaks), but in generating a whitespace patch myself using emacs

Re: [PATCH wayland] util: Clarify documentation of wl_dispatcher_func_t

On Thu, Nov 17, 2016 at 08:23:14AM -0800, Yong Bakos wrote: > From: Yong Bakos > > Adjust the brief, clarify the behavior and arguments, correct a grammar > error, and document the parameters. > > Signed-off-by: Yong Bakos Definitely an

Re: [PATCH] xdg-shell: clarify popup constrain's slide mechanism

On Thu, Nov 17, 2016 at 07:32:02AM -0800, Yong Bakos wrote: > Hi Mike, > > > On Nov 16, 2016, at 7:23 AM, Mike Blumenkrantz > > wrote: > > > > some restrictions must be placed on this or else it becomes legal for > > the compositor to place popups in unexpected locations

Re: [PATCH] weston-editor: Don't copy the preedit string before inserting it

On Thu, Nov 17, 2016 at 09:43:05PM +0100, Silvan Jegen wrote: > Signed-off-by: Silvan Jegen > --- > clients/editor.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/clients/editor.c b/clients/editor.c > index 6805d8a..1ed3eec 100644 > ---

Re: [PATCH] weston-editor: Free preferred_language in text_entry_destroy

On Thu, Nov 17, 2016 at 09:43:06PM +0100, Silvan Jegen wrote: > Signed-off-by: Silvan Jegen Yep, the value is set via a strdup in main(), so needs free'd. Reviewed-by: Bryce Harrington > --- > clients/editor.c | 1 + > 1 file changed, 1 insertion(+)

[PATCH] weston-editor: Don't copy the preedit string before inserting it

Signed-off-by: Silvan Jegen --- clients/editor.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index 6805d8a..1ed3eec 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -944,16 +944,10 @@

[PATCH] weston-editor: Free preferred_language in text_entry_destroy

Signed-off-by: Silvan Jegen --- clients/editor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/clients/editor.c b/clients/editor.c index 1ed3eec..a0d66d1 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -719,6 +719,7 @@ text_entry_destroy(struct text_entry *entry)

Re: [PATCH wayland] util: Clarify documentation of wl_dispatcher_func_t

On Nov 17, 2016, at 8:23 AM, Yong Bakos wrote: > > From: Yong Bakos > > Adjust the brief, clarify the behavior and arguments, correct a grammar > error, and document the parameters. > > Signed-off-by: Yong Bakos Eh

[PATCH wayland] util: Clarify documentation of wl_dispatcher_func_t

From: Yong Bakos Adjust the brief, clarify the behavior and arguments, correct a grammar error, and document the parameters. Signed-off-by: Yong Bakos --- src/wayland-util.h | 25 +++-- 1 file changed, 15 insertions(+),

Re: [PATCH] xdg-shell: clarify popup constrain's slide mechanism

Hi Mike, > On Nov 16, 2016, at 7:23 AM, Mike Blumenkrantz wrote: > > some restrictions must be placed on this or else it becomes legal for > the compositor to place popups in unexpected locations when sliding > is allowed > > Signed-off-by: Mike Blumenkrantz

Re: [wayland-protocols] linux-dmabuf: advertise format modifiers with modifier event

Hi Varad, > On Nov 17, 2016, at 3:55 AM, Varad Gautam wrote: > > From: Varad Gautam > > advertise the supported fourcc format modifiers along with supported > formats to the client. > > bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1

Re: [PATCH weston v2] xwayland: Fix X11 lock file size confusion

On Thu, 17 Nov 2016 12:17:59 + Daniel Stone wrote: > The X11 lock file was somewhat opaque. Into a sized array of 16 > characters, we previously read 11 bytes. 61beda653b fixed the parsing of > this input to ensure that we only considered the first 10 bytes: this > has

Re: [PATCH weston v2] xwayland: Fix X11 lock file size confusion

On Thursday, 2016-11-17 12:17:59 +, Daniel Stone wrote: > The X11 lock file was somewhat opaque. Into a sized array of 16 > characters, we previously read 11 bytes. 61beda653b fixed the parsing of > this input to ensure that we only considered the first 10 bytes: this > has the effect of

Re: [PATCH 1/3 v4] wayland-server: Add API to control globals visibility

On Wed, 16 Nov 2016 03:28:57 -0500 (EST) Olivier Fourdan wrote: > Hi Pekka, > > > > > [...] > > > > Therefore I think this would be a beneficial addition: > > > > Acked-by: Pekka Paalanen > > > > > > So, if I amend the commit message as

[PATCH weston v2] xwayland: Fix X11 lock file size confusion

The X11 lock file was somewhat opaque. Into a sized array of 16 characters, we previously read 11 bytes. 61beda653b fixed the parsing of this input to ensure that we only considered the first 10 bytes: this has the effect of culling a LF byte at the end of the string. This commit more explicitly

Re: [PATCH weston 5/9] clients/simple-dmabuf-intel: rename to simple-dmabuf-drm

On Thursday, 2016-11-17 17:25:59 +0530, Varad Gautam wrote: > From: Varad Gautam > > this will allow adding other drm backends later. > > Signed-off-by: Varad Gautam > --- > Makefile.am | 12 +- >

Re: [PATCH weston] xwayland: Fix X11 lock file size confusion

Hi, On 17 November 2016 at 12:03, Eric Engestrom wrote: > On Thursday, 2016-11-17 11:35:53 +, Daniel Stone wrote: >> diff --git a/xwayland/launcher.c b/xwayland/launcher.c >> index 97d7c6e..56b949e 100644 >> --- a/xwayland/launcher.c >> +++ b/xwayland/launcher.c >>

Re: [PATCH weston] xwayland: Fix X11 lock file size confusion

On Thu, 17 Nov 2016 11:35:53 + Daniel Stone wrote: > The X11 lock file was somewhat opaque. Into a sized array of 16 > characters, we previously read 11 bytes. 61beda653b fixed the parsing of > this input to ensure that we only considered the first 10 bytes: this > has

Re: [PATCH weston] xwayland: Fix X11 lock file size confusion

On Thursday, 2016-11-17 11:35:53 +, Daniel Stone wrote: > The X11 lock file was somewhat opaque. Into a sized array of 16 > characters, we previously read 11 bytes. 61beda653b fixed the parsing of > this input to ensure that we only considered the first 10 bytes: this > has the effect of

[PATCH weston 7/9] clients/simple-dmabuf-drm: import with dmabuf modifiers

From: Varad Gautam mesa's freedreno driver supports importing dmabufs with format DRM_FORMAT_NV12 and DRM_FORMAT_MOD_SAMSUNG_64_32_TILE modifier. demonstrate weston modifier advertising and import path using this combination when run with --import-format=NV12.

[PATCH weston 9/9] clients/simple-dmabuf-drm: use tiled frame data with modifiers

From: Varad Gautam fill the dmabuf with valid DRM_FORMAT_NV12 + DRM_FORMAT_MOD_SAMSUNG_64_32_TILE frame data before importing to display a non-gibberish pattern when importing with modifiers. Signed-off-by: Varad Gautam ---

[PATCH weston 5/9] clients/simple-dmabuf-intel: rename to simple-dmabuf-drm

From: Varad Gautam this will allow adding other drm backends later. Signed-off-by: Varad Gautam --- Makefile.am | 12 +- clients/simple-dmabuf-drm.c | 668 ++

[PATCH weston 3/9] gl-renderer: allow importing dmabufs with format modifiers

From: Varad Gautam pass over the modifier attributes to EGL. Signed-off-by: Varad Gautam --- libweston/gl-renderer.c| 26 ++ libweston/weston-egl-ext.h | 6 ++ 2 files changed, 28 insertions(+), 4

[PATCH weston 6/9] clients/simple-dmabuf-drm: add freedreno support alongside intel

From: Varad Gautam abstract drm specific bits to struct drm_device and support running on freedreno. Signed-off-by: Varad Gautam --- Makefile.am | 2 +- clients/simple-dmabuf-drm.c | 214

[PATCH weston 2/9] linux-dmabuf: advertise supported formats and modifiers

From: Varad Gautam implement 'format' and 'modifier' events to communicate available formats and modifiers to the client and support zwp_linux_dmabuf_v1 interface version 3. Signed-off-by: Varad Gautam --- libweston/linux-dmabuf.c | 33

[PATCH weston 4/9] gl-renderer: allow importing fourth dmabuf plane

From: Varad Gautam EGL_EXT_image_dma_buf_import_modifiers supports importing upto four dmabuf planes into an EGLImage. Signed-off-by: Varad Gautam --- libweston/gl-renderer.c| 17 - libweston/weston-egl-ext.h | 5

[PATCH weston 1/9] gl-renderer: support format and modifier queries

From: Varad Gautam EGL_EXT_image_dma_buf_import_modifiers allows querying the formats and modifiers supported by the platform. expose these to the compositor. Signed-off-by: Varad Gautam --- libweston/compositor.h | 7

[wayland-protocols] linux-dmabuf: advertise format modifiers with modifier event

From: Varad Gautam advertise the supported fourcc format modifiers along with supported formats to the client. bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interface versions to 3. Signed-off-by: Varad Gautam ---

Re: [PATCH weston] xwayland: Fix X11 lock file size confusion

On 17 November 2016 at 11:35, Daniel Stone wrote: > The X11 lock file was somewhat opaque. Into a sized array of 16 > characters, we previously read 11 bytes. 61beda653b fixed the parsing of > this input to ensure that we only considered the first 10 bytes: this > has the

Re: [PATCH wayland] Makefile: build also test programs during a normal build

On Thu, 17 Nov 2016 10:34:58 +0200 Pekka Paalanen wrote: > On Wed, 16 Nov 2016 16:30:59 + > Daniel Stone wrote: > > > Hi Jan, > > > > On 16 November 2016 at 16:19, Jan Engelhardt wrote: > > > On Wednesday 2016-11-16 17:16,

[PATCH weston] xwayland: Fix X11 lock file size confusion

The X11 lock file was somewhat opaque. Into a sized array of 16 characters, we previously read 11 bytes. 61beda653b fixed the parsing of this input to ensure that we only considered the first 10 bytes: this has the effect of culling a LF byte at the end of the string. This commit more explicitly

Re: [PATCH wayland] Makefile: build also test programs during a normal build

On Wed, 16 Nov 2016 16:30:59 + Daniel Stone wrote: > Hi Jan, > > On 16 November 2016 at 16:19, Jan Engelhardt wrote: > > On Wednesday 2016-11-16 17:16, Daniel Stone wrote: > >>> noinst_PROGRAMS = \ > >>> +