Re: [PATCH libinput] touchpad: mark the Apple onebutton touchpad as clickfinger-default

2017-02-07 Thread Peter Hutterer
On Wed, Feb 08, 2017 at 03:58:37PM +1000, Peter Hutterer wrote: > We don't initialize click methods on devices with physical buttons. This model > is a special case, it's not a clickpad but it only has one button (because one > button is all you ever need and whatnot). > > https://bugs.freedesktop

[PATCH libinput] touchpad: mark the Apple onebutton touchpad as clickfinger-default

2017-02-07 Thread Peter Hutterer
We don't initialize click methods on devices with physical buttons. This model is a special case, it's not a clickpad but it only has one button (because one button is all you ever need and whatnot). https://bugs.freedesktop.org/show_bug.cgi?id=99283 Signed-off-by: Peter Hutterer --- src/evdev-

Re: [PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

2017-02-07 Thread Armin Krezović
If the required definitions are in UAPI headers, maybe you can just import the most recent header into weston source for the time being. IIRC, libevdev (used by libinput) does something similar in order to keep the build from breaking on older kernels. Maybe Peter can explain better. (Sent from we

Re: [PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

2017-02-07 Thread Derek Foreman
On 07/02/17 07:17 PM, Bryce Harrington wrote: On Tue, Feb 07, 2017 at 11:48:47AM +0200, Pekka Paalanen wrote: On Mon, 6 Feb 2017 12:57:41 -0500 Micah Fedke wrote: The v4l2 API can be queried to detect if the input video image is horizontally or vertically flipped. If the image is y-flipped,

[ANNOUNCE] wayland 1.12.92

2017-02-07 Thread Bryce Harrington
Here is the beta for the upcoming 1.13 release. In addition to a range of bug fixes, this adds some API for controlling the visibility of globals and numerous documentation additions and improvements. As per the previously announced schedule the first release candidate will be in a week's time.

Re: [PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

2017-02-07 Thread Bryce Harrington
On Tue, Feb 07, 2017 at 11:48:47AM +0200, Pekka Paalanen wrote: > On Mon, 6 Feb 2017 12:57:41 -0500 > Micah Fedke wrote: > > > The v4l2 API can be queried to detect if the input video image is > > horizontally or vertically flipped. If the image is y-flipped, we can > > set the ZWP_LINUX_BUFFER_

[PATCH libinput] touchpad: expand top middle button to cover 40mm to 60mm

2017-02-07 Thread Peter Hutterer
42 and 58 were within the middle button already, 40/60 are more accurate values. https://bugs.freedesktop.org/show_bug.cgi?id=99212 Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/evdev-mt-touchpad-but

[PATCH weston v3] compositor-wayland: Don't use two different presentation methods for fs shell

2017-02-07 Thread Armin Krezović
This patch fixes the wayland backend to not use two different presentation methods when running on fullscreen-shell. See also: https://patchwork.freedesktop.org/patch/114534/ v2: - Add missing wayland_output_resize_surface() call - Start repaint loop after initial frame has been drawn v3: -

[RFC wayland, weston] Expose an output's connector name

2017-02-07 Thread Matthias Treydte
I already brought this up on IRC before and finally started to work on it. The goal is to give an Wayland client some identifier which allows it to recognize the physical connector which corresponds to some Wayland output. The rationale why such an API is useful is that a client might want to

[PATCH weston v2] compositor-wayland: Don't use two different presentation methods for fs shell

2017-02-07 Thread Armin Krezović
This patch fixes the wayland backend to not use two different presentation methods when running on fullscreen-shell. See also: https://patchwork.freedesktop.org/patch/114534/ v2: - Add missing wayland_output_resize_surface() call - Start repaint loop after initial frame has been drawn Signed-

[PATCH] compositor-wayland: Don't use two different presentation methods for fs shell

2017-02-07 Thread Armin Krezović
This patch fixes the wayland backend to not use two different presentation methods when running on fullscreen-shell. See also: https://patchwork.freedesktop.org/patch/114534/ Signed-off-by: Armin Krezović --- libweston/compositor-wayland.c | 85 +++--- 1 file

Re: [PATCH weston v3 2/2] compositor: allow to control the vt switching

2017-02-07 Thread Giulio Camuffo
2017-02-07 16:12 GMT+01:00 Pekka Paalanen : > On Mon, 5 Dec 2016 14:50:37 +0100 > Giulio Camuffo wrote: > >> A compositor may want to control the vt switching, for example to >> ensure to have a lock screen before it. To enable that add a vfunc >> that will be called when CTRL+ALT+FN is pressed.

Re: [PATCH weston v3 2/2] compositor: allow to control the vt switching

2017-02-07 Thread Pekka Paalanen
On Mon, 5 Dec 2016 14:50:37 +0100 Giulio Camuffo wrote: > A compositor may want to control the vt switching, for example to > ensure to have a lock screen before it. To enable that add a vfunc > that will be called when CTRL+ALT+FN is pressed. The default behavior > is to do the switching, but t

[PATCH 4/4] tests: add transform and scale tests

2017-02-07 Thread Micah Fedke
These tests check all combinations of wl_surface::set_buffer_transform and wl_surface::set_buffer_scale --- Makefile.am| 7 +- tests/reference/transform_and_scale-01.png | Bin 0 -> 4133 bytes tests/reference/transform_and_scale-02.png | Bin 0 -> 2731 bytes tests

[PATCH 2/4] tests: promote subsurface-shot-test's write_visual_diff() to a utility function

2017-02-07 Thread Micah Fedke
This function writes out a png file containing the visual diff between a reference image and a screenshot. --- tests/subsurface-shot-test.c | 24 - tests/weston-test-client-helper.c | 44 +++ tests/weston-test-client-helper.h | 5 +

[PATCH 1/4] tests: add a blank reference png for test development

2017-02-07 Thread Micah Fedke
This png can be used as a reference image (diff will fail, of course) for a new test until an appropriate reference image can be generated. --- tests/reference/blank.png | Bin 0 -> 624 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/reference/blank.png diff --git

[PATCH 3/4] tests: promote subsurface-shot-tests's check_screen() to a utility function

2017-02-07 Thread Micah Fedke
This function takes a screenshot of a provided client, compares it to a reference image, outputs the result as a PNG, and returns a value indicating whether the two images matched or not. A difference image is generated if the screenshot and reference do not match. --- tests/subsurface-shot-test.

[PATCH 0/4] Add transform and scale tests

2017-02-07 Thread Micah Fedke
With the test-desktop-shell in place, we can now add more weston feature tests. This is a patch to add tests for the various transform and scale modes. All permutations of all transform modes and scales up to 3x are tested. The initial patches add some utilities necessary for these tests. These

Re: [PATCH weston 1/2] compositor-drm: Construct mode list in create_output_for_connector

2017-02-07 Thread Daniel Stone
Hi Armin, On 9 October 2016 at 22:48, Armin Krezović wrote: > And properly deconstruct it in drm_output_destroy. > > Might be useful for finding out which modes are supported > before even setting them, in case we want to extend the > modesetting API. This is (finally): Reviewed-by: Daniel Stone

Re: [PATCH weston v3 1/2] launcher: don't try to switch to weston's vt

2017-02-07 Thread Pekka Paalanen
On Mon, 5 Dec 2016 14:50:36 +0100 Giulio Camuffo wrote: > Signed-off-by: Giulio Camuffo > Reviewed-by: Pekka Paalanen > --- > > v3: changed the summary to say "weston's vt" instead of "current vt" > > libweston/launcher-direct.c| 12 > libweston/launcher-impl.h

Re: [PATCH weston v2] (multiple): Use standard permission notice

2017-02-07 Thread Daniel Stone
Hi, On 7 February 2017 at 13:56, Pekka Paalanen wrote: > I believe all the Collabora copyrighted code is ok for the change, and > I would not expect anyone of the other copyright holders to complain > since we already did the same fix in 2015, and IIRC it wasn't necessary > then to ask all copyri

Re: [PATCH weston v2] (multiple): Use standard permission notice

2017-02-07 Thread Pekka Paalanen
On Mon, 23 Jan 2017 06:17:44 -0800 Yong Bakos wrote: > From: Yong Bakos > > A handful of source files were not using the MIT Expat text in > COPYING. Update these files to bring them inline with the rest, > standardizing on the MIT Expat text. > > Signed-off-by: Yong Bakos > --- > > v2: Add

Re: [PATCH weston v2] ivi-shell: Damage view below after unmapping

2017-02-07 Thread Pekka Paalanen
On Tue, 7 Feb 2017 12:55:59 + "Ucan, Emre (ADITG/SW1)" wrote: > If ivilayer or ivisurf of ivi_view is made invisible in the > commit_changes call, we have to damage the weston_view below this > ivi_view. Otherwise content of this ivi_view will stay visible. > > Signed-off-by: Emre Ucan > --

Re: [PATCH weston] ivi-shell: add screen_remove_layer API

2017-02-07 Thread Pekka Paalanen
On Tue, 7 Feb 2017 12:28:45 + "Ucan, Emre (ADITG/SW1)" wrote: > Hi Pekka, > > > -Original Message- > > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > > Sent: Montag, 6. Februar 2017 13:47 > > To: Ucan, Emre (ADITG/SW1) > > Cc: wayland-devel@lists.freedesktop.org > > Subject: Re:

[PATCH weston v2] ivi-shell: Damage view below after unmapping

2017-02-07 Thread Ucan, Emre (ADITG/SW1)
If ivilayer or ivisurf of ivi_view is made invisible in the commit_changes call, we have to damage the weston_view below this ivi_view. Otherwise content of this ivi_view will stay visible. Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout.c | 13 - 1 file changed, 12 insertions(+)

RE: [PATCH weston v2] ivi-shell: add screen_remove_layer API

2017-02-07 Thread Ucan, Emre (ADITG/SW1)
Hi, My bad I will fix it. Best regards Emre Ucan Software Group I (ADITG/SW1) Tel. +49 5121 49 6937 > -Original Message- > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > Sent: Montag, 6. Februar 2017 11:19 > To: Ucan, Emre (ADITG/SW1) > Cc: wayland-devel@lists.freedesktop.org > Su

Re: [PATCH weston 7/7] compositor: damage pending subsurfaces when committing them

2017-02-07 Thread Pekka Paalanen
On Wed, 1 Feb 2017 11:47:06 -0500 Micah Fedke wrote: > On 01/27/2017 04:30 AM, Emilio Pozuelo Monfort wrote: > > When a client changes the subsurfaces state, we need to damage > > them so the result is visible. We do that by flagging the surfaces > > when the state changes and causing damage when

RE: [PATCH weston] ivi-shell: add screen_remove_layer API

2017-02-07 Thread Ucan, Emre (ADITG/SW1)
Hi Pekka, > -Original Message- > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > Sent: Montag, 6. Februar 2017 13:47 > To: Ucan, Emre (ADITG/SW1) > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: [PATCH weston] ivi-shell: add screen_remove_layer API > > On Mon, 30 Jan 2017 14:4

Re: [PATCH weston 4/7] tests: implement get_test_name()

2017-02-07 Thread Quentin Glidic
On 07/02/2017 12:34, Pekka Paalanen wrote: On Tue, 7 Feb 2017 11:39:38 +0100 Quentin Glidic wrote: On 27/01/2017 17:30, Emilio Pozuelo Monfort wrote: From: Pekka Paalanen Screenshot tests often want to use the test name for writing out images. This is a helper to get the test name without w

Re: [PATCH weston 6/7] tests: add subsurface-shot test

2017-02-07 Thread Pekka Paalanen
On Tue, 7 Feb 2017 12:14:03 +0100 Quentin Glidic wrote: > On 27/01/2017 17:30, Emilio Pozuelo Monfort wrote: > > From: Pekka Paalanen > > > > This is marked as a FAIL_TEST, because the last image comparison fails > > due to a bug in Weston. > > > > Jointly authored by Pekka and Emilio. > > >

Re: [PATCH weston 4/7] tests: implement get_test_name()

2017-02-07 Thread Pekka Paalanen
On Tue, 7 Feb 2017 11:39:38 +0100 Quentin Glidic wrote: > On 27/01/2017 17:30, Emilio Pozuelo Monfort wrote: > > From: Pekka Paalanen > > > > Screenshot tests often want to use the test name for writing out images. > > This is a helper to get the test name without writing it multiple times > >

Re: [PATCH weston 6/7] tests: add subsurface-shot test

2017-02-07 Thread Quentin Glidic
On 27/01/2017 17:30, Emilio Pozuelo Monfort wrote: From: Pekka Paalanen This is marked as a FAIL_TEST, because the last image comparison fails due to a bug in Weston. Jointly authored by Pekka and Emilio. Signed-off-by: Pekka Paalanen Signed-off-by: Emilio Pozuelo Monfort A few comments i

Re: [PATCH weston 5/7] tests: put screenshots to ./logs by default

2017-02-07 Thread Quentin Glidic
On 27/01/2017 17:30, Emilio Pozuelo Monfort wrote: From: Pekka Paalanen Logs is where we write all our custom test logs, let's also put the screenshots in the same place by default from cluttering the base directory. Signed-off-by: Pekka Paalanen Reviewed-by: Emilio Pozuelo Monfort Not sur

Re: [PATCH weston 4/7] tests: implement get_test_name()

2017-02-07 Thread Quentin Glidic
On 27/01/2017 17:30, Emilio Pozuelo Monfort wrote: From: Pekka Paalanen Screenshot tests often want to use the test name for writing out images. This is a helper to get the test name without writing it multiple times in the source. Signed-off-by: Pekka Paalanen Reviewed-by: Emilio Pozuelo Mon

Re: [PATCH weston 3/7] tests/shell: change background color

2017-02-07 Thread Quentin Glidic
On 27/01/2017 17:30, Emilio Pozuelo Monfort wrote: From: Pekka Paalanen Pick the color 0xCC336699 as AARRGGBB, as if blended on black. This is the color used with developing the sub-surface shot tests. No other big reason than it should not be black to have better chances of catching blending

Re: [PATCH weston 2/7] tests/shell: get rid of static variables

2017-02-07 Thread Quentin Glidic
On 27/01/2017 17:30, Emilio Pozuelo Monfort wrote: From: Pekka Paalanen Stop using static variables and clean up when we're done. [Emilio: update to latest weston_layer API] Signed-off-by: Pekka Paalanen Signed-off-by: Emilio Pozuelo Monfort Nice: Reviewed-by: Quentin Glidic Thanks,

Re: [PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

2017-02-07 Thread Pekka Paalanen
On Mon, 6 Feb 2017 12:57:41 -0500 Micah Fedke wrote: > The v4l2 API can be queried to detect if the input video image is > horizontally or vertically flipped. If the image is y-flipped, we can > set the ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT flag to notify the > compositor. If the image is h

Re: [PATCH weston 1/2] compositor-drm: update connectors with connector config

2017-02-07 Thread Pekka Paalanen
On Tue, 7 Feb 2017 08:36:59 + "Ucan, Emre (ADITG/SW1)" wrote: > Hi, > > I would not mind if connector option is removed in next release. > I found the issue while I was debugging my hotplug patches for ivi-shell. > > But I also agree with Daniel that my patches are legitimate bugfixes. > We

RE: [PATCH weston 1/2] compositor-drm: update connectors with connector config

2017-02-07 Thread Ucan, Emre (ADITG/SW1)
Hi, I would not mind if connector option is removed in next release. I found the issue while I was debugging my hotplug patches for ivi-shell. But I also agree with Daniel that my patches are legitimate bugfixes. We can merge them this release and remove the option altogether in next release. Be

Re: [PATCH] [weston, v4] weston.ini: Add natural scroll support to weston.ini This adds support for enabling/disabling natural scrolling via a boolean in weston.ini:

2017-02-07 Thread Pekka Paalanen
On Tue, 7 Feb 2017 11:00:03 +1000 Peter Hutterer wrote: > On Mon, Feb 06, 2017 at 12:00:08PM +0200, Pekka Paalanen wrote: > > On Mon, 6 Feb 2017 10:36:56 +1000 > > Peter Hutterer wrote: > > > > > On Sun, Feb 05, 2017 at 07:30:18PM -0500, Jiayi Zhao wrote: > > > > ​​ > > > > Hmmm, after usin