Re: [PATCH wayland 7/9] client: Simplify some logic in queue_event

2017-04-12 Thread Bryce Harrington
On Fri, Apr 07, 2017 at 03:27:53PM -0500, Derek Foreman wrote: > Both the blocks in this if/else clause do the same thing, so combine > the comparisons into one. > > No functional change. > > Signed-off-by: Derek Foreman Reviewed-by: Bryce Harrington

Re: [PATCH wayland 8/9] client: Replace the singleton zombie with bespoke zombies

2017-04-12 Thread Derek Foreman
On 12/04/17 09:07 AM, Pekka Paalanen wrote: On Wed, 12 Apr 2017 11:53:02 +0800 Jonas Ådahl wrote: On Tue, Apr 11, 2017 at 10:37:28AM -0500, Derek Foreman wrote: On 07/04/17 03:27 PM, Derek Foreman wrote: Using the singleton zombie object doesn't allow us to posthumously

Re: [PATCH weston v10 21/61] compositor-drm: Track all plane types

2017-04-12 Thread Pekka Paalanen
On Tue, 4 Apr 2017 17:54:39 +0100 Daniel Stone wrote: > Retain drm_plane tracking objects for all actual DRM planes when using > universal planes, not just overlay planes. Rename uses of 'sprite' to > 'plane' to make it clear that it can now be any kind of plane, not just

Re: [PATCH wayland 8/9] client: Replace the singleton zombie with bespoke zombies

2017-04-12 Thread Pekka Paalanen
On Wed, 12 Apr 2017 11:53:02 +0800 Jonas Ådahl wrote: > On Tue, Apr 11, 2017 at 10:37:28AM -0500, Derek Foreman wrote: > > On 07/04/17 03:27 PM, Derek Foreman wrote: > > > Using the singleton zombie object doesn't allow us to posthumously retain > > > object interface

Re: [PATCH] libweston: fix pixel-format helpers compilation on non-X11 EGL platforms

2017-04-12 Thread Daniel Stone
Hi Philipp, On 12 April 2017 at 14:32, Philipp Zabel wrote: > Since building libweston includes EGL/egl.h from pixel-formats.c, > EGL_CFLAGS must be added to libweston_CFLAGS, as on some platforms that > contains -DMESA_EGL_NO_X11_HEADERS, and fails to compile without it:

[PATCH] libweston: fix pixel-format helpers compilation on non-X11 EGL platforms

2017-04-12 Thread Philipp Zabel
Since building libweston includes EGL/egl.h from pixel-formats.c, EGL_CFLAGS must be added to libweston_CFLAGS, as on some platforms that contains -DMESA_EGL_NO_X11_HEADERS, and fails to compile without it: CC libweston/libweston_3_la-pixel-formats.lo In file included from

Re: [PATCH weston v10 20/61] compositor-drm: Add universal plane awareness

2017-04-12 Thread Pekka Paalanen
On Tue, 4 Apr 2017 17:54:38 +0100 Daniel Stone wrote: > From: Pekka Paalanen > > Add awareness of, rather than support for, universal planes. Activate > the client cap when we start if possible, and if this is activated, > studiously

Re: [PATCH weston 02/15] libweston: untangle weston_compositor_remove_output doc

2017-04-12 Thread Pekka Paalanen
On Wed, 12 Apr 2017 11:08:59 +0200 Armin Krezović wrote: > On 11.04.2017 14:49, Pekka Paalanen wrote: > > On Tue, 4 Apr 2017 21:30:04 +0200 > > Armin Krezović wrote: > > > >> On 04.04.2017 12:58, Pekka Paalanen wrote: > >>> From: Pekka

Re: [PATCH weston 02/15] libweston: untangle weston_compositor_remove_output doc

2017-04-12 Thread Armin Krezović
On 11.04.2017 14:49, Pekka Paalanen wrote: > On Tue, 4 Apr 2017 21:30:04 +0200 > Armin Krezović wrote: > >> On 04.04.2017 12:58, Pekka Paalanen wrote: >>> From: Pekka Paalanen >>> >>> Trying to make it more readable. Things that happen

Re: [PATCH 2/2 v3] Add keyboard shortcuts inhibitor

2017-04-12 Thread Jonas Ådahl
On Wed, Apr 05, 2017 at 02:30:15PM +0200, Olivier Fourdan wrote: > This adds a new protocol to let Wayland clients specify that they want > all keyboard events to be send to the client, regardless of the > compositor own shortcuts. > > This is for use by virtual machine and remote connections

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

2017-04-12 Thread Jonas Ådahl
On Wed, Mar 22, 2017 at 05:27:22PM +0100, Olivier Fourdan wrote: > This patch introduces a new protocol for grabbing the keyboard from > Xwayland. > > This is needed for X11 applications that map an override redirect window > (ths not focused by the window manager) and issue an active grab on the