Re: [PATCH weston 4/4] libweston-desktop/xdg-shell-v5: initialize configure list

2017-08-05 Thread Quentin Glidic
On 8/5/17 1:59 PM, Arnaud Vrac wrote: Without this weston crashes when a client using xdg-shell-v5 is run. Signed-off-by: Arnaud Vrac --- libweston-desktop/xdg-shell-v5.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libweston-desktop/xdg-shell-v5.c

Re: [PATCH weston 4/4] libweston-desktop/xdg-shell-v5: initialize configure list

2017-08-05 Thread Quentin Glidic
On 8/5/17 1:59 PM, Arnaud Vrac wrote: Without this weston crashes when a client using xdg-shell-v5 is run. Signed-off-by: Arnaud Vrac Oops. Good catch: Reviewed-by: Quentin Glidic Thanks, --- libweston-desktop/xdg-shell-v5.c | 2 ++ 1

Re: [PATCH weston 3/4] configure.ac: remove dependency on mtdev

2017-08-05 Thread Quentin Glidic
On 8/5/17 1:59 PM, Arnaud Vrac wrote: It's been unused since the legacy (non-libinput) input backends have been removed. Signed-off-by: Arnaud Vrac Sounds good: Reviewed-by: Quentin Glidic Thanks, --- configure.ac| 4 ++--

Re: [PATCH weston 1/4] gl-renderer: fix leak on dmabuf image destroy

2017-08-05 Thread Quentin Glidic
On 8/5/17 1:58 PM, Arnaud Vrac wrote: Signed-off-by: Arnaud Vrac --- libweston/gl-renderer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c index da29b072..5768f05a 100644 --- a/libweston/gl-renderer.c +++

Re: [PATCH weston 2/4] configure.ac: fix linking when using compiler sanitizers

2017-08-05 Thread Quentin Glidic
On 8/5/17 1:58 PM, Arnaud Vrac wrote: The GCC address sanitizer overrides dlopen and dlclose, so the configure test does not detect libdl as a needed dependency for linking. It is still needed though, as dlsym is not exported by the sanitizer. The result is that linking fails in the end. Fix

[PATCH weston 3/4] configure.ac: remove dependency on mtdev

2017-08-05 Thread Arnaud Vrac
It's been unused since the legacy (non-libinput) input backends have been removed. Signed-off-by: Arnaud Vrac --- configure.ac| 4 ++-- libweston/libinput-device.c | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac

[PATCH weston 2/4] configure.ac: fix linking when using compiler sanitizers

2017-08-05 Thread Arnaud Vrac
The GCC address sanitizer overrides dlopen and dlclose, so the configure test does not detect libdl as a needed dependency for linking. It is still needed though, as dlsym is not exported by the sanitizer. The result is that linking fails in the end. Fix this by checking for dlsym instead of

[PATCH weston 4/4] libweston-desktop/xdg-shell-v5: initialize configure list

2017-08-05 Thread Arnaud Vrac
Without this weston crashes when a client using xdg-shell-v5 is run. Signed-off-by: Arnaud Vrac --- libweston-desktop/xdg-shell-v5.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libweston-desktop/xdg-shell-v5.c b/libweston-desktop/xdg-shell-v5.c index

[PATCH weston 1/4] gl-renderer: fix leak on dmabuf image destroy

2017-08-05 Thread Arnaud Vrac
Signed-off-by: Arnaud Vrac --- libweston/gl-renderer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c index da29b072..5768f05a 100644 --- a/libweston/gl-renderer.c +++ b/libweston/gl-renderer.c @@ -337,6 +337,7 @@