[PATCH Weston] Load xkb map from file

2017-09-15 Thread Constantine Bytensky
I use my own keymap file on X.Org and I want to use it at Weston. compositor/main.c | 2 ++ libweston/compositor.h | 1 + libweston/input.c | 13 ++--- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/compositor/main.c b/compositor/main.c index f8a60e9..fccc741

Re: [PATCH] Add m1bpp (monochrome, 1 bit/pixel) pixel format

2017-09-15 Thread Eric Engestrom
On Friday, 2017-09-15 11:17:29 -0400, Drew DeVault wrote: > On 2017-09-15 6:06 PM, Pekka Paalanen wrote: > > Indeed, 2 and 4 bit formats are also missing, but 8 and 16 bit ones are > > already defined unless you meant some new variation. > > The 8 and 16 bit ones, so far as I can tell, are 8/16

Re: [PATCH] Add m1bpp (monochrome, 1 bit/pixel) pixel format

2017-09-15 Thread Pekka Paalanen
On Fri, 15 Sep 2017 11:17:29 -0400 Drew DeVault wrote: > On 2017-09-15 6:06 PM, Pekka Paalanen wrote: > > I ask about endianess, because Pixman has some fun pixel formats where > > endianess is defined to affect also the order of bits, not just bytes. > > This is such a

Re: [PATCH] Add m1bpp (monochrome, 1 bit/pixel) pixel format

2017-09-15 Thread Daniel Stone
Hi Drew, On 15 September 2017 at 16:21, Drew DeVault wrote: > On 2017-09-15 6:17 PM, Pekka Paalanen wrote: >> DRM is for driving any kind of display, GPU or not, acceleratable or >> not. What it gives us is a standard userspace ABI to poke all display >> devices with. >> >>

Re: [RFC wayland 1/9] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-09-15 Thread Daniel Stone
Hi Emil, On 15 September 2017 at 15:54, Emil Velikov wrote: > On 15 September 2017 at 14:50, Daniel Stone wrote: >> Currently the client-facing libwayland-egl API is defined by a header >> file shipped by Wayland, but the implementation is left to

Re: [PATCH] Add m1bpp (monochrome, 1 bit/pixel) pixel format

2017-09-15 Thread Drew DeVault
On 2017-09-15 6:17 PM, Pekka Paalanen wrote: > DRM is for driving any kind of display, GPU or not, acceleratable or > not. What it gives us is a standard userspace ABI to poke all display > devices with. > > There could be other reasons to not write a DRM driver, but "only for > GPU stuff" is

Re: [PATCH] Add m1bpp (monochrome, 1 bit/pixel) pixel format

2017-09-15 Thread Drew DeVault
On 2017-09-15 6:06 PM, Pekka Paalanen wrote: > I'm sure you knew this, but you don't need this protocol addition just > for driving the display. I guess you want this protocol addition so > that you can write clients that draw directly in the 1-bit format so > they don't waste 8x the memory

Re: [PATCH] Add m1bpp (monochrome, 1 bit/pixel) pixel format

2017-09-15 Thread Pekka Paalanen
On Fri, 15 Sep 2017 10:59:56 -0400 Drew DeVault wrote: > I missed this from your earlier email: > > >I believe that all the formats* are analogous to the ones used in the > >kernel, as defined in drm_fourcc.h. > >Is there such an equivalent, if not should one consider adding one

Re: [PATCH] Add m1bpp (monochrome, 1 bit/pixel) pixel format

2017-09-15 Thread Pekka Paalanen
On Fri, 15 Sep 2017 08:43:18 -0400 Drew DeVault wrote: > On 2017-09-15 1:41 PM, Emil Velikov wrote: > > Can you add some commit message where this format is doing to be used, how? > > I'm not sure what Wayland devs' stance is on s-o-b line is, but I'd > > imagine they won't

Re: [PATCH] Add m1bpp (monochrome, 1 bit/pixel) pixel format

2017-09-15 Thread Drew DeVault
I missed this from your earlier email: >I believe that all the formats* are analogous to the ones used in the >kernel, as defined in drm_fourcc.h. >Is there such an equivalent, if not should one consider adding one first? Adding support for this screen in Linux is an interesting idea... but

Re: [RFC wayland 1/9] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-09-15 Thread Emil Velikov
Hi Dan, Thanks for the quick review/feedback. On 15 September 2017 at 14:50, Daniel Stone wrote: > Hi Emil, > > On 15 September 2017 at 11:29, Emil Velikov wrote: >> Currently we're in a bit of a pickle - both from vendor and user POV. > > This

Re: [PATCH wayland 1/4] scanner: use c99 initializers for the wl_interface * array

2017-09-15 Thread Pekka Paalanen
On Wed, 30 Aug 2017 16:33:15 +0100 Emil Velikov wrote: > On 30 August 2017 at 16:21, Emil Velikov wrote: > > From: Emil Velikov > > > > Allows us to remove the explicit NULL init, keeping the list shorter and > >

Re: [RFC wayland 1/9] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-09-15 Thread Daniel Stone
Hi Emil, On 15 September 2017 at 11:29, Emil Velikov wrote: > Currently we're in a bit of a pickle - both from vendor and user POV. This commit message is a bit long-winded. Could you please try to compress it down to something like: Currently the client-facing

Re: [PATCH] Add m1bpp (monochrome, 1 bit/pixel) pixel format

2017-09-15 Thread Drew DeVault
On 2017-09-15 1:41 PM, Emil Velikov wrote: > Can you add some commit message where this format is doing to be used, how? > I'm not sure what Wayland devs' stance is on s-o-b line is, but I'd > imagine they won't object to it. Sure! I'm doing some hacking on the ZeroPhone[1], which has a 128x64

Re: [PATCH] Add m1bpp (monochrome, 1 bit/pixel) pixel format

2017-09-15 Thread Emil Velikov
Hi Drew, Can you add some commit message where this format is doing to be used, how? I'm not sure what Wayland devs' stance is on s-o-b line is, but I'd imagine they won't object to it. On 14 September 2017 at 21:08, Drew DeVault wrote: > --- > This patch is pretty

Re: [PATCH weston 3/3] gl-renderer: Emit GPU rendering begin and end timeline timepoints

2017-09-15 Thread Daniel Stone
On 15 September 2017 at 12:39, Pekka Paalanen wrote: > I am not familiar yet with the fence/sync APIs so I cannot review their > usage at this time. I do review all the Weston parts. I walked through it the other night, and the fence bits at least are: Reviewed-by: Daniel

Re: [PATCH weston 3/3] gl-renderer: Emit GPU rendering begin and end timeline timepoints

2017-09-15 Thread Pekka Paalanen
On Thu, 14 Sep 2017 14:07:35 +0300 Alexandros Frantzis wrote: > Use EGL fence sync objects to emit timepoints for the beginning and the > end of rendering on the GPU. The timepoints are emitted asynchronously > using the sync file fds associated with the fence

Re: [RFC wayland 0/9] Introduce/import wayland-egl frontend library

2017-09-15 Thread Pekka Paalanen
On Fri, 15 Sep 2017 11:29:18 +0100 Emil Velikov wrote: > Hi all, > > Some of you may know, but there's been a few interesting predicaments > with wayland-egl. One of which is - vendors have been assuming that the > wayland-egl in mesa has a stable backend ABI... > >

[RFC wayland 5/9] build: wire-up wayland-egl

2017-09-15 Thread Emil Velikov
From: Emil Velikov Wire-up the imported sources, test and pkg-config files. Signed-off-by: Emil Velikov --- Makefile.am | 18 +- configure.ac | 2 ++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git

[RFC wayland 7/9] wayland-egl: forward declare struct wl_surface

2017-09-15 Thread Emil Velikov
From: Emil Velikov It makes the header self-contained and with next commit we'll remove the unnessesary wayland-client.h include. Signed-off-by: Emil Velikov --- egl/wayland-egl-priv.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[RFC wayland 9/9] wayland-egl: remove no longer needed wayland-client.h include

2017-09-15 Thread Emil Velikov
From: Emil Velikov Was used for wl_surface, which is opaque and forward declared with earlier patch. Signed-off-by: Emil Velikov --- egl/wayland-egl-priv.h | 1 - egl/wayland-egl.c | 1 - 2 files changed, 2 deletions(-) diff --git

[RFC wayland 8/9] wayland-egl: add stdint.h include for intptr_t

2017-09-15 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- egl/wayland-egl-priv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/egl/wayland-egl-priv.h b/egl/wayland-egl-priv.h index ada5226..9e56fbe 100644 --- a/egl/wayland-egl-priv.h +++

[RFC wayland 6/9] wayland-egl: move the wayland-egl{, -core}.h headers to egl/

2017-09-15 Thread Emil Velikov
From: Emil Velikov Now we have all the wayland-egl stuff in one place. Signed-off-by: Emil Velikov --- Makefile.am | 5 +++-- {src => egl}/wayland-egl-core.h | 0 {src => egl}/wayland-egl.h | 0 3 files changed,

[RFC wayland 1/9] wayland-egl: import libwayland-egl.so frontend library from Mesa

2017-09-15 Thread Emil Velikov
From: Emil Velikov Currently we're in a bit of a pickle - both from vendor and user POV. - User: The wayland repository defines the wayland-egl interface. At the same time, it leaves the actual implementation (DSO) and ways to manage both files (wayland-egl.pc) to

[RFC wayland 4/9] wayland-egl: add a note about keeping the backend version in sync

2017-09-15 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- egl/wayland-egl-priv.h | 4 1 file changed, 4 insertions(+) diff --git a/egl/wayland-egl-priv.h b/egl/wayland-egl-priv.h index 3b59908..2b4ed36 100644 --- a/egl/wayland-egl-priv.h

[RFC wayland 2/9] wayland-egl: correct wayland-egl.pc description/version

2017-09-15 Thread Emil Velikov
From: Emil Velikov Drop the "Mesa" part from the commit message and change the version to XXX. The number is based on the following users (and suppliers). Note: the "users" list was pulled from Ubuntu 17.04. Providers: - Mali: 7.10 - Mesa: 17.2.1 Users: -

[RFC wayland 3/9] wayland-egl: introduce wayland-egl-backend.pc

2017-09-15 Thread Emil Velikov
From: Emil Velikov File will be installed alongside the backend header. This way Vendor implementations have enough information about the interface and they can build their backend/driver library accordingly. Cc: Miguel A. Vico Cc: James Jones

[RFC wayland 0/9] Introduce/import wayland-egl frontend library

2017-09-15 Thread Emil Velikov
Hi all, Some of you may know, but there's been a few interesting predicaments with wayland-egl. One of which is - vendors have been assuming that the wayland-egl in mesa has a stable backend ABI... With that one resolved (props to Miguel from NVIDIA), Daniel suggested that we might want to have

Re: [PATCH weston 2/3] gl-renderer: Add support for fence sync extensions

2017-09-15 Thread Pekka Paalanen
On Thu, 14 Sep 2017 13:16:17 +0100 Emil Velikov wrote: > Hi Alexandros, > > On 14 September 2017 at 12:07, Alexandros Frantzis > wrote: > > Check for the EGL_KHR_fence_sync and EGL_ANDROID_native_fence_sync > > extensions and get

Re: [PATCH weston 1/3] timeline: Add GPU timestamp timepoint argument

2017-09-15 Thread Pekka Paalanen
On Thu, 14 Sep 2017 14:07:33 +0300 Alexandros Frantzis wrote: > The purpose of this argument is to hold timestamp information about > events that occurred on the GPU. > --- > libweston/timeline.c | 12 > libweston/timeline.h | 2 ++ > 2 files

[PATCH weston] desktop-shell: use binding_modifier for zoom

2017-09-15 Thread Ian Ray
Support for kiosk-style use cases where binding modififer is `none': - Use binding modifier instead of hard-coded MODIFIER_SUPER for zoom. - Disable opacity zoom if there is no binding modifier. Signed-off-by: Ian Ray --- desktop-shell/shell.c | 16 ++-- 1 file