Re: [PATCH weston] libweston-desktop/xdg-shell-v6: Actually send same-as-current configure if needed

On Tue, Oct 17, 2017 at 04:18:51PM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > If a surface is in state A, and we just sent a configure for state B, > setting back state A would be ignored, because state B has not been > committed yet. > Since we only

[PATCH weston] libweston-desktop/xdg-shell-v6: Actually send same-as-current configure if needed

From: Quentin Glidic If a surface is in state A, and we just sent a configure for state B, setting back state A would be ignored, because state B has not been committed yet. Since we only send a configure event if the state was different, consider pending as

Re: [PATCH weston 8/14] ivi-shell: added libweston-desktop-api implementation

Hi, I will limit my review to the libweston-desktop usage, as it’s the only part I know. On 10/17/17 11:59 AM, Michael Teyfel wrote: Signed-off-by: Michael Teyfel --- ivi-shell/ivi-shell.c | 172 ++ 1 file changed,

RE: [PATCH weston 00/14] Desktop Protocol Support for IVI-Shell

Hi, I already reviewed the patches before Michael sent: Reviewed-by: Emre Ucan Best regards Emre Ucan Engineering Software Base (ADITG/ESB) Tel. +49 5121 49 6937 > -Original Message- > From: wayland-devel [mailto:wayland-devel- > boun...@lists.freedesktop.org]

[PATCH weston 5/14] ivi-layout: introduced configure_desktop_changed

Introduced signal configure_desktop_changed with interface. This signal should be sent, when a desktop-surface is configured. Signed-off-by: Michael Teyfel --- ivi-shell/ivi-layout-export.h | 10 ++ ivi-shell/ivi-layout-private.h | 1 + ivi-shell/ivi-layout.c

[PATCH weston 03/14] ivi-shell: introduction of IVI_INVALID_ID

Introduction of IVI_INVALID_ID for xdg-shell applications. Signed-off-by: Michael Teyfel --- ivi-shell/ivi-layout-export.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ivi-shell/ivi-layout-export.h b/ivi-shell/ivi-layout-export.h index 2317d6e..e1e897e 100644

[PATCH weston 04/14] layout-interface: added interface to change surface id

This interface enables an id-agent to change the surface ids of an ivi-layout-surface once. Signed-off-by: Michael Teyfel --- ivi-shell/ivi-layout-export.h | 6 ++ ivi-shell/ivi-layout.c| 39 +++ 2 files changed, 45

[PATCH weston 00/14] Desktop Protocol Support for IVI-Shell

Hello all, since some time I’m working on ivi-shell to add xdg-protocol support by means of libweston-desktop. Due to my changes both xdg-protocol applications and ivi-shell / ivi-application-protocol applications are supported within ivi-shell now. The known functionality is preserved and

[PATCH weston 01/14] ivi-shell: rework goto labels to avoid memory leaks

Signed-off-by: Michael Teyfel --- ivi-shell/ivi-shell.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi-shell.c index 67619b8..e9ddf9a 100644 --- a/ivi-shell/ivi-shell.c +++

[PATCH weston 02/14] ivi-shell: removed assert

Removed assert, that checks if ivi-surface is not available, since this can now happen with xdg-shell support. Signed-off-by: Michael Teyfel --- ivi-shell/ivi-shell.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi-shell.c index

[PATCH weston 11/14] hmi-controller: register for desktop_surface_configured

Since ivi-shell now supports xdg-protocol, the surface_created listener can be removed and the desktop_surface_configured listener is needed. ivi-layout: libweston-desktop api is used to send configure event to application. Signed-off-by: Michael Teyfel ---

[PATCH weston 12/14] simple-egl: remove ivi-application support

Signed-off-by: Michael Teyfel --- Makefile.am | 4 +-- clients/simple-egl.c | 86 2 files changed, 13 insertions(+), 77 deletions(-) diff --git a/Makefile.am b/Makefile.am index 23f79df..f9c8010 100644 ---

[PATCH weston 14/14] window client: remove ivi-application support

Signed-off-by: Michael Teyfel --- Makefile.am | 2 -- clients/window.c | 44 +--- 2 files changed, 1 insertion(+), 45 deletions(-) diff --git a/Makefile.am b/Makefile.am index c37cd00..f30ddbe 100644 --- a/Makefile.am +++

[PATCH weston 13/14] simple-shm: remove ivi-application support

Signed-off-by: Michael Teyfel --- Makefile.am | 4 +--- clients/simple-shm.c | 40 2 files changed, 1 insertion(+), 43 deletions(-) diff --git a/Makefile.am b/Makefile.am index f9c8010..c37cd00 100644 --- a/Makefile.am

[PATCH weston 10/14] ivi-shell: create weston_desktop in wet_shell_init

Signed-off-by: Michael Teyfel --- ivi-shell/ivi-shell.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi-shell.c index a634ab8..74aa60a 100644 --- a/ivi-shell/ivi-shell.c +++ b/ivi-shell/ivi-shell.c @@

[PATCH weston 8/14] ivi-shell: added libweston-desktop-api implementation

Signed-off-by: Michael Teyfel --- ivi-shell/ivi-shell.c | 172 ++ 1 file changed, 172 insertions(+) diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi-shell.c index 84db2c9..049aa43 100644 --- a/ivi-shell/ivi-shell.c +++

[PATCH weston 9/14] ivi-shell: remove surface_destroy_listener

Since the surface_destroy_listener is only registered for ivi-shell applications, it should only be removed for ivi-shell applications. Signed-off-by: Michael Teyfel --- ivi-shell/ivi-shell.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH weston 7/14] ivi-shell: linked libweston-desktop and added structs

Signed-off-by: Michael Teyfel --- Makefile.am| 1 + ivi-shell/ivi-layout-private.h | 2 ++ ivi-shell/ivi-shell.c | 4 +++- ivi-shell/ivi-shell.h | 2 ++ 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/Makefile.am

[PATCH weston 6/14] ivi-layout: introduced surface create and configure

Introduced surface create and configure function for xdg-apps. Signed-off-by: Michael Teyfel --- ivi-shell/ivi-layout-shell.h | 8 + ivi-shell/ivi-layout.c | 74 ++-- 2 files changed, 59 insertions(+), 23 deletions(-)