RE: [PATCH weston 00/14] Desktop Protocol Support for IVI-Shell

Hi Matt, Thank you for your support. It was our main motivation for these changes to be able to use existing programs/frameworks with ivi-shell. Because it is not feasible to upstream ivi-shell support for all these existing programs. From: wayland-devel

Re: [PATCH weston 00/14] Desktop Protocol Support for IVI-Shell

I'm not at all familiar with the internal implementation of ivi-shell, so I can't give much meaningful review. But I am very much in favor of this patch series. Without wl_shell and xdg_shell support, I've never been able to really give ivi-shell serious consideration on my products. The ability

Re: Automatically choosing a VT for DRM compositor?

On Tue, Oct 24, 2017 at 1:33 AM, Pekka Paalanen wrote: > On Mon, 23 Oct 2017 14:37:37 -0500 > Matt Hoosier wrote: > >> It would be nice for non-session uses of Weston (embedded systems) if >> the controlling TTY didn't need to be manually supplied. >>

Re: [PATCH weston 00/10] wayland-backend fixes

Hi, On 24 October 2017 at 11:31, Quentin Glidic wrote: > On 10/24/17 12:15 PM, Pekka Paalanen wrote: >> From: Pekka Paalanen >> as part of my clone mode work[1] I obviously should test that I don't >> regress >> the backends. The

Re: [PATCH weston 00/10] wayland-backend fixes

On 10/24/17 12:15 PM, Pekka Paalanen wrote: From: Pekka Paalanen Hi, as part of my clone mode work[1] I obviously should test that I don't regress the backends. The Wayland backend made regression testing hard by being already broken in many ways. Here is a

[PATCH weston 10/10] compositor-wayland: fix shm_buffer damage init

From: Pekka Paalanen It appears that wayland_shm_buffer::damage is in the global coordinate space. Therefore initializing it to width x height at 0,0 is not correct for any output not positioned at 0,0. That is, all outputs after the first one get it wrong.

[PATCH weston 09/10] compositor-wayland: fix damage coordinates with pixman renderer

From: Armin Krezović Damage coordinates are in global coordinate space, and they need to be translated to local coordinate space so multiple outputs can work. This path now matches the similar path in the X11 backend. This patch fixes the appearance of multiple

[PATCH weston 08/10] compositor-wayland: clarify wl_display_connect() error

From: Pekka Paalanen Clarify the error message to explicitly say one was trying to connect to a parent Wayland compositor. This hopefully is a good enough hint on what using the wayland-backend is trying to do. Add the command line display option value and

[PATCH weston 07/10] compositor-wayland: windowed/fullscreen not on fullscreen-shell

From: Pekka Paalanen The set_windowed and set_fullscreen functions are only useful on a desktop shell, and never called on fullscreen-shell. Remove the confusing dead code, and ensure we notice if these functions get called in the wrong environment.

[PATCH weston 03/10] compositor-wayland: remove unused 'scale'

From: Pekka Paalanen This member is only ever set and never read, therefore it is dead. Delete dead code. Signed-off-by: Pekka Paalanen --- libweston/compositor-wayland.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH weston 01/10] weston: fix boolean wayland backend options

From: Pekka Paalanen Surprisingly, WESTON_OPTION_BOOLEAN uses the type int32_t, not bool. Passing in a pointer bool does not end well. Fix this to pass in pointers as parse_options() expects. This fixes a bug where 'weston --use-pixman --sprawl' would work but

[PATCH weston 04/10] compositor-wayland: fix mode_list corruption on --sprawl

From: Pekka Paalanen The wayland-backend with --sprawl is one way to trigger wayland_output_create_for_parent_output(), which intends to find a mode from the parent mode list and use it. Calling wayland_output_set_size() initialized an embedded struct weston_mode

[PATCH weston 06/10] compositor-wayland: allow to unset fullscreen

From: Pekka Paalanen To be more symmetric with wayland_output_set_fullscreen(), implement the xdg-shell path in wayland_output_set_windowed(). This should make it possible to use the fullscreen key binding to toggle between a floating window and fullscreen also

[PATCH weston 00/10] wayland-backend fixes

From: Pekka Paalanen Hi, as part of my clone mode work[1] I obviously should test that I don't regress the backends. The Wayland backend made regression testing hard by being already broken in many ways. Here is a series to fix the issues I found. The series can

[PATCH weston 02/10] compositor-wayland: avoid recursive dispatch with wl_outputs

From: Pekka Paalanen Calling wl_display_roundtrip() from within a Wayland event handler means we will re-enter event dispatch, that is, it will lead to recursive dispatch. Even if libwayland-client was safe, this would lead to unexpected code paths: the first

[PATCH weston 05/10] compositor-wayland: actually free parent_output

From: Pekka Paalanen I could not find anywhere where struct parent_output was freed, so apparently we were leaking it. Check against wayland_backend_register_output() and add the missing clean-up: removal from the parent output list, and free().

Re: Automatically choosing a VT for DRM compositor?

GDM seems to use VT_OPENQRY . https://git.gnome.org/browse/gdm/tree/daemon/gdm-session-worker.c#n2209 (Sent from gmail web interface) On Tue, Oct 24, 2017 at 8:33 AM, Pekka Paalanen wrote: > On Mon, 23 Oct 2017 14:37:37 -0500 > Matt Hoosier wrote:

Re: [PATCH] compositor-wayland: Use correct damage coordinates for pixman backend

On Mon, 23 Oct 2017 16:10:01 +0200 Armin Krezović wrote: > Damage coordinates are in global coordinate space, and they need to > be translated to local coordinate space so multiple outputs can work. > --- > libweston/compositor-wayland.c | 6 +- > 1 file changed, 5

Re: Automatically choosing a VT for DRM compositor?

On Mon, 23 Oct 2017 14:37:37 -0500 Matt Hoosier wrote: > It would be nice for non-session uses of Weston (embedded systems) if > the controlling TTY didn't need to be manually supplied. > > Has anybody suggested using something like VT_OPENQRY in the > weston-launcher