Re: Wayland talk at FOSDEM

On Tue, 05 Dec 2017 16:46:41 +0200 Philipp Kerling wrote: > Hey everyone, > > I've been thinking about submitting a Wayland-themed talk to the FOSDEM > graphics devroom [1] and wanted to check with the community if anyone > else has considered this or another Wayland topic

Building Wayland/weston with a LFS/BLFS minimum packagelist?

Sorry, but i've read a lot of pages on your site and the git repositories and can't find an answer or hint of one anywhere. Does someone have a minimum packageset/packagelist needed, anywhere in their files to build the Linux that Wayland/Weston sits on top of, I'm looking at building the

[PATCH wayland v3 09/10] tests: Add a test for fd leaks on zombie objects

Until recently, if a client destroying a resource raced with the server generating an event on that resource that delivered a file descriptor, we would leak the fd. This tests for a leaked fd from that race condition. Reviewed-by: Daniel Stone Signed-off-by: Derek Foreman

[PATCH wayland v3 10/10] tests: Check for wrong fd delivery with zombie objects

Until recently, if an event attempting to deliver an fd to a zombie object was demarshalled after the object was made into a zombie, we leaked the fd and left it in the buffer. If another event attempting to deliver an fd to a live object was in that same buffer, the zombie's fd would be

[PATCH wayland v3 00/10] Stop leaking file descriptors

New edition of my patch series to stop leaking file descriptors on failed marshal/demarshal, and to fix the long standing bug where an fd destined for a zombie isn't properly consumed on the client side, potentially resulting in the leaked fd being passed in another event in the same buffer.

[PATCH wayland v3 05/10] connection: Make wl_closure_destroy() close fds of undispatched closures

When we have a closure that can't be dispatched for some reason, and it contains file descriptors, we must close those descriptors to prevent leaking them. Signed-off-by: Derek Foreman --- src/connection.c | 21 + 1 file changed, 21 insertions(+)

[PATCH wayland v3 07/10] client: Replace the singleton zombie with bespoke zombies

Using the singleton zombie object doesn't allow us to posthumously retain object interface information, which makes it difficult to properly inter future events destined for the recently deceased proxy. Notably, this makes it impossible for zombie proxy destined file descriptors to be properly

[PATCH wayland v3 06/10] util: Pass flags to map iterators

On the client side we're going to need to know if an object from the map is a zombie before we attempt to dereference it, so we need to pass this to the iterator. Reviewed-by: Daniel Stone Signed-off-by: Derek Foreman --- src/wayland-private.h |

[PATCH wayland v3 03/10] connection: Refactor out closure allocation

Moves the common/similar bits into one place. This has a minor functional change - count and message are now initialized immediately, previously they'd only be set if (de)marshal was successful. Signed-off-by: Derek Foreman --- src/connection.c | 71

[PATCH wayland v3 08/10] client: Consume file descriptors destined for zombie proxies

We need to close file descriptors sent to zombie proxies to avoid leaking them, and perhaps more importantly, to prevent them from being dispatched in events on other objects (since they would previously be left in the buffer and potentially fed to following events destined for live proxies)

[PATCH wayland v3 04/10] connection: Clear fds we shouldn't close to -1

This initializes all the fd arguments in closures to -1 and clears them back to -1 when they've been dispatched or serialized. This means that any valid fd in a closure is currently libwayland's responsibility to close in the case of an error. Signed-off-by: Derek Foreman

[PATCH wayland v3 02/10] server: Log closure before sending it

This seems foolishly cosmetic on the surface - and will reorder log messages in certain failure cases. "request could not be marshalled" will now appear after logging the request that failed to marshal instead of before. The real point of this is that a follow up patch will make

[PATCH wayland v3 01/10] connection: Don't declare a local variable just to takes its size

We can sizeof the struct type instead of declaring a pointer and taking the size of what it points to. Signed-off-by: Derek Foreman --- src/connection.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/connection.c b/src/connection.c index

Re: [RFC PATCH xserver] xwayland: Fix non-argb cursor conversion

On Tue, 2017-12-05 at 10:51 +, Daniel Stone wrote: > On 27 September 2017 at 17:01, Olivier Fourdan > wrote: > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=103012 > > Signed-off-by: Olivier Fourdan > > Reviewed-by: Daniel Stone

Re: [PATCH weston 1/2] config-parser: fix `short_name` type

On Tuesday, 2017-12-05 13:47:06 +, Daniel Stone wrote: > Hi Eric, > > On 8 June 2017 at 22:20, Eric Engestrom wrote: > > On Wednesday, 2017-05-24 21:23:14 +0100, Eric Engestrom wrote: > >> This field is populated with chars, compared to chars and printed as > >> a