Re: [PATCH 3/5] scanner: introduce --object-type option

2018-01-25 Thread Jonas Ådahl
On Thu, Jan 25, 2018 at 05:56:45PM +, Emil Velikov wrote: > On 25 January 2018 at 02:01, Jonas Ådahl wrote: > > On Wed, Jan 24, 2018 at 07:15:09PM +, Emil Velikov wrote: > >> On 24 January 2018 at 18:20, Derek Foreman wrote: > >> > On 2018-01-22

RE: [PATCH weston] RFC: libweston/compositor-drm: Add support for drm-lease.

2018-01-25 Thread Marius-cristian Vlad
-Original Message- From: Pekka Paalanen [mailto:pekka.paala...@collabora.co.uk] Sent: Thursday, January 25, 2018 2:06 PM To: Daniel Stone Cc: Marius-cristian Vlad ; Keith Packard ;

Re: [PATCH 3/5] scanner: introduce --object-type option

2018-01-25 Thread Emil Velikov
On 25 January 2018 at 02:01, Jonas Ådahl wrote: > On Wed, Jan 24, 2018 at 07:15:09PM +, Emil Velikov wrote: >> On 24 January 2018 at 18:20, Derek Foreman wrote: >> > On 2018-01-22 09:30 AM, Emil Velikov wrote: >> >> >> >> On 22 August 2017 at 14:02,

Re: [PATCH xserver] xwayland: remove dirty window unconditionally on unrealize

2018-01-25 Thread Adam Jackson
On Thu, 2018-01-25 at 12:52 +, Daniel Stone wrote: > Hi Olivier, > > On 24 January 2018 at 16:45, Olivier Fourdan wrote: > > Signed-off-by: Olivier Fourdan > > This is also: > Reviewed-by: Daniel Stone Merged both: remote:

Re: [systemd-devel] [PATCH weston] doc/systemd: system service example

2018-01-25 Thread Matt Hoosier
On Mon, Jan 22, 2018 at 7:49 AM, Pekka Paalanen wrote: > On Fri, 29 Dec 2017 15:09:28 -0600 > Matt Hoosier wrote: > >> Hi Lennart, >> >> On Mon, Dec 4, 2017 at 9:11 AM, Pekka Paalanen wrote: >> > On Fri, 1 Dec 2017 18:25:35 +0100

[PATCH weston v2 6/6] ivi-shell: remove ivi_shell_setting

2018-01-25 Thread Emre Ucan
it has only developermode option parameter. The parameter is only used in init_ivi_shell. Therefore, we can basically remove the struct, and check the option locally in the function. Signed-off-by: Emre Ucan Reviewed-by: Pekka Paalanen ---

[PATCH weston v2 1/6] ivi-shell: register ivi_layout_interface

2018-01-25 Thread Emre Ucan
Signed-off-by: Emre Ucan Acked-by: Pekka Paalanen --- ivi-shell/ivi-layout-export.h | 13 + ivi-shell/ivi-layout.c| 6 ++ ivi-shell/ivi-shell.c | 2 -- 3 files changed, 19 insertions(+), 2 deletions(-) diff

[PATCH weston v2 5/6] ivi-shell: don't load controller modules

2018-01-25 Thread Emre Ucan
controller modules can be loaded as weston modules from the main function of weston. Signed-off-by: Emre Ucan Reviewed-by: Pekka Paalanen --- ivi-shell/ivi-layout.c | 40 ivi-shell/ivi-shell.c | 28

[PATCH weston v2 4/6] tests: load ivi-shell test plugins as weston module

2018-01-25 Thread Emre Ucan
It is better to load ivi controller modules as a generic weston module. Then, we do not need to have a specific ivi way of loading modules. Signed-off-by: Emre Ucan --- tests/ivi_layout-internal-test.c | 21 - tests/ivi_layout-test-plugin.c | 20

[PATCH weston v2 3/6] hmi-controller: load as weston module

2018-01-25 Thread Emre Ucan
weston loads hmi-controller as a weston module. IVI-shell does not need to load it explicitly. Signed-off-by: Emre Ucan Reviewed-by: Pekka Paalanen --- ivi-shell/hmi-controller.c | 36

[PATCH weston v2 2/6] hmi-controller: remove ivi_layout_interface global

2018-01-25 Thread Emre Ucan
Put the interface into hmi_controller struct. It is better to have it in an object. Signed-off-by: Emre Ucan Reviewed-by: Pekka Paalanen --- ivi-shell/hmi-controller.c | 194 +++-- 1 file changed, 100

RE: [PATCH weston 4/6] tests: load ivi-shell test plugins as weston module

2018-01-25 Thread Ucan, Emre (ADITG/ESB)
Hi Pekka, > -Original Message- > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > Sent: Montag, 22. Januar 2018 13:31 > To: Ucan, Emre (ADITG/ESB) > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: [PATCH weston 4/6] tests: load ivi-shell test plugins as weston > module > > On

RE: [PATCH weston 3/6] hmi-controller: load as weston module

2018-01-25 Thread Ucan, Emre (ADITG/ESB)
Hi, > -Original Message- > From: wayland-devel [mailto:wayland-devel- > boun...@lists.freedesktop.org] On Behalf Of Pekka Paalanen > Sent: Montag, 22. Januar 2018 13:29 > To: Ucan, Emre (ADITG/ESB) > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: [PATCH weston 3/6] hmi-controller:

RE: [PATCH weston 1/6] ivi-shell: register ivi_layout_interface

2018-01-25 Thread Ucan, Emre (ADITG/ESB)
> -Original Message- > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > Sent: Montag, 22. Januar 2018 13:28 > To: Ucan, Emre (ADITG/ESB) > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: [PATCH weston 1/6] ivi-shell: register ivi_layout_interface > > On Wed, 3 Jan 2018 16:09:16

Re: [PATCH xserver] xwayland: remove dirty window unconditionally on unrealize

2018-01-25 Thread Daniel Stone
Hi Olivier, On 24 January 2018 at 16:45, Olivier Fourdan wrote: > This is a rare occurrence of a crash in Xwayland for which I don't have > the reproducing steps, just a core file. > > The backtrace looks as follow: > [...] > > The crash is caused by dereferencing

[PATCH xserver] xwayland: place a manual redirect on windows

2018-01-25 Thread Olivier Fourdan
Place a manual redirect on windows on xwl_realize_window() and remove it on xwl_unrealize_window() to avoid the X11 window manager removing its redirect before Xwayland has unrealized the window (e.g. if the X11 window manager has terminated unexpectedly) Suggested by Daniel Stone

Re: [PATCH v14 26/41] compositor-drm: Remove no_addfb2 handling

2018-01-25 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:43 + Daniel Stone wrote: > If AddFB2 ever fails for any reason, we fall back to legacy AddFB, which > doesn't support the same swathe of formats, or multi-planar formats, or > modifiers. > > This can happen with arbitrary client buffers,

Re: [PATCH weston] RFC: libweston/compositor-drm: Add support for drm-lease.

2018-01-25 Thread Pekka Paalanen
On Thu, 25 Jan 2018 11:33:34 + Daniel Stone wrote: > Hi Marius, > > On 25 January 2018 at 11:10, Marius-cristian Vlad > wrote: > > >> + wl_signal_emit(>wake_signal, > > >> compositor); > > >> +

Re: [PATCH v14 24/41] compositor-drm: Extract overlay FB import to helper

2018-01-25 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:41 + Daniel Stone wrote: > ... in order to be able to use it from scanout as well. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 221 > - > 1 file

Re: [PATCH v14 25/41] compositor-drm: Use plane FB-import helper for scanout

2018-01-25 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:42 + Daniel Stone wrote: > Use the same codepath, which has the added advantage of being able to > import dmabufs. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 48 >

Re: [PATCH weston] RFC: libweston/compositor-drm: Add support for drm-lease.

2018-01-25 Thread Daniel Stone
Hi Marius, On 25 January 2018 at 11:10, Marius-cristian Vlad wrote: > >> +struct drm_display { > >> + uint32_t connector_id; > >> + uint32_t crtc_id; > >> + uint32_t plane_id; > >> +}; > > > > This seems to get stored but not used after that? > >

Re: [PATCH v14 24/41] compositor-drm: Extract overlay FB import to helper

2018-01-25 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:41 + Daniel Stone wrote: > ... in order to be able to use it from scanout as well. > > Signed-off-by: Daniel Stone > --- > libweston/compositor-drm.c | 221 > - > 1 file

RE: [PATCH weston] RFC: libweston/compositor-drm: Add support for drm-lease.

2018-01-25 Thread Marius-cristian Vlad
-Original Message- From: Daniel Stone [mailto:dan...@fooishbar.org] Sent: Thursday, January 25, 2018 12:07 AM To: Marius-cristian Vlad Cc: wayland-devel@lists.freedesktop.org; Pekka Paalanen ; Keith Packard

Re: [PATCH wayland-protocols] RFC: unstable: DRM lease support

2018-01-25 Thread Daniel Stone
Hi Marius, On 25 January 2018 at 10:17, Marius-cristian Vlad wrote: > > This interface seems a little idiosyncratic. Essentially, the client asks > > for creation of one lease (any lease), and the server returns it a lease > > with an ID. After that, the client

RE: [PATCH wayland-protocols] RFC: unstable: DRM lease support

2018-01-25 Thread Marius-cristian Vlad
Apologies for inline answers. But there's no other way :(. I'll add my replies prefixed with my name. -Original Message- From: Daniel Stone [mailto:dan...@fooishbar.org] Sent: Wednesday, January 24, 2018 11:42 PM To: Marius-cristian Vlad Cc:

Re: [PATCH xserver] xwayland: Support for BTN_STYLUS3 kernel events

2018-01-25 Thread Peter Hutterer
On Wed, Jan 24, 2018 at 10:54:53AM -0800, Jason Gerecke wrote: > On Thu, Nov 9, 2017 at 2:19 PM, Jason Gerecke wrote: > > On Tue, Nov 7, 2017 at 2:37 PM, Peter Hutterer > > wrote: > >> On Tue, Nov 07, 2017 at 11:09:44AM -0800, Jason Gerecke wrote: