Re: T480s Trackpoint drifts

On Mon, Mar 19, 2018 at 04:28:20PM +0800, Kai Hendry wrote: > Hi there, > > I'm an Archlinux user who has a new T480s Thinkpad and unfortunately > the Trackpoint can (not always or reproducibly) "drift". I hope that > makes sense! what exactly is drift in this context? it moves on its own to the

[PATCH] xwm: Fix memory leak

Fix memory leak introduced by 6b58ea8c. weston_wm_handle_icon() was calling xcb_get_property_reply() without freeing the reply. --- xwayland/window-manager.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c index c307e19..24e7213 100644

[ANNOUNCE] weston 3.0.92

This is the beta for the weston 4.0.0 release. Chris Wilson (1): gl-renderer: Create a high priority context Daniel Stone (4): compositor-drm: Don't need safe view-list traversal compositor-drm: Rename region variable compositor-drm: Remove no_addfb2 handling

[ANNOUNCE] wayland 1.14.92

This is the beta for the wayland 1.15 release. Daniel Stone (2): wayland-egl: Pass nm path to check script wayland-egl: Make symbol test fail on failure Derek Foreman (3): client: Don't inappropriatly close fds for zombie objects walyand-client: Fix trivial build break

Re: [PATCH weston v4 4/4] simple-dmabuf-drm: support etnaviv drm as well

On 2018-03-19 11:45 AM, Guido Günther wrote: Signed-off-by: Guido Günther --- Makefile.am | 1 + clients/simple-dmabuf-drm.c | 77 + configure.ac| 5 ++- 3 files changed, 82 insertions(+), 1

Re: [PATCH v2] xwm: Update input region on resize

On Mon, Mar 19, 2018 at 1:13 PM, Derek Foreman wrote: > On 2018-03-16 06:42 PM, Scott Moreau wrote: > >> Hi Pekka, >> >> On Fri, Mar 16, 2018 at 9:20 AM, Pekka Paalanen > > wrote: >> >> On Tue, 13 Mar 2018 21:22:04

Re: [PATCH weston v4 2/4] simple-dmabuf-drm: use large enough buffer (freedreno)

On 2018-03-19 12:23 PM, Eric Engestrom wrote: On Monday, 2018-03-19 17:45:19 +0100, Guido Günther wrote: Use stride instead of width for buffer calculation. Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [PATCH v2] xwm: Update input region on resize

On 2018-03-16 06:42 PM, Scott Moreau wrote: Hi Pekka, On Fri, Mar 16, 2018 at 9:20 AM, Pekka Paalanen > wrote: On Tue, 13 Mar 2018 21:22:04 -0600 Scott Moreau > wrote: > Commit 332d1892

Re: [PATCH weston v4 1/4] simple-dmabuf-drm: Always define ALIGN

On 2018-03-19 11:45 AM, Guido Günther wrote: Other backends might want to use it. Signed-off-by: Guido Günther Reviewed-by: Derek Foreman (and pushed) Thanks, Derek --- clients/simple-dmabuf-drm.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH weston v4 3/4] simple-dmabuf-drm: 0 is a valid fd (freedreno)

On Monday, 2018-03-19 17:45:20 +0100, Guido Günther wrote: > Signed-off-by: Guido Günther It is indeed :) Reviewed-by: Eric Engestrom > --- > clients/simple-dmabuf-drm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH weston v4 2/4] simple-dmabuf-drm: use large enough buffer (freedreno)

On Monday, 2018-03-19 17:45:19 +0100, Guido Günther wrote: > Use stride instead of width for buffer calculation. > > Signed-off-by: Guido Günther > --- > clients/simple-dmabuf-drm.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

On 2018-03-19 11:20 AM, Eric Engestrom wrote: On Monday, 2018-03-19 16:10:57 +, Daniel Stone wrote: Hi, On 19 March 2018 at 16:08, Eric Engestrom wrote: On Monday, 2018-03-19 15:13:14 +, Daniel Stone wrote: +if ! test -f "$LIB"; then + echo "Test

[PATCH weston v4 4/4] simple-dmabuf-drm: support etnaviv drm as well

Signed-off-by: Guido Günther --- Makefile.am | 1 + clients/simple-dmabuf-drm.c | 77 + configure.ac| 5 ++- 3 files changed, 82 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am

[PATCH weston v4 0/4] simple-dmabuf-drm: Support etnaviv and freedreno cleanups

Changes from v3: - Use ALIGN macro by default - Don't multiply by bpp twice - unmap buffer Former patches 1-3 where already applied. Thanks! Changes from v2: - Use stride to calculate buffer size (etnaviv) - Use stride to calculate buffer size (freedreno) - Use less

[PATCH weston v4 3/4] simple-dmabuf-drm: 0 is a valid fd (freedreno)

Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index a184d7e7..22891639 100644 --- a/clients/simple-dmabuf-drm.c +++

[PATCH weston v4 1/4] simple-dmabuf-drm: Always define ALIGN

Other backends might want to use it. Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 4f26e4a9..efe3b7f5 100644 ---

[PATCH weston v4 2/4] simple-dmabuf-drm: use large enough buffer (freedreno)

Use stride instead of width for buffer calculation. Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index efe3b7f5..a184d7e7 100644

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

On Monday, 2018-03-19 16:10:57 +, Daniel Stone wrote: > Hi, > > On 19 March 2018 at 16:08, Eric Engestrom wrote: > > On Monday, 2018-03-19 15:13:14 +, Daniel Stone wrote: > >> +if ! test -f "$LIB"; then > >> + echo "Test binary \"$LIB\" does not exist" > >>

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

Hi, On 19 March 2018 at 16:08, Eric Engestrom wrote: > On Monday, 2018-03-19 15:13:14 +, Daniel Stone wrote: >> +if ! test -f "$LIB"; then >> + echo "Test binary \"$LIB\" does not exist" >> + exit 99 >> +fi >> + >> +if ! test -n "$NM"; then >> + echo

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

On Monday, 2018-03-19 15:13:14 +, Daniel Stone wrote: > The previous rewrite of the wayland-egl ABI checker introduced checks > for removed symbols as well as added symbols, but broke some failure > conditions. Add an explict return-code variable set in failure paths, > rather than chaining or

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

On 19 March 2018 at 13:39, Daniel Stone wrote: > Hi Emil, > > On 19 March 2018 at 13:27, Emil Velikov wrote: >> On 19 March 2018 at 13:20, Daniel Stone wrote: >>> Me neither really, but it seemed best for consistency with the

[PATCH wayland] wayland-egl: Make symbol test fail on failure

The previous rewrite of the wayland-egl ABI checker introduced checks for removed symbols as well as added symbols, but broke some failure conditions. Add an explict return-code variable set in failure paths, rather than chaining or conditions. If we cannot find the binary or nm, we regard this

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

On Mon, 19 Mar 2018 at 13:39:30 +, Daniel Stone wrote: > On 19 March 2018 at 13:27, Emil Velikov wrote: > >> I'd not realised AC_PROG_NM didn't set a full path. Brilliant. Maybe > >> replace test -x "$NM" with $NM -V >/dev/null 2>&1? Or just trusting it > >> works if

Re: [PATCH weston v3 1/3] simple-dmabuf-drm: support etnaviv drm as well

On Mon, 19 Mar 2018 13:38:11 +0100 Guido Günther wrote: > Signed-off-by: Guido Günther > --- > Makefile.am | 1 + > clients/simple-dmabuf-drm.c | 74 > + > configure.ac| 5 ++- >

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

Hi Emil, On 19 March 2018 at 13:27, Emil Velikov wrote: > On 19 March 2018 at 13:20, Daniel Stone wrote: >> Me neither really, but it seemed best for consistency with the rest of >> the file which used test rather than [. > > Sounds fine either

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

On 19 March 2018 at 13:20, Daniel Stone wrote: > Hi Quentin, > Thanks for the quick review! > > On 19 March 2018 at 13:06, Quentin Glidic > wrote: >> On 3/19/18 1:31 PM, Daniel Stone wrote: >>> diff --git a/egl/wayland-egl-symbols-check

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

Hi Quentin, Thanks for the quick review! On 19 March 2018 at 13:06, Quentin Glidic wrote: > On 3/19/18 1:31 PM, Daniel Stone wrote: >> diff --git a/egl/wayland-egl-symbols-check b/egl/wayland-egl-symbols-check >> index c47026b2..d1a4a6be 100755 >> ---

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

On 3/19/18 1:31 PM, Daniel Stone wrote: The previous rewrite of the wayland-egl ABI checker introduced checks for removed symbols as well as added symbols, but broke some failure conditions. Add an explict return-code variable set in failure paths, rather than chaining or conditions. If we

Re: [PATCH wayland 1/2] wayland-egl: Pass nm path to check script

On 3/19/18 1:31 PM, Daniel Stone wrote: A previous patch used $NM as an environment variable, but this was only set as a make variable. Make sure it is passed through from make to the environment we use to run tests. Signed-off-by: Daniel Stone Reported-by: Pekka

[PATCH weston v3 3/3] simple-dmabuf-drm: name ALIGN FD_ALIGN

Other backends might have different alignment requirements and since we can have several backends we want a less generic name. Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH weston v3 2/3] simple-dmabuf-drm: use large enough buffer for freedreno

Use stride instead of width fur buffer calculation. Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 174d0f85..08e794c8 100644

[PATCH weston v3 1/3] simple-dmabuf-drm: support etnaviv drm as well

Signed-off-by: Guido Günther --- Makefile.am | 1 + clients/simple-dmabuf-drm.c | 74 + configure.ac| 5 ++- 3 files changed, 79 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am

[PATCH weston v3 0/3] simple-dmabuf-drm: Support etnaviv (and other cleanups)

Former patches 1-3 where already applied. Thanks! Changes from v2: - Use stride to calculate buffer size (etnaviv) - Use stride to calculate buffer size (freedreno) - Use less generic name for ALIGN macro Changes from v1: - Split up changes - autoconf: - don't define

[PATCH libinput] meson: point users to disabled documentation when dot/doxygen is missing

Especially dot is hard to find for some users, so provide the solution to their problems right there in the error message. And because users are likely to just copy/paste, remove the disable-libwacom option. Save them from themselves... Signed-off-by: Peter Hutterer

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

Hi, On 19 March 2018 at 11:43, Emil Velikov wrote: > On 19 March 2018 at 09:56, Pekka Paalanen wrote: >> On Fri, 16 Mar 2018 16:18:57 + >> Emil Velikov wrote: >>> Right - I was aiming to remove the bonkers envvar and

[PATCH wayland 1/2] wayland-egl: Pass nm path to check script

A previous patch used $NM as an environment variable, but this was only set as a make variable. Make sure it is passed through from make to the environment we use to run tests. Signed-off-by: Daniel Stone Reported-by: Pekka Paalanen Fixes:

[PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

The previous rewrite of the wayland-egl ABI checker introduced checks for removed symbols as well as added symbols, but broke some failure conditions. Add an explict return-code variable set in failure paths, rather than chaining or conditions. If we cannot find the binary or nm, we regard this

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

On Monday, 2018-03-19 12:11:50 +, Eric Engestrom wrote: > On Monday, 2018-03-19 11:43:08 +, Emil Velikov wrote: > > On 19 March 2018 at 09:56, Pekka Paalanen wrote: > > > On Fri, 16 Mar 2018 16:18:57 + > > > Emil Velikov wrote: > > > > >

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

On Monday, 2018-03-19 11:43:08 +, Emil Velikov wrote: > On 19 March 2018 at 09:56, Pekka Paalanen wrote: > > On Fri, 16 Mar 2018 16:18:57 + > > Emil Velikov wrote: > > > >> On 16 March 2018 at 13:52, Pekka Paalanen

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

On 19 March 2018 at 09:56, Pekka Paalanen wrote: > On Fri, 16 Mar 2018 16:18:57 + > Emil Velikov wrote: > >> On 16 March 2018 at 13:52, Pekka Paalanen wrote: >> > On Thu, 15 Mar 2018 14:30:27 + >> > Emil Velikov

Re: [RFC] weston-launch: add option to start compositors other than weston

On Mon, 19 Mar 2018 12:33:27 +0200 Ilia Bozhinov wrote: > Oops, sorry, I didn't consider that and I should have. Mods should remove > this patch. Hi, if you mean mark it as rejected in Patchwork, I've now done that. If you wanted to make a login with Patchwork, you could

Re: [RFC] weston-launch: add option to start compositors other than weston

Oops, sorry, I didn't consider that and I should have. Mods should remove this patch. But anyway, does that mean every compositor should provide its own version of weston-launch or require systemd-login? On Mon, Mar 19, 2018 at 12:24 PM, Pekka Paalanen wrote: > On Mon, 19

Re: [PATCH weston 0/3] Allow simple-dmabuf-drm to pass y_inverted flag and cleanups

On Mon, Mar 19, 2018 at 12:12:36PM +0200, Pekka Paalanen wrote: > On Fri, 16 Mar 2018 18:56:47 +0100 > Guido Günther wrote: > > > Changes from v2 > > > > - Explain OPT_* usage > > - Switch is_immediate to OPT_* > > - use getopt_long > > > > Changes from v1 > > > > -

Re: [RFC] weston-launch: add option to start compositors other than weston

On Mon, 19 Mar 2018 11:41:46 +0200 Ilia Bozhinov wrote: > This is helpful for other compositors which utilize libweston without > systemd-login support. > > Signed-off-by: Ilia Bozhinov > --- > libweston/weston-launch.c | 35

Re: [PATCH weston] Fix an uninitialized variable

On Sun, 18 Mar 2018 00:20:29 -0400 Dima Ryazanov wrote: > "has_discrete" gets set to true in if/else if, but gets left unset otherwise. > So let's initialize it to false. > > (This was caught by valgrind.) > > Signed-off-by: Dima Ryazanov > --- >

Re: [PATCH weston 0/3] Allow simple-dmabuf-drm to pass y_inverted flag and cleanups

On Fri, 16 Mar 2018 18:56:47 +0100 Guido Günther wrote: > Changes from v2 > > - Explain OPT_* usage > - Switch is_immediate to OPT_* > - use getopt_long > > Changes from v1 > > - introduce opts as a bitmask of features that can be used to >manipulate the displayed

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

On Fri, 16 Mar 2018 16:18:57 + Emil Velikov wrote: > On 16 March 2018 at 13:52, Pekka Paalanen wrote: > > On Thu, 15 Mar 2018 14:30:27 + > > Emil Velikov wrote: > > > >> From: Emil Velikov

Re: [PATCH wayland] wayland-egl: set the correct path to libwayland-egl.so

On Fri, 16 Mar 2018 16:14:54 + Emil Velikov wrote: > From: Emil Velikov > > Earlier commit changed to passing the binary name as env. variable > introducing a typo. > > That went unnoticed, since we do not check if the file is present

[RFC] weston-launch: add option to start compositors other than weston

This is helpful for other compositors which utilize libweston without systemd-login support. Signed-off-by: Ilia Bozhinov --- libweston/weston-launch.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

On Sun, 18 Mar 2018 14:59:58 -0400 Simon Ser wrote: > On March 16, 2018 1:22 PM, Pekka Paalanen wrote: > > > > I'm missing a comment that describes what happens if the xdg_toplevel is > > > > destroyed. There is some object dependency here that needs to

T480s Trackpoint drifts

Hi there, I'm an Archlinux user who has a new T480s Thinkpad and unfortunately the Trackpoint can (not always or reproducibly) "drift". I hope that makes sense! https://bbs.archlinux.org/viewtopic.php?id=235400 The trouble is I can't seem to disable the Trackpoint pointer itself, but still have