On Fri, Aug 07, 2015 at 12:50:19AM +0900, Ryo Munakata wrote:
On Fri, 29 May 2015 10:46:44 -0500
Derek Foreman der...@osg.samsung.com wrote:
Hi all.
I sent an almost same patch to ML recently, which means this problem hasn't
been fixed.
So now:
Reviewed-by: Ryo Munakata
On Tue, Jul 07, 2015 at 07:31:26AM -0500, Derek Foreman wrote:
On 06/07/15 03:31 AM, Sjoerd Simons wrote:
This patchset add support for driving multiple framebuffers from weston.
First
patch drops the intermediate shadow buffer in the fbdev compositor, which
turned out to be both
On Thu, Aug 06, 2015 at 04:36:14PM -0500, Derek Foreman wrote:
This all looks ok to me, and it's not too bad for stomping all over
heavily contested files.
Reviewed-by: Derek Foreman der...@osg.samsung.com
Thanks! Applied to trunk.
To ssh://git.freedesktop.org/git/wayland/weston
On Fri, Aug 07, 2015 at 10:50:20AM -0500, Derek Foreman wrote:
These all look good to me.
Reviewed-by: Derek Foreman der...@osg.samsung.com
Thanks, applied to trunk.
To ssh://git.freedesktop.org/git/wayland/weston
b18f788..5e653ca master - master
On 07/08/15 06:20 AM, Ryo Munakata
On Fri, Aug 07, 2015 at 12:00:12PM -0500, Derek Foreman wrote:
Thanks,
Reviewed-by: Derek Foreman der...@osg.samsung.com
Thanks, pushed to trunk:
To ssh://git.freedesktop.org/git/wayland/weston
58106d7..2f7d33d master - master
On 06/08/15 07:04 PM, Dawid Gajownik wrote:
When the
On Wed, Aug 05, 2015 at 03:24:01PM -0500, Derek Foreman wrote:
On 05/08/15 03:05 PM, Dawid Gajownik wrote:
On Wed, Aug 5, 2015 at 4:18 PM, Derek Foreman der...@osg.samsung.com
wrote:
This looks good to me barring two tiny style nits below.
That fixed,
Reviewed-by: Derek Foreman
On Sat, Aug 01, 2015 at 10:03:12PM +0200, Hardening wrote:
Le 01/08/2015 16:02, Dawid Gajownik a écrit :
There's no need to check if a pointer exists before passing it to free().
free() can handle NULL pointers.
Signed-off-by: Dawid Gajownik gajow...@gmail.com
Reviewed-By: David FORT
On Fri, Jul 31, 2015 at 02:57:54PM -0300, Dawid Gajownik wrote:
BTW is there a reason why backend modules are not listed in the
alphabetical order in `weston --help' output? I know it's just
cosmetic but maybe it would be a bit easier to find necessary
information if thing were sorted.
I
: { WESTON_OPTION_BOOLEAN, env-socket, 0,
config.env_socket },
src/main.c: --env-socket=SOCKET\tUse that socket as
peer connection\n
Reviewed-by: Bryce Harrington br...@osg.samsung.com
Pushed:
To ssh://git.freedesktop.org/git/wayland/weston
d88f194..d99a050 master
On Wed, Jul 29, 2015 at 12:55:55AM -0300, Dawid Gajownik wrote:
Hi,
after running configure with Enable developer documentation set to
yes git status warns about two new untracked files:
doc/doxygen/tooldev.doxygen
doc/doxygen/tools.doxygen
Below is a small patch.
On Thu, Jul 30, 2015 at 09:40:56AM +0800, Jonas Ådahl wrote:
On Wed, Jul 15, 2015 at 01:00:48PM -0500, Derek Foreman wrote:
Keyboards and pointers aren't freed when devices are removed, so we should
really be testing keyboard_device_count and pointer_device_count in most
cases, not the
On Fri, Jul 31, 2015 at 06:28:59PM -0300, Dawid Gajownik wrote:
Fixes incorrect commit d95637905861162c08251843a11e509b5d94
Signed-off-by: Dawid Gajownik gajow...@gmail.com
Thanks for the follow up fix.
Reviewed-by: Bryce Harrington br...@osg.samsung.com
Pushed:
To ssh
Reviewed-by: Bryce Harrington br...@osg.samsung.com
---
src/scanner.c | 164
+++---
1 file changed, 111 insertions(+), 53 deletions(-)
diff --git a/src/scanner.c b/src/scanner.c
index 7d8cfb9..da33818 100644
--- a/src/scanner.c
+++ b/src
On Thu, Jul 30, 2015 at 04:42:00PM +0200, Marek Chalupa wrote:
scanner does not complain if we put into version attribute
things like -1 1x 1:3 etc.
Signed-off-by: Marek Chalupa mchqwe...@gmail.com
Reviewed-by: Bryce Harrington br...@osg.samsung.com
Yep, nice improvement. Pushed to trunk
On Thu, Jul 30, 2015 at 05:58:05PM -0700, Bryce Harrington wrote:
On Thu, Jul 30, 2015 at 03:07:20PM +0200, Marek Chalupa wrote:
wrap creating and initializing objects (structures)
into functions and use them in the code.
v2. make create_.* functions consistent
(no func will return
On Thu, Jul 30, 2015 at 03:07:22PM +0200, Marek Chalupa wrote:
Use xzalloc instead of xmalloc. This allows us to get rid
of manual initializing the memory to 0s and the code is
shorter and cleaner
Suggested by Bryce Harrington
Signed-off-by: Marek Chalupa mchqwe...@gmail.com
Reviewed
fixes
Signed-off-by: Marek Chalupa mchqwe...@gmail.com
One stylistic comment below, but it can be handled in follow-up.
Everything else looks good to me, so:
Reviewed-by: Bryce Harrington br...@osg.samsung.com
---
src/scanner.c | 106
similar code, but didn't spot anything. Did you check as
well?
Anyway, looks good.
Reviewed-by: Bryce Harrington br...@osg.samsung.com
diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
index a8e63e1..70f0939 100644
--- a/src/compositor-wayland.c
+++ b/src/compositor-wayland.c
On Thu, Jul 23, 2015 at 05:53:40PM -0700, Bryce Harrington wrote:
On Thu, Jul 23, 2015 at 02:55:14PM -0500, Derek Foreman wrote:
It doesn't do anything with a pointer, and zoom can be initiated by the
keyboard, so the name was a little confusing.
Signed-off-by: Derek Foreman der
On Thu, Jul 23, 2015 at 03:44:35PM -0700, Bryce Harrington wrote:
On Thu, Jul 23, 2015 at 02:55:12PM -0500, Derek Foreman wrote:
Signed-off-by: Derek Foreman der...@osg.samsung.com
Reviewed-by: Bryce Harrington br...@osg.samsung.com
To ssh://git.freedesktop.org/git/wayland/weston
b3463a9
On Mon, Jul 20, 2015 at 11:19:18AM +0100, Daniel Stone wrote:
Hey Bryce,
On 17 July 2015 at 21:19, Bryce Harrington br...@osg.samsung.com wrote:
Could I bother you to request we update patchwork on fdo?
The latest version now displays counts of Acked/Reviewed/Tested which
would be quite
On Thu, Jul 23, 2015 at 02:55:13PM -0500, Derek Foreman wrote:
No longer call weston_output_update_zoom() when trying to zoom out
on an unzoomed output.
Add an assert() to make sure update_zoom is never called without an
active zoom.
Signed-off-by: Derek Foreman der...@osg.samsung.com
A
On Thu, Jul 23, 2015 at 02:55:12PM -0500, Derek Foreman wrote:
Signed-off-by: Derek Foreman der...@osg.samsung.com
Reviewed-by: Bryce Harrington br...@osg.samsung.com
---
src/compositor.h | 2 +-
src/zoom.c | 7 ---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git
On Thu, Jul 23, 2015 at 02:55:14PM -0500, Derek Foreman wrote:
It doesn't do anything with a pointer, and zoom can be initiated by the
keyboard, so the name was a little confusing.
Signed-off-by: Derek Foreman der...@osg.samsung.com
Reviewed-by: Bryce Harrington br...@osg.samsung.com
On Tue, Jul 21, 2015 at 02:38:08PM +0300, Pekka Paalanen wrote:
On Mon, 20 Jul 2015 14:39:19 +0200
David FORT rdp.eff...@gmail.com wrote:
Misc things fixed in the RDP compositor:
* bad return value in backend_init, introduced by the libweston refactoring;
* an initialization that was
On Thu, Jul 23, 2015 at 02:55:15PM -0500, Derek Foreman wrote:
Track the seat that initiated a seat instead of picking the first one.
initiated a zoom? ;-)
Previously, if there are multiple seats then any seat can adjust the zoom
level but the zoom tracks the first seat's pointer.
Now
On Fri, Jul 17, 2015 at 01:45:00PM +0200, Quentin Glidic wrote:
On 2015-07-17 13:33, Ross Burton wrote:
In parallel out-of-tree builds it is possible for e.g. ivi-shell/weston.ini
to
be written before ivi-shell/ exists. Solve this by creating the target
directory first.
On Sat, Jul 18, 2015 at 08:07:11AM +0200, Mario Kleiner wrote:
cms-colord used the weston_compositor destroy signal to
trigger its final colord_module_destroy cleanup, and the
wl_output destroy signal to trigger per output cleanup.
The problem is that the compositor destroy signal gets
On Tue, Jul 21, 2015 at 02:42:52PM +0300, Pekka Paalanen wrote:
On Mon, 20 Jul 2015 11:17:15 -0500
Derek Foreman der...@osg.samsung.com wrote:
On 18/07/15 01:10 AM, Mario Kleiner wrote:
Allows to force loading an identity gamma table if
option icc_profile= is given in weston.ini for
On Thu, Jul 23, 2015 at 07:39:30AM +0200, Marek Chalupa wrote:
wrap creating and initializing objects (structures)
into functions and use them in the code.
Signed-off-by: Marek Chalupa mchqwe...@gmail.com
---
src/scanner.c | 158
++
...@gmail.com
This one looks good but looks like it depends on patch #1 in the series
so will likely need rebased once that one is fixed. This one looks fine
though, so:
Reviewed-by: Bryce Harrington br...@osg.samsung.com
One question at the very end...
---
src/scanner.c | 110
On Tue, Jul 21, 2015 at 02:31:55PM +0300, Pekka Paalanen wrote:
On Mon, 20 Jul 2015 16:28:13 -0500
Derek Foreman der...@osg.samsung.com wrote:
Removing the screensaver had the accidental side effect of disabling
DPMS display shut down.
Signed-off-by: Derek Foreman
On Thu, Jul 23, 2015 at 04:52:30PM +0200, Marek Chalupa wrote:
wldbg is a tool for debugging wayland applications
Signed-off-by: Marek Chalupa mchqwe...@gmail.com
---
extras.html | 6 ++
1 file changed, 6 insertions(+)
diff --git a/extras.html b/extras.html
index 55ff35c..eba7133
On Thu, Jul 16, 2015 at 01:59:05PM +0200, Marek Chalupa wrote:
Wrap few long lines to the length around 80 chars
Signed-off-by: Marek Chalupa mchqwe...@gmail.com
How hard core are we about maintaining the 80-column rule? Frankly I
think the original code with the logging message on one line
Daniel,
Could I bother you to request we update patchwork on fdo?
The latest version now displays counts of Acked/Reviewed/Tested which
would be quite handy in picking out patches to land as we start heading
towards the next alpha.
http://patchwork.ozlabs.org/project/patchwork/list/
Bryce
int, and sizeof's type isn't a
factor.
Thanks,
pq
On Sat, Jun 20, 2015 at 1:28 AM, Bryce Harrington br...@osg.samsung.com
wrote:
Addresses this warning found by Denis Denisov:
[src/logind-util.c:702]: (warning) %d in format string (no. 1)
requires 'int' but the argument
On Fri, Jul 17, 2015 at 03:19:20PM -0700, Bryce Harrington wrote:
Hi Derek,
Here's a list of your patches in patchwork, and whether they still apply
or not. (This just sequentially applied all your patches, so
potentially the conflict could be between one of your newer patches and
one
On Fri, Jul 17, 2015 at 08:58:02PM -0500, Derek Foreman wrote:
I flipped a ! in cee82d62865ab5b239935f102c2e1f7868e0fa65
and the exposay keyboard grab became permanent.
Signed-off-by: Derek Foreman der...@osg.samsung.com
Thanks for catching that!
Pushed to git.
---
On Fri, Jul 17, 2015 at 03:33:50PM -0500, Derek Foreman wrote:
Reviewed-By: Derek Foreman der...@osg.samsung.com
Thanks, pushed:
To ssh://git.freedesktop.org/git/wayland/weston
179c186..27135af master - master
On 16/07/15 11:07 PM, Ryo Munakata wrote:
Signed-off-by: Ryo Munakata
Hi Derek,
Here's a list of your patches in patchwork, and whether they still apply
or not. (This just sequentially applied all your patches, so
potentially the conflict could be between one of your newer patches and
one of your older ones.)
Bryce
47258
Applying: desktop-shell: add output
On Thu, Jul 16, 2015 at 08:56:32PM +0100, Ross Burton wrote:
dist_wayland_session_DATA will distribute and install src/weston.desktop, so
the
definition of wayland_session_DATA which also installs src/weston.desktop will
result in the file being installed twice and (rarely) cause install to
On Wed, Jul 15, 2015 at 01:00:31PM -0500, Derek Foreman wrote:
v7 of my Don't allow direct use of seat-device pointers stuff.
Those pointers are funny in that they only exist after a device has been
plugged in, and they don't ever go away. We're supposed to check if
the associated
On Mon, Jun 08, 2015 at 11:37:31AM -0500, Derek Foreman wrote:
Reviewed-by: Pekka Paalanen pekka.paala...@collabora.co.uk
Signed-off-by: Derek Foreman der...@osg.samsung.com
Thanks, pushed:
To ssh://git.freedesktop.org/git/wayland/weston
4a8a3a1..6bc33d6 master - master
---
Nested the
On Fri, Jun 26, 2015 at 01:57:44PM +1000, Peter Hutterer wrote:
On Thu, Jun 25, 2015 at 04:03:30PM -0500, Derek Foreman wrote:
Currently rotate is on the right mouse button and resize is on the middle.
As fantastic as rotating windows is, it's probably nicer to have resize on
the right
On Wed, Jul 15, 2015 at 01:03:24PM +0100, Daniel Stone wrote:
Hi,
On 14 July 2015 at 11:07, Pekka Paalanen ppaala...@gmail.com wrote:
From: Pekka Paalanen pekka.paala...@collabora.co.uk
What is libweston and where do we intend to go with it.
Sounds good to me, although the bit about
On Wed, Jul 15, 2015 at 01:09:03PM +0100, Emil Velikov wrote:
Hello gents,
On 15 July 2015 at 09:51, Marek Chalupa mchqwe...@gmail.com wrote:
Reviewed-by: Marek Chalupa mchqwe...@gmail.com
(http://lists.freedesktop.org/archives/wayland-devel/2015-May/021952.html)
On 05/16/2015 07:38
On Wed, Jul 15, 2015 at 03:19:35PM -0500, Derek Foreman wrote:
Reviewed-By: Derek Foreman der...@osg.samsung.com
Thanks, pushed:
To ssh://git.freedesktop.org/git/wayland/weston
a820b4d..8c7287f master - master
On 15/07/15 03:19 PM, Emmanuel Gil Peyrot wrote:
This reverts commit
On Tue, Jul 14, 2015 at 09:20:42AM +0300, Pekka Paalanen wrote:
On Mon, 13 Jul 2015 13:04:38 -0700
Bryce Harrington br...@osg.samsung.com wrote:
On Mon, Jul 13, 2015 at 09:12:24AM +0300, Pekka Paalanen wrote:
On Fri, 10 Jul 2015 15:31:03 -0700
Bryce Harrington br...@osg.samsung.com
for libweston and gives
definitive answers to some of the questions that have been floating
about. Apart from the trivial copyedits above, the scope and
development approach sounds good to me:
Reviewed-by: Bryce Harrington br...@osg.samsung.com
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
tools/zunitc/doc/zunitc.dox | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/zunitc/doc/zunitc.dox b/tools/zunitc/doc/zunitc.dox
index 0222690..cef6c34 100644
--- a/tools/zunitc/doc/zunitc.dox
+++ b/tools
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
tools/zunitc/doc/zunitc.dox | 30 ++
1 file changed, 22 insertions(+), 8 deletions(-)
diff --git a/tools/zunitc/doc/zunitc.dox b/tools/zunitc/doc/zunitc.dox
index 24f20fa..0222690 100644
--- a/tools/zunitc/doc
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
tools/zunitc/inc/zunitc/zunitc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/zunitc/inc/zunitc/zunitc.h b/tools/zunitc/inc/zunitc/zunitc.h
index fc6ee1c..d8c3cb0 100644
--- a/tools/zunitc/inc/zunitc/zunitc.h
On Mon, Jul 13, 2015 at 11:02:07AM -0500, Derek Foreman wrote:
looks correct to me.
Reviewed-by: Derek Foreman der...@osg.samsung.com
Thanks, pushed:
To ssh://git.freedesktop.org/git/wayland/weston
2f2a70c..29f09fe master - master
On 10/07/15 08:52 PM, Bryce Harrington wrote
On Mon, Jul 13, 2015 at 09:12:24AM +0300, Pekka Paalanen wrote:
On Fri, 10 Jul 2015 15:31:03 -0700
Bryce Harrington br...@osg.samsung.com wrote:
On Fri, Jul 10, 2015 at 09:33:46AM -0400, Christopher Michael wrote:
Thanks for the review. I've included an updated patch which fixes
On Thu, Jul 09, 2015 at 01:46:46PM -0400, Christopher Michael wrote:
Here is an updated patch which changes the wording to match what
Giulio offered.
Documentation for the prepare_lock_surface event description is
incorrect. The summary says Tell the client... however the full-text
/wayland/weston
430aee1..da9d8fa master - master
On Sat, Jun 20, 2015 at 1:12 AM, Bryce Harrington br...@osg.samsung.com
wrote:
It is redundant to check x*alloc's return value for null pointers, since
they are guaranteed to either return non-NULL or terminate the program.
In cases
On Wed, Jul 01, 2015 at 11:52:28AM +0200, Marek Chalupa wrote:
Reviewed-by: Marek Chalupa mchqwe...@gmail.com
Thanks, pushed as commit 430aee1c23a641cf3227bcde08419458ef2ea252
On Sat, Jun 20, 2015 at 12:47 AM, Bryce Harrington br...@osg.samsung.com
wrote:
error(1, ...) already
On Wed, Jul 01, 2015 at 05:12:27PM -0700, Bryce Harrington wrote:
On Wed, Jul 01, 2015 at 11:19:09AM +0200, Marek Chalupa wrote:
On Wed, Jul 1, 2015 at 6:35 AM, Bryce Harrington br...@osg.samsung.com
wrote:
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
xwayland
On Fri, Jul 10, 2015 at 09:36:45AM +0300, Pekka Paalanen wrote:
On Thu, 9 Jul 2015 13:46:46 -0400
Christopher Michael cpmich...@osg.samsung.com wrote:
Here is an updated patch which changes the wording to match what Giulio
offered.
Documentation for the prepare_lock_surface event
On Fri, Jun 19, 2015 at 04:13:11PM -0700, Jon A. Cruz wrote:
On 06/19/2015 03:58 PM, Bryce Harrington wrote:
Addresses this warning found by Denis Denisov:
[tests/array-test.c:137]: (warning) Assert statement modifies 'i'.
Signed-off-by: Bryce Harrington br...@osg.samsung.com
wl_display_sync without first setting up a registry
listener, then clients will miss the advertisement of registry globals.
Signed-off-by: Chris Michael cp.mich...@samsung.com
Reviewed-by: Bryce Harrington br...@osg.samsung.com
---
protocol/wayland.xml | 4 ++--
1 file changed, 2 insertions(+), 2
On Fri, Jun 26, 2015 at 02:16:55PM -0500, Derek Foreman wrote:
On 22/06/15 11:25 AM, Daniel Stone wrote:
Hi,
Thanks to everyone who reviewed the previous series. This new series
cleans up the previous patches, introduces a few fixes (e.g. not relying
on a repaint to pull us out of DPMS),
dump_property allows reply to be NULL. Calling it unconditionally will
ensure user knows where the selection failed.
Also refactor code a bit.
Suggested by Marek Chalupa
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
xwayland/selection.c | 10 +-
1 file changed, 5
On Fri, May 29, 2015 at 04:32:52PM -0500, Derek Foreman wrote:
The wl_list_for_each operation on the free_buffers list should use
free_link not link, which is a different list.
This fixes a crash when entering fullscreen mode when using the pixman
renderer on the wayland back-end.
On Wed, Jul 01, 2015 at 04:51:24PM +0800, Jonas Ådahl wrote:
On Wed, Jun 03, 2015 at 03:53:22PM -0500, Derek Foreman wrote:
Make it a bool in both surface_move() and struct weston_move_grab
Signed-off-by: Derek Foreman der...@osg.samsung.com
Reviewed-by: Jonas Ådahl jad...@gmail.com
On Fri, Jul 03, 2015 at 09:33:23AM +0200, Marek Chalupa wrote:
Fixed benchmark uses main(int argc, char *argv[])
but does not use the arguments, so we can replace them with void
Signed-off-by: Marek Chalupa mchqwe...@gmail.com
Reviewed-by: Bryce Harrington br...@osg.samsung.com
Pushed
On Fri, Jun 26, 2015 at 01:57:22PM -0500, Derek Foreman wrote:
On 22/06/15 11:25 AM, Daniel Stone wrote:
From: Pekka Paalanen pekka.paala...@collabora.co.uk
Refactor the code for choosing the initial mode for an output from
create_output_for_connector() to
pekka.paala...@collabora.co.uk
Signed-off-by: Daniel Stone dani...@collabora.com
Reviewed-by: Bryce Harrington br...@osg.samsung.com
Also a simple refactor that could land early. But doesn't apply
presently.
Bryce
---
src/compositor-drm.c | 28 ++--
1 file changed, 18
if
(drmModeConnectorSetProperty(... ?
Reviewed-by: Bryce Harrington br...@osg.samsung.com
+ weston_log(DRM: DPMS: failed property set for %s\n,
+output-base.name);
+ return;
+ }
+
+ output-dpms = level;
}
static const char * const
On Fri, Jul 10, 2015 at 10:50:43AM +0200, Marek Chalupa wrote:
On 07/10/2015 06:30 AM, Bryce Harrington wrote:
From the man pages it appears this routine can return NULL on certain
error conditions.
Suggested by Marek Chalupa
Signed-off-by: Bryce Harrington br...@osg.samsung.com
On Fri, May 29, 2015 at 04:32:52PM -0500, Derek Foreman wrote:
The wl_list_for_each operation on the free_buffers list should use
free_link not link, which is a different list.
This fixes a crash when entering fullscreen mode when using the pixman
renderer on the wayland back-end.
On Fri, Jul 10, 2015 at 06:16:11PM -0700, Bryce Harrington wrote:
dump_property allows reply to be NULL. Calling it unconditionally will
ensure user knows where the selection failed.
Also refactor code a bit.
Suggested by Marek Chalupa
Signed-off-by: Bryce Harrington br
The wl_list_for_each operation on the free_buffers list should use
free_link not link, which is a different list.
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
src/screen-share.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/screen-share.c b/src/screen
Addresses this warning found by Denis Denisov:
[src/logind-util.c:702]: (warning) %d in format string (no. 1)
requires 'int' but the argument type is 'unsigned int'.
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
src/logind-util.c | 2 +-
1 file changed, 1 insertion(+), 1
On Wed, Jul 01, 2015 at 04:50:39PM +0800, Jonas Ådahl wrote:
On Wed, Jun 03, 2015 at 03:53:20PM -0500, Derek Foreman wrote:
Signed-off-by: Derek Foreman der...@osg.samsung.com
Reviewed-by: Jonas Ådahl jad...@gmail.com
Reviewed-by: Bryce Harrington br...@osg.samsung.com
No longer applies
Tell the client... however the full-text
description says tell the shell...
Signed-off-by: Chris Michael cp.mich...@samsung.com
Reviewed-by: Bryce Harrington br...@osg.samsung.com
---
protocol/desktop-shell.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
From the man pages it appears this routine can return NULL on certain
error conditions.
Suggested by Marek Chalupa
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
xwayland/selection.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/xwayland/selection.c b/xwayland/selection.c
On Wed, Jul 01, 2015 at 10:51:01PM +0100, Ross Burton wrote:
The previous idiom for building a cross-compiled Wayland is to build once for
the build host (with --enable-scanner --disable-libraries) to get a
wayland-scanner binary that can then be used in a cross-compile (with
On Mon, Jul 06, 2015 at 09:02:40PM +0100, Burton, Ross wrote:
On 6 July 2015 at 20:40, Bryce Harrington br...@osg.samsung.com wrote:
An even cleaner solution would be to break the scanner out as a separate
source package from libwayland. Then all this mess can be handled
through normal
On Wed, Jul 01, 2015 at 11:19:09AM +0200, Marek Chalupa wrote:
On Wed, Jul 1, 2015 at 6:35 AM, Bryce Harrington br...@osg.samsung.com
wrote:
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
xwayland/selection.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
xwayland/selection.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/xwayland/selection.c b/xwayland/selection.c
index 572a0b5..451b915 100644
--- a/xwayland/selection.c
+++ b/xwayland/selection.c
@@ -119,8
On Mon, Jun 22, 2015 at 10:08:04AM -0500, Derek Foreman wrote:
Reviewed-By: Derek Foreman der...@osg.samsung.com
Thanks, pushed:
To ssh://git.freedesktop.org/git/wayland/weston
872797c..8081704 master - master
On 21/06/15 02:25 PM, Mario Kleiner wrote:
Initialize output-native_mode
On Fri, Jun 26, 2015 at 01:34:42PM -0500, Derek Foreman wrote:
On 21/06/15 02:25 PM, Mario Kleiner wrote:
Allow proper handling of output-pipe 1 to support
triple-head graphics cards etc. by using the high-crtc
support introduced in Linux 2.6.39 and libdrm 2.4.25
around May 2011.
On Sun, Jun 21, 2015 at 09:25:09PM +0200, Mario Kleiner wrote:
The matching logic in choose_mode() compared refresh rate
of a drm_mode candidate mode expressed in Hz against the
requested refresh rate of the target weston_mode expressed
in milliHz, so the match always failed and the logic
On Sun, Jun 21, 2015 at 09:25:08PM +0200, Mario Kleiner wrote:
Desktop shell demoted all fullscreen shell surfaces on all active
outputs of a multi-display setup whenever any shell surface was
activated anywhere. This made it impossible to have multiple
fullscreen windows on separate outputs
On Tue, Jun 23, 2015 at 12:48:13PM -0700, Jon A. Cruz wrote:
Actually... yesterday I was just bouncing off of Bryce some ideas in
regards to tuning up the options parser to clean up a bit of the current
mess in regards to params, help messages, keeping multiple areas in
sync, etc.
Yeah at the
On Tue, Jun 23, 2015 at 07:29:17PM +0900, JoonCheol Park wrote:
Instead of adding available backends and usage outputs at build time,
this patch finds all available backend plugins in MODULEDIR and prints
them. It also prints usage output for selected backend by calling
backend_usage() in the
On Mon, Jun 22, 2015 at 11:02:50PM +0300, Giulio Camuffo wrote:
This commits starts to separate the libweston code from the weston
specific code. As such, the main() is moved, together with signals
handling and configuration handling.
---
Makefile.am | 1 +
src/compositor.c | 801
Addresses this error reported by Denis Denisov:
[src/scanner.c:1415]: (error) Resource leak: input
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
src/scanner.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/scanner.c b/src/scanner.c
index 7d8cfb9..2843d85 100644
--- a/src
, but on some systems (e.g. OpenVMS apparently) exit(1) means
success so EXIT_FAILURE there is defined to some other non-zero value.
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
src/weston-launch.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/weston-launch.c b
Addresses this warning found by Denis Denisov:
[src/logind-util.c:702]: (warning) %d in format string (no. 1)
requires 'int' but the argument type is 'unsigned int'.
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
src/logind-util.c | 2 +-
1 file changed, 1 insertion(+), 1
null.
[clients/window.c:4513] - [clients/window.c:4514]: (warning) Possible
null pointer dereference: surface - otherwise it is redundant to check
it against null.
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
clients/window.c | 13 ++---
1 file changed, 2 insertions
Addresses this warning found by Denis Denisov:
[tests/array-test.c:137]: (warning) Assert statement modifies 'i'.
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
tests/array-test.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tests/array-test.c b
On Mon, Jun 15, 2015 at 12:18:44PM +0300, Pekka Paalanen wrote:
On Fri, 12 Jun 2015 16:44:15 -0700
Bryce Harrington br...@osg.samsung.com wrote:
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
doc/publican/sources/Book_Info.xml | 46
On Mon, Jun 15, 2015 at 02:21:09PM +0300, Pekka Paalanen wrote:
Hi Bryce,
well handled.
On Fri, 12 Jun 2015 15:04:37 -0700
Bryce Harrington br...@osg.samsung.com wrote:
Following on from the wayland license switch, do the same for Weston,
along with some minor cleanup.
Several
):
Remove redundant #include path component.
Moved helper macro to a discrete include file.
Moved the MIN() macro to the helper include.
Unified multiple definitions of container_of() macro.
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net for the series
LGTM too.
Reviewed-by: Bryce
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
protocol/text.xml | 38 ++
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/protocol/text.xml b/protocol/text.xml
index 9cf78b3..0f824ea 100644
--- a/protocol/text.xml
+++ b/protocol
On Mon, Jun 15, 2015 at 01:48:27PM -0700, Bryce Harrington wrote:
On Mon, Jun 15, 2015 at 10:57:31AM +1000, Peter Hutterer wrote:
On Fri, Jun 12, 2015 at 09:25:01PM -0700, Jon A. Cruz wrote:
As a follow-up to review feedback from Peter Hutterer this
set moves a few duplicated macros
On Mon, Jun 15, 2015 at 03:27:51PM -0700, Bryce Harrington wrote:
Signed-off-by: Bryce Harrington br...@osg.samsung.com
I just went ahead and landed this since at this point there's nothing
controversial here.
Bryce
---
protocol/text.xml | 38 ++
1 file
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
clients/calibrator.c | 33 +
clients/clickdot.c | 33 +
clients/cliptest.c | 33 +
clients
901 - 1000 of 1433 matches
Mail list logo
