Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Carlos Garnacho
Hey Peter, On jue, 2015-01-29 at 21:54 +1000, Peter Hutterer wrote: On 29/01/2015 20:58 , Carlos Garnacho wrote: On jue, 2015-01-29 at 16:26 +1000, Peter Hutterer wrote: On Wed, Jan 28, 2015 at 06:18:44PM +, Carlos Garnacho wrote: Hey, On mié, 2015-01-28 at 15:51 +0100, Hans de

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Carlos Garnacho
On jue, 2015-01-29 at 16:26 +1000, Peter Hutterer wrote: On Wed, Jan 28, 2015 at 06:18:44PM +, Carlos Garnacho wrote: Hey, On mié, 2015-01-28 at 15:51 +0100, Hans de Goede wrote: Hi, On 28-01-15 13:59, Carlos Garnacho wrote: Hey Hans!, (sorry for chiming in late

Re: [PATCH weston 1/2] libinput: Ignore non seat wide pointer button events

2015-01-29 Thread Carlos Garnacho
On mié, 2015-01-28 at 13:09 -0800, Bill Spitzak wrote: I would greatly prefer to get an event when this happens. The user expects something to happen when they push a button. You cannot just throw it away. I think it is perfectly safe to send multiple press and release events. No program

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Carlos Garnacho
Hey Hans!, (sorry for chiming in late, things got busy around Fosdem...) On jue, 2015-01-22 at 16:52 +0100, Hans de Goede wrote: + LIBINPUT_EVENT_GESTURE_SWIPE_START = 600, + LIBINPUT_EVENT_GESTURE_SWIPE, + LIBINPUT_EVENT_GESTURE_SWIPE_END, }; One thing I'm unsure about this

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Carlos Garnacho
Hey Jonas, On mar, 2015-01-27 at 13:49 +0800, Jonas Ådahl wrote: snip anyway, the other escape hatch we have is: we don't _have_ to support all gestures. 2fg scrolling and swiping are incompatible, so short of changing all scrolling to swiping and letting the caller deal with the

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Carlos Garnacho
Hey, On mié, 2015-01-28 at 15:51 +0100, Hans de Goede wrote: Hi, On 28-01-15 13:59, Carlos Garnacho wrote: Hey Hans!, (sorry for chiming in late, things got busy around Fosdem...) On jue, 2015-01-22 at 16:52 +0100, Hans de Goede wrote: + LIBINPUT_EVENT_GESTURE_SWIPE_START = 600

Fwd: [PATCH libinput] evdev: Ensure the libevdev object receives the new fd on resume

2014-12-10 Thread Carlos Garnacho
Doh, resending to list from the subscribed account... Hey Peter :), On Wed, Dec 10, 2014 at 1:40 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Dec 09, 2014 at 03:55:32PM +0100, Carlos Garnacho wrote: Otherwise, input_events will be attempted to read from the wrong place

Re: Fwd: [PATCH libinput] evdev: Ensure the libevdev object receives the new fd on resume

2014-12-10 Thread Carlos Garnacho
Hey Peter, already done, please look at the two patches here http://lists.freedesktop.org/archives/wayland-devel/2014-December/018916.html Yeah... I only noticed there was a 2/2 patch after I hit send. Thanks for taking care! had to modify your original patch too with the libevdev sync

[PATCH libinput] evdev: Ensure the libevdev object receives the new fd on resume

2014-12-09 Thread Carlos Garnacho
Otherwise, input_events will be attempted to read from the wrong place, which also leaves the right/current fd with pending data to be read, making the epoll fd wake up constantly. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: xdg shell status and gaps

2014-09-26 Thread Carlos Garnacho
Hey, On Thu, Sep 25, 2014 at 7:30 PM, Matthias Clasen matthias.cla...@gmail.com wrote: On Thu, Sep 25, 2014 at 10:32 AM, Jasper St. Pierre jstpie...@mecheye.net wrote: Anyway, here's the list: snip 7) Root window drop When is this useful? One place where it is used is

Re: [PATCH libinput 0/24] Tablet support

2014-05-25 Thread Carlos Garnacho
Hey Peter, On vie, 2014-05-23 at 16:19 +1000, Peter Hutterer wrote: On Fri, May 23, 2014 at 01:40:49AM +0200, Carlos Garnacho wrote: Hi, First of all, I'm sorry I dropped the ball this long. It's great to see you've been doing some progress. On jue, 2014-05-22 at 01:17 -0400

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Carlos Garnacho
of that good stuff, and I wanted to make sure I had a decent understanding of it before I actually wrote up a response. On Mon, 2014-04-21 at 19:11 +0200, Carlos Garnacho wrote: Hey there!, Here's a few patches to have libinput handle events from tablets, these devices are basically

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Carlos Garnacho
-21 at 19:11 +0200, Carlos Garnacho wrote: Hey there!, Here's a few patches to have libinput handle events from tablets, these devices are basically pointer devices, with a varying range of extra buttons (either stylus or pad buttons), and extra ABS_* axes. These devices also often offer

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Carlos Garnacho
Hi Ping! On lun, 2014-04-21 at 18:03 -0700, Ping Cheng wrote: Benjamin is right. Those are absolute values. Most Linux applications do not use those extra values. But, there are in-house applications need those values. I'll have to ask around to give you some use cases if you are interested.

[PATCH libinput 02/24] evdev: use an axis_frame event to mark the end of axis changes

2014-04-21 Thread Carlos Garnacho
It will be unlikely in this case to get both REL_WHEEL and REL_HWHEEL on a single EV_SYN, but for completeness. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 901b310..94fe67b 100644

[PATCH libinput 03/24] touchpad: Use an axis_frame event to mark the end of scroll changes

2014-04-21 Thread Carlos Garnacho
If both v/h scroll axes change, users may process both changes at once when this event is received. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev-touchpad.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/evdev-touchpad.c b/src/evdev-touchpad.c index 1a48441..7312d11

[PATCH libinput 10/24] tools: Handle tablet axes in event-debug

2014-04-21 Thread Carlos Garnacho
Signed-off-by: Carlos Garnacho carl...@gnome.org --- tools/event-debug.c | 12 1 file changed, 12 insertions(+) diff --git a/tools/event-debug.c b/tools/event-debug.c index 3a72bfa..17dafe0 100644 --- a/tools/event-debug.c +++ b/tools/event-debug.c @@ -310,6 +310,18

[PATCH libinput 01/24] Add LIBINPUT_EVENT_POINTER_AXIS_FRAME event

2014-04-21 Thread Carlos Garnacho
This event marks the end of 1..N simultaneous axis changes. Will be useful to have users compress vscroll/hscroll processing in a single point, and will prove even more useful on devices with a higher number of axes, like tablets. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/libinput

[PATCH libinput 0/24] Tablet support

2014-04-21 Thread Carlos Garnacho
Hey there!, Here's a few patches to have libinput handle events from tablets, these devices are basically pointer devices, with a varying range of extra buttons (either stylus or pad buttons), and extra ABS_* axes. These devices also often offer information about the stylus in use, and its

[PATCH libinput 16/24] tablet: Emit axis events on v/h stylus tilt changes.

2014-04-21 Thread Carlos Garnacho
Those are normalized to be in the [-1..1] range. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev-tablet.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 70f3210..cc55c74 100644 --- a/src/evdev-tablet.c

[PATCH libinput 07/24] Add extra libinput_pointer_axis values for tablets

2014-04-21 Thread Carlos Garnacho
distance/pressure/xtilt/ytilt are handled at the moment, this leaves wheels/strips out at the moment... Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/libinput.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/libinput.h b/src/libinput.h index 5b3d79e

[PATCH libinput 17/24] tablet: Emit axis events on distance/pressure changes

2014-04-21 Thread Carlos Garnacho
Those have been made mutually exclusive, to make sure only one or the other is notified when there is some uncertainty from the device. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev-tablet.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src

[PATCH libinput 04/24] mt-touchpad: Use an axis_frame event to mark the end of scroll changes

2014-04-21 Thread Carlos Garnacho
If both v/h scroll axes change, users may process both changes at once when this event is received. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev-mt-touchpad.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev

[PATCH libinput 08/24] Add LIBINPUT_DEVICE_CAP_STYLUS libinput_device_capability value

2014-04-21 Thread Carlos Garnacho
This capability flag would be enabled when events are driven through a stylus, ie. on a tablet. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev.c| 2 ++ src/evdev.h| 3 ++- src/libinput.h | 3 ++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b

[PATCH libinput 06/24] tests: drain events before testing scroll events in test-pointer

2014-04-21 Thread Carlos Garnacho
This is so LIBINPUT_EVENT_POINTER_AXIS_FRAME events remaining from previous tests are discarded. Signed-off-by: Carlos Garnacho carl...@gnome.org --- test/pointer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/pointer.c b/test/pointer.c index 59fe818..ecb7dbd 100644 --- a/test

[PATCH libinput 18/24] test: Add infrastructure for testing tablet events.

2014-04-21 Thread Carlos Garnacho
no vfuncs are used, only input_event arrays. Signed-off-by: Carlos Garnacho carl...@gnome.org --- test/litest-int.h | 8 + test/litest.c | 90 +++ test/litest.h | 14 + 3 files changed, 112 insertions(+) diff --git a/test

[PATCH libinput 19/24] test: Add Wacom Bamboo 16FG 4x5 Pen device definition

2014-04-21 Thread Carlos Garnacho
Signed-off-by: Carlos Garnacho carl...@gnome.org --- test/Makefile.am | 1 + test/litest-wacom-bamboo-tablet.c | 106 ++ test/litest.c | 2 + 3 files changed, 109 insertions(+) create mode 100644 test/litest-wacom

[PATCH libinput 14/24] tablet: handle button events

2014-04-21 Thread Carlos Garnacho
This works for stylus tap and primary/secondary button, and pad buttons. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/evdev-tablet.c | 104 + src/evdev-tablet.h | 3 ++ 2 files changed, 107 insertions(+) diff --git a/src/evdev

[PATCH libinput 23/24] test: Add proximity tablet test

2014-04-21 Thread Carlos Garnacho
Signed-off-by: Carlos Garnacho carl...@gnome.org --- test/Makefile.am | 6 + test/tablet.c| 82 2 files changed, 88 insertions(+) create mode 100644 test/tablet.c diff --git a/test/Makefile.am b/test/Makefile.am index 74d9a06

[PATCH libinput 20/24] test: Add Wacom Cintiq 12WX device definition

2014-04-21 Thread Carlos Garnacho
Signed-off-by: Carlos Garnacho carl...@gnome.org --- test/Makefile.am | 1 + test/litest-wacom-cintiq-tablet.c | 137 ++ test/litest.c | 2 + 3 files changed, 140 insertions(+) create mode 100644 test/litest-wacom

[PATCH libinput 24/24] test: Add motion event test for tablets

2014-04-21 Thread Carlos Garnacho
Signed-off-by: Carlos Garnacho carl...@gnome.org --- test/tablet.c | 48 1 file changed, 48 insertions(+) diff --git a/test/tablet.c b/test/tablet.c index 591742a..08592c7 100644 --- a/test/tablet.c +++ b/test/tablet.c @@ -73,10 +73,58

[PATCH libinput 21/24] test: Add Wacom Intuos5 touch M Pen device definition

2014-04-21 Thread Carlos Garnacho
Signed-off-by: Carlos Garnacho carl...@gnome.org --- test/Makefile.am | 1 + test/litest-wacom-intuos-tablet.c | 136 ++ test/litest.c | 2 + 3 files changed, 139 insertions(+) create mode 100644 test/litest-wacom

[PATCH libinput 09/24] Add LIBINPUT_EVENT_POINTER_TOOL_UPDATE event type

2014-04-21 Thread Carlos Garnacho
to LIBINPUT_TOOL_NONE, so this event comes in pairs and can be used to track stylus proximity. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/libinput-private.h | 6 ++ src/libinput.c | 41 ++ src/libinput.h | 54

[PATCH libinput 12/24] evdev: Add support for tablet devices

2014-04-21 Thread Carlos Garnacho
is implemented. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/Makefile.am| 2 + src/evdev-tablet.c | 134 + src/evdev-tablet.h | 40 src/evdev.c| 12 - src/evdev.h| 3 ++ 5 files changed, 189

Fixes for minor libinput typos/style issues

2014-04-21 Thread Carlos Garnacho
Hey, I've spotted a few typos and other minor docs/style glitches on libinput, here's some patches for those. Cheers, Carlos ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org

[PATCH libinput 1/6] Fix doc typo

2014-04-21 Thread Carlos Garnacho
Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/libinput.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libinput.h b/src/libinput.h index 810a66c..9b4f198 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -59,7 +59,7 @@ enum libinput_log_priority

[PATCH libinput 5/6] tools: Add missing newline

2014-04-21 Thread Carlos Garnacho
Signed-off-by: Carlos Garnacho carl...@gnome.org --- tools/event-debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/event-debug.c b/tools/event-debug.c index c0a08a7..fb79be4 100644 --- a/tools/event-debug.c +++ b/tools/event-debug.c @@ -221,8 +221,7

[PATCH libinput 3/6] Fix doc typo in function name

2014-04-21 Thread Carlos Garnacho
Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/libinput.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libinput.h b/src/libinput.h index 20bf574..90e9fa4 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -790,7 +790,7 @@ libinput_path_create_context(const

[PATCH libinput 4/6] Fix doc typo

2014-04-21 Thread Carlos Garnacho
The infinitive reads a bit odd there. Signed-off-by: Carlos Garnacho carl...@gnome.org --- src/libinput.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libinput.h b/src/libinput.h index 90e9fa4..57a10e4 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -798,7

<    1   2   3